GNU bug report logs - #20543
24.5; <SPC> in ispell-buffer accepts spelling for the whole line

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Jürgen Hartmann <juergen_hartmann_@HIDDEN>; dated Sun, 10 May 2015 18:40:04 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Removed tag(s) fixed. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
bug No longer marked as fixed in versions 28.1 and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 20543 <at> debbugs.gnu.org:


Received: (at 20543) by debbugs.gnu.org; 29 May 2021 02:09:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 28 22:09:01 2021
Received: from localhost ([127.0.0.1]:55572 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lmoPM-0002TB-Tu
	for submit <at> debbugs.gnu.org; Fri, 28 May 2021 22:09:01 -0400
Received: from quimby.gnus.org ([95.216.78.240]:33038)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1lmoPI-0002So-UO
 for 20543 <at> debbugs.gnu.org; Fri, 28 May 2021 22:08:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=5W4s2/rFy0qgAK/1ZUZ4YqSiZHNcCCcCanWOTTd7nRE=; b=doOBxJNw/vBXhwO42FeWc65gZA
 BUDEJs1n6qXYwihEDdnSWnVzoxtD+2BtVoG2Tz1UuO6wtKj32UhnZNF5o6+PINq9qF6w27hL8KiDl
 /PZ8LDNVmS/7hTrqJxhX6VGnCe/rmViqB4pHKluH5S9dWmhs6aDYWvx0AVQy9u/xeVr4=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1lmoP9-0008AA-Sn; Sat, 29 May 2021 04:08:50 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#20543: 24.5; <SPC> in ispell-buffer accepts spelling for
 the whole line
References: <DUB124-W164F44F8556B5F2FC09049A8DC0@HIDDEN>
 <87fuuwvuzy.fsf@HIDDEN> <87h7in3egl.fsf@HIDDEN>
 <83eedr8jeb.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
 SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXLtaDx6+OIXEnM
 qU7////Dgg/GAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFHQIIB7X362YAAAHCSURBVDjLZZQN0q4g
 CIVRN4C1AS9ugGT/e/sOouU712aq8Qnk5xARU00ifTz1ZxFx4yxYjYnSAZhankBuo9NCqY25b1jP
 6UrJt3M3G13rJW3aJyowGCoDFjKBTPCP/DHScmWHK+u5w0KG/R6CELlImwbyc3hJbBHUkN4OIO0W
 gSubQZ/A1xAk6s8DRHYe+Lx/AOHazInsQcE+0N2Rr24PPP4PSEyzpNcXIZp1TB9ZHgBnzAC2jvcy
 hkEKiwOcJTHrq6ASILHbwBWqbWVbmBEntNUBOqG3vcAUZSVeoJYD8JsHPN8OFqFVK7ymeiMX/6S/
 hGqxB28WxwOof+hgplNH9/wHAsT1BPB1ywQdgoHJAS4L0KdYNATnt2yrjtguAZBoZbQLH8e+A16H
 F7p8MzSnrjuegLvefSluJU8+BsSqvLfI78kLSTiKNG1QzDitfmiqmsoGRd9GoQKGsFy7RlZWq2im
 M2i1qmh5legFkLx7mPaIQE44K7cSmRMdYvBS9VWSYh/wKK5t8QmIZleuFsMgIaCYcxdkbk2WtFL1
 PwQuqAVVX5KT2CdHmJes3qQ5JPapPfojlJu/7oLsGcR4YIF9qv4DhcN+HZa5VD0AAAAldEVYdGRh
 dGU6Y3JlYXRlADIwMjEtMDUtMjlUMDI6MDg6MDcrMDA6MDCaVdqgAAAAJXRFWHRkYXRlOm1vZGlm
 eQAyMDIxLTA1LTI5VDAyOjA4OjA3KzAwOjAw6whiHAAAAABJRU5ErkJggg==
X-Now-Playing: Joni Mitchell's _Joni Mitchell_: "I Had A King"
Date: Sat, 29 May 2021 04:08:47 +0200
In-Reply-To: <83eedr8jeb.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 28 May
 2021 09:25:16 +0300")
Message-ID: <87k0niwats.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Eli Zaretskii <eliz@HIDDEN> writes: > If we don't have good
 ideas how to fix the SPC case, we > should revert the change and add a FIXME.
 Right; I'll revert and reopen this bug report. Fixing the problem should
 be possible, though. 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 20543
Cc: juergen_hartmann_@HIDDEN, mbork@HIDDEN, 20543 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> If we don't have good ideas how to fix the SPC case, we
> should revert the change and add a FIXME.

Right; I'll revert and reopen this bug report.  Fixing the problem
should be possible, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20543; Package emacs. Full text available.

Message received at 20543 <at> debbugs.gnu.org:


Received: (at 20543) by debbugs.gnu.org; 28 May 2021 06:25:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 28 02:25:30 2021
Received: from localhost ([127.0.0.1]:53481 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lmVw1-0001MI-W4
	for submit <at> debbugs.gnu.org; Fri, 28 May 2021 02:25:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:58142)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1lmVvx-0001M4-DN
 for 20543 <at> debbugs.gnu.org; Fri, 28 May 2021 02:25:28 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:48808)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1lmVvn-0000EY-RW; Fri, 28 May 2021 02:25:15 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3206
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1lmVvk-0004bR-TT; Fri, 28 May 2021 02:25:15 -0400
Date: Fri, 28 May 2021 09:25:16 +0300
Message-Id: <83eedr8jeb.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
In-Reply-To: <87h7in3egl.fsf@HIDDEN> (message from Lars Ingebrigtsen on Fri, 
 28 May 2021 02:10:50 +0200)
Subject: Re: bug#20543: 24.5;
 <SPC> in ispell-buffer accepts spelling for the whole line
References: <DUB124-W164F44F8556B5F2FC09049A8DC0@HIDDEN>
 <87fuuwvuzy.fsf@HIDDEN> <87h7in3egl.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 20543
Cc: juergen_hartmann_@HIDDEN, mbork@HIDDEN, 20543 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Date: Fri, 28 May 2021 02:10:50 +0200
> Cc: Jürgen Hartmann <juergen_hartmann_@HIDDEN>,
>  20543 <at> debbugs.gnu.org
> 
> Marcin Borkowski <mbork@HIDDEN> writes:
> 
> >> line 3651 of emacs-24.5/lisp/textmodes/ispell.el:
> >>
> >>    ;; Do not recheck accepted word on this line.
> 
> I think there's two meanings of "accepted" in that function -- one is
> hitting SPC, and the other is when the word is already in the dictionary.

No, the two meanings of "accepted" here are:

  . the user hits SPC to "leave the word unchanged"
  . the user hits 'a' to "accept the word for this session"

See below.

> >> This suggests that there might be a reason for that behavior. If this is
> >> true, what is it?
> >
> > I've just seen this report.  I'm also very curious about that reason.
> 
> It seems nonsensical to me -- just because you accept the word once on a
> line, it might not be acceptable in the next instance.  So I've changed
> this in Emacs 28.

This is wrong, because now 'a' doesn't work as expected.

Recipe:

  . emacs -Q
  . type into *scratch*:
    foobarical something foobarical something else
  . M-x ispell-buffer
  . a (to "accept" the first "foobarical")
  . observe Emacs stopping on the next "foobarical", instead of
    skipping it, as expected

The problem is that replace == nil means two things: either the user
pressed SPC or the user pressed 'a' (but NOT 'A').  However, the
"don't check the same line" logic should only be applied for 'a', not
for SPC.  So what we need to fix this is IMO adding a way to
distinguish between 'a' and SPC (perhaps by looking at
ispell-buffer-session-localwords?).

Note that the comments in ispell-process-line wrt the meaning of the
value of 'replace' are AFAICT inaccurate:

            ;; Insert correction if needed.
            (cond
             ((equal 0 replace)         ; INSERT
              (if (equal 0 replace)     ; BUFFER-LOCAL DICT ADD
                  (ispell-add-per-file-word-list (car poss)))
              ;; Do not recheck accepted word on this line.
              (setq accept-list (cons (car poss) accept-list)))
             (t
              ;; The user hit SPC, so accept this word, but keep
              ;; checking the rest of the line.
              (unless replace
                (setq accepted t)
                (setq replace (list (buffer-substring-no-properties
                                     (point) (+ word-len (point))))))

(This is also inelegant, as it tests 'replace' for being zero twice.)

Contrary to the comment, as can be seen from ispell-command-loop, the
value of 'replace' can be:

  nil if user pressed 'i' or 'u'
  nil if user pressed 'a'
  nil if user typed SPC
  0 if user pressed 'A'
  replacement word if user typed 'r' or 'R'
  t if the spelling session should end

So the above 'cond' is incorrect and should be fixed.

In any case, the change, as it is, is for the worse, because 'a' is by
far more important than SPC during spell-checking of technical text,
where there are many acronyms and jargon words unknown to the
dictionary.  If we don't have good ideas how to fix the SPC case, we
should revert the change and add a FIXME.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20543; Package emacs. Full text available.
bug marked as fixed in version 28.1, send any further explanations to 20543 <at> debbugs.gnu.org and Jürgen Hartmann <juergen_hartmann_@HIDDEN> Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 20543 <at> debbugs.gnu.org:


Received: (at 20543) by debbugs.gnu.org; 28 May 2021 00:11:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 27 20:11:09 2021
Received: from localhost ([127.0.0.1]:53123 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lmQ5i-0007oE-Jl
	for submit <at> debbugs.gnu.org; Thu, 27 May 2021 20:11:09 -0400
Received: from quimby.gnus.org ([95.216.78.240]:48294)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1lmQ5d-0007ng-L6
 for 20543 <at> debbugs.gnu.org; Thu, 27 May 2021 20:11:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID
 :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=FkWtve9+8f+cVy1a7vPFQquFxFjwz5dfgepzJQl6v8Q=; b=mHtGpq/hM331yj9u9NgzlkZvzv
 iWeX7gZtg2gQ3s10NfTQ84RNFy9XABNhgjUMFYcywpslBJxi3T4PQ1E9Qe/BiWLGStwXCZ8Lq4QxB
 7KZdWuE1esu06Xbj4a0fCRAal1Sry97ybaVNaA2lzPc0aPBXxSQNPUxOSBJ5YZ5qg/7E=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1lmQ5S-0002Em-Mg; Fri, 28 May 2021 02:10:53 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Marcin Borkowski <mbork@HIDDEN>
Subject: Re: bug#20543: 24.5; <SPC> in ispell-buffer accepts spelling for
 the whole line
References: <DUB124-W164F44F8556B5F2FC09049A8DC0@HIDDEN>
 <87fuuwvuzy.fsf@HIDDEN>
X-Now-Playing: The Residents's _The King & Eye: RMX_: "A Fool such as I"
Date: Fri, 28 May 2021 02:10:50 +0200
In-Reply-To: <87fuuwvuzy.fsf@HIDDEN> (Marcin Borkowski's message of "Fri, 08
 Apr 2016 20:02:57 +0200")
Message-ID: <87h7in3egl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 
 Content preview:  Marcin Borkowski <mbork@HIDDEN> writes: >> line 3651 of
   emacs-24.5/lisp/textmodes/ispell.el: >> >>    ;; Do not recheck accepted
    word on this line. I think there's two meanings of "accepted" in that function
    -- one is hitting SPC, and the other is when the word is already in the dictionary.
    
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 20543
Cc: =?utf-8?Q?J=C3=BCrgen?= Hartmann <juergen_hartmann_@HIDDEN>,
 20543 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Marcin Borkowski <mbork@HIDDEN> writes:

>> line 3651 of emacs-24.5/lisp/textmodes/ispell.el:
>>
>> =C2=A0=C2=A0 ;; Do not recheck accepted word on this line.

I think there's two meanings of "accepted" in that function -- one is
hitting SPC, and the other is when the word is already in the dictionary.

>> This suggests that there might be a reason for that behavior. If this is
>> true, what is it?
>
> I've just seen this report.  I'm also very curious about that reason.

It seems nonsensical to me -- just because you accept the word once on a
line, it might not be acceptable in the next instance.  So I've changed
this in Emacs 28.

--=20
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20543; Package emacs. Full text available.

Message received at 20543 <at> debbugs.gnu.org:


Received: (at 20543) by debbugs.gnu.org; 8 Apr 2016 18:03:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 08 14:03:04 2016
Received: from localhost ([127.0.0.1]:54880 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aoakK-00045J-Ga
	for submit <at> debbugs.gnu.org; Fri, 08 Apr 2016 14:03:04 -0400
Received: from mail.mojserwer.eu ([195.110.48.8]:47165)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mbork@HIDDEN>) id 1aoakJ-00044r-3L
 for 20543 <at> debbugs.gnu.org; Fri, 08 Apr 2016 14:03:03 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.mojserwer.eu (Postfix) with ESMTP id 1DA29AA2742;
 Fri,  8 Apr 2016 20:03:01 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu
Received: from mail.mojserwer.eu ([127.0.0.1])
 by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id TLtXHMpo5B3l; Fri,  8 Apr 2016 20:02:58 +0200 (CEST)
Received: from localhost (98-171.echostar.pl [213.156.98.171])
 by mail.mojserwer.eu (Postfix) with ESMTPSA id 451B9AA273F;
 Fri,  8 Apr 2016 20:02:58 +0200 (CEST)
From: Marcin Borkowski <mbork@HIDDEN>
To: =?utf-8?Q?J=C3=BCrgen?= Hartmann <juergen_hartmann_@HIDDEN>
Subject: Re: bug#20543: 24.5;
 <SPC> in ispell-buffer accepts spelling for the whole line
References: <DUB124-W164F44F8556B5F2FC09049A8DC0@HIDDEN>
Date: Fri, 08 Apr 2016 20:02:57 +0200
In-Reply-To: <DUB124-W164F44F8556B5F2FC09049A8DC0@HIDDEN> (=?utf-8?Q?=22J?=
 =?utf-8?Q?=C3=BCrgen?=
 Hartmann"'s message of "Sun, 10 May 2015 18:05:25 +0200")
Message-ID: <87fuuwvuzy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 20543
Cc: 20543 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

On 2015-05-10, at 18:05, J=C3=BCrgen Hartmann <juergen_hartmann_@HIDDEN=
m> wrote:

> Using GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.2)--b=
ut
> this applies to former Emacs versions also--I found the following puzzling
> behavior of ispell-buffer:
>
> If a suspicious word is accepted once by pressing <SPC> in an interactive
> ispell-buffer session, all further occurrences of the same spelling on the
> same line are skipped, i.e. considered as accepted too.
>
> Here is an example:
>
> Open an Emacs 24.5 session (it is the same with Emacs 24.4) by
>
> =C2=A0=C2=A0 LC_ALL=3DC emacs -Q
>
> and enter the following line (with or without newline does not matter) in=
 the
> *scratch* buffer:
>
> =C2=A0=C2=A0 The term charset is short for charset.
>
> Assume that the last word is a typo that should read "character set". Now
> change the dictionary to american and run ispell-buffer. The first occurr=
ence
> of "charset" gets highlighted, but since it is correct here, we use <SPC>=
 to
> accept it once and proceed. But oops... the spell-check finishes immediat=
ely
> without giving us the chance to correct the second occurrence of "charset=
" in
> that line.
>
> This finding was shortly discussed in help-gnu-emacs
> (http://lists.gnu.org/archive/html/help-gnu-emacs/2015-05/threads.html#00=
134)
> and it was Eli Zaretskii who indicated that there is the following commen=
t in
> line 3651 of emacs-24.5/lisp/textmodes/ispell.el:
>
> =C2=A0=C2=A0 ;; Do not recheck accepted word on this line.
>
> This suggests that there might be a reason for that behavior. If this is
> true, what is it?

I've just seen this report.  I'm also very curious about that reason.

> Apart from that, I can not imagine why such a behavior might be desirable.
>
> Juergen


--=20
Marcin
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#20543; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 May 2015 18:39:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 10 14:39:44 2015
Received: from localhost ([127.0.0.1]:40231 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1YrW8d-0007uw-9m
	for submit <at> debbugs.gnu.org; Sun, 10 May 2015 14:39:44 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33077)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <juergen_hartmann_@HIDDEN>) id 1YrU2u-0004j3-DT
 for submit <at> debbugs.gnu.org; Sun, 10 May 2015 12:25:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <juergen_hartmann_@HIDDEN>) id 1YrU2o-0002hJ-Bd
 for submit <at> debbugs.gnu.org; Sun, 10 May 2015 12:25:35 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: ***
X-Spam-Status: No, score=3.3 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
 RECEIVED_FROM_WINDOWS_HOST autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:46222)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <juergen_hartmann_@HIDDEN>) id 1YrU2o-0002hF-7g
 for submit <at> debbugs.gnu.org; Sun, 10 May 2015 12:25:34 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46579)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <juergen_hartmann_@HIDDEN>) id 1YrU2m-0003rw-Ru
 for bug-gnu-emacs@HIDDEN; Sun, 10 May 2015 12:25:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <juergen_hartmann_@HIDDEN>) id 1YrU2i-0002fo-Lq
 for bug-gnu-emacs@HIDDEN; Sun, 10 May 2015 12:25:32 -0400
Received: from dub004-omc1s27.hotmail.com ([157.55.0.226]:63806)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <juergen_hartmann_@HIDDEN>) id 1YrU2i-0002fE-BA
 for bug-gnu-emacs@HIDDEN; Sun, 10 May 2015 12:25:28 -0400
Received: from DUB124-W16 ([157.55.0.237]) by DUB004-OMC1S27.hotmail.com over
 TLS secured channel with Microsoft SMTPSVC(7.5.7601.22751); 
 Sun, 10 May 2015 09:05:25 -0700
X-TMN: [nbEpXroJUxLsRejnWhJFLC8tBD++LrA7]
X-Originating-Email: [juergen_hartmann_@HIDDEN]
Message-ID: <DUB124-W164F44F8556B5F2FC09049A8DC0@HIDDEN>
From: =?iso-8859-1?B?SvxyZ2VuIEhhcnRtYW5u?= <juergen_hartmann_@HIDDEN>
To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN>
Subject: 24.5; <SPC> in ispell-buffer accepts spelling for the whole line
Date: Sun, 10 May 2015 18:05:25 +0200
Importance: Normal
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginalArrivalTime: 10 May 2015 16:05:25.0352 (UTC)
 FILETIME=[20368680:01D08B3B]
X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sun, 10 May 2015 14:39:41 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

Using GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu=2C GTK+ Version 3.10.2)--b=
ut=0A=
this applies to former Emacs versions also--I found the following puzzling=
=0A=
behavior of ispell-buffer:=0A=
=0A=
If a suspicious word is accepted once by pressing <SPC> in an interactive=
=0A=
ispell-buffer session=2C all further occurrences of the same spelling on th=
e=0A=
same line are skipped=2C i.e. considered as accepted too.=0A=
=0A=
Here is an example:=0A=
=0A=
Open an Emacs 24.5 session (it is the same with Emacs 24.4) by=0A=
=0A=
=A0=A0 LC_ALL=3DC emacs -Q=0A=
=0A=
and enter the following line (with or without newline does not matter) in t=
he=0A=
*scratch* buffer:=0A=
=0A=
=A0=A0 The term charset is short for charset.=0A=
=0A=
Assume that the last word is a typo that should read "character set". Now=
=0A=
change the dictionary to american and run ispell-buffer. The first occurren=
ce=0A=
of "charset" gets highlighted=2C but since it is correct here=2C we use <SP=
C> to=0A=
accept it once and proceed. But oops... the spell-check finishes immediatel=
y=0A=
without giving us the chance to correct the second occurrence of "charset" =
in=0A=
that line.=0A=
=0A=
This finding was shortly discussed in help-gnu-emacs=0A=
(http://lists.gnu.org/archive/html/help-gnu-emacs/2015-05/threads.html#0013=
4)=0A=
and it was Eli Zaretskii who indicated that there is the following comment =
in=0A=
line 3651 of emacs-24.5/lisp/textmodes/ispell.el:=0A=
=0A=
=A0=A0 =3B=3B Do not recheck accepted word on this line.=0A=
=0A=
This suggests that there might be a reason for that behavior. If this is=0A=
true=2C what is it?=0A=
=0A=
Apart from that=2C I can not imagine why such a behavior might be desirable=
.=0A=
=0A=
Juergen=0A=
=0A=
 		 	   		  =
Acknowledgement sent to Jürgen Hartmann <juergen_hartmann_@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#20543; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 29 May 2021 02:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.