GNU bug report logs - #21137
typo in libtool.m4 ( _LT_SYS_HIDDEN_LIBDEPS)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21137 in the body.
You can then email your comments to 21137 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gilles Gouaillardet <gilles.gouaillardet <at> gmail.com>
To: bug-libtool <at> gnu.org
Subject: typo in libtool.m4 ( _LT_SYS_HIDDEN_LIBDEPS)
Date: Mon, 27 Jul 2015 10:55:46 +0900

Dear libtool folks,

i'd like to report a typo in libtool.m4 that was introduced in libtool 2.4.3

This issue was initially discussed at
https://github.com/open-mpi/ompi/issues/751

The patch below does fix this.

could you please check this out ?

Best regards,

Gilles

diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 068f0d8..5bbd0a8 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -7155,8 +7155,8 @@ if AC_TRY_EVAL(ac_compile); then
     -L* | -R* | -l*)
        # Some compilers place space between "-{L,R}" and the path.
        # Remove the space.
-       if test x-L = "$p" ||
-          test x-R = "$p"; then
+       if test x-L = "x$p" ||
+          test x-R = "x$p"; then
         prev=$p
         continue
        fi

Message #8 received at 21137 <at> debbugs.gnu.org (full text, mbox):

From: Gilles Gouaillardet <gilles.gouaillardet <at> gmail.com>
To: 21137 <at> debbugs.gnu.org
Subject: Re: bug#21137: typo in libtool.m4 ( _LT_SYS_HIDDEN_LIBDEPS)
Date: Tue, 18 Aug 2015 13:25:52 +0900

Dear libtool folks,

did you have any chance to review this patch ?

Thanks and regards,

Gilles

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clement Foyer <cfoyer <at> cray.com>
To: "bug-libtool <at> gnu.org" <bug-libtool <at> gnu.org>
Subject: Follow up on bug#21137: typo in libtool.m4 ( _LT_SYS_HIDDEN_LIBDEPS)
Date: Fri, 24 Aug 2018 10:05:31 +0000

[Message part 1 (text/plain, inline)]

Dear libtool maintainers,

Sorry to dig this bug up, but it seems like it is not solved yet in master. Gilles provided a patch that may not have reached you.

I ended up digging this out because we faced a strange behaviour that is related to the same part of the code. For some fortran code linking, we end up with couple empty -l pending in the command line, that get mixed up with the following -L/some/path ending up in a faulty command. From my understanding, it may be some trivial library that get removed because added by default (or added multiple times), but the trimming is either too much or not enough.
One work around (provided in https://github.com/open-mpi/ompi/issues/751 ) is to add a test to -l in the first if statement to set the $prev variable properly.

It seems to work well as this work around have been used in the autogen process for Open MPI for many years now, but I did not check each sub-function to see if it would unexpectedly break anything.

Thanks you very much,
Best regards,
Clement
--
Clément Foyer |  Research Engineer
Mobile +44 (0) 771 179 9985 | Office +44 (0) 117 992 6790 |  cfoyer <at> cray.com
Broad Quay House | Broad Quay  |  Bristol  |  BS1 4DJ  |  http://www.cray.com/

Cray U.K. Limited is a limited company registered in England and Wales.
Company Registration No. 03941275. Registered Offices: 5 Fleet Place, London, EC4M 7RD, UK

[Message part 2 (text/html, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clement Foyer <cfoyer <at> cray.com>
To: "bug-libtool <at> gnu.org" <bug-libtool <at> gnu.org>
Subject: Follow up on bug#21137: typo in libtool.m4 ( _LT_SYS_HIDDEN_LIBDEPS)
Date: Tue, 4 Sep 2018 10:10:42 +0000

[Message part 1 (text/plain, inline)]

Dear libtool maintainers,

Sorry to dig this bug up, but it seems like it is not solved yet in master. Gilles provided a patch that may not have reached you.

I ended up digging this out because we faced a strange behaviour that is related to the same part of the code. For some fortran code linking, we end up with couple empty -l pending in the command line, that get mixed up with the following -L/some/path ending up in a faulty link command. From my understanding, it may be some trivial library that get removed because added by default (or added multiple times), but the trimming is either too much or not enough.
One work around (provided in https://github.com/open-mpi/ompi/issues/751 ) is to add a test to -l in the first if statement to set the $prev variable properly.

It seems to work well as this work around have been used in the autogen process for Open MPI for many years now, but I did not check each sub-function to see if it would unexpectedly break anything.

Thanks you very much,
Best regards,
Clement
--
Clément Foyer |  Research Engineer – PhD Student
Mobile +44 (0) 771 179 9985 | Office +44 (0) 117 992 6790 |  cfoyer <at> cray.com
Broad Quay House | Broad Quay  |  Bristol  |  BS1 4DJ  |  http://www.cray.com/

Cray U.K. Limited is a limited company registered in England and Wales.
Company Registration No. 03941275. Registered Offices: 5 Fleet Place, London, EC4M 7RD, UK

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.