GNU bug report logs - #21387
24.3; ediff bug with french

Previous Next

Package: emacs;

Reported by: Mathieu Brisson <brissonmathieu <at> ovh.fr>

Date: Mon, 31 Aug 2015 15:37:01 UTC

Severity: minor

Tags: fixed

Found in version 24.3

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21387 in the body.
You can then email your comments to 21387 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#21387; Package emacs. (Mon, 31 Aug 2015 15:37:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mathieu Brisson <brissonmathieu <at> ovh.fr>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 31 Aug 2015 15:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Brisson <brissonmathieu <at> ovh.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; ediff bug with french
Date: Mon, 31 Aug 2015 16:38:50 +0200
ediff fails with the same symptom present in
http://stackoverflow.com/questions/9242651/emacs-ediff-error-no-newline-at-end-of-file 

but in french. I assume it is a bug, and not a misconfiguration on my
side.
Thanks! BTW, emacs is a great tool, thank s for developping this awesome
editor!
Bye,
Mathieu.






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21387; Package emacs. (Mon, 28 Dec 2020 00:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 21387 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mathieu Brisson <brissonmathieu <at> ovh.fr>
Cc: 21387 <at> debbugs.gnu.org
Subject: Re: bug#21387: 24.3; ediff bug with french
Date: Mon, 28 Dec 2020 01:46:20 +0100
[Message part 1 (text/plain, inline)]
Mathieu Brisson <brissonmathieu <at> ovh.fr> writes:

> ediff fails with the same symptom present in
> http://stackoverflow.com/questions/9242651/emacs-ediff-error-no-newline-at-end-of-file
> but in french. I assume it is a bug, and not a misconfiguration on my
> side.

Steps to reproduce:

echo -n foo > /tmp/foo1
echo bar > /tmp/foo2

LANGUAGE=de_DE src/emacs -Q /tmp/di.el

(ediff-files "/tmp/foo1" "/tmp/foo2")

Result:

[Message part 2 (image/png, inline)]
[Message part 3 (text/plain, inline)]
Well, we obviously can't add all the languages in the world to
`ediff-diff-ok-lines-regexp', but we can run diff in a known
environment.

Any comments?  Is this the best way to do this sort of stuff?  The
LOCALE/LANGUAGE/LC_* variables can be kinda confusing.

diff --git a/lisp/vc/ediff-diff.el b/lisp/vc/ediff-diff.el
index adb6ce8053..38c546729e 100644
--- a/lisp/vc/ediff-diff.el
+++ b/lisp/vc/ediff-diff.el
@@ -1146,7 +1146,10 @@ ediff-exec-process
 	 (if (string-match "buffer" (symbol-name ediff-job-name))
 	     ediff-coding-system-for-write
 	   ediff-coding-system-for-read))
-	args)
+        (process-environment
+         ;; Avoid localization of messages so we can parse the output.
+         (cons "LC_MESSAGES=C" process-environment))
+        args)
     (setq args (append (split-string options)
                        (mapcar (lambda (file)
                                  (when (stringp file)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21387; Package emacs. (Wed, 26 May 2021 22:40:02 GMT) Full text and rfc822 format available.

Message #11 received at 21387 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mathieu Brisson <brissonmathieu <at> ovh.fr>
Cc: 21387 <at> debbugs.gnu.org
Subject: Re: bug#21387: 24.3; ediff bug with french
Date: Thu, 27 May 2021 00:38:56 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Any comments?  Is this the best way to do this sort of stuff?  The
> LOCALE/LANGUAGE/LC_* variables can be kinda confusing.

There were no comments, so I've now pushed this change.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 26 May 2021 22:40:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 21387 <at> debbugs.gnu.org and Mathieu Brisson <brissonmathieu <at> ovh.fr> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 26 May 2021 22:40:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21387; Package emacs. (Thu, 27 May 2021 06:57:02 GMT) Full text and rfc822 format available.

Message #18 received at 21387 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: brissonmathieu <at> ovh.fr, 21387 <at> debbugs.gnu.org
Subject: Re: bug#21387: 24.3; ediff bug with french
Date: Thu, 27 May 2021 09:56:08 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Thu, 27 May 2021 00:38:56 +0200
> Cc: 21387 <at> debbugs.gnu.org
> 
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> 
> > Any comments?  Is this the best way to do this sort of stuff?  The
> > LOCALE/LANGUAGE/LC_* variables can be kinda confusing.
> 
> There were no comments, so I've now pushed this change.

FTR, please note that this fix is 100% reliable only on Posix systems.
MS-Windows's setlocale doesn't heed the LC_* environment variables,
unless the program was built with the Gnulib replacement for
setlocale, or took special care to access the environment from the
application code.  Some programs do, others don't, so don't expect
this to work for every port of Diff out there.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Jun 2021 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 279 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.