GNU bug report logs - #21578
`ibuffer-copy-filename-as-kill' unconsistent with `dired-copy-filename-as-kill'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21578 in the body.
You can then email your comments to 21578 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: `ibuffer-copy-filename-as-kill' unconsistent with
 `dired-copy-filename-as-kill'
Date: Mon, 28 Sep 2015 22:28:49 +0900 (JST)

[Message part 1 (text/plain, inline)]

This is not a bug, its a suggestion.

It would be pleasant if these two functions would behave similarly
whenever we dont have marked files: the later one returns filename for 
next ARG files (or file in the current line if ARG nil), which i found useful.
The former one report an error and exists.

I found better if `ibuffer-copy-filename-as-kill' behaves as the 
dired function in that situation.

Attached two patches:

*) one over emacs-v24.5 ibuf-ext.el
*) another including patches from bug reports #21576, #21577.

[patch3 (text/plain, attachment)]

[patch4 (text/plain, attachment)]

Message #8 received at 21578 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 21578 <at> debbugs.gnu.org
Subject: 24.5; `ibuffer-copy-filename-as-kill' unconsistent with
 `dired-copy-filename-as-kill'
Date: Fri, 2 Oct 2015 20:46:25 +0900 (JST)

dired-copy-filename-as-kill doesnt make distinction between dir/files.

Considering that these functions names just differ in the prefix,
and the documentation strings looks almost the same,
consistenty reasons demand that they behave almost the same:
ibuffer-copy-filename-as-kill should return the (dired-default-directory)
for those buffers in dired mode.

It would be also natural (but maybe not very useful) if
ibuffer-copy-filename-as-kill behaves as its dired partner when we
have marked buffers but we pass a numerical argument !=0: my patches didnt 
took this in account.
By the way, my patch3 should replace:
?>
with
ibuffer-marked-char

Message #11 received at 21578 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 21578 <at> debbugs.gnu.org
Subject: `ibuffer-copy-buffername-as-kill'
Date: Sun, 4 Oct 2015 23:15:33 +0900 (JST)

I also miss a function like:
ibuffer-copy-buffername-as-kill

Sometimes you want the buffer name at the current line regardless
of whether this buffer is visiting a file or not.
I would like this function behave similarly as
ibuffer-copy-filename-as-kill concerning with if we have marked buffers
or not.

In principle, such function could be bind to "B".
In my case i bind it to "b" (re-binding `ibuffer-bury-buffer'
to "B", because i rarely use this function).

Message #14 received at 21578 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 21578 <at> debbugs.gnu.org
Subject: Re: bug#21578: `ibuffer-copy-filename-as-kill' unconsistent with
 `dired-copy-filename-as-kill'
Date: Tue, 25 Jun 2019 17:23:31 +0200

Tino Calancha <f92capac <at> gmail.com> writes:

> This is not a bug, its a suggestion.
>
> It would be pleasant if these two functions would behave similarly
> whenever we dont have marked files: the later one returns filename for
> next ARG files (or file in the current line if ARG nil), which i found
> useful.
> The former one report an error and exists.
>
> I found better if `ibuffer-copy-filename-as-kill' behaves as the dired
> function in that situation.

That does makes sense to me.  The patch no longer applies, though --
would it be possible to redo it now?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 21578 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 21578 <at> debbugs.gnu.org
Subject: Re: bug#21578: `ibuffer-copy-filename-as-kill' unconsistent with
 `dired-copy-filename-as-kill'
Date: Wed, 12 Aug 2020 14:43:36 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Tino Calancha <f92capac <at> gmail.com> writes:
>
>> This is not a bug, its a suggestion.
>>
>> It would be pleasant if these two functions would behave similarly
>> whenever we dont have marked files: the later one returns filename for
>> next ARG files (or file in the current line if ARG nil), which i found
>> useful.
>> The former one report an error and exists.
>>
>> I found better if `ibuffer-copy-filename-as-kill' behaves as the dired
>> function in that situation.
>
> That does makes sense to me.  The patch no longer applies, though --
> would it be possible to redo it now?

Oh, looking at this again, it seems like this was already applied (in
2016), so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.