GNU logs - #21613, boring messages

Message sent to bug-guile@HIDDEN:

Subject: bug#21613: Include messes up when compiling file in load path
Resent-From: taylanbayirli@HIDDEN (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sun, 04 Oct 2015 14:37:02 +0000
Resent-Message-ID: <handler.21613.B.144396939425269 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 21613 <at> debbugs.gnu.org
From: taylanbayirli@HIDDEN (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
Date: Sun, 04 Oct 2015 16:36:21 +0200
Message-ID: <8737xqaefu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

When a file to be compiled, A.scm, contains (include "B.scm"), the
compiler fails to find B.scm if the directory containing A and B are in
Guile's load path.

Here's a shell transcript showcasing the bug:

--- snip ---
$ mkdir test
$ echo '(include "test2.scm")' > test/test1.scm
$ echo '(display "foo\n")' > test/test2.scm
$ pwd
/home/taylan
$ export GUILE_LOAD_PATH=/home/taylan/test
$ unset GUILE_LOAD_COMPILED_PATH
$ guile -q
GNU Guile 2.0.11
Copyright (C) 1995-2014 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (compile-file "/home/taylan/test/test1.scm")
ice-9/boot-9.scm:106:20: In procedure #<procedure 248a580 at ice-9/boot-9.scm:97:6 (thrown-k . args)>:
ice-9/boot-9.scm:106:20: In procedure open-file: No such file or directory: "./test2.scm"

Entering a new prompt.  Type `,bt' for a backtrace or `,q' to continue.
scheme@(#{ g269}#) [1]>
--- snip ---

This seems to be related to 'compile-file' setting
'%file-port-name-canonicalization' to 'relative', but I don't know what
the correct fix is.

Taylan

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: taylanbayirli@HIDDEN (Taylan Ulrich
 =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
Subject: bug#21613: Acknowledgement (Include messes up when compiling file
 in load path)
Message-ID: <handler.21613.B.144396939425269.ack <at> debbugs.gnu.org>
References: <8737xqaefu.fsf@HIDDEN>
X-Gnu-PR-Message: ack 21613
X-Gnu-PR-Package: guile
Reply-To: 21613 <at> debbugs.gnu.org
Date: Sun, 04 Oct 2015 14:37:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guile@HIDDEN

If you wish to submit further information on this problem, please
send it to 21613 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
21613: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21613
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guile@HIDDEN:

Subject: bug#21613: Include messes up when compiling file in load path
Resent-From: taylanbayirli@HIDDEN (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Sun, 04 Oct 2015 22:32:01 +0000
Resent-Message-ID: <handler.21613.B.14439979061288 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 21613 <at> debbugs.gnu.org
From: taylanbayirli@HIDDEN (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
References: <8737xqaefu.fsf@HIDDEN>
Date: Mon, 05 Oct 2015 00:31:34 +0200
In-Reply-To: <8737xqaefu.fsf@HIDDEN> ("Taylan Ulrich
 \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
 message of "Sun, 04 Oct 2015 16:36:21 +0200")
Message-ID: <87twq68dvd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

taylanbayirli@HIDDEN (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes:

> This seems to be related to 'compile-file' setting
> '%file-port-name-canonicalization' to 'relative', but I don't know
> what the correct fix is.

With the following trivial patch changing 'relative' to 'absolute',
Guile's test suite passes and the bug seems to be fixed, but I still
don't know whether this is the right fix...


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-Fix-include-for-files-in-load-path.patch

From 3e508926631a6fe3d81f6a584352562afc0e96ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@HIDDEN>
Date: Mon, 5 Oct 2015 00:15:56 +0200
Subject: [PATCH] Fix 'include' for files in load path.

Fixes <http://debbugs.gnu.org/21613>.

* module/system/base/compile.scm (compile-file): Set
  %file-port-name-canonicalization to 'absolute by default.
(compile-and-load): Ditto.
---
 module/system/base/compile.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/module/system/base/compile.scm b/module/system/base/compile.scm
index c522b74..66eec44 100644
--- a/module/system/base/compile.scm
+++ b/module/system/base/compile.scm
@@ -136,7 +136,7 @@
                        (to 'objcode)
                        (env (default-environment from))
                        (opts '())
-                       (canonicalization 'relative))
+                       (canonicalization 'absolute))
   (with-fluids ((%file-port-name-canonicalization canonicalization))
     (let* ((comp (or output-file (compiled-file-name file)
                      (error "failed to create path for auto-compiled file"
@@ -157,7 +157,7 @@
 
 (define* (compile-and-load file #:key (from (current-language)) (to 'value)
                            (env (current-module)) (opts '())
-                           (canonicalization 'relative))
+                           (canonicalization 'absolute))
   (with-fluids ((%file-port-name-canonicalization canonicalization))
     (read-and-compile (open-input-file file)
                       #:from from #:to to #:opts opts
-- 
2.5.0


--=-=-=--

Message sent to bug-guile@HIDDEN:

Subject: bug#21613: Include messes up when compiling file in load path
Resent-From: taylanbayirli@HIDDEN (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Tue, 21 Jun 2016 08:50:02 +0000
Resent-Message-ID: <handler.21613.B.146649896812156 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 21613 <at> debbugs.gnu.org
Cc: wingo@HIDDEN
From: taylanbayirli@HIDDEN (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=)
References: <8737xqaefu.fsf@HIDDEN> <87twq68dvd.fsf@HIDDEN>
Date: Tue, 21 Jun 2016 10:49:10 +0200
In-Reply-To: <87twq68dvd.fsf@HIDDEN> ("Taylan Ulrich
 \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
 message of "Mon, 05 Oct 2015 00:31:34 +0200")
Message-ID: <8760t3lyex.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Ping with CC to Andy. :-)

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21613: Include messes up when compiling file in load path
Resent-From: Andy Wingo <wingo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Fri, 24 Jun 2016 14:50:02 +0000
Resent-Message-ID: <handler.21613.B21613.146677975919209 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21613
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: taylanbayirli@HIDDEN (Taylan Ulrich "=?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=")
Cc: 21613 <at> debbugs.gnu.org
Received: via spool by 21613-submit <at> debbugs.gnu.org id=B21613.146677975919209
          (code B ref 21613); Fri, 24 Jun 2016 14:50:02 +0000
Received: (at 21613) by debbugs.gnu.org; 24 Jun 2016 14:49:19 +0000
Received: from localhost ([127.0.0.1]:54432 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1bGSQ3-0004zl-0V
	for submit <at> debbugs.gnu.org; Fri, 24 Jun 2016 10:49:19 -0400
Received: from pb-sasl2.pobox.com ([64.147.108.67]:59709
 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <wingo@HIDDEN>) id 1bGSQ1-0004zb-EZ
 for 21613 <at> debbugs.gnu.org; Fri, 24 Jun 2016 10:49:17 -0400
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])
 by pb-sasl2.pobox.com (Postfix) with ESMTP id DEF9721EFF;
 Fri, 24 Jun 2016 10:49:13 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
 :subject:references:date:in-reply-to:message-id:mime-version
 :content-type:content-transfer-encoding; s=sasl; bh=yODMHfi2r/s2
 X4lC7BVADazr2YA=; b=rv28Y53o01K9L2ViE8k8QG7rdH6i1cD6E+0gNKYF4p5k
 zKjOOtNXYGNun27IPac8Hd8TjY8lNCv+N0eOwzbuoebTqmpk+lgL/7tS4nEKb0Ba
 bJU+kF/PCkkVZ6sZkR2LVhxqOmThPnK7TvpTJPO5AUwscCvELs6MxSFsMqhZwBw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
 :subject:references:date:in-reply-to:message-id:mime-version
 :content-type:content-transfer-encoding; q=dns; s=sasl; b=QwaAcH
 e6otaHGMsGVAP95Ym4Kusd3EjljVlegrS2WgK72eGBDObtbbXssssym68W4TERGs
 JVQ/Epqm+lt10ZlJDX5hEnBLuFoZAsN+FfwUS4qO/m0f/52qFW7/uDkWqSJlBQEM
 dD391j5zBr2vo2vPuFVWEHJr0mqdooKamZVFM=
Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1])
 by pb-sasl2.pobox.com (Postfix) with ESMTP id D6AFC21EFD;
 Fri, 24 Jun 2016 10:49:13 -0400 (EDT)
Received: from clucks (unknown [88.160.190.192])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 224C221EFC;
 Fri, 24 Jun 2016 10:49:13 -0400 (EDT)
From: Andy Wingo <wingo@HIDDEN>
References: <8737xqaefu.fsf@HIDDEN>
Date: Fri, 24 Jun 2016 16:49:05 +0200
In-Reply-To: <8737xqaefu.fsf@HIDDEN> ("Taylan Ulrich
 \"=?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer\?=""'s message of "Sun, 04
 Oct 2015 16:36:21 +0200")
Message-ID: <87d1n6fxr2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Pobox-Relay-ID: D12F9F50-3A1A-11E6-A84B-28A6F1301B6D-02397024!pb-sasl2.pobox.com
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.4 (-)

On Sun 04 Oct 2015 16:36, taylanbayirli@HIDDEN (Taylan Ulrich "Bay=C4=B1=
rl=C4=B1/Kammer") writes:

> $ mkdir test
> $ echo '(include "test2.scm")' > test/test1.scm
> $ echo '(display "foo\n")' > test/test2.scm
> $ pwd
> /home/taylan
> $ export GUILE_LOAD_PATH=3D/home/taylan/test
> $ unset GUILE_LOAD_COMPILED_PATH
> $ guile -L test test/test1.scm
...
> ERROR: In procedure open-file:
> ERROR: In procedure open-file: No such file or directory: "./test2.scm"

The way this works is that test/test1.scm is opened.  To set the
port-filename of the port, Guile uses "relative" canonicalization of the
path, which will result in "test1.scm" being the port-filename, as we
found test1.scm in test/.  After that it all breaks down -- the
intention is for `include' of a relative path to look for it relative to
the dirname of the file doing the including, but (dirname "test1.scm")
is ".", so it looks for "./test2.scm"... bogus.

The intention of relative canonicalization is to allow for errors to be
signalled relative to a path-relative file name.  For example in a
recent backtrace:

In ice-9/psyntax.scm:
  1200:36  5 (expand-top-sequence ((include "test2.scm")) _ _ #f e # #)

The fact that it's ice-9/psyntax.scm comes from there.  You can build
the file locally and install it and it the debugging information doesn't
embed the full dirname of the build tree.

But, for that to work well, you really need `include-from-path' and not
`include'.  All of the uses of `include' in Guile itself are really
`include-from-path'.  And if you use `include' in a file which is in a
path... well I guess that's not working.

Clearly going backwards from a relative path to an absolute path is not
going to work.  I guess my only proposal would be to include the
absolute path of a file port, in addition to the relative path.  I guess
that would be somewhere around the call to fport_canonicalize_filename
in fports.c.

Thoughts?

Andy

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.