GNU bug report logs - #21857
package install should give better feedback

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21857 in the body.
You can then email your comments to 21857 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: package install should give better feedback
Date: Sat, 7 Nov 2015 18:41:40 -0500

When installing a package, give an acceptable “XXX successfully installed” message in the echo area as the last message.
As it is, it seems to just show a “done” for the last dependency, which is confusing or uninformative.

Also, if the *Packages* buffer is present--which it will be because the user may have picked the package to install after doing M-x list-packages—this buffer should be updated to show that the package was installed.

(Observed in master branch, installing JDEE from MELPA.)

Message #8 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Artur Malabarba <bruce.connor.am <at> gmail.com>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: package install should give better feedback
Date: Mon, 9 Nov 2015 00:06:27 +0000

[Message part 1 (text/plain, inline)]

On 7 Nov 2015 11:41 pm, "David Reitter" <david.reitter <at> gmail.com> wrote:
>
> When installing a package, give an acceptable “XXX successfully
installed” message in the echo area as the last message.
>
> Also, if the *Packages* buffer is present this buffer should be updated
to show that the package was installed.

Agree with all of it.
And if anyone would like to try their hand at it, both issues should be
very easy to fix.

[Message part 2 (text/html, inline)]

Message #13 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Olson <ryan.olson.x <at> gmail.com>
To: 21857 <at> debbugs.gnu.org
Subject: PATCH to show message after `package-install` installs successfully
Date: Fri, 17 Jan 2020 10:53:42 -0700

When `package-install` function finishes successfully, this patch
(below) shows the message "Package `package-name` installed."  This
matches the message that is shown with the function `package-delete`.
I feel like this solves the primary issue: messaging.  After this
patch, the user should know that everything was a success.

*** package.el.orig 2020-01-17 10:11:48.000000000 -0700
--- package.el 2020-01-17 10:12:36.000000000 -0700
*************** to install it but still mark it as selec
*** 2076,2082 ****
                   (package-compute-transaction () (list (list pkg))))))
          (progn
            (package-download-transaction transaction)
!           (package--quickstart-maybe-refresh))
        (message "`%s' is already installed" name))))

  (defun package-strip-rcs-id (str)
--- 2076,2083 ----
                   (package-compute-transaction () (list (list pkg))))))
          (progn
            (package-download-transaction transaction)
!           (package--quickstart-maybe-refresh)
!           (message "Package `%s' installed." name))
        (message "`%s' is already installed" name))))

  (defun package-strip-rcs-id (str)

Message #16 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Olson <ryan.olson.x <at> gmail.com>
To: 21857 <at> debbugs.gnu.org
Subject: Re: PATCH to show message after `package-install` installs
 successfully
Date: Fri, 17 Jan 2020 11:04:22 -0700

Switched patch to `diff -u` variant.

--- package.el.orig 2020-01-17 10:11:48.000000000 -0700
+++ package.el 2020-01-17 10:12:36.000000000 -0700
@@ -2076,7 +2076,8 @@
                  (package-compute-transaction () (list (list pkg))))))
         (progn
           (package-download-transaction transaction)
-          (package--quickstart-maybe-refresh))
+          (package--quickstart-maybe-refresh)
+          (message "Package `%s' installed." name))
       (message "`%s' is already installed" name))))

 (defun package-strip-rcs-id (str)

On Fri, Jan 17, 2020 at 10:53 AM Ryan Olson <ryan.olson.x <at> gmail.com> wrote:
>
> When `package-install` function finishes successfully, this patch
> (below) shows the message "Package `package-name` installed."  This
> matches the message that is shown with the function `package-delete`.
> I feel like this solves the primary issue: messaging.  After this
> patch, the user should know that everything was a success.
>
> *** package.el.orig 2020-01-17 10:11:48.000000000 -0700
> --- package.el 2020-01-17 10:12:36.000000000 -0700
> *************** to install it but still mark it as selec
> *** 2076,2082 ****
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)
> --- 2076,2083 ----
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh)
> !           (message "Package `%s' installed." name))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)

Message #21 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Olson <ryan.olson.x <at> gmail.com>
To: 21857 <at> debbugs.gnu.org
Subject: Feedback / Merge on patch
Date: Thu, 20 Feb 2020 10:52:07 -0700

What can I do to get this merged into emacs master?  Any feedback on my patch?

Message #24 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ryan Olson <ryan.olson.x <at> gmail.com>
Cc: 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: PATCH to show message after `package-install` installs
 successfully
Date: Sun, 23 Feb 2020 09:39:20 -0500

Ryan Olson <ryan.olson.x <at> gmail.com> writes:

> What can I do to get this merged into emacs master?  Any feedback on my patch?

The patch looks fine.  It would help if it included a commit log message
(as described in CONTRIBUTE).  That way it's a bit less work to merge
it, and is therefore more likely to happen.

Message #27 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Olson <ryan.olson.x <at> gmail.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: PATCH to show message after `package-install` installs
 successfully
Date: Sun, 23 Feb 2020 08:19:07 -0700

[Message part 1 (text/plain, inline)]

Noam Postavsky <npostavs <at> gmail.com> wrote:
> The patch looks fine.  It would help if it included a commit log message
> (as described in CONTRIBUTE).  That way it's a bit less work to merge
> it, and is therefore more likely to happen.

Thanks! Attached is a new patch created using instructions found in CONTRIBUTE.

[0001-Show-friendly-message-after-package-install.patch (application/octet-stream, attachment)]

Message #30 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ryan Olson <ryan.olson.x <at> gmail.com>
Cc: 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: PATCH to show message after `package-install` installs
 successfully
Date: Tue, 25 Feb 2020 19:47:10 -0500

Ryan Olson <ryan.olson.x <at> gmail.com> writes:

> Noam Postavsky <npostavs <at> gmail.com> wrote:
>> The patch looks fine.  It would help if it included a commit log message
>> (as described in CONTRIBUTE).  That way it's a bit less work to merge
>> it, and is therefore more likely to happen.
>
> Thanks! Attached is a new patch created using instructions found in CONTRIBUTE.

Thanks, I've pushed it to master after adding ChangeLog formatting.  I'm
leaving this bug open, since there's also a mention of updating the
*Packages* buffer.

[1: 4a94881345]: 2020-02-25 19:42:08 -0500
  Show friendly message after package install
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4a94881345819dd68062bc729b5b7ddeab00041b

Message #33 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 39163 <at> debbugs.gnu.org, 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: package install should give better feedback
Date: Sun, 09 Aug 2020 14:09:21 +0200

David Reitter <david.reitter <at> gmail.com> writes:

> When installing a package, give an acceptable “XXX successfully
> installed” message in the echo area as the last message.
> As it is, it seems to just show a “done” for the last dependency,
> which is confusing or uninformative.

This was fixed, apparently.

> Also, if the *Packages* buffer is present--which it will be because
> the user may have picked the package to install after doing M-x
> list-packages—this buffer should be updated to show that the package
> was installed.

If I `I' and then `x', the package buffer is updated.  Do you have a
recipe to reproduce this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #36 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: David Reitter <david.reitter <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 39163 <at> debbugs.gnu.org, 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: package install should give better feedback
Date: Sun, 9 Aug 2020 16:29:02 +0200

[Message part 1 (text/plain, inline)]

No recipe, too old - I no longer maintain Aquamacs. If the first bug was
fixed and there is a way to update it, so be it. Automatic update is
suggested.

On Sun, Aug 9, 2020 at 14:09 Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> David Reitter <david.reitter <at> gmail.com> writes:
>
> > When installing a package, give an acceptable “XXX successfully
> > installed” message in the echo area as the last message.
> > As it is, it seems to just show a “done” for the last dependency,
> > which is confusing or uninformative.
>
> This was fixed, apparently.
>
> > Also, if the *Packages* buffer is present--which it will be because
> > the user may have picked the package to install after doing M-x
> > list-packages—this buffer should be updated to show that the package
> > was installed.
>
> If I `I' and then `x', the package buffer is updated.  Do you have a
> recipe to reproduce this bug?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[Message part 2 (text/html, inline)]

Message #39 received at 21857 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 39163 <at> debbugs.gnu.org, 21857 <at> debbugs.gnu.org
Subject: Re: bug#21857: package install should give better feedback
Date: Mon, 10 Aug 2020 12:49:22 +0200

David Reitter <david.reitter <at> gmail.com> writes:

> No recipe, too old - I no longer maintain Aquamacs. If the first bug
> was fixed and there is a way to update it, so be it. Automatic update
> is suggested.

OK; then I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.