GNU logs - #21867, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Zachary Kanfer <zkanfer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 09 Nov 2015 04:59:01 +0000
Resent-Message-ID: <handler.21867.B.144704513032637 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 21867 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Zachary Kanfer <zkanfer@HIDDEN>
Date: Sun, 8 Nov 2015 23:58:01 -0500
Message-ID: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
Content-Type: multipart/alternative; boundary=001a1146d85c45762305241471f0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--001a1146d85c45762305241471f0
Content-Type: text/plain; charset=UTF-8

The way that lossage now shows different commands on different lines is
really useful, but I found a way where it's not treating two different
things as different commands. To reproduce:

emacs -Q

open the scratch buffer

insert this whole s-expression:

(read-char)

Then, with point at the end of that line, type:

C-x C-e a C-h l

This evaluates the (read-char) sexp which reads the `a` typed, then
views lossage.

The last lines of lossage are:

 C-x C-e [eval-last-sexp]
 a C-h l [view-lossage]

Note that the log line calling view-lossage also includes "a", the
command read by read-char. I would expect the lossage buffer to be
something like this:

 C-x C-e [eval-last-sexp]
 a [char read by read-char]
 C-h l [view-lossage]

This does not happen with read-string; one gets logs like:

 C-x C-e [eval-last-sexp]
 p [self-insert-command]
 a [self-insert-command]
 n [self-insert-command]
 t [self-insert-command]
 s [self-insert-command]
 <return> [exit-minibuffer]
 C-h l [view-lossage]

I noted this when viewing lossage after calling org-agenda, which I
think uses read-char to get a character to dispatch on. However, I'm not
sure; the package is too complicated for me to track down how it's
reading the character. The same behavior happens when calling read-char,
so it might be the same thing.


In GNU Emacs 25.0.50.9 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2015-10-31
Repository revision: e4740877d6feeb357d7437e6025dba641800c11d
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:    Ubuntu 14.04.3 LTS

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Help

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
C-h j is undefined
Rebuilding agenda buffer...done
Log mode is on
Type "q" in help window to restore its previous buffer.
C-, is undefined
Press key for agenda command:
C-c l is undefined
Press key for agenda command:

C-, is undefined

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
help-fns mail-prsvr mail-utils help-mode cal-iso org-agenda org
org-macro org-footnote org-pcomplete pcomplete org-list org-faces
org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint comint
ansi-color ring ob-core ob-eval org-compat org-macs org-loaddefs
format-spec find-func cal-menu easymenu calendar cal-loaddefs edmacro
kmacro cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 133879 6850)
 (symbols 48 25562 0)
 (miscs 40 489 115)
 (strings 32 32608 5367)
 (string-bytes 1 1089148)
 (vectors 16 16809)
 (vector-slots 8 483236 6626)
 (floats 8 171 440)
 (intervals 56 364 3)
 (buffers 976 14)
 (heap 1024 35202 1287))

--001a1146d85c45762305241471f0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">The way that lossage now shows different commands on diffe=
rent lines is<br>really useful, but I found a way where it&#39;s not treati=
ng two different<br>things as different commands. To reproduce:<br><br>emac=
s -Q<br><br>open the scratch buffer<br><br>insert this whole s-expression:<=
br><br>(read-char)<br><br>Then, with point at the end of that line, type:<b=
r><br>C-x C-e a C-h l<br><br>This evaluates the (read-char) sexp which read=
s the `a` typed, then<br>views lossage.<br><br>The last lines of lossage ar=
e:<br><br>=C2=A0C-x C-e [eval-last-sexp]<br>=C2=A0a C-h l [view-lossage]<br=
><br>Note that the log line calling view-lossage also includes &quot;a&quot=
;, the<br>command read by read-char. I would expect the lossage buffer to b=
e<br>something like this:<br><br>=C2=A0C-x C-e [eval-last-sexp]<br>=C2=A0a =
[char read by read-char]<br>=C2=A0C-h l [view-lossage]<br><br>This does not=
 happen with read-string; one gets logs like:<br><br>=C2=A0C-x C-e [eval-la=
st-sexp]<br>=C2=A0p [self-insert-command]<br>=C2=A0a [self-insert-command]<=
br>=C2=A0n [self-insert-command]<br>=C2=A0t [self-insert-command]<br>=C2=A0=
s [self-insert-command]<br>=C2=A0&lt;return&gt; [exit-minibuffer]<br>=C2=A0=
C-h l [view-lossage]<br><br>I noted this when viewing lossage after calling=
 org-agenda, which I<br>think uses read-char to get a character to dispatch=
 on. However, I&#39;m not<br>sure; the package is too complicated for me to=
 track down how it&#39;s<br>reading the character. The same behavior happen=
s when calling read-char,<br>so it might be the same thing.<br><br><br>In G=
NU Emacs 25.0.50.9 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)<br>=C2=
=A0of 2015-10-31<br>Repository revision: e4740877d6feeb357d7437e6025dba6418=
00c11d<br>Windowing system distributor &#39;The X.Org Foundation&#39;, vers=
ion 11.0.11501000<br>System Description:=C2=A0=C2=A0=C2=A0 Ubuntu 14.04.3 L=
TS<br><br>Configured features:<br>XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOT=
IFY GNUTLS LIBXML2 FREETYPE XFT<br>ZLIB TOOLKIT_SCROLL_BARS GTK3 X11<br><br=
>Important settings:<br>=C2=A0 value of $LANG: en_US.UTF-8<br>=C2=A0 value =
of $XMODIFIERS: @im=3Dibus<br>=C2=A0 locale-coding-system: utf-8-unix<br><b=
r>Major mode: Help<br><br>Minor modes in effect:<br>=C2=A0 tooltip-mode: t<=
br>=C2=A0 global-eldoc-mode: t<br>=C2=A0 electric-indent-mode: t<br>=C2=A0 =
mouse-wheel-mode: t<br>=C2=A0 tool-bar-mode: t<br>=C2=A0 menu-bar-mode: t<b=
r>=C2=A0 file-name-shadow-mode: t<br>=C2=A0 global-font-lock-mode: t<br>=C2=
=A0 font-lock-mode: t<br>=C2=A0 blink-cursor-mode: t<br>=C2=A0 auto-composi=
tion-mode: t<br>=C2=A0 auto-encryption-mode: t<br>=C2=A0 auto-compression-m=
ode: t<br>=C2=A0 buffer-read-only: t<br>=C2=A0 line-number-mode: t<br>=C2=
=A0 transient-mark-mode: t<br><br>Recent messages:<br>C-h j is undefined<br=
>Rebuilding agenda buffer...done<br>Log mode is on<br>Type &quot;q&quot; in=
 help window to restore its previous buffer.<br>C-, is undefined<br>Press k=
ey for agenda command:<br>C-c l is undefined<br>Press key for agenda comman=
d:<br><br>C-, is undefined<br><br>Load-path shadows:<br>None found.<br><br>=
Features:<br>(shadow sort gnus-util mail-extr emacsbug message dired rfc822=
 mml<br>mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev=
<br>gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util<br>hel=
p-fns mail-prsvr mail-utils help-mode cal-iso org-agenda org<br>org-macro o=
rg-footnote org-pcomplete pcomplete org-list org-faces<br>org-entities nout=
line outline easy-mmode org-version ob-emacs-lisp ob<br>ob-tangle ob-ref ob=
-lob ob-table ob-exp org-src ob-keys ob-comint comint<br>ansi-color ring ob=
-core ob-eval org-compat org-macs org-loaddefs<br>format-spec find-func cal=
-menu easymenu calendar cal-loaddefs edmacro<br>kmacro cl-loaddefs pcase cl=
-lib time-date mule-util tooltip eldoc<br>electric uniquify ediff-hook vc-h=
ooks lisp-float-type mwheel x-win<br>term/common-win x-dnd tool-bar dnd fon=
tset image regexp-opt fringe<br>tabulated-list newcomment elisp-mode lisp-m=
ode prog-mode register page<br>menu-bar rfn-eshadow timer select scroll-bar=
 mouse jit-lock font-lock<br>syntax facemenu font-core frame cl-generic cha=
m georgian utf-8-lang<br>misc-lang vietnamese tibetan thai tai-viet lao kor=
ean japanese eucjp-ms<br>cp51932 hebrew greek romanian slovak czech europea=
n ethiopic indian<br>cyrillic chinese charscript case-table epa-hook jka-cm=
pr-hook help<br>simple abbrev minibuffer cl-preloaded nadvice loaddefs butt=
on faces<br>cus-face macroexp files text-properties overlay sha1 md5 base64=
 format<br>env code-pages mule custom widget hashtable-print-readable backq=
uote<br>inotify dynamic-setting system-font-setting font-render-setting<br>=
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)<br><br>M=
emory information:<br>((conses 16 133879 6850)<br>=C2=A0(symbols 48 25562 0=
)<br>=C2=A0(miscs 40 489 115)<br>=C2=A0(strings 32 32608 5367)<br>=C2=A0(st=
ring-bytes 1 1089148)<br>=C2=A0(vectors 16 16809)<br>=C2=A0(vector-slots 8 =
483236 6626)<br>=C2=A0(floats 8 171 440)<br>=C2=A0(intervals 56 364 3)<br>=
=C2=A0(buffers 976 14)<br>=C2=A0(heap 1024 35202 1287))<br><br></div>

--001a1146d85c45762305241471f0--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.503 (Entity 5.503)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Zachary Kanfer <zkanfer@HIDDEN>
Subject: bug#21867: Acknowledgement (25.0.50; lossage's log doesn't treat
 characters read by read-char as separate commands)
Message-ID: <handler.21867.B.144704513032637.ack <at> debbugs.gnu.org>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
X-Gnu-PR-Message: ack 21867
X-Gnu-PR-Package: emacs
Reply-To: 21867 <at> debbugs.gnu.org
Date: Mon, 09 Nov 2015 04:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 21867 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
21867: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D21867
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 18:06:02 +0000
Resent-Message-ID: <handler.21867.B21867.156468273616546 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Zachary Kanfer <zkanfer@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
Date: Thu, 01 Aug 2019 20:05:29 +0200
In-Reply-To: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 (Zachary Kanfer's message of "Sun, 8 Nov 2015 23:58:01 -0500")
Message-ID: <87blx8iwwm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Zachary Kanfer <zkanfer@HIDDEN> writes:

> The way that lossage now shows different commands on different lines is
> really useful, but I found a way where it's not treating two different
> things as different commands. To reproduce:
>
> emacs -Q
>
> open the scratch buffer
>
> insert this whole s-expression:
>
> (read-char)
>
> Then, with point at the end of that line, type:
>
> C-x C-e a C-h l
>
> This evaluates the (read-char) sexp which reads the `a` typed, then
> views lossage.
>
> The last lines of lossage are:
>
>  C-x C-e [eval-last-sexp]
>  a C-h l [view-lossage]
>
> Note that the log line calling view-lossage also includes "a", the
> command read by read-char. I would expect the lossage buffer to be
> something like this:
>
>  C-x C-e [eval-last-sexp]
>  a [char read by read-char]
>  C-h l [view-lossage]
>
> This does not happen with read-string; one gets logs like:
>
>  C-x C-e [eval-last-sexp]
>  p [self-insert-command]
>  a [self-insert-command]
>  n [self-insert-command]
>  t [self-insert-command]
>  s [self-insert-command]
>  <return> [exit-minibuffer]
>  C-h l [view-lossage]

(I'm going through old bug reports that have unfortunately not gotten
any responses.)

I'm seeing the same thing in Emacs 27 -- C-x C-e on the `(read-char)'
and then a couple of <down>s:

 C-x C-e		;; eval-last-sexp
 a <down>		;; next-line
 <down>			;; next-line

This is what's returned by `recent-keys':

 24 5
 (nil . eval-last-sexp)
 97 down
 (nil . next-line)
 down
 (nil . next-line)

97 is the ?a.

The reason is that `read-char' does this:

  /* Store these characters into recent_keys, the dribble file if any,
     and the keyboard macro being defined, if any.  */
  record_char (c);
  recorded = true;
  if (! NILP (also_record))
    record_char (also_record);

But...  it's not clear what `read-char' should put into recent_keys
here, which is a not-very-clear structure.  Perhaps (nil . "char read by
read-char") after the char and then adjust `view-lossage'?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 1 Aug 2019 18:05:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 01 14:05:44 2019
Received: from localhost ([127.0.0.1]:55160 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htFSS-0004JN-CK
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:05:44 -0400
Received: from quimby.gnus.org ([80.91.231.51]:43660)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htFSQ-0004JE-33
 for control <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:05:42 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1htFSN-0002dI-HB
 for control <at> debbugs.gnu.org; Thu, 01 Aug 2019 20:05:41 +0200
Date: Thu, 01 Aug 2019 20:05:38 +0200
Message-Id: <87a7csiwwd.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #21867
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 21867 + confirmed quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 21867 + confirmed
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 18:22:01 +0000
Resent-Message-ID: <handler.21867.B21867.156468370626296 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156468370626296
          (code B ref 21867); Thu, 01 Aug 2019 18:22:01 +0000
Received: (at 21867) by debbugs.gnu.org; 1 Aug 2019 18:21:46 +0000
Received: from localhost ([127.0.0.1]:55176 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htFhx-0006q4-Nf
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:21:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:45198)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1htFht-0006pq-W3
 for 21867 <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:21:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42167)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1htFho-00077w-PI; Thu, 01 Aug 2019 14:21:36 -0400
Received: from [176.228.60.248] (port=4855 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1htFho-00043P-5F; Thu, 01 Aug 2019 14:21:36 -0400
Date: Thu, 01 Aug 2019 21:21:29 +0300
Message-Id: <83o918hhli.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87blx8iwwm.fsf@HIDDEN> (message from Lars Ingebrigtsen
 on Thu, 01 Aug 2019 20:05:29 +0200)
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Date: Thu, 01 Aug 2019 20:05:29 +0200
> Cc: 21867 <at> debbugs.gnu.org
> 
> > (read-char)
> >
> > Then, with point at the end of that line, type:
> >
> > C-x C-e a C-h l
> >
> > This evaluates the (read-char) sexp which reads the `a` typed, then
> > views lossage.
> >
> > The last lines of lossage are:
> >
> >  C-x C-e [eval-last-sexp]
> >  a C-h l [view-lossage]
> >
> > Note that the log line calling view-lossage also includes "a", the
> > command read by read-char. I would expect the lossage buffer to be
> > something like this:
> >
> >  C-x C-e [eval-last-sexp]
> >  a [char read by read-char]
> >  C-h l [view-lossage]

FWIW, I don't see why 'a' should be treated as a command here.  It
isn't.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 18:42:01 +0000
Resent-Message-ID: <handler.21867.B21867.15646848703969 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.15646848703969
          (code B ref 21867); Thu, 01 Aug 2019 18:42:01 +0000
Received: (at 21867) by debbugs.gnu.org; 1 Aug 2019 18:41:10 +0000
Received: from localhost ([127.0.0.1]:55205 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htG0j-00011w-NF
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:41:09 -0400
Received: from quimby.gnus.org ([80.91.231.51]:44112)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htG0i-00011p-Bd
 for 21867 <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:41:08 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1htG0f-0002s5-0G; Thu, 01 Aug 2019 20:41:07 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
Date: Thu, 01 Aug 2019 20:41:04 +0200
In-Reply-To: <83o918hhli.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Aug
 2019 21:21:29 +0300")
Message-ID: <87tvb0hgov.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> > C-x C-e
 [eval-last-sexp]
 >> > a [char read by read-char] >> > C-h l [view-lossage] > > FWIW, I don't
 see why 'a' should be treated as a command here. It > isn't. 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> >  C-x C-e [eval-last-sexp]
>> >  a [char read by read-char]
>> >  C-h l [view-lossage]
>
> FWIW, I don't see why 'a' should be treated as a command here.  It
> isn't.

No, but `view-lossage' says "Display last few input keystrokes and the
commands run."  What `read-char' comes under "input keystrokes", I
guess?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 18:52:01 +0000
Resent-Message-ID: <handler.21867.B21867.156468548013147 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156468548013147
          (code B ref 21867); Thu, 01 Aug 2019 18:52:01 +0000
Received: (at 21867) by debbugs.gnu.org; 1 Aug 2019 18:51:20 +0000
Received: from localhost ([127.0.0.1]:55218 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htGAZ-0003Px-A3
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:51:19 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50820)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1htGAX-0003Pj-SJ
 for 21867 <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:51:18 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42461)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1htGAS-00046b-Ld; Thu, 01 Aug 2019 14:51:12 -0400
Received: from [176.228.60.248] (port=2678 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1htGAS-0007h5-1t; Thu, 01 Aug 2019 14:51:12 -0400
Date: Thu, 01 Aug 2019 21:51:05 +0300
Message-Id: <83mugshg86.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87tvb0hgov.fsf@HIDDEN> (message from Lars Ingebrigtsen
 on Thu, 01 Aug 2019 20:41:04 +0200)
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: zkanfer@HIDDEN,  21867 <at> debbugs.gnu.org
> Date: Thu, 01 Aug 2019 20:41:04 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> >  C-x C-e [eval-last-sexp]
> >> >  a [char read by read-char]
> >> >  C-h l [view-lossage]
> >
> > FWIW, I don't see why 'a' should be treated as a command here.  It
> > isn't.
> 
> No, but `view-lossage' says "Display last few input keystrokes and the
> commands run."

Which is what we do: we display 'a', but we don't show any command for
it.

> What `read-char' comes under "input keystrokes", I guess?

Yes.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 18:59:01 +0000
Resent-Message-ID: <handler.21867.B21867.156468593713972 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156468593713972
          (code B ref 21867); Thu, 01 Aug 2019 18:59:01 +0000
Received: (at 21867) by debbugs.gnu.org; 1 Aug 2019 18:58:57 +0000
Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htGHx-0003dI-75
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:58:57 -0400
Received: from quimby.gnus.org ([80.91.231.51]:44364)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htGHv-0003d9-Bo
 for 21867 <at> debbugs.gnu.org; Thu, 01 Aug 2019 14:58:56 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1htGHs-0002zU-15; Thu, 01 Aug 2019 20:58:54 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
Date: Thu, 01 Aug 2019 20:58:50 +0200
In-Reply-To: <83mugshg86.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Aug
 2019 21:51:05 +0300")
Message-ID: <877e7whfv9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Eli Zaretskii <eliz@HIDDEN> writes: >> No,
 but `view-lossage'
 says "Display last few input keystrokes and the >> commands run." > > Which
 is what we do: we display 'a', but we don't show any command for > it. >
 >> What `read-char' comes [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> No, but `view-lossage' says "Display last few input keystrokes and the
>> commands run."
>
> Which is what we do: we display 'a', but we don't show any command for
> it.
>
>> What `read-char' comes under "input keystrokes", I guess?
>
> Yes.

Right, but view-lossage currently says

 C-x C-e ;; eval-last-sexp
 a C-h l ;; view-lossage

which is a very curious way of displaying this.  It makes it look like
"a C-h l" is a key stroke.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 19:19:02 +0000
Resent-Message-ID: <handler.21867.B21867.156468710832379 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156468710832379
          (code B ref 21867); Thu, 01 Aug 2019 19:19:02 +0000
Received: (at 21867) by debbugs.gnu.org; 1 Aug 2019 19:18:28 +0000
Received: from localhost ([127.0.0.1]:55268 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htGap-0008QA-Ot
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 15:18:27 -0400
Received: from eggs.gnu.org ([209.51.188.92]:58696)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1htGan-0008Pv-Q6
 for 21867 <at> debbugs.gnu.org; Thu, 01 Aug 2019 15:18:26 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:42875)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1htGai-0006TP-KL; Thu, 01 Aug 2019 15:18:20 -0400
Received: from [176.228.60.248] (port=4325 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1htGai-0002vZ-5A; Thu, 01 Aug 2019 15:18:20 -0400
Date: Thu, 01 Aug 2019 22:18:13 +0300
Message-Id: <83lfwcheyy.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <877e7whfv9.fsf@HIDDEN> (message from Lars Ingebrigtsen
 on Thu, 01 Aug 2019 20:58:50 +0200)
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: 21867 <at> debbugs.gnu.org,  zkanfer@HIDDEN
> Date: Thu, 01 Aug 2019 20:58:50 +0200
> 
> >> What `read-char' comes under "input keystrokes", I guess?
> >
> > Yes.
> 
> Right, but view-lossage currently says
> 
>  C-x C-e ;; eval-last-sexp
>  a C-h l ;; view-lossage
> 
> which is a very curious way of displaying this.  It makes it look like
> "a C-h l" is a key stroke.

A newline should be enough to fix that, I think.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Aug 2019 19:26:01 +0000
Resent-Message-ID: <handler.21867.B21867.1564687556780 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.1564687556780
          (code B ref 21867); Thu, 01 Aug 2019 19:26:01 +0000
Received: (at 21867) by debbugs.gnu.org; 1 Aug 2019 19:25:56 +0000
Received: from localhost ([127.0.0.1]:55291 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htGi3-0000CW-SA
	for submit <at> debbugs.gnu.org; Thu, 01 Aug 2019 15:25:56 -0400
Received: from quimby.gnus.org ([80.91.231.51]:44804)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htGi2-0000CO-T7
 for 21867 <at> debbugs.gnu.org; Thu, 01 Aug 2019 15:25:55 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1htGhy-0003Bv-CP; Thu, 01 Aug 2019 21:25:54 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
Date: Thu, 01 Aug 2019 21:25:49 +0200
In-Reply-To: <83lfwcheyy.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Aug
 2019 22:18:13 +0300")
Message-ID: <87k1bwg01u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From: Lars
 Ingebrigtsen
 <larsi@HIDDEN> >> Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN >> Date:
 Thu, 01 Aug 2019 20:58:50 +0200 >> >> >> What `read-char' comes under "input
 keystrokes", I guess? [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Lars Ingebrigtsen <larsi@HIDDEN>
>> Cc: 21867 <at> debbugs.gnu.org,  zkanfer@HIDDEN
>> Date: Thu, 01 Aug 2019 20:58:50 +0200
>> 
>> >> What `read-char' comes under "input keystrokes", I guess?
>> >
>> > Yes.
>> 
>> Right, but view-lossage currently says
>> 
>>  C-x C-e ;; eval-last-sexp
>>  a C-h l ;; view-lossage
>> 
>> which is a very curious way of displaying this.  It makes it look like
>> "a C-h l" is a key stroke.
>
> A newline should be enough to fix that, I think.

Yes, that'd be OK, I think, but it means that we have to
put...  something...  into the recent_keys variable to mark the "a" as
having been read by `read-string'.  I suggested (nil . "some-string"),
but perhaps just (nil) would be OK?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Aug 2019 06:42:01 +0000
Resent-Message-ID: <handler.21867.B21867.156472811116858 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156472811116858
          (code B ref 21867); Fri, 02 Aug 2019 06:42:01 +0000
Received: (at 21867) by debbugs.gnu.org; 2 Aug 2019 06:41:51 +0000
Received: from localhost ([127.0.0.1]:55720 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htRGA-0004Nq-OB
	for submit <at> debbugs.gnu.org; Fri, 02 Aug 2019 02:41:51 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37476)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1htRG9-0004Nb-1K
 for 21867 <at> debbugs.gnu.org; Fri, 02 Aug 2019 02:41:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50849)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1htRG3-0000hm-DY; Fri, 02 Aug 2019 02:41:43 -0400
Received: from [176.228.60.248] (port=2078 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1htRG2-0000XR-MZ; Fri, 02 Aug 2019 02:41:43 -0400
Date: Fri, 02 Aug 2019 09:41:37 +0300
Message-Id: <83ef24gjby.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87k1bwg01u.fsf@HIDDEN> (message from Lars Ingebrigtsen
 on Thu, 01 Aug 2019 21:25:49 +0200)
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: 21867 <at> debbugs.gnu.org,  zkanfer@HIDDEN
> Date: Thu, 01 Aug 2019 21:25:49 +0200
> 
> >>  C-x C-e ;; eval-last-sexp
> >>  a C-h l ;; view-lossage
> >> 
> >> which is a very curious way of displaying this.  It makes it look like
> >> "a C-h l" is a key stroke.
> >
> > A newline should be enough to fix that, I think.
> 
> Yes, that'd be OK, I think, but it means that we have to
> put...  something...  into the recent_keys variable to mark the "a" as
> having been read by `read-string'.  I suggested (nil . "some-string"),
> but perhaps just (nil) would be OK?

Or maybe a special symbol?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Aug 2019 11:20:01 +0000
Resent-Message-ID: <handler.21867.B21867.156474474819061 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156474474819061
          (code B ref 21867); Fri, 02 Aug 2019 11:20:01 +0000
Received: (at 21867) by debbugs.gnu.org; 2 Aug 2019 11:19:08 +0000
Received: from localhost ([127.0.0.1]:55867 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htVaV-0004xN-IW
	for submit <at> debbugs.gnu.org; Fri, 02 Aug 2019 07:19:07 -0400
Received: from quimby.gnus.org ([80.91.231.51]:57084)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htVaU-0004xD-Dv
 for 21867 <at> debbugs.gnu.org; Fri, 02 Aug 2019 07:19:07 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1htVaP-0001SV-U3; Fri, 02 Aug 2019 13:19:04 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
Date: Fri, 02 Aug 2019 13:19:01 +0200
In-Reply-To: <83ef24gjby.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 02 Aug
 2019 09:41:37 +0300")
Message-ID: <8736ijak7u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Eli Zaretskii <eliz@HIDDEN> writes: > Or maybe a special
 symbol? The following patch does this. Does this look like the thing to do?
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> Or maybe a special symbol?

The following patch does this.  Does this look like the thing to do?

The test case, with this patch, now looks like this:

 C-e			;; move-end-of-line
 C-x C-e		;; eval-last-sexp
 a 			;; 
 C-h l			;; view-lossage

I've looked at other in-tree usages of `recent-keys', and it doesn't
look like this should affect anything else.

diff --git a/lisp/help.el b/lisp/help.el
index 039d0c44e4..0cd2aecba5 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -471,6 +471,9 @@ view-lossage
 			 ((and (consp key) (null (car key)))
 			  (format ";; %s\n" (if (symbolp (cdr key)) (cdr key)
 					      "anonymous-command")))
+                         ((eq key 'non-command-character)
+                          ;; This comes from `read-char'.
+                          "\n")
 			 ((or (integerp key) (symbolp key) (listp key))
 			  (single-key-description key))
 			 (t
diff --git a/src/keyboard.c b/src/keyboard.c
index db5ca4e547..4e13bec5dd 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -2091,7 +2091,6 @@ show_help_echo (Lisp_Object help, Lisp_Object window, Lisp_Object object,
 
 static Lisp_Object kbd_buffer_get_event (KBOARD **kbp, bool *used_mouse_menu,
 					 struct timespec *end_time);
-static void record_char (Lisp_Object c);
 
 static Lisp_Object help_form_saved_window_configs;
 static void
@@ -3192,7 +3191,7 @@ help_char_p (Lisp_Object c)
 
 /* Record the input event C in various ways.  */
 
-static void
+void
 record_char (Lisp_Object c)
 {
   /* quail.el binds this to avoid recording keys twice.  */
@@ -11069,6 +11068,8 @@ syms_of_keyboard (void)
 
   DEFSYM (Qundefined, "undefined");
 
+  DEFSYM (Qnon_command_character, "non-command-character");
+
   /* Hooks to run before and after each command.  */
   DEFSYM (Qpre_command_hook, "pre-command-hook");
   DEFSYM (Qpost_command_hook, "post-command-hook");
diff --git a/src/lisp.h b/src/lisp.h
index f437609fe1..ef03935b7a 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -4375,6 +4375,7 @@ fast_string_match_ignore_case (Lisp_Object regexp, Lisp_Object string)
 extern void init_keyboard (void);
 extern void syms_of_keyboard (void);
 extern void keys_of_keyboard (void);
+extern void record_char (Lisp_Object);
 
 /* Defined in indent.c.  */
 extern ptrdiff_t current_column (void);
diff --git a/src/lread.c b/src/lread.c
index eec88760d4..88a27531eb 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -679,8 +679,11 @@ read_filtered_event (bool no_switch_frame, bool ascii_required,
   /* Read until we get an acceptable event.  */
  retry:
   do
-    val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
-		     NUMBERP (seconds) ? &end_time : NULL);
+    {
+      val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
+		       NUMBERP (seconds) ? &end_time : NULL);
+      record_char (Qnon_command_character);
+    }
   while (FIXNUMP (val) && XFIXNUM (val) == -2); /* wrong_kboard_jmpbuf */
 
   if (BUFFERP (val))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 2 Aug 2019 11:19:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Aug 02 07:19:14 2019
Received: from localhost ([127.0.0.1]:55870 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htVab-0004xi-Tx
	for submit <at> debbugs.gnu.org; Fri, 02 Aug 2019 07:19:14 -0400
Received: from quimby.gnus.org ([80.91.231.51]:57100)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htVaa-0004xa-5u
 for control <at> debbugs.gnu.org; Fri, 02 Aug 2019 07:19:12 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1htVaX-0001Sg-Jr
 for control <at> debbugs.gnu.org; Fri, 02 Aug 2019 13:19:11 +0200
Date: Fri, 02 Aug 2019 13:19:09 +0200
Message-Id: <871ry3ak7m.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #21867
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 21867 + patch quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 21867 + patch
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Aug 2019 12:03:02 +0000
Resent-Message-ID: <handler.21867.B21867.15647473447128 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Lars Ingebrigtsen <larsi@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.15647473447128
          (code B ref 21867); Fri, 02 Aug 2019 12:03:02 +0000
Received: (at 21867) by debbugs.gnu.org; 2 Aug 2019 12:02:24 +0000
Received: from localhost ([127.0.0.1]:55939 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htWGN-0001qq-Ak
	for submit <at> debbugs.gnu.org; Fri, 02 Aug 2019 08:02:24 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48225)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1htWGL-0001qd-Bt
 for 21867 <at> debbugs.gnu.org; Fri, 02 Aug 2019 08:02:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37020)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1htWGF-0004YE-TB; Fri, 02 Aug 2019 08:02:15 -0400
Received: from [176.228.60.248] (port=2111 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1htWGF-0003He-1h; Fri, 02 Aug 2019 08:02:15 -0400
Date: Fri, 02 Aug 2019 15:02:10 +0300
Message-Id: <83lfwbg4hp.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <8736ijak7u.fsf@HIDDEN> (message from Lars Ingebrigtsen
 on Fri, 02 Aug 2019 13:19:01 +0200)
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Lars Ingebrigtsen <larsi@HIDDEN>
> Cc: 21867 <at> debbugs.gnu.org,  zkanfer@HIDDEN
> Date: Fri, 02 Aug 2019 13:19:01 +0200
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > Or maybe a special symbol?
> 
> The following patch does this.  Does this look like the thing to do?
> 
> The test case, with this patch, now looks like this:
> 
>  C-e			;; move-end-of-line
>  C-x C-e		;; eval-last-sexp
>  a 			;; 
>  C-h l			;; view-lossage
> 
> I've looked at other in-tree usages of `recent-keys', and it doesn't
> look like this should affect anything else.

SGTM.  Stefan, any comments/objections/suggestions?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Aug 2019 20:17:02 +0000
Resent-Message-ID: <handler.21867.B21867.156477700724381 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156477700724381
          (code B ref 21867); Fri, 02 Aug 2019 20:17:02 +0000
Received: (at 21867) by debbugs.gnu.org; 2 Aug 2019 20:16:47 +0000
Received: from localhost ([127.0.0.1]:57828 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htdyp-0006Kt-58
	for submit <at> debbugs.gnu.org; Fri, 02 Aug 2019 16:16:47 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40738)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1htdyn-0006F0-4g
 for 21867 <at> debbugs.gnu.org; Fri, 02 Aug 2019 16:16:45 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C5499445C32;
 Fri,  2 Aug 2019 16:16:39 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7EEAB445C30;
 Fri,  2 Aug 2019 16:16:38 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1564776998;
 bh=1CIuPnsrW54vO/joHyjFG3XwiUNX02b87z9wDtMVWnA=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
 b=plvE/czn2Vf1lG8X2LuHNPJcdgyA4JDTW8WnBXpCnGgam/OiUe8GUY4l080ElGyPg
 Pmgnc9JrIimOxv2oK27PxmM/g2n7ekFic1C7pxe5q59pTdNZwbzPGylGpxWWpyxl+R
 q3EZUFqPPndP5oXEN1nx920DEGPWK986P2NiEDU8U4QF3yF1mHBfF+8jqu9tKa97k9
 07gE64nckIaCxeCaOiWsz0i8/p2LOK45Dji8NJTRHiaei27bPWWhBiJmIBlA+CMxHA
 M96Q3589WvavSVd9mAPB5ktLEbAQ9jx99EvQfvbJj+Zh5JKORd5Kz2+houEVWa3rpy
 GkHyDFOMdoFdg==
Received: from pastel (unknown [45.72.135.224])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 282341202D5;
 Fri,  2 Aug 2019 16:16:38 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
Date: Fri, 02 Aug 2019 16:16:37 -0400
In-Reply-To: <8736ijak7u.fsf@HIDDEN> (Lars Ingebrigtsen's message of
 "Fri, 02 Aug 2019 13:19:01 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.034 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>   retry:
>    do
> -    val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
> -		     NUMBERP (seconds) ? &end_time : NULL);
> +    {
> +      val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
> +		       NUMBERP (seconds) ? &end_time : NULL);
> +      record_char (Qnon_command_character);
> +    }

Currently, the view-lossage doesn't actually say

    `a C-h l` resulted in running view-lossage

contrarily to what Lars seems to assume (and I guess, contrarily to
what the display suggests).  Instead it just says

    we saw `a` then `C-h` then `l` then view-lossage was run

I think considering this problem as specific to `read-char` is kinda wrong
(after all, `read-char` can be called as part of input-decode-map in
which case the event still very much belongs to "the events that resulted
in running a particular command"; this happens for example for
mouse-clicks in xterm-mouse-mode).

So I think maybe a better way to look at it is to add marker
pseudo-events like `end-of-command` (e.g. after running
post-command-hook), so we can discover that `a` was processed as part of
the execution of the command bound to `C-x C-e` rather than as part of
the sequence of events that triggered view-lossage.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 03 Aug 2019 12:14:02 +0000
Resent-Message-ID: <handler.21867.B21867.15648344389238 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Stefan Monnier <monnier@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.15648344389238
          (code B ref 21867); Sat, 03 Aug 2019 12:14:02 +0000
Received: (at 21867) by debbugs.gnu.org; 3 Aug 2019 12:13:58 +0000
Received: from localhost ([127.0.0.1]:58419 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1htsv8-0002Ov-38
	for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 08:13:58 -0400
Received: from quimby.gnus.org ([80.91.231.51]:46308)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1htsv6-0002On-Rs
 for 21867 <at> debbugs.gnu.org; Sat, 03 Aug 2019 08:13:57 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1htsv0-0004CO-Og; Sat, 03 Aug 2019 14:13:53 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
Date: Sat, 03 Aug 2019 14:13:49 +0200
In-Reply-To: <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Fri, 02 Aug 2019 16:16:37 -0400")
Message-ID: <87wofujvk2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Stefan Monnier <monnier@HIDDEN> writes: > So I
 think
 maybe a better way to look at it is to add marker > pseudo-events like
 `end-of-command`
 (e.g. after running > post-command-hook), so we can discover that `a` was
 processed as part of > th [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

> So I think maybe a better way to look at it is to add marker
> pseudo-events like `end-of-command` (e.g. after running
> post-command-hook), so we can discover that `a` was processed as part of
> the execution of the command bound to `C-x C-e` rather than as part of
> the sequence of events that triggered view-lossage.

Makes sense.  With the following patch I get:

24 5 (nil . eval-last-sexp) 97 end-of-command

in recent_keys.  `view-lossage' could use this to output this as

C-x C-e a    ;; eval-last-sexp

It does make the recent_keys list even more...  uhm...  eccentric, I
guess.  And during typical text entry, there'll be slightly more memory
usage:

72 (nil . self-insert-command) end-of-command
101 (nil . self-insert-command) end-of-command 

If this approach makes sense, I can fix up view-lossage to interpret the
new structure.

diff --git a/src/keyboard.c b/src/keyboard.c
index db5ca4e547..1a4a7d2711 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -307,6 +307,7 @@ #define GROW_RAW_KEYBUF							\
 
 static void echo_now (void);
 static ptrdiff_t echo_length (void);
+static void record_char (Lisp_Object c);
 
 /* Incremented whenever a timer is run.  */
 unsigned timers_run;
@@ -1424,6 +1425,8 @@ command_loop_1 (void)
 	      Fcons (Qnil, cmd));
 	if (++recent_keys_index >= NUM_RECENT_KEYS)
 	  recent_keys_index = 0;
+	/* Mark this as a complete command in recent_keys. */
+	record_char (Qend_of_command);
       }
       Vthis_command = cmd;
       Vreal_this_command = cmd;
@@ -1474,6 +1477,9 @@ command_loop_1 (void)
 
       safe_run_hooks (Qpost_command_hook);
 
+      /* Mark this as a complete command in recent_keys. */
+      record_char (Qend_of_command);
+
       /* If displaying a message, resize the echo area window to fit
 	 that message's size exactly.  Do this only if the echo area
 	 window is the minibuffer window of the selected frame.  See
@@ -2091,7 +2097,6 @@ show_help_echo (Lisp_Object help, Lisp_Object window, Lisp_Object object,
 
 static Lisp_Object kbd_buffer_get_event (KBOARD **kbp, bool *used_mouse_menu,
 					 struct timespec *end_time);
-static void record_char (Lisp_Object c);
 
 static Lisp_Object help_form_saved_window_configs;
 static void
@@ -11069,6 +11074,8 @@ syms_of_keyboard (void)
 
   DEFSYM (Qundefined, "undefined");
 
+  DEFSYM (Qend_of_command, "end-of-command");
+
   /* Hooks to run before and after each command.  */
   DEFSYM (Qpre_command_hook, "pre-command-hook");
   DEFSYM (Qpost_command_hook, "post-command-hook");


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 03 Aug 2019 21:08:02 +0000
Resent-Message-ID: <handler.21867.B21867.156486643429945 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156486643429945
          (code B ref 21867); Sat, 03 Aug 2019 21:08:02 +0000
Received: (at 21867) by debbugs.gnu.org; 3 Aug 2019 21:07:14 +0000
Received: from localhost ([127.0.0.1]:60115 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hu1FB-0007mv-Tq
	for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 17:07:14 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15622)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1hu1FA-0007mh-Ec
 for 21867 <at> debbugs.gnu.org; Sat, 03 Aug 2019 17:07:12 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2629C445CCA;
 Sat,  3 Aug 2019 17:07:07 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2B7C844518B;
 Sat,  3 Aug 2019 17:07:06 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1564866426;
 bh=rCP0K9QIVjCpKN15dpIJFIRlyNw5B+9u4Q1Mrq4pID8=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
 b=eexoNK9t7isROvKUMCvEiQELEeS0VnjTlCvnnfjLsIcBHkvDjpOmqyhDoD0jIC0cG
 Jsme8KzJkRuaXlo/5I+4Vn+RoDmGo4ojAhfmAvoAHMVqw0SRoWn0HbSUkQbBtpez2k
 XvSwpIfzJC5oez+IbZQWWlyKvmcNpN3FmvFApODSWDyn3oJ52rlsZEpuAYluW+enPj
 VvYR/STrTMn4GmCVUQqKFkkhjU64wZW/7SrcOfjq6DS6iCk82/g+AQCSx0CZtKw6xE
 SybXlpjrOt7iWWIgvkr06hWFqQvK1WuBShvywz4w6wyr6VRRUC4rAPH/BTdiAdwavy
 Acihj/YXuM3gQ==
Received: from alfajor (unknown [78.192.50.77])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6F40D120C2C;
 Sat,  3 Aug 2019 17:07:05 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
Date: Sat, 03 Aug 2019 17:07:03 -0400
In-Reply-To: <87wofujvk2.fsf@HIDDEN> (Lars Ingebrigtsen's message of
 "Sat, 03 Aug 2019 14:13:49 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.163 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> in recent_keys.  `view-lossage' could use this to output this as
>
> C-x C-e a    ;; eval-last-sexp

I think that would be no better than what we have now.  To be better,
we'd want something like:

    C-x C-e [eval-last-sexp] a

which clearly separates between the events received before the command
from those received during the command.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 03 Aug 2019 21:15:02 +0000
Resent-Message-ID: <handler.21867.B21867.156486689130692 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Stefan Monnier <monnier@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156486689130692
          (code B ref 21867); Sat, 03 Aug 2019 21:15:02 +0000
Received: (at 21867) by debbugs.gnu.org; 3 Aug 2019 21:14:51 +0000
Received: from localhost ([127.0.0.1]:60135 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hu1MY-0007yy-Ni
	for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 17:14:50 -0400
Received: from quimby.gnus.org ([80.91.231.51]:54020)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hu1MW-0007yn-TW
 for 21867 <at> debbugs.gnu.org; Sat, 03 Aug 2019 17:14:49 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1hu1MQ-00088a-VF; Sat, 03 Aug 2019 23:14:45 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
Date: Sat, 03 Aug 2019 23:14:42 +0200
In-Reply-To: <jwvblx6kli7.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Sat, 03 Aug 2019 17:07:03 -0400")
Message-ID: <87sgqiar3x.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Stefan Monnier <monnier@HIDDEN> writes: >> in
 recent_keys.
 `view-lossage' could use this to output this as >> >> C-x C-e a ; ;
 eval-last-sexp
 > > I think that would be no better than what we have now. To be better,
 > we'd want something like [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

>> in recent_keys.  `view-lossage' could use this to output this as
>>
>> C-x C-e a    ;; eval-last-sexp
>
> I think that would be no better than what we have now.  To be better,
> we'd want something like:
>
>     C-x C-e [eval-last-sexp] a
>
> which clearly separates between the events received before the command
> from those received during the command.

Yes, that's better and should be even easier to achieve.  Although we
may have to give up the columnar buffer to do that.

Did the patch otherwise make sense?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 03 Aug 2019 21:51:01 +0000
Resent-Message-ID: <handler.21867.B21867.15648690219866 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.15648690219866
          (code B ref 21867); Sat, 03 Aug 2019 21:51:01 +0000
Received: (at 21867) by debbugs.gnu.org; 3 Aug 2019 21:50:21 +0000
Received: from localhost ([127.0.0.1]:60159 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hu1uv-0002Z3-0e
	for submit <at> debbugs.gnu.org; Sat, 03 Aug 2019 17:50:21 -0400
Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:10021)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1hu1us-0002Yr-T3
 for 21867 <at> debbugs.gnu.org; Sat, 03 Aug 2019 17:50:19 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
 by relay.mailchannels.net (Postfix) with ESMTP id AF3B28C17FA;
 Sat,  3 Aug 2019 21:50:17 +0000 (UTC)
Received: from pdx1-sub0-mail-a75.g.dreamhost.com
 (100-96-90-160.trex.outbound.svc.cluster.local [100.96.90.160])
 (Authenticated sender: dreamhost)
 by relay.mailchannels.net (Postfix) with ESMTPA id 3CFDC8C14C8;
 Sat,  3 Aug 2019 21:50:17 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL].
 [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
 by 0.0.0.0:2500 (trex/5.17.5); Sat, 03 Aug 2019 21:50:17 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Bubble-Well-Made: 38e3b70740fef8ac_1564869017529_1213459579
X-MC-Loop-Signature: 1564869017529:2711390181
X-MC-Ingress-Time: 1564869017529
Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1])
 by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id 0550B7FECF;
 Sat,  3 Aug 2019 14:50:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc
 :subject:references:date:in-reply-to:message-id:mime-version
 :content-type; s=linkov.net; bh=wjbLuCTUVUogxYt2hPle/ErPO6U=; b=
 fkvVKXe0gaaQDb/Hmj9aRynjhDpezEefOriOhYkbm55fy7WaEDE9AmPkYKTLCF49
 gHcfj/ZxXM8PUmtDn5j5DrMAbU60kLgTGUpnQf+PFealdmrZH4S4PbWHE9gACVbA
 vbG/Zu6v1wH1AEeZ6MV4Hg10g6yDPEP8uYMbGqCq1cQ=
Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 (Authenticated sender: jurta@HIDDEN)
 by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 2588C7F0F9;
 Sat,  3 Aug 2019 14:50:07 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a75
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN>
Date: Sun, 04 Aug 2019 00:49:22 +0300
In-Reply-To: <87sgqiar3x.fsf@HIDDEN> (Lars Ingebrigtsen's message of
 "Sat, 03 Aug 2019 23:14:42 +0200")
Message-ID: <874l2xvs0t.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddtvddgvddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrghenucevlhhushhtvghrufhiiigvpedt
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>>> in recent_keys.  `view-lossage' could use this to output this as
>>>
>>> C-x C-e a    ;; eval-last-sexp
>>
>> I think that would be no better than what we have now.  To be better,
>> we'd want something like:
>>
>>     C-x C-e [eval-last-sexp] a
>>
>> which clearly separates between the events received before the command
>> from those received during the command.
>
> Yes, that's better and should be even easier to achieve.  Although we
> may have to give up the columnar buffer to do that.

The intention of the columnar format was to maintain compatibility
with the Keyboard Macro Editor (edit-last-kbd-macro).  After typing
the same keys while recording the keyboard macro produces the
buffer where `a' is presented as `self-insert-command':

  ;; Keyboard Macro Editor.  Press C-c C-c to finish; press C-x k RET to cancel.
  ;; Original keys: C-x C-e a

  Command: last-kbd-macro
  Key: none

  Macro:

  C-x C-e                 ;; eval-last-sexp
  a                       ;; self-insert-command

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Aug 2019 11:46:01 +0000
Resent-Message-ID: <handler.21867.B21867.15649191158076 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Juri Linkov <juri@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.15649191158076
          (code B ref 21867); Sun, 04 Aug 2019 11:46:01 +0000
Received: (at 21867) by debbugs.gnu.org; 4 Aug 2019 11:45:15 +0000
Received: from localhost ([127.0.0.1]:60690 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huEws-00026C-VG
	for submit <at> debbugs.gnu.org; Sun, 04 Aug 2019 07:45:15 -0400
Received: from quimby.gnus.org ([80.91.231.51]:36170)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1huEwq-000261-BY
 for 21867 <at> debbugs.gnu.org; Sun, 04 Aug 2019 07:45:13 -0400
Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1huEwi-00070F-Jm; Sun, 04 Aug 2019 13:45:07 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
Date: Sun, 04 Aug 2019 13:45:03 +0200
In-Reply-To: <874l2xvs0t.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 04 Aug 2019 00:49:22 +0300")
Message-ID: <87lfw9b1ds.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Juri Linkov <juri@HIDDEN> writes: > The intention of the
 columnar format was to maintain compatibility > with the Keyboard Macro Editor
 (edit-last-kbd-macro). After typing > the same keys while recording the
 keyboard macro produces th [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.0 TVD_RCVD_IP            Message was received from an IP address
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Juri Linkov <juri@HIDDEN> writes:

> The intention of the columnar format was to maintain compatibility
> with the Keyboard Macro Editor (edit-last-kbd-macro).  After typing
> the same keys while recording the keyboard macro produces the
> buffer where `a' is presented as `self-insert-command':
>
>   ;; Keyboard Macro Editor.  Press C-c C-c to finish; press C-x k RET to cancel.
>   ;; Original keys: C-x C-e a
>
>   Command: last-kbd-macro
>   Key: none
>
>   Macro:
>
>   C-x C-e                 ;; eval-last-sexp
>   a                       ;; self-insert-command

Hm...  well, that's a spanner in the works.

Is `edit-last-kbd-macro' just wrong here?  Because that "a" isn't really
a `self-insert-command', surely.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Aug 2019 13:02:01 +0000
Resent-Message-ID: <handler.21867.B21867.156492371731060 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Juri Linkov <juri@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156492371731060
          (code B ref 21867); Sun, 04 Aug 2019 13:02:01 +0000
Received: (at 21867) by debbugs.gnu.org; 4 Aug 2019 13:01:57 +0000
Received: from localhost ([127.0.0.1]:60756 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huG96-00084t-Ud
	for submit <at> debbugs.gnu.org; Sun, 04 Aug 2019 09:01:57 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11725)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1huG94-00083y-II
 for 21867 <at> debbugs.gnu.org; Sun, 04 Aug 2019 09:01:55 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4E047445D38;
 Sun,  4 Aug 2019 08:55:02 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 510B2445D35;
 Sun,  4 Aug 2019 08:55:01 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1564923301;
 bh=anDJzx6DZlTka6tuFDX3AmyHzAJatniYa6g3p7Ty20I=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
 b=oVf6hLWWDYnnRASRohU1QOR+zdjipbTqYH2DAUl3qPa2sTjJ+/yzv41wow1TpcpEc
 Frrq7heFITnGb4IdYjpeDAgvjqSLcb+oQdMuGmFuGFc+wv2X7l2OYj5E34fbCXVIrl
 z1Xzk1Vxtm0azakpOByGq9NC5f5Hg4Wx+M0SBalt7/RUOXZLIqwlyOHmeL4rK7cS4e
 bJuIn3zprYgvhTtf5ABSZHSyPENl6BGNFr8rNDKgJIG3f9QadPe5eb2an748cqVy9v
 9PSmDARVx91mqtpWHLC3LydzodI7iFGHfE+EOLb3xVSKghARq2ykOWKcXPae0VjU8i
 t1DFJCoVC+bkQ==
Received: from alfajor (unknown [78.192.50.77])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B0CA120B93;
 Sun,  4 Aug 2019 08:55:00 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvo915jdm1.fsf-monnier+emacs@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
Date: Sun, 04 Aug 2019 08:54:58 -0400
In-Reply-To: <874l2xvs0t.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 04 Aug 2019 00:49:22 +0300")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.108 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>   C-x C-e                 ;; eval-last-sexp
>   a                       ;; self-insert-command

This specific output would be wrong, but I guess we could output
something like:

    C-x C-e                 ;; eval-last-sexp
    a                       ;; <during eval-last-sexp>


-- Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Aug 2019 19:52:02 +0000
Resent-Message-ID: <handler.21867.B21867.156494827023938 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Stefan Monnier <monnier@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156494827023938
          (code B ref 21867); Sun, 04 Aug 2019 19:52:02 +0000
Received: (at 21867) by debbugs.gnu.org; 4 Aug 2019 19:51:10 +0000
Received: from localhost ([127.0.0.1]:34273 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huMX8-0006E1-DB
	for submit <at> debbugs.gnu.org; Sun, 04 Aug 2019 15:51:10 -0400
Received: from black.elm.relay.mailchannels.net ([23.83.212.19]:34156)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1huMX6-0006Dq-7h
 for 21867 <at> debbugs.gnu.org; Sun, 04 Aug 2019 15:51:08 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
 by relay.mailchannels.net (Postfix) with ESMTP id 35F5D1A10E2;
 Sun,  4 Aug 2019 19:51:07 +0000 (UTC)
Received: from pdx1-sub0-mail-a13.g.dreamhost.com
 (100-96-15-31.trex.outbound.svc.cluster.local [100.96.15.31])
 (Authenticated sender: dreamhost)
 by relay.mailchannels.net (Postfix) with ESMTPA id B167F1A0C10;
 Sun,  4 Aug 2019 19:51:06 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a13.g.dreamhost.com ([TEMPUNAVAIL].
 [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
 by 0.0.0.0:2500 (trex/5.17.5); Sun, 04 Aug 2019 19:51:07 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Imminent-Occur: 5718052449b32500_1564948267002_4234074640
X-MC-Loop-Signature: 1564948267002:853250689
X-MC-Ingress-Time: 1564948267001
Received: from pdx1-sub0-mail-a13.g.dreamhost.com (localhost [127.0.0.1])
 by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTP id 9AE2A7FE4A;
 Sun,  4 Aug 2019 12:51:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc
 :subject:references:date:in-reply-to:message-id:mime-version
 :content-type; s=linkov.net; bh=Oddv6cBR/OxzQeWPuvDxB7fkePU=; b=
 X7S35ediLdW5cNIaJFUopbogfVaxK9ZmqVbjG29MWAxTB6YtadOh3bc5YYgWL1BG
 CSm7u9xrv1akVLEPfPf2/I3BNWEC0E2sF4NBH3mloeHhjwSN/R1WFMrrF70yktc9
 jTbpGnQ1jYZGqnoKbrTxgnOvnM4WhKIWx+S46MP+qAA=
Received: from mail.jurta.org (m91-129-103-91.cust.tele2.ee [91.129.103.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 (Authenticated sender: jurta@HIDDEN)
 by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTPSA id BB32F7FE67;
 Sun,  4 Aug 2019 12:50:57 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a13
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
 <jwvo915jdm1.fsf-monnier+emacs@HIDDEN>
Date: Sun, 04 Aug 2019 22:44:30 +0300
In-Reply-To: <jwvo915jdm1.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Sun, 04 Aug 2019 08:54:58 -0400")
Message-ID: <87imrcsokh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddthedgudeggecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrledunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrledupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrnecuvehluhhsthgvrhfuihiivgepge
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>>   C-x C-e                 ;; eval-last-sexp
>>   a                       ;; self-insert-command
>
> This specific output would be wrong, but I guess we could output
> something like:
>
>     C-x C-e                 ;; eval-last-sexp
>     a                       ;; <during eval-last-sexp>

Is it safe to assume that any characters not belonging to
a keysequence bound to a command, are read by the previous
command?  If yes, then I guess one of the patches that Lars
sent (with 'non-command-character') could be adapted
for this output.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 04 Aug 2019 21:30:02 +0000
Resent-Message-ID: <handler.21867.B21867.1564954192794 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.1564954192794
          (code B ref 21867); Sun, 04 Aug 2019 21:30:02 +0000
Received: (at 21867) by debbugs.gnu.org; 4 Aug 2019 21:29:52 +0000
Received: from localhost ([127.0.0.1]:34325 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huO4d-0000Cj-NO
	for submit <at> debbugs.gnu.org; Sun, 04 Aug 2019 17:29:52 -0400
Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:59332)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1huO4c-0000Cb-DF
 for 21867 <at> debbugs.gnu.org; Sun, 04 Aug 2019 17:29:51 -0400
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
 by relay.mailchannels.net (Postfix) with ESMTP id 171565E200E;
 Sun,  4 Aug 2019 21:29:49 +0000 (UTC)
Received: from pdx1-sub0-mail-a13.g.dreamhost.com
 (100-96-90-160.trex.outbound.svc.cluster.local [100.96.90.160])
 (Authenticated sender: dreamhost)
 by relay.mailchannels.net (Postfix) with ESMTPA id 909215E1EE2;
 Sun,  4 Aug 2019 21:29:48 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN
Received: from pdx1-sub0-mail-a13.g.dreamhost.com ([TEMPUNAVAIL].
 [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
 by 0.0.0.0:2500 (trex/5.17.5); Sun, 04 Aug 2019 21:29:49 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Eyes-Minister: 08de10cd1b9baa21_1564954188897_835882068
X-MC-Loop-Signature: 1564954188897:746822972
X-MC-Ingress-Time: 1564954188897
Received: from pdx1-sub0-mail-a13.g.dreamhost.com (localhost [127.0.0.1])
 by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTP id 99AB37FE7A;
 Sun,  4 Aug 2019 14:29:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc
 :subject:references:date:in-reply-to:message-id:mime-version
 :content-type; s=linkov.net; bh=vd4TB2RaQBn6ar+/QupKGH8RUS8=; b=
 oWAxoxKvrVwhYi6s2cCxiXATNgbeBvHA/5z+zhXaqb8MnGwVmWCUDnjENZfl7gMe
 PWGcHGrJ2lJ/4JzPnKFb6YVB9q+0lV4EBizhxN6XZejGzZUjPuQy00xwXSIp8SGg
 wGBhOOmajSdp2RqLU+JiaA1q2lxWm2ktDosfcMHQrUc=
Received: from mail.jurta.org (m91-129-103-91.cust.tele2.ee [91.129.103.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 (Authenticated sender: jurta@HIDDEN)
 by pdx1-sub0-mail-a13.g.dreamhost.com (Postfix) with ESMTPSA id 5591A7FE75;
 Sun,  4 Aug 2019 14:29:41 -0700 (PDT)
X-DH-BACKEND: pdx1-sub0-mail-a13
From: Juri Linkov <juri@HIDDEN>
Organization: LINKOV.NET
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
 <87lfw9b1ds.fsf@HIDDEN>
Date: Mon, 05 Aug 2019 00:04:25 +0300
In-Reply-To: <87lfw9b1ds.fsf@HIDDEN> (Lars Ingebrigtsen's message of
 "Sun, 04 Aug 2019 13:45:03 +0200")
Message-ID: <87a7cor563.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddthedgudeifecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrledunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrledupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheplhgrrhhsihesghhnuhhsrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

>>   Command: last-kbd-macro
>>   Key: none
>>
>>   Macro:
>>
>>   C-x C-e                 ;; eval-last-sexp
>>   a                       ;; self-insert-command
>
> Hm...  well, that's a spanner in the works.
>
> Is `edit-last-kbd-macro' just wrong here?  Because that "a" isn't really
> a `self-insert-command', surely.

A similar problem is complained about in the comments of lisp/repeat.el:

;; This works correctly inside a keyboard macro as far as recording and
;; playback go, but `edit-kbd-macro' gets it wrong.  That shouldn't really
;; matter; if you need to edit something like
;;   C-x ]              ;; forward-page
;;   C-x z              ;; repeat
;;   zz                 ;; self-insert-command * 2
;;   C-x                ;; Control-X-prefix
;; you can just kill the bogus final 2 lines, then duplicate the repeat line
;; as many times as it's really needed.  Also, `edit-kbd-macro' works
;; correctly if `repeat' is invoked through a rebinding to a single keystroke
;; and the global variable repeat-on-final-keystroke is set to a value
;; that doesn't include that keystroke.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 05 Aug 2019 09:16:01 +0000
Resent-Message-ID: <handler.21867.B21867.156499651921990 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed patch
To: Stefan Monnier <monnier@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN, Juri Linkov <juri@HIDDEN>
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156499651921990
          (code B ref 21867); Mon, 05 Aug 2019 09:16:01 +0000
Received: (at 21867) by debbugs.gnu.org; 5 Aug 2019 09:15:19 +0000
Received: from localhost ([127.0.0.1]:34594 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huZ5L-0005ib-Ga
	for submit <at> debbugs.gnu.org; Mon, 05 Aug 2019 05:15:19 -0400
Received: from quimby.gnus.org ([80.91.231.51]:52518)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1huZ5J-0005iT-MW
 for 21867 <at> debbugs.gnu.org; Mon, 05 Aug 2019 05:15:18 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1huZ5D-0000uu-QS; Mon, 05 Aug 2019 11:15:14 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
 <jwvo915jdm1.fsf-monnier+emacs@HIDDEN>
Date: Mon, 05 Aug 2019 11:15:11 +0200
In-Reply-To: <jwvo915jdm1.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Sun, 04 Aug 2019 08:54:58 -0400")
Message-ID: <87o914dlcw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: Stefan Monnier <monnier@HIDDEN> writes: > This
 specific
 output would be wrong, but I guess we could output > something like: > >
 C-x C-e ;; eval-last-sexp > a ;; <during eval-last-sexp> OK; looks good to
 me. I'll do that... 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

> This specific output would be wrong, but I guess we could output
> something like:
>
>     C-x C-e                 ;; eval-last-sexp
>     a                       ;; <during eval-last-sexp>

OK; looks good to me.  I'll do that...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 5 Aug 2019 10:43:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 05 06:43:36 2019
Received: from localhost ([127.0.0.1]:34711 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huaSm-0001dA-Kg
	for submit <at> debbugs.gnu.org; Mon, 05 Aug 2019 06:43:36 -0400
Received: from quimby.gnus.org ([80.91.231.51]:54278)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1huaSk-0001cz-Bm
 for control <at> debbugs.gnu.org; Mon, 05 Aug 2019 06:43:34 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1huaSg-0001jU-LI
 for control <at> debbugs.gnu.org; Mon, 05 Aug 2019 12:43:32 +0200
Date: Mon, 05 Aug 2019 12:43:30 +0200
Message-Id: <871rxzevu5.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #21867
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 21867 fixed close 21867 27.1 quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 21867 fixed
close 21867 27.1
quit

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 5 Aug 2019 10:43:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 05 06:43:36 2019
Received: from localhost ([127.0.0.1]:34711 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huaSm-0001dA-Kg
	for submit <at> debbugs.gnu.org; Mon, 05 Aug 2019 06:43:36 -0400
Received: from quimby.gnus.org ([80.91.231.51]:54278)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1huaSk-0001cz-Bm
 for control <at> debbugs.gnu.org; Mon, 05 Aug 2019 06:43:34 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1huaSg-0001jU-LI
 for control <at> debbugs.gnu.org; Mon, 05 Aug 2019 12:43:32 +0200
Date: Mon, 05 Aug 2019 12:43:30 +0200
Message-Id: <871rxzevu5.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #21867
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 21867 fixed close 21867 27.1 quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 21867 fixed
close 21867 27.1
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 05 Aug 2019 18:37:01 +0000
Resent-Message-ID: <handler.21867.B21867.156503020319863 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed confirmed patch
To: Juri Linkov <juri@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156503020319863
          (code B ref 21867); Mon, 05 Aug 2019 18:37:01 +0000
Received: (at 21867) by debbugs.gnu.org; 5 Aug 2019 18:36:43 +0000
Received: from localhost ([127.0.0.1]:35858 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1huhqc-0005AI-Rw
	for submit <at> debbugs.gnu.org; Mon, 05 Aug 2019 14:36:43 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38871)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1huhqb-0005A0-IX
 for 21867 <at> debbugs.gnu.org; Mon, 05 Aug 2019 14:36:41 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 27302100B39;
 Mon,  5 Aug 2019 14:36:35 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 55C1010044B;
 Mon,  5 Aug 2019 14:36:33 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1565030193;
 bh=Usb54HlXxNPuteJGvcEFVKxGb49Ur+N5XSIyb9syU94=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
 b=kn5rxXdb0InzaMd2G7f3PHMA9/nPPzstDe/jzyYQjhthMOBXhaVpE9e8lItRYyHei
 Czck15otsXZL0OMRDnnUKg/vt9e3gQRVCc2gCl49/2nXZ1bYYmoHCGs11ccT6y3lQ2
 WUB68qiWSxjCMDRUCA+Oz+vC7j2MmCnPikaMfMyLAusjOm6ItITV8Fd5HmOKNVJE5R
 8TWAV97oJuY+hCU0YcC0Clz5PPMdHN3E/M2xVCvS7bI7GTSK92IiCO/H0NiKkhz1SF
 mNu+DoSqEoV5O4iLjgxjR2jnmqGumy2BskC6UkBe1nrWvLA+2W4EWjNoT+MwE+TcHN
 utZVUPiVKuuWQ==
Received: from alfajor (unknown [78.192.50.77])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2FA281207EB;
 Mon,  5 Aug 2019 14:36:32 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvpnljihu6.fsf-monnier+emacs@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
 <jwvo915jdm1.fsf-monnier+emacs@HIDDEN>
 <87imrcsokh.fsf@HIDDEN>
Date: Mon, 05 Aug 2019 14:36:30 -0400
In-Reply-To: <87imrcsokh.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 04 Aug 2019 22:44:30 +0300")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
X-SPAM-LEVEL: 
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> Is it safe to assume that any characters not belonging to
> a keysequence bound to a command, are read by the previous
> command?

I think it's safe to say that an event read after the start of a command
and before the end of the execution of that command was received "during
<thecommand>".

The reality can be pretty complex (e.g. event can be read during
pre-command-hook, post-command-hook, recursive-edits, unrelated
process-filters, etc...), and I don't think we should strive to explain
precisely all possible cases.  The point is just to avoid misleading
output like the one under discussion.

Maybe rather than "during eval-last-sexp" we should say "during command
execution" to try and be more vague (e.g. if it's done in
post-command-hook, it's not done "during eval-last-sexp" but it's
arguably still during "during command execution").


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 07 Aug 2019 18:32:02 +0000
Resent-Message-ID: <handler.21867.B21867.156520268622048 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: fixed confirmed patch
To: Stefan Monnier <monnier@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN, Juri Linkov <juri@HIDDEN>
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156520268622048
          (code B ref 21867); Wed, 07 Aug 2019 18:32:02 +0000
Received: (at 21867) by debbugs.gnu.org; 7 Aug 2019 18:31:26 +0000
Received: from localhost ([127.0.0.1]:39338 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hvQic-0005jX-69
	for submit <at> debbugs.gnu.org; Wed, 07 Aug 2019 14:31:26 -0400
Received: from quimby.gnus.org ([80.91.231.51]:45310)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hvQia-0005jO-QT
 for 21867 <at> debbugs.gnu.org; Wed, 07 Aug 2019 14:31:25 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1hvQiV-0000fs-1n; Wed, 07 Aug 2019 20:31:21 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
 <jwvo915jdm1.fsf-monnier+emacs@HIDDEN>
 <87imrcsokh.fsf@HIDDEN>
 <jwvpnljihu6.fsf-monnier+emacs@HIDDEN>
Date: Wed, 07 Aug 2019 20:31:18 +0200
In-Reply-To: <jwvpnljihu6.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Mon, 05 Aug 2019 14:36:30 -0400")
Message-ID: <878ss496a1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Stefan Monnier <monnier@HIDDEN> writes: > Maybe
 rather than "during eval-last-sexp" we should say "during command > execution"
 to try and be more vague (e.g. if it's done in > post-command-hook, it's
 not done "during eval-last-sexp" but it' [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

> Maybe rather than "during eval-last-sexp" we should say "during command
> execution" to try and be more vague (e.g. if it's done in
> post-command-hook, it's not done "during eval-last-sexp" but it's
> arguably still during "during command execution").

That makes sense.  When I reintroduce the patch (after figuring out how
it broke macros) I'll change the text to that.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at fakecontrol@fakecontrolmessage:

Received: (at fakecontrol) by fakecontrolmessage;
To: internal_control <at> debbugs.gnu.org
From: Debbugs Internal Request <help-debbugs@HIDDEN>
Subject: Internal Control
Message-Id: bug No longer marked as fixed in versions 27.1 and reopened.
Date: Wed, 07 Aug 2019 18:32:03 +0000
User-Agent: Fakemail v42.6.9

# This is a fake control message.
#
# The action:
# bug No longer marked as fixed in versions 27.1 and reopened.
thanks
# This fakemail brought to you by your local debbugs
# administrator

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 7 Aug 2019 18:31:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 07 14:31:37 2019
Received: from localhost ([127.0.0.1]:39341 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hvQin-0005k0-F0
	for submit <at> debbugs.gnu.org; Wed, 07 Aug 2019 14:31:37 -0400
Received: from quimby.gnus.org ([80.91.231.51]:45326)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hvQil-0005jp-Cn
 for control <at> debbugs.gnu.org; Wed, 07 Aug 2019 14:31:35 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1hvQii-0000g4-Qp
 for control <at> debbugs.gnu.org; Wed, 07 Aug 2019 20:31:34 +0200
Date: Wed, 07 Aug 2019 20:31:32 +0200
Message-Id: <877e7o969n.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #21867
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  reopen 21867 tags 21867 - fixed patch quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

reopen 21867
tags 21867 - fixed patch
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 23 Aug 2019 01:42:02 +0000
Resent-Message-ID: <handler.21867.B21867.156652448816231 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 21867
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: confirmed
To: Stefan Monnier <monnier@HIDDEN>
Cc: 21867 <at> debbugs.gnu.org, zkanfer@HIDDEN, Juri Linkov <juri@HIDDEN>
Received: via spool by 21867-submit <at> debbugs.gnu.org id=B21867.156652448816231
          (code B ref 21867); Fri, 23 Aug 2019 01:42:02 +0000
Received: (at 21867) by debbugs.gnu.org; 23 Aug 2019 01:41:28 +0000
Received: from localhost ([127.0.0.1]:38655 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1i0yZz-0004Di-Qf
	for submit <at> debbugs.gnu.org; Thu, 22 Aug 2019 21:41:28 -0400
Received: from quimby.gnus.org ([80.91.231.51]:37234)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1i0yZx-0004Da-PW
 for 21867 <at> debbugs.gnu.org; Thu, 22 Aug 2019 21:41:26 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=sandy)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>)
 id 1i0yZq-0002QI-O2; Fri, 23 Aug 2019 03:41:21 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAFXT+RMGJ_DwsKBM0D7WnAtcxJ=TFKx6spUa4B5-iDVmxeh8Sw@HIDDEN>
 <87blx8iwwm.fsf@HIDDEN> <83o918hhli.fsf@HIDDEN>
 <87tvb0hgov.fsf@HIDDEN> <83mugshg86.fsf@HIDDEN>
 <877e7whfv9.fsf@HIDDEN> <83lfwcheyy.fsf@HIDDEN>
 <87k1bwg01u.fsf@HIDDEN> <83ef24gjby.fsf@HIDDEN>
 <8736ijak7u.fsf@HIDDEN>
 <jwvblx7tjo7.fsf-monnier+emacs@HIDDEN>
 <87wofujvk2.fsf@HIDDEN>
 <jwvblx6kli7.fsf-monnier+emacs@HIDDEN>
 <87sgqiar3x.fsf@HIDDEN> <874l2xvs0t.fsf@HIDDEN>
 <jwvo915jdm1.fsf-monnier+emacs@HIDDEN>
 <87imrcsokh.fsf@HIDDEN>
 <jwvpnljihu6.fsf-monnier+emacs@HIDDEN>
 <878ss496a1.fsf@HIDDEN>
Date: Fri, 23 Aug 2019 03:41:18 +0200
In-Reply-To: <878ss496a1.fsf@HIDDEN> (Lars Ingebrigtsen's message of
 "Wed, 07 Aug 2019 20:31:18 +0200")
Message-ID: <87r25cd5fl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  I've now fixed the kmacro problems, but there's still some
 irregularities in the recorded keystrokes and commands. Presently, if you
 type (foo)RET 
 Content analysis details:   (-2.0 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 NO_DNS_FOR_FROM        DNS: Envelope sender has no MX or A DNS records
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 0.9 DKIM_ADSP_NXDOMAIN     No valid author signature and domain not in
 DNS
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.4 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)

I've now fixed the kmacro problems, but there's still some
irregularities in the recorded keystrokes and commands.

Presently, if you type

(foo)RET

view-lossage will say:

 (			;; self-insert-command
 f			;; self-insert-command
 o			;; self-insert-command
 o			;; self-insert-command
 )			;; self-insert-command
 <return> <return>	;; newline-and-indent

Which is...  kinda wrong?  Because there's only one RET, but at least
we're told that `newline-and-indent' is the result, so it's not that
bad.

But with the patch set, we get:

(			;; self-insert-command
f			;; self-insert-command
o			;; self-insert-command
o			;; self-insert-command
)			;; self-insert-command
<return>		;; <during command execution>
<return>		;; newline-and-indent

which is even more wrong.

Where is that first <return> coming from?  The raw output from
`(recent-keys t)' is:

 40
 (nil . self-insert-command)
 102
 (nil . self-insert-command)
 111
 (nil . self-insert-command)
 111
 (nil . self-insert-command)
 41
 (nil . self-insert-command)
 return return
 (nil . newline-and-indent)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.