GNU bug report logs - #22072
Error in display-startup-screen if create-image fails

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Richard Copley <rcopley@HIDDEN>; dated Wed, 2 Dec 2015 01:55:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 22072 <at> debbugs.gnu.org:


Received: (at 22072) by debbugs.gnu.org; 2 Dec 2015 12:37:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 02 07:37:07 2015
Received: from localhost ([127.0.0.1]:35750 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1a46eg-0008PU-Qq
	for submit <at> debbugs.gnu.org; Wed, 02 Dec 2015 07:37:07 -0500
Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:39675)
 by debbugs.gnu.org with smtp (Exim 4.80)
 (envelope-from <stephen_leake@HIDDEN>) id 1a46ed-0008PL-KG
 for 22072 <at> debbugs.gnu.org; Wed, 02 Dec 2015 07:37:05 -0500
Received: (qmail 21340 invoked by uid 0); 2 Dec 2015 12:36:57 -0000
Received: from unknown (HELO cmgw3) (10.0.90.84)
 by gproxy4.mail.unifiedlayer.com with SMTP; 2 Dec 2015 12:36:57 -0000
Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw3 with 
 id ojcr1r00A2UdiVW01jcunY; Wed, 02 Dec 2015 12:36:54 -0700
X-Authority-Analysis: v=2.1 cv=Caqbutbl c=1 sm=1 tr=0
 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8
 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10
 a=wUQvQvOEmiQA:10 a=pGLkceISAAAA:8 a=cwJsGDipi4G-k-tNeckA:9
Received: from [76.218.37.33] (port=58166 helo=TAKVER2)
 by host114.hostmonster.com with esmtpa (Exim 4.84)
 (envelope-from <stephen_leake@HIDDEN>)
 id 1a46eT-0000yF-IM; Wed, 02 Dec 2015 05:36:53 -0700
From: Stephen Leake <stephen_leake@HIDDEN>
To: Richard Copley <rcopley@HIDDEN>
Subject: Re: bug#22072: Error in display-startup-screen if create-image fails
References: <CAPM58oj9dAKttjmxooajEx5B6dAz=5TmY59Gz-jWpH5vkXoVwA@HIDDEN>
Date: Wed, 02 Dec 2015 06:36:48 -0600
In-Reply-To: <CAPM58oj9dAKttjmxooajEx5B6dAz=5TmY59Gz-jWpH5vkXoVwA@HIDDEN>
 (Richard Copley's message of "Wed, 2 Dec 2015 01:53:38 +0000")
Message-ID: <86mvttm3hb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt)
MIME-Version: 1.0
Content-Type: text/plain
X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org}
 {sentby:smtp auth 76.218.37.33 authed with stephen_leake@HIDDEN}
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 22072
Cc: 22072 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Richard Copley <rcopley@HIDDEN> writes:

Can you test this patch:

diff --git a/lisp/startup.el b/lisp/startup.el
index 1346310..a281f86 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1874,13 +1874,13 @@ we put it on this frame."
                  (image-type-available-p 'pbm)))
     (let ((frame (fancy-splash-frame)))
       (when frame
-	(let* ((img (create-image (fancy-splash-image-file)))
-	       (image-height (and img (cdr (image-size img nil frame))))
-	       ;; We test frame-height so that, if the frame is split
-	       ;; by displaying a warning, that doesn't cause the normal
-	       ;; splash screen to be used.
-	       (frame-height (1- (frame-height frame))))
-	  (> frame-height (+ image-height 19)))))))
+	(let ((img (create-image (fancy-splash-image-file))))
+              (image-height (and img (cdr (image-size img nil frame))))
+              ;; We test frame-height so that, if the frame is split
+              ;; by displaying a warning, that doesn't cause the normal
+              ;; splash screen to be used.
+              (frame-height (and img (1- (frame-height frame)))))
+	  (and img (> frame-height (+ image-height 19))))))))
 
-- 
-- Stephe




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#22072; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 2 Dec 2015 01:54:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 01 20:54:03 2015
Received: from localhost ([127.0.0.1]:35509 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1a3wcN-0008PE-8w
	for submit <at> debbugs.gnu.org; Tue, 01 Dec 2015 20:54:03 -0500
Received: from eggs.gnu.org ([208.118.235.92]:58591)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <rcopley@HIDDEN>) id 1a3wc3-0008OR-LG
 for submit <at> debbugs.gnu.org; Tue, 01 Dec 2015 20:54:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <rcopley@HIDDEN>) id 1a3wc2-0003hH-6l
 for submit <at> debbugs.gnu.org; Tue, 01 Dec 2015 20:53:43 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
 T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:42024)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <rcopley@HIDDEN>) id 1a3wc2-0003hD-3q
 for submit <at> debbugs.gnu.org; Tue, 01 Dec 2015 20:53:42 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40360)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <rcopley@HIDDEN>) id 1a3wc0-0008At-SC
 for bug-gnu-emacs@HIDDEN; Tue, 01 Dec 2015 20:53:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <rcopley@HIDDEN>) id 1a3wbz-0003h1-Pm
 for bug-gnu-emacs@HIDDEN; Tue, 01 Dec 2015 20:53:40 -0500
Received: from mail-yk0-x22e.google.com ([2607:f8b0:4002:c07::22e]:36105)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <rcopley@HIDDEN>) id 1a3wbz-0003gx-Kk
 for bug-gnu-emacs@HIDDEN; Tue, 01 Dec 2015 20:53:39 -0500
Received: by ykdr82 with SMTP id r82so30560921ykd.3
 for <bug-gnu-emacs@HIDDEN>; Tue, 01 Dec 2015 17:53:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:date:message-id:subject:from:to:content-type;
 bh=swzkeqiA3SjAWsi+8OeTzMyIm6tJrGvnfjBdLGUfYKo=;
 b=pCU+t5pjUlRkmtveceim4OgW8CcrvyQy/4iHZMeAjkjE35rbAuUvcbq7p7PMcshEyt
 AftWqHvlKhMH0PCWvReZ5PFRRfZKp7MXKykTUtYx31vIXiXuRhgnMfYqxzM1FdYwNbp6
 FgOuFMqa+dznPXI9l4WYpbzBmJkfO7210aFhSGqvwTch8CCKJfOy2n+cYqFlRHdMuA0R
 Z9hn6Gw9uvYIPHJ77r8KQtYkZbqHKq7kTyHfMJrjejueKM+lhZo9WIXwkkrcu9SXPg1O
 mzXCmzxc9UcoTjfAxqjaTD0JkRVUiI6OdlH3YVAVUMJyJiC4f79XZTVNiDB+0Gi0GQKO
 ulvw==
MIME-Version: 1.0
X-Received: by 10.129.53.148 with SMTP id c142mr415692ywa.138.1449021218943;
 Tue, 01 Dec 2015 17:53:38 -0800 (PST)
Received: by 10.37.195.129 with HTTP; Tue, 1 Dec 2015 17:53:38 -0800 (PST)
Date: Wed, 2 Dec 2015 01:53:38 +0000
Message-ID: <CAPM58oj9dAKttjmxooajEx5B6dAz=5TmY59Gz-jWpH5vkXoVwA@HIDDEN>
Subject: Error in display-startup-screen if create-image fails
From: Richard Copley <rcopley@HIDDEN>
To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN>
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

There's a mistake in the function "use-fancy-splash-screens-p" in
startup.el. It can set the local variable "image-height" to nil (if
creating an image from the fancy-splash-image-file fails), but later
it uses the value of "image-height" in an arithmetic expression, and
gives the error "Wrong type argument: number-or-marker-p, nil".

(The reason create-image has suddenly started failing for me is a
difference in my build environment. I'm trying out a build using only
stuff available from the MSYS2 package manager. I haven't noticed
any other problems so far. The create-image problem goes away if
I configure --without-imagemagick.)

In GNU Emacs 25.1.50.1 (x86_64-w64-mingw32)
 of 2015-12-02
Repository revision: 098738ff1a193ff6e6af71071461f75635d1b790
Windowing system distributor 'Microsoft Corp.', version 10.0.10586
Configured using:
 'configure --prefix /c/emacs/emacs-20151201-205551
 --disable-dependency-tracking
 --enable-locallisppath=%emacs_dir%/../site-lisp 'CFLAGS=-Og -g -ggdb''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS NOTIFY ACL GNUTLS
LIBXML2 ZLIB TOOLKIT_SCROLL_BARS

Important settings:
  value of $LANG: ENG
  locale-coding-system: cp1252

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
display-startup-screen: Wrong type argument: number-or-marker-p, nil

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr
mail-utils advice time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table
w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote w32notify dbusbind w32 multi-tty
make-network-process emacs)

Memory information:
((conses 16 84676 9280)
 (symbols 56 19141 0)
 (miscs 48 36 128)
 (strings 32 14569 3411)
 (string-bytes 1 399450)
 (vectors 16 11586)
 (vector-slots 8 411206 1940)
 (floats 8 141 49)
 (intervals 56 243 0)
 (buffers 976 11))




Acknowledgement sent to Richard Copley <rcopley@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#22072; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 2 Dec 2015 12:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.