GNU bug report logs - #22451
24.5; `customize-apropos-options': wrong message

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22451 in the body.
You can then email your comments to 22451 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; `customize-apropos-options': wrong message
Date: Sat, 23 Jan 2016 17:55:32 -0800 (PST)

emacs -Q
M-x customize-apropos-options .* RET

You see the message "Resetting customization items...", which is quite
wrong.  Nothing is being reset.  Users will be confused and certainly
hope/pray that that no option is actually being "reset".


In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'

Message #10 received at 22451 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 22451 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>
Subject: Re: bug#22451: 24.5; `customize-apropos-options': wrong message
Date: Tue, 16 Feb 2016 17:53:59 +1100

Drew Adams <drew.adams <at> oracle.com> writes:

> emacs -Q
> M-x customize-apropos-options .* RET
>
> You see the message "Resetting customization items...", which is quite
> wrong.  Nothing is being reset.  Users will be confused and certainly
> hope/pray that that no option is actually being "reset".

Richard added those messages in 2005...  I'm not quite sure what the
logic is here, but there does seem to be something...  reset...  here...

   (message "Creating customization items ...done")
+  (message "Resetting customization items...")
   (unless (eq custom-buffer-style 'tree)
     (mapc 'custom-magic-reset custom-options))
+  (message "Resetting customization items...done")
   (message "Creating customization setup...")

Oh, it's just a redrawing thing:

----------
custom-magic-reset is a compiled Lisp function in ‘cus-edit.el’.

(custom-magic-reset WIDGET)

Redraw the :custom-magic property of WIDGET.
----------

In that case I agree that the message is misleading, and I think it
should just be removed.  That part doesn't seem to take that much time,
anyway.  Richard?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 22451 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 22451 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#22451: 24.5; `customize-apropos-options': wrong message
Date: Thu, 11 Jul 2019 06:17:44 +0200

[Message part 1 (text/plain, inline)]

tags 22451 + patch
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Drew Adams <drew.adams <at> oracle.com> writes:
>
>> emacs -Q
>> M-x customize-apropos-options .* RET
>>
>> You see the message "Resetting customization items...", which is quite
>> wrong.  Nothing is being reset.  Users will be confused and certainly
>> hope/pray that that no option is actually being "reset".
>
> Richard added those messages in 2005...  I'm not quite sure what the
> logic is here, but there does seem to be something...  reset...  here...
>
>    (message "Creating customization items ...done")
> +  (message "Resetting customization items...")
>    (unless (eq custom-buffer-style 'tree)
>      (mapc 'custom-magic-reset custom-options))
> +  (message "Resetting customization items...done")
>    (message "Creating customization setup...")
>
> Oh, it's just a redrawing thing:
>
> ----------
> custom-magic-reset is a compiled Lisp function in ‘cus-edit.el’.
>
> (custom-magic-reset WIDGET)
>
> Redraw the :custom-magic property of WIDGET.
> ----------
>
> In that case I agree that the message is misleading, and I think it
> should just be removed.  That part doesn't seem to take that much time,
> anyway.  Richard?

That was three years ago.

I think it's time to get rid of them.  See the attached patch, which
does just that.

Thanks,
Stefan Kangas

[0001-Remove-misleading-message-in-customize.patch (application/octet-stream, attachment)]

Message #18 received at 22451 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 22451 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#22451: 24.5; `customize-apropos-options': wrong message
Date: Thu, 11 Jul 2019 16:06:25 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> That was three years ago.
>
> I think it's time to get rid of them.  See the attached patch, which
> does just that.

Thanks; I've applied the patch to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.