GNU logs - #22466, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Artur Malabarba <bruce.connor.am@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 11:04:01 +0000
Resent-Message-ID: <handler.22466.B.14538061824967 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 22466 <at> debbugs.gnu.org
From: Artur Malabarba <bruce.connor.am@HIDDEN>
Date: Tue, 26 Jan 2016 09:02:29 +0000
Message-ID: <87y4bcsogq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

1. From =E2=80=9Cemacs -Q=E2=80=9D evaluate `(load-theme 'tango-dark)'. Any=
 other theme
with a dark background will also do.

2. Then, notice how every time you evaluate the following code, the
screen flashes white for a moment, and then resumes the exact same
appearance.

    (progn (disable-theme 'tango-dark)
           (load-theme 'tango-dark))

Of course, =E2=80=9Cresuming the same appearance=E2=80=9D is expected, the =
problem is
that the white flash is distracting, unnecessary, and eye-hurting.

I understand _why_ it happens (after `disable-theme' the background is
actually white), but I don't see why it _has_ to happen. That is, why
does Emacs redisplay the frame in the middle of lisp evaluation, instead
of waiting until the end of the command loop?

More importantly, is this redisplay (or =E2=80=9Cpartial redisplay=E2=80=9D=
, or whatever
it is) be avoided, so Emacs doesn't flash white on my pretty little eyes?

-----

ps: In case it helps, investigation shows that this is caused by this
form inside `disable-theme':

    (set-frame-parameter frame 'background-color
    			     (custom--frame-color-default
    			      frame :background "background" "Background"
    			      "unspecified-bg" "white"))

I'm not saying this form is wrong. I'm just pointing to where it happens.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Artur Malabarba <bruce.connor.am@HIDDEN>
Subject: bug#22466: Acknowledgement (25.0.50; disable-theme apparently
 forces a redisplay and causes a screen flash)
Message-ID: <handler.22466.B.14538061824967.ack <at> debbugs.gnu.org>
References: <87y4bcsogq.fsf@HIDDEN>
X-Gnu-PR-Message: ack 22466
X-Gnu-PR-Package: emacs
Reply-To: 22466 <at> debbugs.gnu.org
Date: Tue, 26 Jan 2016 11:04:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 22466 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
22466: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22466
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 14:59:01 +0000
Resent-Message-ID: <handler.22466.B22466.1453820302995 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Artur Malabarba <bruce.connor.am@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Date: Tue, 26 Jan 2016 16:58:26 +0200
Message-Id: <83powo1j71.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87y4bcsogq.fsf@HIDDEN> (message from Artur Malabarba on Tue, 
 26 Jan 2016 09:02:29 +0000)
References: <87y4bcsogq.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Artur Malabarba <bruce.connor.am@HIDDEN>
> Date: Tue, 26 Jan 2016 09:02:29 +0000
> 
> 
> 1. From “emacs -Q” evaluate `(load-theme 'tango-dark)'. Any other theme
> with a dark background will also do.
> 
> 2. Then, notice how every time you evaluate the following code, the
> screen flashes white for a moment, and then resumes the exact same
> appearance.
> 
>     (progn (disable-theme 'tango-dark)
>            (load-theme 'tango-dark))
> 
> Of course, “resuming the same appearance” is expected, the problem is
> that the white flash is distracting, unnecessary, and eye-hurting.
> 
> I understand _why_ it happens (after `disable-theme' the background is
> actually white), but I don't see why it _has_ to happen. That is, why
> does Emacs redisplay the frame in the middle of lisp evaluation, instead
> of waiting until the end of the command loop?

It's not redisplay that does this.  It's the fact that disable-theme
changes the frame's background color, and when that happens, we
immediately clear the frame using the new background color, as part of
the modify-frame-parameters call.

Redisplay only handles the portions of display where there's text and
other decorations that we manage.  Clearing the frame with the new
background color is not redisplay's job.

> More importantly, is this redisplay (or “partial redisplay”, or whatever
> it is) be avoided, so Emacs doesn't flash white on my pretty little eyes?
> 
> -----
> 
> ps: In case it helps, investigation shows that this is caused by this
> form inside `disable-theme':
> 
>     (set-frame-parameter frame 'background-color
>     			     (custom--frame-color-default
>     			      frame :background "background" "Background"
>     			      "unspecified-bg" "white"))
> 
> I'm not saying this form is wrong. I'm just pointing to where it happens.

What happens if you remove that from disable-theme?  (I don't really
understand why it has to specify "white".)

Anyway, how come you get to doing this so often it hurts your eyes?
Aren't people setting their beloved theme once when the session
starts, and then never change it?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 16:38:01 +0000
Resent-Message-ID: <handler.22466.B22466.145382622610350 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>, Artur Malabarba <bruce.connor.am@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org
MIME-Version: 1.0
Message-ID: <1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
Date: Tue, 26 Jan 2016 08:36:56 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
In-Reply-To: <83powo1j71.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Anyway, how come you get to doing this so often it hurts your eyes?
> Aren't people setting their beloved theme once when the session
> starts, and then never change it?

I can't speak for the OP, but no, users can well want to cycle
through a set of themes before choosing one.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 17:03:01 +0000
Resent-Message-ID: <handler.22466.B22466.145382777812676 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Drew Adams <drew.adams@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145382777812676
          (code B ref 22466); Tue, 26 Jan 2016 17:03:01 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 17:02:58 +0000
Received: from localhost ([127.0.0.1]:37856 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aO717-0003IO-S6
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:02:58 -0500
Received: from eggs.gnu.org ([208.118.235.92]:60055)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <eliz@HIDDEN>) id 1aO715-0003IA-J0
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:02:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1aO70v-0001Ct-Sj
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:02:50 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39688)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1aO70v-0001Cp-PT; Tue, 26 Jan 2016 12:02:45 -0500
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1424
 helo=HOME-C4E4A596F7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1aO70u-0000NF-6a; Tue, 26 Jan 2016 12:02:44 -0500
Date: Tue, 26 Jan 2016 19:03:12 +0200
Message-Id: <83d1so1df3.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> (message from Drew
 Adams on Tue, 26 Jan 2016 08:36:56 -0800 (PST))
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> Date: Tue, 26 Jan 2016 08:36:56 -0800 (PST)
> From: Drew Adams <drew.adams@HIDDEN>
> Cc: 22466 <at> debbugs.gnu.org
> 
> > Anyway, how come you get to doing this so often it hurts your eyes?
> > Aren't people setting their beloved theme once when the session
> > starts, and then never change it?
> 
> I can't speak for the OP, but no, users can well want to cycle
> through a set of themes before choosing one.

Yes, once.  Until they choose that one.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 17:08:01 +0000
Resent-Message-ID: <handler.22466.B22466.145382804613089 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145382804613089
          (code B ref 22466); Tue, 26 Jan 2016 17:08:01 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 17:07:26 +0000
Received: from localhost ([127.0.0.1]:37860 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aO75S-0003P3-EX
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:07:26 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:34081)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <drew.adams@HIDDEN>) id 1aO75R-0003Oq-6O
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:07:25 -0500
Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])
 by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 u0QH7Im8007862
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
 Tue, 26 Jan 2016 17:07:19 GMT
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])
 by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u0QH7Ipp010175
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);
 Tue, 26 Jan 2016 17:07:18 GMT
Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12])
 by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u0QH7Is9014156;
 Tue, 26 Jan 2016 17:07:18 GMT
MIME-Version: 1.0
Message-ID: <36e71def-75ba-4cb6-be82-2546d21403d7@default>
Date: Tue, 26 Jan 2016 09:07:17 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
References: <<87y4bcsogq.fsf@HIDDEN>> <<83powo1j71.fsf@HIDDEN>>
 <<1bbf7218-bd5b-4618-822c-cd75884a81ee@default>> <<83d1so1df3.fsf@HIDDEN>>
In-Reply-To: <<83d1so1df3.fsf@HIDDEN>>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9  (901082) [OL
 12.0.6691.5000 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

> > > Anyway, how come you get to doing this so often it hurts your eyes?
> > > Aren't people setting their beloved theme once when the session
> > > starts, and then never change it?
> >
> > I can't speak for the OP, but no, users can well want to cycle
> > through a set of themes before choosing one.
>=20
> Yes, once.  Until they choose that one.

But they might do this over and over, in different contexts.
Anyway, I've made the point.  Up to you whether it matters.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Michael Albinus <michael.albinus@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 18:42:02 +0000
Resent-Message-ID: <handler.22466.B22466.145383369222065 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, Drew Adams <drew.adams@HIDDEN>
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145383369222065
          (code B ref 22466); Tue, 26 Jan 2016 18:42:02 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 18:41:32 +0000
Received: from localhost ([127.0.0.1]:37897 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aO8YW-0005jo-Er
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:41:32 -0500
Received: from mout.gmx.net ([212.227.17.21]:53691)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <michael.albinus@HIDDEN>) id 1aO8YV-0005jb-79
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:41:31 -0500
Received: from detlef.gmx.de ([79.195.30.160]) by mail.gmx.com (mrgmx102) with
 ESMTPSA (Nemesis) id 0MZOan-1agcCo4B13-00LGwy;
 Tue, 26 Jan 2016 19:41:20 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
 <83d1so1df3.fsf@HIDDEN>
Date: Tue, 26 Jan 2016 19:41:18 +0100
In-Reply-To: <83d1so1df3.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 26 Jan
 2016 19:03:12 +0200")
Message-ID: <87y4bc89pt.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K0:XtAXB/enZmAX5cCejQML6ifLuU7dKEX8vHuI+dEqo//6caeTYhh
 jBXL9hX5KBNHGKALxAdPqdqd3u0Zk/2LxHI2BXyg1XUS4gvJJCP3hlRQB2nVYYTybHTiSJX
 xBl+0ROrlP4ooQagH0R/mJaFYWs0ou1Lfl40Q5gE1GvhI+nMTGDl7jJytuDBlFTVW5zKNiG
 nVZYkmN4ocs0JUnhwCZrA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:vIl/ryvjgHU=:mFLPkjR3BSc18tuL+em/wU
 hMKxIQfK9DpEe/fbPTZHFYKb/uMpsv2d6f8mkscvx80qDbCcactpLktghM+3/olktBinOYHSF
 FVejtcdxwD9GjfC1Sf92VVV36Nu4QRkmWVvgoPKZOm9i7Aa4046SoBrv4uujk76nTg8dLo09B
 fC+Isy8TQiuzkWdeAhknaHbrKx9ShVCGnJDPQT+yxBY1XDb17FdOeiqK9nPMKRfQRfwED41nD
 r0/m++YZ2JUJIYykKBYyPS2ts8XfZWkwe4Y8DoKT5grqc/gflJlKLotfHpwmc+SCUgxzoe8Bz
 qauk8a1oeN2/I2e4mXxImID8JkcTJB6v+GAWGpKoLNoZ6hD4YADY+pbvrwTNMEKIbKeBpIcgm
 RXJ7r9hK+rWbIp67C33loRsf+pPIDu1Ew0qR4sM/U1u1ND3wdF43vNEiu8korL5cthOTZxk3K
 fLOoYD67E7ysEJhrUP7jrIdsJ+6GFtc7NnftcSzMacAiIaq7sfyi7+kzfjiqJhd0aECQ0L10E
 oRGyq8TIvZ9hgm90k+Ah6EjwxL+ECvv/fDCy57uFv2DlRoIVWUDg9XN0ybqVZK2/tEjRg7dRx
 UqA66QU/DwJjiH7UFl6mnDe7cd3UMFcsu79Z0oU4jvEo/T03LIlcU+3VwviPzMK5v5k0M1lJE
 yRFLMPwn8Iab+2OCOCmbleyZzYQVRf47fIxOnLCHjnsjkbSZchDV4Vk5e2AQXzyz7IRuAFLFU
 8p4J1T3ayY4DfQcc/LOIm7ddQvFWXqB1YGXDfmBzkcooLzF22VAEgKLVEwAxCsJK1mZvQXyYT
 yJ/GYGs
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Date: Tue, 26 Jan 2016 08:36:56 -0800 (PST)
>> From: Drew Adams <drew.adams@HIDDEN>
>> Cc: 22466 <at> debbugs.gnu.org
>> 
>> > Anyway, how come you get to doing this so often it hurts your eyes?
>> > Aren't people setting their beloved theme once when the session
>> > starts, and then never change it?
>> 
>> I can't speak for the OP, but no, users can well want to cycle
>> through a set of themes before choosing one.
>
> Yes, once.  Until they choose that one.

On my todo list there is also writing tramp-theme.el. Something, which
makes it obvious that you are editing a remote file, or not. Even more
important: you are editing a file as root, or not.

This could fall into the category of enabling-disabling the theme more
often than just at the start of your session.

Best regards, Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 18:56:02 +0000
Resent-Message-ID: <handler.22466.B22466.145383451023418 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Michael Albinus <michael.albinus@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, drew.adams@HIDDEN
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145383451023418
          (code B ref 22466); Tue, 26 Jan 2016 18:56:02 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 18:55:10 +0000
Received: from localhost ([127.0.0.1]:37918 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aO8li-00065e-KB
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:55:10 -0500
Received: from eggs.gnu.org ([208.118.235.92]:40438)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <eliz@HIDDEN>) id 1aO8lg-00065S-1B
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:55:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1aO8la-0003pf-C2
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:55:03 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41762)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1aO8lX-0003oj-4D; Tue, 26 Jan 2016 13:54:59 -0500
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1499
 helo=HOME-C4E4A596F7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1aO8lW-0003Go-8M; Tue, 26 Jan 2016 13:54:58 -0500
Date: Tue, 26 Jan 2016 20:55:26 +0200
Message-Id: <834me01881.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87y4bc89pt.fsf@HIDDEN> (message from Michael Albinus on Tue, 26
 Jan 2016 19:41:18 +0100)
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
 <83d1so1df3.fsf@HIDDEN> <87y4bc89pt.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Michael Albinus <michael.albinus@HIDDEN>
> Cc: Drew Adams <drew.adams@HIDDEN>,  22466 <at> debbugs.gnu.org,  bruce.connor.am@HIDDEN
> Date: Tue, 26 Jan 2016 19:41:18 +0100
> 
> On my todo list there is also writing tramp-theme.el. Something, which
> makes it obvious that you are editing a remote file, or not. Even more
> important: you are editing a file as root, or not.
> 
> This could fall into the category of enabling-disabling the theme more
> often than just at the start of your session.

I hope that theme won't change my frame's background color ;-)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Michael Albinus <michael.albinus@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 19:32:02 +0000
Resent-Message-ID: <handler.22466.B22466.145383668526874 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, drew.adams@HIDDEN
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145383668526874
          (code B ref 22466); Tue, 26 Jan 2016 19:32:02 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 19:31:25 +0000
Received: from localhost ([127.0.0.1]:37927 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aO9Km-0006zO-QZ
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:31:24 -0500
Received: from mout.gmx.net ([212.227.15.15]:49646)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <michael.albinus@HIDDEN>) id 1aO9Kl-0006zB-Fx
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:31:23 -0500
Received: from detlef.gmx.de ([79.195.30.160]) by mail.gmx.com (mrgmx001) with
 ESMTPSA (Nemesis) id 0Me8di-1ake2J16Q2-00Pv63;
 Tue, 26 Jan 2016 20:31:13 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
 <83d1so1df3.fsf@HIDDEN> <87y4bc89pt.fsf@HIDDEN>
 <834me01881.fsf@HIDDEN>
Date: Tue, 26 Jan 2016 20:31:10 +0100
In-Reply-To: <834me01881.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 26 Jan
 2016 20:55:26 +0200")
Message-ID: <87twm087ep.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K0:7EbELqDjChnG4xHcecq8K8kWugAZsMr1jZno4Sv5wF9O8OHnOXf
 v7vVVQPw2vd+SvgYxmm6jAJ12W8T4ssTJvthw2qpWjazE66pAlzh8w3aFmoiHC1TngjjS90
 dNp0OgdSbuIMyYclYeKY8Z6B+XG+KDuA2k7DWdHypU+dY1F29BMsvH/KLJterduTgsirGlV
 wcUztSofSqocuESpVbh/Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:hyLFLIad4nw=:UJNkTUQ/s0MbDF2Z6ObSWL
 WTD+wygwgGvVhfpOjaVmFTpt5HCwOqB3tXynxYmEHuhbYjwRxy1T42qyQxQsaOHTftMLRWWaj
 +VxOarPPJlX7ePSu0OH9GxRQBjefN2YmdXD+IYRE1l/NQpUj1DWZn7hn8w94K0OIh/A6Uvlkz
 U4HNO9HPr6vlHp0MVvGyCYMo0AjT//n/Vp0i3HlqmLZqPlF4HEpzrUpo7p59SnufVsIRr4os7
 GEs5Ksm1daSDrg9HOv9RjpUxSfdpzsARn6aKq9YmAUpv5LEIWqaJef7OhiSnNnEaXz9Dv0dPX
 NGj53v+R3y2SS7F4fByP4W6+XFdaKnjAL1rUaRI9IsYXEoo7FPsFNkz2x0kqlKt6NZxsM8Ti2
 JoLDHr9nMvPXNuDtG+mimX460/9327GL+2BlQVvKLcMGpLAkPj0EgGGY/laIMxCdkJ5fhMui+
 LIvyFzFezyCMmZxIjB0OxRE2xG4GJThQZfu/b8tA0DfziaVXS4kfRJzpzqJ/z4a0UPhZLRc/X
 GQWZI8YOsFDsf/hu3TWt38IpOsAXtoKMullZRqznEZsIKlFBjsXSZU/fP2nSfrlZTnqRZuV48
 jQdtyWqjII/Fky1hGh8yx74ZxcfrCoBWVNX3rCeSLNIa0AD9EbLkt66AhntlkX/HEzaxiAOSp
 2/LXSnRUjzyGqguHfSBv0/TzMHAp9Bt6nEnxPBE+yhEmoqTqE+TFTSgvhSrbUVwAHOvR/BQhP
 34gesJaEKveNhxOo2c70fFsi9nVqiclTkiOv4HKPKVWmYRkcozWMhouHlVxBWZNkB2DE55rYe
 cs5hvX6
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Eli Zaretskii <eliz@HIDDEN> writes:

> I hope that theme won't change my frame's background color ;-)

Don't know yet. What about blinking alarm red, in case you are root? :-)
The screen flash, as discussed in this bug, would be a feature then.

Another option would be white foreground / white background. For
security reasons. :-)

Hmm. Maybe I let you customize it yourself ...

Best regards, Michael.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
In-Reply-To: <87y4bcsogq.fsf@HIDDEN>
Resent-From: Artur Malabarba <bruce.connor.am@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 19:56:01 +0000
Resent-Message-ID: <handler.22466.B22466.145383814529073 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145383814529073
          (code B ref 22466); Tue, 26 Jan 2016 19:56:01 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 19:55:45 +0000
Received: from localhost ([127.0.0.1]:37933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aO9iK-0007Yr-PL
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:55:44 -0500
Received: from mail-qg0-f52.google.com ([209.85.192.52]:36709)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <bruce.connor.am@HIDDEN>) id 1aO9iJ-0007Ye-Oh
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:55:44 -0500
Received: by mail-qg0-f52.google.com with SMTP id e32so149169257qgf.3
 for <22466 <at> debbugs.gnu.org>; Tue, 26 Jan 2016 11:55:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:from:to:cc:subject:date:references:message-id:mime-version
 :content-type; bh=0gKk7pHqt3LV2fHaDwi/iRIu2O39avqVNMwLGGxzYco=;
 b=ZJNQS4z5dvCws5gzvQsVk4SHDOh8NhshK8g/oEiuPTu6pHJ3Q8N2adMRVsRbffDl9K
 HuGWSjXuC13woV6swCQcIxO4rpSrn3nEuvPfxtpLers7eSnCd1TUAN6TCVb3rFHtAaxc
 iHHM65priTq4YjXWaC3Py0Nsz+aSBnd664xWfbBRbjK5Sv5WpSo2mrIF0dt/BaeSiOYu
 1QN1wP9UdIbjfgEK02RqlmtT/jab9ZvLz2tQTmWSQpRIozauaqI5R5RdhpX5Bu0ZBmWU
 4a/IVQVOLfHYcDpNKUjKctFpegh9b4hkW2BH7lO3uzfD62QUQev+OcC4pkCV5D7TzAJH
 OACw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:sender:from:to:cc:subject:date:references
 :message-id:mime-version:content-type;
 bh=0gKk7pHqt3LV2fHaDwi/iRIu2O39avqVNMwLGGxzYco=;
 b=UQ/4kJ+U89bH1BYeV9yuAz/9p6ONsdpiyHC0UP0i4NMaHRQo0rOquJ/QTkvPd/gUW9
 uJ3qs8Ocg99g/T/nUusx3Zrp1uTYWwL/F+KsMZCmpYYl1cRhZnyuGlp4NZ+AVDhXNQgK
 yGQ+KuVrWOOMDrk/27f0RuRm8LL1UygEIg0Xb16iAJqPhE7tBTKeNJKA0GrHJJs770wf
 RWxozDoFraiGmvfWhfO8/NH0JCbL8tJjzZwYfVxB5hP523pCr/ShJhMsZAnsWgQeNkjG
 u/sNhePwKkGWv0xj9qF6CdSFCRGUqHwLl0K6uTJgjn67IDDzZDTBcD4w0OAsc5FD+lVU
 t+jA==
X-Gm-Message-State: AG10YOQI185jxrj3So4NkTcuzxvQvypABXiYHesfRP6cXLdzfh+vXW6+Lw5keNm3+CAAtA==
X-Received: by 10.140.42.139 with SMTP id c11mr30768626qga.5.1453838138143;
 Tue, 26 Jan 2016 11:55:38 -0800 (PST)
Received: from Gandalf-Linux.gmail.com ([201.37.162.188])
 by smtp.gmail.com with ESMTPSA id h99sm1145544qge.7.2016.01.26.11.55.36
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 26 Jan 2016 11:55:37 -0800 (PST)
From: Artur Malabarba <bruce.connor.am@HIDDEN>
Date: Tue, 26 Jan 2016 17:25:36 +0000
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
Message-ID: <87io2gns3b.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Eli Zaretskii <eliz@HIDDEN> writes:

> It's not redisplay that does this.  It's the fact that disable-theme
> changes the frame's background color, and when that happens, we
> immediately clear the frame using the new background color, as part of
> the modify-frame-parameters call.
>
> Redisplay only handles the portions of display where there's text and
> other decorations that we manage.  Clearing the frame with the new
> background color is not redisplay's job.

Thanks, that's good to know.

>>     (set-frame-parameter frame 'background-color
>>     			     (custom--frame-color-default
>>     			      frame :background "background" "Background"
>>     			      "unspecified-bg" "white"))
>> 
>> I'm not saying this form is wrong. I'm just pointing to where it happens.
>
> What happens if you remove that from disable-theme?

Then there's no flashing, but then if I simply disable the theme
(without enabling a new one) I'm left with theme's background.

> (I don't really understand why it has to specify "white".)

I guess it's meant to reset the face to the default. Although, I don't
see why this is explicitly necessary for the default
background/foreground colors, but isn't necessary for other faces.

> Anyway, how come you get to doing this so often it hurts your eyes?
> Aren't people setting their beloved theme once when the session
> starts, and then never change it?

I never change my main color theme, but I always have a second theme
enabled that only affects the mode-line. This second theme is changed
occasionally and it always causes a flash (even though the theme has
nothing to do with the background).

Besides, custom themes are not just for faces. This also came up because
someone is writing a package that simultaneously toggles between
different values for a set of variables (called a context) using
custom-themes. That's something that's designed to be used a couple
times a day.

Anyway, it's not a huge defficiency and it's not worth any large
efforts. I brought it up because I thought there was an eager redisplay
happening somewhere and that might point to a deeper bug, but you've
clearly explained that's not the case. :-)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 20:16:02 +0000
Resent-Message-ID: <handler.22466.B22466.145383930330902 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Artur Malabarba <bruce.connor.am@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145383930330902
          (code B ref 22466); Tue, 26 Jan 2016 20:16:02 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 20:15:03 +0000
Received: from localhost ([127.0.0.1]:37937 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aOA11-00082L-CU
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 15:15:03 -0500
Received: from eggs.gnu.org ([208.118.235.92]:60652)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <eliz@HIDDEN>) id 1aOA10-00081c-2J
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 15:15:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1aOA0r-0007Dv-My
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 15:14:56 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42907)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1aOA0r-0007Dn-J9; Tue, 26 Jan 2016 15:14:53 -0500
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1591
 helo=HOME-C4E4A596F7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1aOA0q-0002HB-SS; Tue, 26 Jan 2016 15:14:53 -0500
Date: Tue, 26 Jan 2016 22:15:22 +0200
Message-Id: <831t9414it.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87io2gns3b.fsf@HIDDEN> (message from Artur Malabarba on Tue, 
 26 Jan 2016 17:25:36 +0000)
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <87io2gns3b.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Artur Malabarba <bruce.connor.am@HIDDEN>
> Cc: 22466 <at> debbugs.gnu.org
> Date: Tue, 26 Jan 2016 17:25:36 +0000
> 
> >>     (set-frame-parameter frame 'background-color
> >>     			     (custom--frame-color-default
> >>     			      frame :background "background" "Background"
> >>     			      "unspecified-bg" "white"))
> >> 
> >> I'm not saying this form is wrong. I'm just pointing to where it happens.
> >
> > What happens if you remove that from disable-theme?
> 
> Then there's no flashing, but then if I simply disable the theme
> (without enabling a new one) I'm left with theme's background.

So disable-theme actually means go back to the default theme?  If so,
when someone changes a theme, they don't really need to call
disable-theme, right?  They could just call load-theme with the new
theme as an argument?

> I never change my main color theme, but I always have a second theme
> enabled that only affects the mode-line. This second theme is changed
> occasionally and it always causes a flash (even though the theme has
> nothing to do with the background).
> 
> Besides, custom themes are not just for faces. This also came up because
> someone is writing a package that simultaneously toggles between
> different values for a set of variables (called a context) using
> custom-themes. That's something that's designed to be used a couple
> times a day.

Then it would make sense to find a way of switching a theme without
changing the frame's background color, if that's possible (i.e. if the
new theme keeps the same background color).  If there's a function
missing for that, I'd suggest to add one.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 26 Jan 2016 23:04:01 +0000
Resent-Message-ID: <handler.22466.B22466.145384939014313 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, drew.adams@HIDDEN
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145384939014313
          (code B ref 22466); Tue, 26 Jan 2016 23:04:01 +0000
Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 23:03:10 +0000
Received: from localhost ([127.0.0.1]:37966 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aOCdh-0003in-Tn
	for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 18:03:10 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:19584)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <drew.adams@HIDDEN>) id 1aOCdg-0003ia-GO
 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 18:03:08 -0500
Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])
 by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id
 u0QN32br027364
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
 Tue, 26 Jan 2016 23:03:02 GMT
Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])
 by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u0QN2xAW022512
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);
 Tue, 26 Jan 2016 23:03:01 GMT
Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15])
 by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u0QN2xT5005475;
 Tue, 26 Jan 2016 23:02:59 GMT
MIME-Version: 1.0
Message-ID: <0af8586e-9886-4684-9a4d-8d82b99f8f8e@default>
Date: Tue, 26 Jan 2016 15:02:57 -0800 (PST)
From: Drew Adams <drew.adams@HIDDEN>
References: <<87y4bcsogq.fsf@HIDDEN>> <<83powo1j71.fsf@HIDDEN>
 <1bbf7218-bd5b-4618-822c-cd75884a81ee@default>	<83d1so1df3.fsf@HIDDEN>>
 <<87y4bc89pt.fsf@HIDDEN>> <<834me01881.fsf@HIDDEN>>
In-Reply-To: <<834me01881.fsf@HIDDEN>>
X-Priority: 3
X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9  (901082) [OL
 12.0.6691.5000 (x86)]
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Source-IP: userv0021.oracle.com [156.151.31.71]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

> > On my todo list there is also writing tramp-theme.el. Something, which
> > makes it obvious that you are editing a remote file, or not. Even more
> > important: you are editing a file as root, or not.
> >
> > This could fall into the category of enabling-disabling the theme more
> > often than just at the start of your session.
>=20
> I hope that theme won't change my frame's background color ;-)

I heard that Michael is working on a special background color
that will take effect only when the user is Eli Zaretskii.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Artur Malabarba <bruce.connor.am@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 27 Jan 2016 22:22:01 +0000
Resent-Message-ID: <handler.22466.B22466.145393326326787 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145393326326787
          (code B ref 22466); Wed, 27 Jan 2016 22:22:01 +0000
Received: (at 22466) by debbugs.gnu.org; 27 Jan 2016 22:21:03 +0000
Received: from localhost ([127.0.0.1]:38998 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aOYSV-0006xx-JD
	for submit <at> debbugs.gnu.org; Wed, 27 Jan 2016 17:21:03 -0500
Received: from mail-qg0-f42.google.com ([209.85.192.42]:34739)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <bruce.connor.am@HIDDEN>) id 1aOYSU-0006xA-C7
 for 22466 <at> debbugs.gnu.org; Wed, 27 Jan 2016 17:21:02 -0500
Received: by mail-qg0-f42.google.com with SMTP id 6so19490728qgy.1
 for <22466 <at> debbugs.gnu.org>; Wed, 27 Jan 2016 14:21:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-type;
 bh=LvYV0T284pZBtSEEcYiRg2HupklylUSlVGRG2H0B81Q=;
 b=kP4KnLU7Y5bzYTLF6YaYvw0m+F53vir6g42hsNzxncejnH6lLAwbER3DxiXE6B0Plk
 e0pi3uoQGnwGfP4ombunXzZsuK189/QPUYV/godixe3XAEw+i3MPGwOZa7/r1LQl/xCt
 4x6Wrmrd+4fyQ1qtFem2kGCR+otN1ZAZyhS2s4oEYWLCr9NYCcAVjjkDk9XLpgMzsal/
 AKB7/18aKXkuXW1JVDbt6wg514fGTsvxQ/AHE3tZ+wv+SnDVM+nquGj+YWiRVxAxSHAJ
 xR2H3J3SYY8dJTGSnZ56i8pc+UKRob0z8Tpz7Pq8AEpB9dAHpKAeCLTOCG6tmOkE5/8R
 uMJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:sender:from:to:cc:subject:references:date
 :in-reply-to:message-id:user-agent:mime-version:content-type;
 bh=LvYV0T284pZBtSEEcYiRg2HupklylUSlVGRG2H0B81Q=;
 b=YY2v1/FRTpLBdtkq0JWov5KafyDbUyUiPpC7e/APoeVUknffVLlXk2Ibi0JhupSF6j
 V7cXT7g/QmxwgSTm5PIGGjv7+eloITKhR9t0VnATvxBAkBlf4UOtYVgsRRSMqf/Jnk45
 9zc56+snULkEANv0zt+58Pji4EOgfMjs9MSGbx9LeIZ6JJDxyJqkG057BG8WSjZfrTx7
 Q3M4g+Hj2F+jV59HSE39d9cqU28JKWj1k1VD+DyedstD34+OkPgjnd74hBghaxmR68EA
 GgmTpp9RcVnR42lREBpVsQd4GF76mmVptslF68ChjRzNsaTMtQxtM6dsd6+nUn6EITwp
 9I9w==
X-Gm-Message-State: AG10YORzysf2s2eDZRztvcszrqbHUZC38zJSggMhdG447WxgXPnF+omEu3+XLXlBlcOLOg==
X-Received: by 10.140.171.5 with SMTP id r5mr40730308qhr.51.1453933257031;
 Wed, 27 Jan 2016 14:20:57 -0800 (PST)
Received: from Gandalf-Linux.gmail.com ([201.37.162.188])
 by smtp.gmail.com with ESMTPSA id v70sm2557583qkl.15.2016.01.27.14.20.55
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 27 Jan 2016 14:20:56 -0800 (PST)
From: Artur Malabarba <bruce.connor.am@HIDDEN>
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <87io2gns3b.fsf@HIDDEN> <831t9414it.fsf@HIDDEN>
Date: Wed, 27 Jan 2016 20:20:43 +0000
In-Reply-To: <831t9414it.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 26 Jan
 2016 22:15:22 +0200")
Message-ID: <87bn86ojtw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Eli Zaretskii <eliz@HIDDEN> writes:

> So disable-theme actually means go back to the default theme?  If so,
> when someone changes a theme, they don't really need to call
> disable-theme, right?  They could just call load-theme with the new
> theme as an argument?

I'm not sure why you reach this conclusion. `disable-theme' is meant to
disable a single theme. If I have theme X enabled, then (disable-theme 'X) is
supposed to restore the default Emacs appearance. If have two themes enabled (X
and Y), then (disable-theme 'X) is supposed to give me just the
appearance of theme Y.

Right now, that's indeed what it does. But if I remove the form (as you
asked) then it fails to do the above (it doesn't remove the background
set by the disabled theme).

> Then it would make sense to find a way of switching a theme without
> changing the frame's background color, if that's possible (i.e. if the
> new theme keeps the same background color).  If there's a function
> missing for that, I'd suggest to add one.

How about just running that form only when necessary (i.e., only if the
disabled theme actually sets the frame `background-color')?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 28 Jan 2016 03:38:02 +0000
Resent-Message-ID: <handler.22466.B22466.145395226423025 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22466
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Artur Malabarba <bruce.connor.am@HIDDEN>
Cc: 22466 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 22466-submit <at> debbugs.gnu.org id=B22466.145395226423025
          (code B ref 22466); Thu, 28 Jan 2016 03:38:02 +0000
Received: (at 22466) by debbugs.gnu.org; 28 Jan 2016 03:37:44 +0000
Received: from localhost ([127.0.0.1]:39062 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1aOdOx-0005zJ-QU
	for submit <at> debbugs.gnu.org; Wed, 27 Jan 2016 22:37:43 -0500
Received: from eggs.gnu.org ([208.118.235.92]:48567)
 by debbugs.gnu.org with esmtp (Exim 4.84)
 (envelope-from <eliz@HIDDEN>) id 1aOdOw-0005z7-EQ
 for 22466 <at> debbugs.gnu.org; Wed, 27 Jan 2016 22:37:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1aOdNh-0007AK-SP
 for 22466 <at> debbugs.gnu.org; Wed, 27 Jan 2016 22:37:37 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42602)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1aOdNh-0007AE-Kj; Wed, 27 Jan 2016 22:36:25 -0500
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2401
 helo=HOME-C4E4A596F7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1aOdNg-0007Dp-UL; Wed, 27 Jan 2016 22:36:25 -0500
Date: Thu, 28 Jan 2016 05:36:58 +0200
Message-Id: <83egd2z86d.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <87bn86ojtw.fsf@HIDDEN> (message from Artur Malabarba on Wed, 
 27 Jan 2016 20:20:43 +0000)
References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN>
 <87io2gns3b.fsf@HIDDEN> <831t9414it.fsf@HIDDEN> <87bn86ojtw.fsf@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Artur Malabarba <bruce.connor.am@HIDDEN>
> Cc: 22466 <at> debbugs.gnu.org
> Date: Wed, 27 Jan 2016 20:20:43 +0000
> 
> > Then it would make sense to find a way of switching a theme without
> > changing the frame's background color, if that's possible (i.e. if the
> > new theme keeps the same background color).  If there's a function
> > missing for that, I'd suggest to add one.
> 
> How about just running that form only when necessary (i.e., only if the
> disabled theme actually sets the frame `background-color')?

Yes, something like that.  Or maybe add a new switch-theme API that
receives both the old and a new theme, and changes the background
color only if the new theme sets a different one.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 5 Nov 2020 22:08:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 05 17:08:41 2020
Received: from localhost ([127.0.0.1]:54375 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kanQu-0001ee-Ve
	for submit <at> debbugs.gnu.org; Thu, 05 Nov 2020 17:08:41 -0500
Received: from mail-wr1-f41.google.com ([209.85.221.41]:44942)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maurooaranda@HIDDEN>) id 1kanQs-0001eM-UA
 for control <at> debbugs.gnu.org; Thu, 05 Nov 2020 17:08:39 -0500
Received: by mail-wr1-f41.google.com with SMTP id c17so3494451wrc.11
 for <control <at> debbugs.gnu.org>; Thu, 05 Nov 2020 14:08:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to:cc;
 bh=YUSgvR9NUYzaGz35t3WBmhN+dbR9e+mktbPdnpYQLwU=;
 b=XXoOgc9eJmHJFQqxSsWyKvX15Bz2cA8z0CMZ+fq2ITVbED1A64j+2xGdYwmpK/DogT
 Y6ypSdwE6Xx40/evcsicOEU6vqqevUqUAJbbyjxZndzUsTN9Php/pwvejwy1mcP3R0cI
 Rnq7jlyNGsvHmB+NEEEkqEZNW9GuzxArc4ooDjtF6JjIMVv5IFRGzgN7v/XF8aIqRSWR
 utXJNlH0FuchERYSldIEN5HaloBpB4Lqqe+5K0ZghIAk8ZycLll2hMOE98u8TeVk0AYu
 VzDBFvLLiDBsT/M03OXAdYjAVQBLCF5lPGoEk9gH0AlrmhsMfWyG8WaFQlI8KpD9WNrq
 DhRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=YUSgvR9NUYzaGz35t3WBmhN+dbR9e+mktbPdnpYQLwU=;
 b=jS+wx/1eHHGUNBtAvIWb7AQE3J6MHw8lToWnjbM53Xa6OtmKIia0XyH97NNMU3Ji+G
 WcmctiCqtwksV9UZF/WXCJEcpQ0NUvSpctdpBBaVAzer91lEIerlGmWEHstF4IS83m9D
 PFSIB1uxK98spNrdgmhVQ/gruNyw5WSE+Y3353TDdFVmRRWS89rc11+WFYsUVD/DIpnY
 5Mf2OxCfgm8RtB5sllBTzSOekdVjZs2EO5G+GruM5rjAgTUbp6bEoQmZolbcDMk083Gw
 i8ngS3x1K9rZo4cd0cBcRsbJbrmAzl6P3Fvyb04hvQtNTTigMjRHnWW8A2pOSiLuXyKc
 RB7g==
X-Gm-Message-State: AOAM532be4spDHFy3vFo+G8fJFLV6kGAMb171ISzrRmddkep7B+j2yEA
 BfOaOQAxlW80GacKLKkJFHK1ZCcJNQWHVHsKTE8=
X-Google-Smtp-Source: ABdhPJwPQtik/O29apJ1clQtd8hKrQexAw2yMqx20Yo5uHmjxHrxYBWGGF8nWsaJMjYO/iEfIaOfNoBu4hs7OeZOOx0=
X-Received: by 2002:a5d:4991:: with SMTP id r17mr5265620wrq.70.1604614113241; 
 Thu, 05 Nov 2020 14:08:33 -0800 (PST)
MIME-Version: 1.0
From: Mauro Aranda <maurooaranda@HIDDEN>
Date: Thu, 5 Nov 2020 19:08:21 -0300
Message-ID: <CABczVwcHU5dCWF74YtpcKiszJTB0+JNCdzjTzMbiRMNVXUSB6w@HIDDEN>
Subject: Re: bug#20016: 24.4; is there a way to avoid white flash while
 switching between themes
To: Marcin Kasperski <Marcin.Kasperski@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000038af1605b36356d2"
Bcc: control <at> debbugs.gnu.org
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: 20016 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000038af1605b36356d2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

merge 22466 20016
quit


Marcin Kasperski <Marcin.Kasperski@HIDDEN> writes:

> I am looking for a way to switch[1] between two themes gently [2],
> without unpleasant effect of window becoming white for a short moment
> (what means unpleasant white flash).
>
> Reproducting the problem
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
>
>   a) (to have clear start) Load any two dark themes and apply one of
>      them.  For example, eval the following:
>
>           (load-theme 'twilight 't 't)
>           (load-theme 'molokai 't 't)
>           (enable-theme 'twilight)
>
>      (feel free to replace twilight and molokai with any other dark
>       themes)
>
>   b) eval the following
>
>           (disable-theme 'twilight)
>           (enable-theme 'molokai)
>
>      Emacs will drop twilight, *flash with white*, and only then apply
>      molokai.
>
>   c) the other way around is similar, eval
>
>           (enable-theme 'twilight)
>           (disable-theme 'molokai)
>
>      The flash is still there, and happens during disable-theme.
>
>      { In Emacs 24.3 case c) was worse than b) =E2=86=92 lasted longer an=
d
>        sometimes caused 2-3 flashes. In 24.4 both cases are similar. }

Although I didn't test with those exact themes because I don't have
them, the description of the problem seems to be like the one in
Bug#22466, so I'm merging the bugs.

--00000000000038af1605b36356d2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">merge 22466 20016<br>quit<br><br><br>Marcin Kasperski &lt;=
<a href=3D"mailto:Marcin.Kasperski@HIDDEN">Marcin.Kasperski@HIDDEN=
l</a>&gt; writes:<br><br>&gt; I am looking for a way to switch[1] between t=
wo themes gently [2],<br>&gt; without unpleasant effect of window becoming =
white for a short moment<br>&gt; (what means unpleasant white flash).<br>&g=
t;<br>&gt; Reproducting the problem<br>&gt; =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br>&gt;<br>&gt; =C2=A0 a) (to=
 have clear start) Load any two dark themes and apply one of<br>&gt; =C2=A0=
 =C2=A0 =C2=A0them.=C2=A0 For example, eval the following:<br>&gt;<br>&gt; =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (load-theme &#39;twilight &#39;t &#39;t)=
<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (load-theme &#39;molokai &#39;t=
 &#39;t)<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (enable-theme &#39;twil=
ight)<br>&gt;<br>&gt; =C2=A0 =C2=A0 =C2=A0(feel free to replace twilight an=
d molokai with any other dark<br>&gt; =C2=A0 =C2=A0 =C2=A0 themes)<br>&gt;<=
br>&gt; =C2=A0 b) eval the following<br>&gt;<br>&gt; =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 (disable-theme &#39;twilight)<br>&gt; =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 (enable-theme &#39;molokai)<br>&gt;<br>&gt; =C2=A0 =C2=A0 =C2=
=A0Emacs will drop twilight, *flash with white*, and only then apply<br>&gt=
; =C2=A0 =C2=A0 =C2=A0molokai.<br>&gt;<br>&gt; =C2=A0 c) the other way arou=
nd is similar, eval<br>&gt;<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (ena=
ble-theme &#39;twilight)<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (disabl=
e-theme &#39;molokai)<br>&gt;<br>&gt; =C2=A0 =C2=A0 =C2=A0The flash is stil=
l there, and happens during disable-theme.<br>&gt;<br>&gt; =C2=A0 =C2=A0 =
=C2=A0{ In Emacs 24.3 case c) was worse than b) =E2=86=92 lasted longer and=
<br>&gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0sometimes caused 2-3 flashes. In 24.4 b=
oth cases are similar. }<br><br>Although I didn&#39;t test with those exact=
 themes because I don&#39;t have<br>them, the description of the problem se=
ems to be like the one in<br>Bug#22466, so I&#39;m merging the bugs.</div>

--00000000000038af1605b36356d2--

Last modified: Thu, 5 Nov 2020 22:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.