GNU logs - #22780, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font
Resent-From: Alex Khesin <alex@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Feb 2016 07:20:01 +0000
Resent-Message-ID: <handler.22780.B.145621195310796 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 22780 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Alex Khesin <alex@HIDDEN>
Date: Tue, 23 Feb 2016 00:41:11 -0500
Message-ID: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
Content-Type: multipart/alternative; boundary=089e01538d98c27911052c696625
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--089e01538d98c27911052c696625
Content-Type: text/plain; charset=UTF-8

emacs 25 choses fonts with different average width for 7x13 font, making
bold text take more horizontal space.  This is particularly a problem when
using themes like https://github.com/bbatsov/zenburn-emacs which use bold
to hihglight matching parenthesis in show-paren-mode, causing characters to
shift as the cursor is moved from a parenthesis to a non-parenthesis
character.

Repro that demonstrates the problem in both 25 pretest 1 and current head
(but is perfectly ok in emacs 24):

$ emacs -Q --eval '(progn (set-face-font '\''default "7x13") (print
(face-font "default")) (print (face-font "bold")))'

shows
  -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1
  -misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1

Notice the jump from 70 to 80 before the iso8859 component - that's the
average width, and that's what I believe is causing bold characters to
render wider than non-bold ones.  Both are 70 in emacs 24.


Below is the diagnostics output from M-x report-emacs-bug:

In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll
bars)
 of 2016-02-22 built on alexk1
Repository revision: 81ef756e6aea369ec78f19b3609f01ceddc5851f
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04 LTS (upgraded from: Ubuntu 12.04.3 LTS)

Configured using:
 'configure --with-x-toolkit=lucid'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF
GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS LUCID X11

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Features:
(shadow sort mail-extr emacsbug message dired dired-loaddefs format-spec
rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config
gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils time-date mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting x-toolkit x
multi-tty make-network-process emacs)

--089e01538d98c27911052c696625
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div>emacs 25 choses fonts with different average wid=
th for 7x13 font, making bold text take more horizontal space.=C2=A0 This i=
s particularly a problem when using themes like <a href=3D"https://github.c=
om/bbatsov/zenburn-emacs">https://github.com/bbatsov/zenburn-emacs</a> whic=
h use bold to hihglight matching parenthesis in show-paren-mode, causing ch=
aracters to shift as the cursor is moved from a parenthesis to a non-parent=
hesis character.</div><div><br></div><div>Repro that demonstrates the probl=
em in both 25 pretest 1 and current head (but is perfectly ok in emacs 24):=
</div><div><br></div><div>$ emacs -Q --eval &#39;(progn (set-face-font &#39=
;\&#39;&#39;default &quot;7x13&quot;) (print (face-font &quot;default&quot;=
)) (print (face-font &quot;bold&quot;)))&#39;</div><div><br></div><div>show=
s</div><div><div>=C2=A0 -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8=
859-1</div><div>=C2=A0 -misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859=
-1</div></div><div><br></div><div>Notice the jump from 70 to 80 before the =
iso8859 component - that&#39;s the average width, and that&#39;s what I bel=
ieve is causing bold characters to render wider than non-bold ones.=C2=A0 B=
oth are 70 in emacs 24.</div><div><br></div><div><br></div><div>Below is th=
e diagnostics output from M-x report-emacs-bug:</div><div><br></div><div>In=
 GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bar=
s)</div><div>=C2=A0of 2016-02-22 built on alexk1</div><div>Repository revis=
ion: 81ef756e6aea369ec78f19b3609f01ceddc5851f</div><div>Windowing system di=
stributor &#39;The X.Org Foundation&#39;, version 11.0.11501000</div><div>S=
ystem Description:<span style=3D"white-space:pre-wrap">	</span>Ubuntu 14.04=
 LTS (upgraded from: Ubuntu 12.04.3 LTS)</div><div><br></div><div>Configure=
d using:</div><div>=C2=A0&#39;configure --with-x-toolkit=3Dlucid&#39;</div>=
<div><br></div><div>Configured features:</div><div>XAW3D XPM JPEG TIFF GIF =
PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF</div><div>GSETTINGS NOTIFY GNUTLS=
 LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB</div><div>TOOLKIT_SCROLL_BARS LU=
CID X11</div><div><br></div><div>Important settings:</div><div>=C2=A0 value=
 of $LANG: en_US.UTF-8</div><div>=C2=A0 value of $XMODIFIERS: @im=3Dibus</d=
iv><div>=C2=A0 locale-coding-system: utf-8-unix</div><div><br></div><div>Ma=
jor mode: Lisp Interaction</div><div><br></div><div>Minor modes in effect:<=
/div><div>=C2=A0 tooltip-mode: t</div><div>=C2=A0 global-eldoc-mode: t</div=
><div>=C2=A0 electric-indent-mode: t</div><div>=C2=A0 mouse-wheel-mode: t</=
div><div>=C2=A0 tool-bar-mode: t</div><div>=C2=A0 menu-bar-mode: t</div><di=
v>=C2=A0 file-name-shadow-mode: t</div><div>=C2=A0 global-font-lock-mode: t=
</div><div>=C2=A0 font-lock-mode: t</div><div>=C2=A0 blink-cursor-mode: t</=
div><div>=C2=A0 auto-composition-mode: t</div><div>=C2=A0 auto-encryption-m=
ode: t</div><div>=C2=A0 auto-compression-mode: t</div><div>=C2=A0 line-numb=
er-mode: t</div><div>=C2=A0 transient-mark-mode: t</div><div><br></div><div=
>Features:<br></div><div>(shadow sort mail-extr emacsbug message dired dire=
d-loaddefs format-spec</div><div>rfc822 mml easymenu mml-sec password-cache=
 epa derived epg epg-config</div><div>gnus-util rmail rmail-loaddefs mm-dec=
ode mm-bodies mm-encode mail-parse</div><div>rfc2231 mailabbrev gmm-utils m=
ailheader sendmail rfc2047 rfc2045</div><div>ietf-drums mm-util mail-prsvr =
mail-utils time-date mule-util tooltip</div><div>eldoc electric uniquify ed=
iff-hook vc-hooks lisp-float-type mwheel</div><div>term/x-win x-win term/co=
mmon-win x-dnd tool-bar dnd fontset image</div><div>regexp-opt fringe tabul=
ated-list newcomment elisp-mode lisp-mode</div><div>prog-mode register page=
 menu-bar rfn-eshadow timer select scroll-bar</div><div>mouse jit-lock font=
-lock syntax facemenu font-core term/tty-colors frame</div><div>cl-generic =
cham georgian utf-8-lang misc-lang vietnamese tibetan thai</div><div>tai-vi=
et lao korean japanese eucjp-ms cp51932 hebrew greek romanian</div><div>slo=
vak czech european ethiopic indian cyrillic chinese charscript</div><div>ca=
se-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer</div>=
<div>cl-preloaded nadvice loaddefs button faces cus-face macroexp files</di=
v><div>text-properties overlay sha1 md5 base64 format env code-pages mule</=
div><div>custom widget hashtable-print-readable backquote dbusbind inotify<=
/div><div>dynamic-setting system-font-setting font-render-setting x-toolkit=
 x</div><div>multi-tty make-network-process emacs)</div><div><br></div></di=
v></div>

--089e01538d98c27911052c696625--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alex Khesin <alex@HIDDEN>
Subject: bug#22780: Acknowledgement (25.1.50; wrong average width picked
 for bold face for 7x13 X11 font)
Message-ID: <handler.22780.B.145621195310796.ack <at> debbugs.gnu.org>
References: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
X-Gnu-PR-Message: ack 22780
X-Gnu-PR-Package: emacs
Reply-To: 22780 <at> debbugs.gnu.org
Date: Tue, 23 Feb 2016 07:20:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 22780 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
22780: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22780
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font
Resent-From: Philipp Stephani <p.stephani2@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Sep 2016 14:17:02 +0000
Resent-Message-ID: <handler.22780.B22780.147386256621440 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Alex Khesin <alex@HIDDEN>, 22780 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
In-Reply-To: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
From: Philipp Stephani <p.stephani2@HIDDEN>
Date: Wed, 14 Sep 2016 14:15:47 +0000
Message-ID: <CAArVCkSbrfacq=aapuKqDw0=+dDDqBGyaoLj8=M92U9TjH6HLw@HIDDEN>
Content-Type: multipart/alternative; boundary=001a114b32cc3d9f33053c785eed
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--001a114b32cc3d9f33053c785eed
Content-Type: text/plain; charset=UTF-8

Alex Khesin <alex@HIDDEN> schrieb am Di., 23. Feb. 2016 um 08:20 Uhr:

> emacs 25 choses fonts with different average width for 7x13 font, making
> bold text take more horizontal space.  This is particularly a problem when
> using themes like https://github.com/bbatsov/zenburn-emacs which use bold
> to hihglight matching parenthesis in show-paren-mode, causing characters to
> shift as the cursor is moved from a parenthesis to a non-parenthesis
> character.
>
> Repro that demonstrates the problem in both 25 pretest 1 and current head
> (but is perfectly ok in emacs 24):
>
> $ emacs -Q --eval '(progn (set-face-font '\''default "7x13") (print
> (face-font "default")) (print (face-font "bold")))'
>
> shows
>   -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1
>   -misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1
>
> Notice the jump from 70 to 80 before the iso8859 component - that's the
> average width, and that's what I believe is causing bold characters to
> render wider than non-bold ones.  Both are 70 in emacs 24.
>
>
This appears to be a regression from Emacs 24. Would be great if somebody
who has knowledge about this area could look into this.

--001a114b32cc3d9f33053c785eed
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br><div class=3D"gmail_quote"><div dir=3D"ltr">Alex K=
hesin &lt;<a href=3D"mailto:alex@HIDDEN">alex@HIDDEN</a>&gt; schrie=
b am Di., 23. Feb. 2016 um 08:20=C2=A0Uhr:<br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex"><div dir=3D"ltr" class=3D"gmail_msg"><div class=3D"gmail_msg"><div =
class=3D"gmail_msg">emacs 25 choses fonts with different average width for =
7x13 font, making bold text take more horizontal space.=C2=A0 This is parti=
cularly a problem when using themes like <a href=3D"https://github.com/bbat=
sov/zenburn-emacs" class=3D"gmail_msg" target=3D"_blank">https://github.com=
/bbatsov/zenburn-emacs</a> which use bold to hihglight matching parenthesis=
 in show-paren-mode, causing characters to shift as the cursor is moved fro=
m a parenthesis to a non-parenthesis character.</div><div class=3D"gmail_ms=
g"><br class=3D"gmail_msg"></div><div class=3D"gmail_msg">Repro that demons=
trates the problem in both 25 pretest 1 and current head (but is perfectly =
ok in emacs 24):</div><div class=3D"gmail_msg"><br class=3D"gmail_msg"></di=
v><div class=3D"gmail_msg">$ emacs -Q --eval &#39;(progn (set-face-font &#3=
9;\&#39;&#39;default &quot;7x13&quot;) (print (face-font &quot;default&quot=
;)) (print (face-font &quot;bold&quot;)))&#39;</div><div class=3D"gmail_msg=
"><br class=3D"gmail_msg"></div><div class=3D"gmail_msg">shows</div><div cl=
ass=3D"gmail_msg"><div class=3D"gmail_msg">=C2=A0 -misc-fixed-medium-r-norm=
al--13-120-75-75-c-70-iso8859-1</div><div class=3D"gmail_msg">=C2=A0 -misc-=
fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1</div></div><div class=3D"g=
mail_msg"><br class=3D"gmail_msg"></div><div class=3D"gmail_msg">Notice the=
 jump from 70 to 80 before the iso8859 component - that&#39;s the average w=
idth, and that&#39;s what I believe is causing bold characters to render wi=
der than non-bold ones.=C2=A0 Both are 70 in emacs 24.</div><div class=3D"g=
mail_msg"><br class=3D"gmail_msg"></div></div></div></blockquote><div><br><=
/div><div>This appears to be a regression from Emacs 24. Would be great if =
somebody who has knowledge about this area could look into this.=C2=A0</div=
></div></div>

--001a114b32cc3d9f33053c785eed--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 14 Sep 2016 16:50:02 +0000
Resent-Message-ID: <handler.22780.B22780.14738717794799 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Philipp Stephani <p.stephani2@HIDDEN>
Cc: 22780 <at> debbugs.gnu.org, alex@HIDDEN
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Date: Wed, 14 Sep 2016 19:49:31 +0300
Message-Id: <838tuu8m04.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAArVCkSbrfacq=aapuKqDw0=+dDDqBGyaoLj8=M92U9TjH6HLw@HIDDEN>
 (message from Philipp Stephani on Wed, 14 Sep 2016 14:15:47 +0000)
References: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
 <CAArVCkSbrfacq=aapuKqDw0=+dDDqBGyaoLj8=M92U9TjH6HLw@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Philipp Stephani <p.stephani2@HIDDEN>
> Date: Wed, 14 Sep 2016 14:15:47 +0000
> 
> Alex Khesin <alex@HIDDEN> schrieb am Di., 23. Feb. 2016 um 08:20 Uhr:
> 
>  emacs 25 choses fonts with different average width for 7x13 font, making bold text take more horizontal
>  space. This is particularly a problem when using themes like https://github.com/bbatsov/zenburn-emacs
>  which use bold to hihglight matching parenthesis in show-paren-mode, causing characters to shift as
>  the cursor is moved from a parenthesis to a non-parenthesis character.
> 
>  Repro that demonstrates the problem in both 25 pretest 1 and current head (but is perfectly ok in emacs
>  24):
> 
>  $ emacs -Q --eval '(progn (set-face-font '\''default "7x13") (print (face-font "default")) (print (face-font
>  "bold")))'
> 
>  shows
>  -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1
>  -misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1
> 
>  Notice the jump from 70 to 80 before the iso8859 component - that's the average width, and that's what
>  I believe is causing bold characters to render wider than non-bold ones. Both are 70 in emacs 24.
> 
> This appears to be a regression from Emacs 24. Would be great if somebody who has knowledge about this
> area could look into this. 

Alas, we don't have such experts on board.  Moreover, I could be
wrong, but I don't think font selection has seen any changes between
Emacs 24 and 25.

Perhaps the best way ahead is for someone who sees the problem to
revert changes since Emacs 24.5 to xftfont.c, ftfont.c, and font.c one
by one, and see which one causes the problem.  There are only a few
changes there that affect the code and font selection in particular.

Sorry, but I have no better advice.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font
References: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
In-Reply-To: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
Resent-From: gnubugs@HIDDEN (Andrew M. Bishop)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 14 Mar 2017 20:27:01 +0000
Resent-Message-ID: <handler.22780.B22780.148952317527195 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22780
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 22780 <at> debbugs.gnu.org
Cc: alex@HIDDEN
Received: via spool by 22780-submit <at> debbugs.gnu.org id=B22780.148952317527195
          (code B ref 22780); Tue, 14 Mar 2017 20:27:01 +0000
Received: (at 22780) by debbugs.gnu.org; 14 Mar 2017 20:26:15 +0000
Received: from localhost ([127.0.0.1]:56065 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cnt1K-00074Z-8w
	for submit <at> debbugs.gnu.org; Tue, 14 Mar 2017 16:26:14 -0400
Received: from vps1.gedanken.org.uk ([176.126.246.21]:42469
 helo=gedanken.org.uk) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gnubugs@HIDDEN>) id 1cnsT7-0006EI-9j
 for 22780 <at> debbugs.gnu.org; Tue, 14 Mar 2017 15:50:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=gedanken.org.uk; s=20160729; 
 h=Message-Id:Content-Type:MIME-Version:Date:CC:Subject:To:From;
 bh=dUgyqcWxkpNcZOj8qAC7CX3Rq9BFo+LoaHH79S4XNqQ=; 
 b=FEErpUYb5tuUiytJOD+H/QxoqwzNQe3s9uj3mKk6TLrsPaD+OFmJBNTp3z1JQZVsGzovdOqIuQJGoNKEE8+wdVH2AA2CzsLMGICguuViQPIECCKeoMeMQwDNREq4MOII3oF04+m6c3O5N49EflaZlq+hfNqh7JnObq2HZG7l/lE=;
From: gnubugs@HIDDEN (Andrew M. Bishop)
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
Date: Tue, 14 Mar 2017 19:50:40 +0000
MIME-Version: 1.0
Content-Type: text/plain
Message-Id: <1cnsT0-0000ii-Ph@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Tue, 14 Mar 2017 16:26:13 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

I have also found this problem since I use 7x13 as my default font.
The widening of the bold version of this font makes Emacs version 25
unusable by me.

Using Alex Khesin's test case:

$ emacs -Q --eval '(progn (set-face-font '\''default "7x13") (print (face-font "default")) (print (face-font "bold")))'

I find that these fonts all work correctly (the width is the same for
normal and bold versions):  6x9, 6x10, 6x12, 6x13, 7x14, 8x13, 8x16.

It is only the 7x13 font that does not scale correctly since it gives
different widths (80 compared to 70) for the bold compared to normal
font:

  -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1
  -misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1


Using 'git bisect' I traced down the change that caused it and
demonstrated that it can be fixed by this patch.

-------------------- src/xfaces.c patch --------------------
diff --git a/src/xfaces.c b/src/xfaces.c
index 5077cb2d94..c898b7886f 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -5485,7 +5485,7 @@ realize_x_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE])
 	}
       if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
 	attrs[LFACE_FONT_INDEX]
-	  = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
+	  = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
       if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
 	{
 	  face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
-------------------- src/xfaces.c patch --------------------

This reverts a patch that was made as part of bug #17973.  The change
in src/font.c that was also made in that bug report seems to not be
relevant.

This is clearly a regression from Emacs 24 but since this change was
made to fix another bug it might be quite difficult to find a change
that works for both.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 15 Mar 2017 15:41:01 +0000
Resent-Message-ID: <handler.22780.B22780.148959242027168 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22780
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: gnubugs@HIDDEN (Andrew M. Bishop), Kenichi Handa <handa@HIDDEN>
Cc: 22780 <at> debbugs.gnu.org, alex@HIDDEN
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 22780-submit <at> debbugs.gnu.org id=B22780.148959242027168
          (code B ref 22780); Wed, 15 Mar 2017 15:41:01 +0000
Received: (at 22780) by debbugs.gnu.org; 15 Mar 2017 15:40:20 +0000
Received: from localhost ([127.0.0.1]:57354 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1coB2B-000748-R2
	for submit <at> debbugs.gnu.org; Wed, 15 Mar 2017 11:40:20 -0400
Received: from eggs.gnu.org ([208.118.235.92]:44519)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1coB29-00073w-PN
 for 22780 <at> debbugs.gnu.org; Wed, 15 Mar 2017 11:40:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1coB23-0003Ag-MK
 for 22780 <at> debbugs.gnu.org; Wed, 15 Mar 2017 11:40:12 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57406)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1coB1x-00034s-TK; Wed, 15 Mar 2017 11:40:05 -0400
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1242
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1coB1w-0008R9-AQ; Wed, 15 Mar 2017 11:40:05 -0400
Date: Wed, 15 Mar 2017 17:39:32 +0200
Message-Id: <83wpbqa6rv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <1cnsT0-0000ii-Ph@HIDDEN> (gnubugs@HIDDEN)
References: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
 <1cnsT0-0000ii-Ph@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: gnubugs@HIDDEN (Andrew M. Bishop)
> Date: Tue, 14 Mar 2017 19:50:40 +0000
> Cc: alex@HIDDEN
> 
> I have also found this problem since I use 7x13 as my default font.
> The widening of the bold version of this font makes Emacs version 25
> unusable by me.
> 
> Using Alex Khesin's test case:
> 
> $ emacs -Q --eval '(progn (set-face-font '\''default "7x13") (print (face-font "default")) (print (face-font "bold")))'
> 
> I find that these fonts all work correctly (the width is the same for
> normal and bold versions):  6x9, 6x10, 6x12, 6x13, 7x14, 8x13, 8x16.
> 
> It is only the 7x13 font that does not scale correctly since it gives
> different widths (80 compared to 70) for the bold compared to normal
> font:
> 
>   -misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1
>   -misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1
> 
> 
> Using 'git bisect' I traced down the change that caused it and
> demonstrated that it can be fixed by this patch.
> 
> -------------------- src/xfaces.c patch --------------------
> diff --git a/src/xfaces.c b/src/xfaces.c
> index 5077cb2d94..c898b7886f 100644
> --- a/src/xfaces.c
> +++ b/src/xfaces.c
> @@ -5485,7 +5485,7 @@ realize_x_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE])
>  	}
>        if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
>  	attrs[LFACE_FONT_INDEX]
> -	  = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
> +	  = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
>        if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
>  	{
>  	  face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
> -------------------- src/xfaces.c patch --------------------
> 
> This reverts a patch that was made as part of bug #17973.  The change
> in src/font.c that was also made in that bug report seems to not be
> relevant.
> 
> This is clearly a regression from Emacs 24 but since this change was
> made to fix another bug it might be quite difficult to find a change
> that works for both.

I'm CC'ing Handa-san who was involved in solving that bug.  Reverting
the solution for that bug is clearly not TRT, but I hope Handa-san
will have comments about your particular problem.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#22780: 25.1.50; wrong average width picked for bold face for 7x13 X11 font
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 17 Nov 2019 06:56:01 +0000
Resent-Message-ID: <handler.22780.B22780.15739737181326 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 22780
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Kenichi Handa <handa@HIDDEN>, 22780 <at> debbugs.gnu.org, alex@HIDDEN, "Andrew M. Bishop" <gnubugs@HIDDEN>
Received: via spool by 22780-submit <at> debbugs.gnu.org id=B22780.15739737181326
          (code B ref 22780); Sun, 17 Nov 2019 06:56:01 +0000
Received: (at 22780) by debbugs.gnu.org; 17 Nov 2019 06:55:18 +0000
Received: from localhost ([127.0.0.1]:40061 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iWESr-0000LK-Lc
	for submit <at> debbugs.gnu.org; Sun, 17 Nov 2019 01:55:17 -0500
Received: from quimby.gnus.org ([95.216.78.240]:43278)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1iWESq-0000L2-HZ
 for 22780 <at> debbugs.gnu.org; Sun, 17 Nov 2019 01:55:17 -0500
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1iWESf-0004Ds-93; Sun, 17 Nov 2019 07:55:08 +0100
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAPt6kTOJ4VDkoAjm96hSQ_oSQXvXjR_2RnFcpJsBRg70vijuxQ@HIDDEN>
 <1cnsT0-0000ii-Ph@HIDDEN> <83wpbqa6rv.fsf@HIDDEN>
Date: Sun, 17 Nov 2019 07:55:04 +0100
In-Reply-To: <83wpbqa6rv.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 15 Mar
 2017 17:39:32 +0200")
Message-ID: <87r227dmbb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  Eli Zaretskii <eliz@HIDDEN> writes: >> Using 'git bisect'
 I traced down the change that caused it and >> demonstrated that it can be
 fixed by this patch. >> >> src/xfaces.c patch >> diff --git a [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 URIBL_BLOCKED          ADMINISTRATOR NOTICE: The query to URIBL was
 blocked.  See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
 for more information. [URIs: gnu.org]
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Using 'git bisect' I traced down the change that caused it and
>> demonstrated that it can be fixed by this patch.
>> 
>> -------------------- src/xfaces.c patch --------------------
>> diff --git a/src/xfaces.c b/src/xfaces.c
>> index 5077cb2d94..c898b7886f 100644
>> --- a/src/xfaces.c
>> +++ b/src/xfaces.c
>> @@ -5485,7 +5485,7 @@ realize_x_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE])
>>  	}
>>        if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
>>  	attrs[LFACE_FONT_INDEX]
>> -	  = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
>> +	  = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
>>        if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
>>  	{
>>  	  face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
>> -------------------- src/xfaces.c patch --------------------
>> 
>> This reverts a patch that was made as part of bug #17973.  The change
>> in src/font.c that was also made in that bug report seems to not be
>> relevant.
>> 
>> This is clearly a regression from Emacs 24 but since this change was
>> made to fix another bug it might be quite difficult to find a change
>> that works for both.
>
> I'm CC'ing Handa-san who was involved in solving that bug.  Reverting
> the solution for that bug is clearly not TRT, but I hope Handa-san
> will have comments about your particular problem.

I tried the recipe with Emacs 27, and the problem still seems to be
present there:

"-misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1"
"-misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1"

The code in realize_gui_face hasn't changed since the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 Nov 2019 08:19:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 17 03:19:16 2019
Received: from localhost ([127.0.0.1]:40207 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iWFm7-0005iY-C5
	for submit <at> debbugs.gnu.org; Sun, 17 Nov 2019 03:19:15 -0500
Received: from quimby.gnus.org ([95.216.78.240]:44492)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1iWFm5-0005iM-UM
 for control <at> debbugs.gnu.org; Sun, 17 Nov 2019 03:19:14 -0500
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1iWFly-0004qf-Ej
 for control <at> debbugs.gnu.org; Sun, 17 Nov 2019 09:19:08 +0100
Date: Sun, 17 Nov 2019 09:19:05 +0100
Message-Id: <877e3yc3uu.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #30203
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  forcemerge 30203 22780 quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

forcemerge 30203 22780
quit

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.