GNU bug report logs - #22843
perl-mode coloring sees too deeply into <<EOF

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Sun, 28 Feb 2016 20:57:02 UTC

Severity: minor

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22843 in the body.
You can then email your comments to 22843 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#22843; Package emacs. (Sun, 28 Feb 2016 20:57:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 28 Feb 2016 20:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: perl-mode coloring sees too deeply into <<EOF
Date: Mon, 29 Feb 2016 04:55:36 +0800

[Message part 1 (text/plain, inline)]
After "print <<EOF;" the colors are all wrong!

[namecard (text/plain, attachment)]
[Message part 3 (text/plain, inline)]
The previous print <<\EOF; doesn't have that problem.

cperl-mode gets both correct.

emacs-version "24.5.1"
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#22843; Package emacs. (Sat, 06 Jul 2019 03:41:02 GMT) Full text and rfc822 format available.

Message #8 received at 22843 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 22843 <at> debbugs.gnu.org
Subject: Re: bug#22843: perl-mode coloring sees too deeply into <<EOF
Date: Sat, 6 Jul 2019 05:40:40 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> After "print <<EOF;" the colors are all wrong!
>
> #!/usr/bin/perl
> # Make a sheet of my substandard size namecards
> # which hopefully fit all on one printer page.
> # Copyright       : http://www.fsf.org/copyleft/gpl.html
> # Created On      : July 2006
> # Last Modified On: Sun Feb 14 00:45:33 2016
> # Update Count    : 214
> use strict;
> use warnings FATAL => 'all';
> ##use HTML::Table;
> use constant ONECARD => <<\EOF;
> 積丹尼 Dan Jacobson<br>
> http://jidanni.org/<br>
> 台中市東勢區慶福街1-6號<br>
> 0963-114343 04-25854780
> EOF
> print <<EOF;
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
> "http://www.w3.org/TR/html4/strict.dtd">
> <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> <meta http-equiv="Content-Language" content="zh-tw">
> <!-- MADE VIA ~/namecard; WILL GET OVERWRITTEN-->
> <style type="text/css">
> TD { text-align: center }
> </style>
> <title>Namecard</title></head><body>
> <table border="1" cellspacing="0" cellpadding="18" summary="Name cards">
> EOF
> ## cellpadding 17 will cause an extra page
> for ( 1 .. 8 ) {
> ## 育才列印 was able to print 1..9 !
>     print '<tr>';
>     for ( 1 .. 3 ) {
>         print '<th>', ONECARD, '</th>';
>     }
>     print "</tr>\n";
> }
> print "</table>\n</body></html>\n";
>
> The previous print <<\EOF; doesn't have that problem.
>
> cperl-mode gets both correct.
>
> emacs-version "24.5.1"

I tried reproducing this on the latest version of Emacs, 26.2, but was
unable to.  The colors after "print <<EOF;" seemed fine to me.

Could you please try reproducing this with the latest version of Emacs?

Please also provide more details on what colors are wrong -- on what
line, which color you see and which you would have expected instead.

Thanks,
Stefan Kangas
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#22843; Package emacs. (Sat, 06 Jul 2019 14:04:02 GMT) Full text and rfc822 format available.

Message #11 received at 22843 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 22843 <at> debbugs.gnu.org
Subject: Re: bug#22843: perl-mode coloring sees too deeply into <<EOF
Date: Sat, 06 Jul 2019 22:03:06 +0800

OK it looks better in 26.1. The main problem remaining is the Here Doc
uses font-lock-comment-face, making it look exactly like (nearby too)
comments! It should get its own face.
Reply sent to Stefan Kangas <stefan <at> marxist.se>:
You have taken responsibility. (Sun, 07 Jul 2019 11:34:01 GMT) Full text and rfc822 format available.
Notification sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
bug acknowledged by developer. (Sun, 07 Jul 2019 11:34:01 GMT) Full text and rfc822 format available.

Message #16 received at 22843-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 22843-done <at> debbugs.gnu.org
Subject: Re: bug#22843: perl-mode coloring sees too deeply into <<EOF
Date: Sun, 7 Jul 2019 13:33:12 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:
> OK it looks better in 26.1. The main problem remaining is the Here Doc
> uses font-lock-comment-face, making it look exactly like (nearby too)
> comments! It should get its own face.

OK, thanks.  The other issue you raise is Bug#23461.

Since we can't reproduce the original issue on a recent Emacs,
I'm closing this bug.

Thanks,
Stefan Kangas
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 05 Aug 2019 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 257 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.