GNU bug report logs - #22892
25.1.50; dired-get-marked-files distinguish marks

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22892 in the body.
You can then email your comments to 22892 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; dired-get-marked-files distinguish marks
Date: Thu, 3 Mar 2016 18:36:56 +0900 (JST)

[Message part 1 (text/plain, inline)]

* lisp/dired.el(dired-get-marked-files):

Added optional argument `marker-char'. If non-nil,
the files retrieved are those marked with MARKER-CHAR.
Otherwise the returned files are those marked with
`dired-marker-char'.

Callers are not affected: the arg is optional and
added at the end of the parameter list.



In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.29)
 of 2016-03-03 built on calancha-pc
Repository revision: 887f6126c5ce9084f93083765ac026ca6b28175c

[dired.patch (text/plain, attachment)]

Message #10 received at 22892 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22892 <at> debbugs.gnu.org
Subject: Re: bug#22892: 25.1.50; dired-get-marked-files distinguish marks
Date: Fri, 04 Mar 2016 12:34:28 +0000

Tino Calancha <f92capac <at> gmail.com> writes:

> * lisp/dired.el(dired-get-marked-files):
>
> Added optional argument `marker-char'. If non-nil,
> the files retrieved are those marked with MARKER-CHAR.
> Otherwise the returned files are those marked with
> `dired-marker-char'.
>
> Callers are not affected: the arg is optional and
> added at the end of the parameter list.

Is this a subset of the subsequent bug report in 22893?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 22892 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, 22892 <at> debbugs.gnu.org
Subject: Re: bug#22892: 25.1.50; dired-get-marked-files distinguish marks
Date: Sat, 5 Mar 2016 22:13:05 +0900 (JST)

> Is this a subset of the subsequent bug report in 22893?
Exactly. Its a conservative proposal which just modified one function.
I though maybe the maintainers would hesitate to add  #22893 which
introduce more changes.
We can close this thread.

Message #18 received at 22892 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22892 <at> debbugs.gnu.org, 22893 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Tue, 25 Jun 2019 16:07:38 +0200

Tino Calancha <f92capac <at> gmail.com> writes:

>> Since you are changing the function signatures anyway,
>> you could make them consistent between `dired-map-over-marks'
>> and `dired-get-marked-files' by adding an explicit arg `marker-char',
>> i.e. both `dired-get-marked-files' and `dired-map-over-marks'
>> could end with "distinguish-one-marked marker-char all-marks",
>> thus explicitly passing `marker-char' arg down the call chain.
>> Then you'll need `(or marker-char dired-marker-char)' in
>> `dired-marker-regexp' for backward-compatibility.  And then also
>> no need to let-bind `dired-marker-char' in `dired-get-marked-files'
>> (it's better to avoid dynamically binding global variables where possible).
>
> It sounds good. Thank you. Implemented in the new patch.

I think the consensus was to apply the patch, but it was never done at
the time, and now it won't apply since this code has changed
substantially in the meantime.

Would it be possible for you to rework the patch and resubmit?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 22892 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22892 <at> debbugs.gnu.org, 22893 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Wed, 12 Aug 2020 13:58:35 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I think the consensus was to apply the patch, but it was never done at
> the time, and now it won't apply since this code has changed
> substantially in the meantime.
>
> Would it be possible for you to rework the patch and resubmit?

I tried fixing up this myself, but the interface for all the marker
functions touched by this patch has changed too much for the patch to
even make sense, as far as I can see.

So I'm closing this bug report; a new one can be opened if this is
something somebody still wants to have in Dired.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.