GNU bug report logs - #22893
25.1.50; dired-get-marked-files get all marked

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22893 in the body.
You can then email your comments to 22893 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 3 Mar 2016 18:38:36 +0900 (JST)

[Message part 1 (text/plain, inline)]

* lisp/dired.el(dired-get-marked-files): Added two optional args,
`marker-char' and `all-maks'.
(dired-map-over-marks): Added optional arg `all-marks'.
(dired-marker-regexp): Added optional arg `all-marks'.

1) `marker-char'. If non-nil,
the files retrieved are those marked with MARKER-CHAR.
Otherwise the returned files are those marked with
`dired-marker-char'.

2) all-marks, if non-nil, all marked files are returned
regardless of their actual mark (`dired-marker-char' or
a different one).

Callers are not affected: the args are optional and
added at the end of the parameter list.


In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.29)
 of 2016-03-03 built on calancha-pc
Repository revision: 887f6126c5ce9084f93083765ac026ca6b28175c

[dired_2.patch (text/plain, attachment)]

Message #10 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22893 <at> debbugs.gnu.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Fri, 04 Mar 2016 12:32:57 +0000

Tino Calancha <f92capac <at> gmail.com> writes:

> * lisp/dired.el(dired-get-marked-files): Added two optional args,
> `marker-char' and `all-maks'.
> (dired-map-over-marks): Added optional arg `all-marks'.
> (dired-marker-regexp): Added optional arg `all-marks'.
>
> 1) `marker-char'. If non-nil,
> the files retrieved are those marked with MARKER-CHAR.
> Otherwise the returned files are those marked with
> `dired-marker-char'.
>
> 2) all-marks, if non-nil, all marked files are returned
> regardless of their actual mark (`dired-marker-char' or
> a different one).

Looks good, I think.  Can you include a NEWS entry for this and resubmit
the patch?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, 22893 <at> debbugs.gnu.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Sat, 5 Mar 2016 22:14:51 +0900 (JST)

> Looks good, I think.  Can you include a NEWS entry for this and resubmit
> the patch?
Sure. I am sending it in the begining of incomming week.

Message #16 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 22893 <at> debbugs.gnu.org
Cc: larsi <at> gnus.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Tue, 8 Mar 2016 14:18:58 +0900 (JST)

[Message part 1 (text/plain, inline)]

> Looks good, I think.  Can you include a NEWS entry for this and resubmit
> the patch?
Attached the patch including the NEWS entry.

[0001-Dired-operate-on-all-kind-of-mark-characters.patch (text/plain, attachment)]

[0002-Add-NEWS-entry-for-last-commit.patch (text/plain, attachment)]

Message #19 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: larsi <at> gnus.org, 22893 <at> debbugs.gnu.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Tue, 08 Mar 2016 18:01:37 +0200

> Date: Tue, 8 Mar 2016 14:18:58 +0900 (JST)
> From: Tino Calancha <f92capac <at> gmail.com>
> Cc: larsi <at> gnus.org
> 
> > Looks good, I think.  Can you include a NEWS entry for this and resubmit
> > the patch?
> Attached the patch including the NEWS entry.

Thanks.  Can you reformat this in the style we use in NEWS, which is
more friendly to Outline mode used to read it?  Please take a look at
the existing entries there, I think they provide enough examples.

Message #22 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, larsi <at> gnus.org, 22893 <at> debbugs.gnu.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 00:27:35 +0900 (JST)

[Message part 1 (text/plain, inline)]

> Thanks.  Can you reformat this in the style we use in NEWS, which is
> more friendly to Outline mode used to read it?  Please take a look at
> the existing entries there, I think they provide enough examples.
Sorry for the inconvenients. I edited the second commit with the NEWS.

[0002-Added-NEWS-entry-for-last-commit.patch (text/plain, attachment)]

Message #25 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 22893 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 01:57:17 +0200

merge 22893 22892
thanks

> +*** New optional arg ALL-MARKS for `dired-map-over-marks'
> +allow to operate over all marked files, not just those
> +marked with `dired-marker-char'.
> +
> +*** New optional args MARKER-CHAR and ALL-MARKS for
> +`dired-get-marked-files' to retrieve marked files with a
> +particular mark character or with any.

Since you are changing the function signatures anyway,
you could make them consistent between `dired-map-over-marks'
and `dired-get-marked-files' by adding an explicit arg `marker-char',
i.e. both `dired-get-marked-files' and `dired-map-over-marks'
could end with "distinguish-one-marked marker-char all-marks",
thus explicitly passing `marker-char' arg down the call chain.
Then you'll need `(or marker-char dired-marker-char)' in
`dired-marker-regexp' for backward-compatibility.  And then also
no need to let-bind `dired-marker-char' in `dired-get-marked-files'
(it's better to avoid dynamically binding global variables where possible).

Message #30 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Tino Calancha <f92capac <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 22893 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 13:19:10 +0900 (JST)

[Message part 1 (text/plain, inline)]

> Since you are changing the function signatures anyway,
> you could make them consistent between `dired-map-over-marks'
> and `dired-get-marked-files' by adding an explicit arg `marker-char',
> i.e. both `dired-get-marked-files' and `dired-map-over-marks'
> could end with "distinguish-one-marked marker-char all-marks",
> thus explicitly passing `marker-char' arg down the call chain.
> Then you'll need `(or marker-char dired-marker-char)' in
> `dired-marker-regexp' for backward-compatibility.  And then also
> no need to let-bind `dired-marker-char' in `dired-get-marked-files'
> (it's better to avoid dynamically binding global variables where possible).

It sounds good. Thank you. Implemented in the new patch.

[0001-Avoid-dynamic-global-var-binding.patch (text/plain, attachment)]

Message #33 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Tino Calancha <f92capac <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 22893 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 13:43:43 +0900 (JST)

What about `dired-map-over-marks-check' in dired-aux.el?
Should we make resemble `dired-map-over-marks' in its
optional arguments?

Message #36 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 22893 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Fri, 11 Mar 2016 02:48:23 +0200

> What about `dired-map-over-marks-check' in dired-aux.el?
> Should we make resemble `dired-map-over-marks' in its
> optional arguments?

Does it make sense to add ALL-MARKS to commands that use
`dired-map-over-marks-check', e.g. to compress or byte-compile
files flagged for deletion?

This also raises the question how do you want to use ALL-MARKS
in bug#22829 to display the number of marked files?  Shouldn't we
display the numbers separately for files flagged for deletion
(helps to see how much space will free up after deletion),
and marked with the default mark (to see whether the total sizes
of marked files will fit to copy to another file partition)?
Or there is not enough screen space in the echo area to display
statistics separately for every used marker-char?

Message #39 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 22893 <at> debbugs.gnu.org
Subject: dired-marker-regexp use dired-re-mark
Date: Tue, 22 Mar 2016 18:31:40 +0900 (JST)

[Message part 1 (text/plain, inline)]

I just realized dired define the variable
'dired-re-mark' to match any mark.
Using it in `dired-marker-regexp'.

[0003-dired-marker-regexp-use-dired-re-mark.patch (text/plain, attachment)]

Message #42 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22892 <at> debbugs.gnu.org, 22893 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Tue, 25 Jun 2019 16:07:38 +0200

Tino Calancha <f92capac <at> gmail.com> writes:

>> Since you are changing the function signatures anyway,
>> you could make them consistent between `dired-map-over-marks'
>> and `dired-get-marked-files' by adding an explicit arg `marker-char',
>> i.e. both `dired-get-marked-files' and `dired-map-over-marks'
>> could end with "distinguish-one-marked marker-char all-marks",
>> thus explicitly passing `marker-char' arg down the call chain.
>> Then you'll need `(or marker-char dired-marker-char)' in
>> `dired-marker-regexp' for backward-compatibility.  And then also
>> no need to let-bind `dired-marker-char' in `dired-get-marked-files'
>> (it's better to avoid dynamically binding global variables where possible).
>
> It sounds good. Thank you. Implemented in the new patch.

I think the consensus was to apply the patch, but it was never done at
the time, and now it won't apply since this code has changed
substantially in the meantime.

Would it be possible for you to rework the patch and resubmit?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #45 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22892 <at> debbugs.gnu.org, 22893 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Wed, 12 Aug 2020 13:58:35 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I think the consensus was to apply the patch, but it was never done at
> the time, and now it won't apply since this code has changed
> substantially in the meantime.
>
> Would it be possible for you to rework the patch and resubmit?

I tried fixing up this myself, but the interface for all the marker
functions touched by this patch has changed too much for the patch to
even make sense, as far as I can see.

So I'm closing this bug report; a new one can be opened if this is
something somebody still wants to have in Dired.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.