Received: (at 22895) by debbugs.gnu.org; 4 Mar 2016 16:32:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 04 11:32:22 2016 Received: from localhost ([127.0.0.1]:33953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1abseM-0003Xe-72 for submit <at> debbugs.gnu.org; Fri, 04 Mar 2016 11:32:22 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36442) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <mhofma@HIDDEN>) id 1abkp1-00035V-DY for 22895 <at> debbugs.gnu.org; Fri, 04 Mar 2016 03:10:51 -0500 Received: by mail-wm0-f49.google.com with SMTP id n186so23158606wmn.1 for <22895 <at> debbugs.gnu.org>; Fri, 04 Mar 2016 00:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=6o1XBLDXC64bhgz5BoUlwGwTcLrJxfAfj+bpACIbKNc=; b=UePe8QpcC80WSiyCgVTAmAJWU14280HGr2i/J//Phw1zV5zfage8wbT0LP9EjxQDST 5M1z2+AlFUfsYlxOggG6SpYUmIP3eeNpxg2EPZnRsdXz+WX5h6+fHdaOx7qO9ZlUMar4 278QeFLqyNpz3u+H7J5HChtCyVG0LkJPOlQ0MaFz7H9rAbh/jmp8X/XiuzGJT3ruqRn9 O8VZYSwsH29+A3jS4MbPAHBuRjRr8NHr2lzCMPdqjSHLCLEKeVUCrGDvM0q6pFkztqDQ VUeV2WMX5BHC9iKJQQ4Xu2DGMYXIq0LJ43YWX/okGRlAzu4IAMUyDRxad4ZvY5tlfysi 3PyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=6o1XBLDXC64bhgz5BoUlwGwTcLrJxfAfj+bpACIbKNc=; b=lGyrEaWjt9tS3IG1YC21/kOFljLYSPhcwsGk81WU8jniUVcO9i4PwNPOzSz2R1spKy +DPSpzjW1sk8msBUphXmu4zcNtqj8LYB6Jn8FqlsUlBnBmRTcpRMwRL4WhPuKF4Pf5cP jxKTxvGs216fa2wOgYhTFQ1NE5qVrejIMRhoHcI3cRvIRJLXqJIdOY2cW5rP+KP5tYWw TDwGpyzgjRyDJOhPxNpo4gsMQr4ZOBs0KL3AjHBD+e8eM+jHDEQt4ZVNLCoKNm+zwidk zj3kgN8ffuK/YQd/68fWoqkrffpENpW1dwRQMjHR0SrVDCKZXKS7UjF4FB6mmUfsH4TB M8qw== X-Gm-Message-State: AD7BkJKBXaxHFnc5rcw4Cd3MC2C3EcmjOQSwFokRk4Z1r8XtT8rqzWLw++Jz4k/1KuAdYA== X-Received: by 10.28.19.204 with SMTP id 195mr3859316wmt.1.1457079045789; Fri, 04 Mar 2016 00:10:45 -0800 (PST) Received: from [134.109.185.33] (amplitude.informatik.tu-chemnitz.de. [134.109.185.33]) by smtp.googlemail.com with ESMTPSA id w136sm2119627wmw.0.2016.03.04.00.10.45 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Mar 2016 00:10:45 -0800 (PST) Subject: Re: bug#22895: broken handling of spaces after -{L,R,l} To: Gilles Gouaillardet <gilles.gouaillardet@HIDDEN> References: <56D7F887.8090703@HIDDEN> <CAAkFZ5uym-Ww_FhMWvQPoF+JoeUrOG7LZ03t6bhdXDjD-UEHDA@HIDDEN> From: Michael <mhofma@HIDDEN> Message-ID: <56D94304.9090202@HIDDEN> Date: Fri, 4 Mar 2016 09:10:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <CAAkFZ5uym-Ww_FhMWvQPoF+JoeUrOG7LZ03t6bhdXDjD-UEHDA@HIDDEN> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22895 X-Mailman-Approved-At: Fri, 04 Mar 2016 11:32:21 -0500 Cc: 22895 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Am 04.03.2016 um 07:14 schrieb Gilles Gouaillardet: > That sounds like a duplicate of > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21137 Yes, but only half. Your patch fixes only the missing "x"s in the tests, but not the missing test for "-l". Best regards, Michael
bug-libtool@HIDDEN
:bug#22895
; Package libtool
.
Full text available.Received: (at 22895) by debbugs.gnu.org; 4 Mar 2016 06:14:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 04 01:14:47 2016 Received: from localhost ([127.0.0.1]:60741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1abj0h-0000Oz-Hv for submit <at> debbugs.gnu.org; Fri, 04 Mar 2016 01:14:47 -0500 Received: from mail-io0-f175.google.com ([209.85.223.175]:36549) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <gilles.gouaillardet@HIDDEN>) id 1abj0g-0000Om-3K for 22895 <at> debbugs.gnu.org; Fri, 04 Mar 2016 01:14:46 -0500 Received: by mail-io0-f175.google.com with SMTP id l127so52694054iof.3 for <22895 <at> debbugs.gnu.org>; Thu, 03 Mar 2016 22:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=31jnsmf8b4GfNwM6RFQb2Nagj7oqe16SUTaBFYiioSc=; b=tPWp9/KXL9PYEH+/Tu9TijGw8ZdEFMEINikhFmgcJPcJMwPJ9leqjGGhe54BpG0TiP gKEYNwlrMaOt0Uo5+xH11bSqaJLIOvtdGFEgfmDOT0WYpi8MobZpXMhmglGWN67rWtn3 ETX1JxU9T/XLA1IRe0d9cTr8t7VAL6N+YFy/z0Edjni/0KqKtX+X9SF6+9RQn64MRzo+ zZFXzqmstg/ZVV/xxhUxFof68WUsKDTQtLnnRqIv56sKofJzWvU3Ir31BzGg7ooSSSGw lTLsi8+iDkRiWimNuMfhxjHa351EQwXn8Ddgr4q55hrQIQT//DZCfhkMjLyCH+P/ZFxK sV2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=31jnsmf8b4GfNwM6RFQb2Nagj7oqe16SUTaBFYiioSc=; b=UAYdRDbJdIv8Vr1RCyI2XAyQG1EQjjxvH/LHYa9cS/R6FP4sJdDldT5ESh9GKcMdXy EOXnhum+Wnh6tfEcm8DdQP7zMfOnATJEfXt2OU6d7KLTQux3RoL7g6ATNctcs7RciD98 riSiE9rKrIeCv9KBxSk0WvW74U9iaGThDkCGqOFZVV3A1aI0zSohbFREYBaOSq9e+3n8 1rjE+DTbowHYEVmF2HD8LDZDx+yS9iGbikZopKiyBaACr9XI/sgg9qisifmFlDXga7Dq 4REf+JD7iNT32J9VQsY3MEcxqiFHA8ZU5W621ZSku3p+VWft9aAnUG7OTGFoXBKIOKAy 8jvg== X-Gm-Message-State: AD7BkJI3nFmUk6UL01weNyRHcWbDmgwPagEy+Jk0FIWlSs/FCtcbo/uQnmcJU+3mZDsq5vtHfiFNnWTg0I6zww== MIME-Version: 1.0 X-Received: by 10.107.33.7 with SMTP id h7mr7001349ioh.30.1457072080549; Thu, 03 Mar 2016 22:14:40 -0800 (PST) Received: by 10.79.67.129 with HTTP; Thu, 3 Mar 2016 22:14:40 -0800 (PST) In-Reply-To: <56D7F887.8090703@HIDDEN> References: <56D7F887.8090703@HIDDEN> Date: Fri, 4 Mar 2016 15:14:40 +0900 Message-ID: <CAAkFZ5uym-Ww_FhMWvQPoF+JoeUrOG7LZ03t6bhdXDjD-UEHDA@HIDDEN> Subject: Re: bug#22895: broken handling of spaces after -{L,R,l} From: Gilles Gouaillardet <gilles.gouaillardet@HIDDEN> To: Michael <mhofma@HIDDEN> Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22895 Cc: 22895 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) That sounds like a duplicate of https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21137 Cheers, Gilles On Thu, Mar 3, 2016 at 5:40 PM, Michael <mhofma@HIDDEN> wrote: > Hi, > > in m4/libtool.m4, the handling of spaces after -{L,R,l} for parsing > linker commands looks as follows: > > case $prev$p in > -L* | -R* | -l*) > # Some compilers place space between "-{L,R}" and the path. > # Remove the space. > if test x-L = "$p" || > test x-R = "$p"; then > prev=$p > continue > fi > > This seems to be broken for two reasons: > 1. The case handling captures -l, but the following tests consider only > -L and -R. > 2. The tests for equality use an x on the left side, but not on the > right side. > > A working code should look as follows (patch is attached): > > case $prev$p in > -L* | -R* | -l*) > # Some compilers place space between "-{L,R,l}" and the path. > # Remove the space. > if test x-L = "x$p" || > test x-R = "x$p" || > test x-l = "x$p"; then > prev=$p > continue > fi > > I stumbled across this bug when using gfortran (5.3.1) which emits the > following (valid) line: > > Driving: gfortran -v conftest.o -l gfortran -l m -shared-libgcc > > The current (broken) libtool leads to "-l -l" in the "postdeps_FC" > variable. After the fix, the correct "-lgfortran -lm" appears. > > > Best regards, > Michael > > _______________________________________________ > Bug-libtool mailing list > Bug-libtool@HIDDEN > https://lists.gnu.org/mailman/listinfo/bug-libtool >
bug-libtool@HIDDEN
:bug#22895
; Package libtool
.
Full text available.Received: (at submit) by debbugs.gnu.org; 3 Mar 2016 10:25:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 03 05:25:45 2016 Received: from localhost ([127.0.0.1]:58612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1abQS1-00089T-0R for submit <at> debbugs.gnu.org; Thu, 03 Mar 2016 05:25:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43360) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <mhofma@HIDDEN>) id 1abOoc-0005iZ-1A for submit <at> debbugs.gnu.org; Thu, 03 Mar 2016 03:40:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <mhofma@HIDDEN>) id 1abOoS-0006qQ-W6 for submit <at> debbugs.gnu.org; Thu, 03 Mar 2016 03:40:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <mhofma@HIDDEN>) id 1abOoS-0006qM-Sc for submit <at> debbugs.gnu.org; Thu, 03 Mar 2016 03:40:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <mhofma@HIDDEN>) id 1abOoR-0003fw-NK for bug-libtool@HIDDEN; Thu, 03 Mar 2016 03:40:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <mhofma@HIDDEN>) id 1abOoM-0006pB-Ix for bug-libtool@HIDDEN; Thu, 03 Mar 2016 03:40:47 -0500 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:34798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <mhofma@HIDDEN>) id 1abOoM-0006ou-8w for bug-libtool@HIDDEN; Thu, 03 Mar 2016 03:40:42 -0500 Received: by mail-wm0-x236.google.com with SMTP id p65so23795689wmp.1 for <bug-libtool@HIDDEN>; Thu, 03 Mar 2016 00:40:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=to:from:subject:message-id:date:user-agent:mime-version; bh=R/kJ1j+FtbFfTEqtdvki+TC2gY6KveAKn+jcgShZDx0=; b=kldOfkhspmUNwDyL2Zw9cuFeDD+WqL6NDn+RCg571fZ6hG75mT01tiWiSHnoR4RFV1 12mjjX48ujzAGAGaboBlejbdf0tzTjy5staxsVDUhzzQCugWgAowH5HIisF4z4+fuMMW j8lknbhV6eB35QUyGBGmjyulUfRiex/4lgbkjXqu7O6yE9K5kRfXNnLsCBXeJQqIesFc E3EApNR6ZRfCn8mW5u3yAFpjYFePVgjVaO/LYzhXa97lN4KGGI2bfFAP/WVWP50EW37L /FcfVWihY9cJRFI+8pFKIgdNY/fjaATaDzBxHYvUWY1L2CrfLvkugSuF11Nx6gijWEH6 Jk4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version; bh=R/kJ1j+FtbFfTEqtdvki+TC2gY6KveAKn+jcgShZDx0=; b=Tc81t6Z+5u1aBxcY8I+2Cr+xTse69qYe8thBlMTLRlO7XcMhb0REyUkxICCBr2DKeS Iw0rUsHDJ6RFh2FBEBp2euea7gCOM878QpAKx22YFtYsvqaflEnsG0qkHUtJUFQKoSK0 AYRSfdC9AtlQMSY4P+zlcFGBXwa+hBxvJ03faQTQBkBeXPpZaiCNPjcjT3pXHXlOCxNk oZiNVg+ONVv4kaqiwf7+mIbcY66PbhvCfJtGslkkED5+o1UAqFQa+D83i4kqeC1iTnhY EJVCASHQpd++PFprvKX1N8dP+xB0rVbxAYV+Oahe6Bfmsm1u39OGl1OL2uB1q8sZ8vDJ e7Bw== X-Gm-Message-State: AD7BkJIl1F/6tOqqVRpWBG4bErZZieda8q5xqbSYV8v96hP/gq2CWIB5tz1uX83SWLJkYA== X-Received: by 10.28.18.85 with SMTP id 82mr2138341wms.5.1456994440915; Thu, 03 Mar 2016 00:40:40 -0800 (PST) Received: from [134.109.185.33] (amplitude.informatik.tu-chemnitz.de. [134.109.185.33]) by smtp.googlemail.com with ESMTPSA id w17sm7845000wmw.5.2016.03.03.00.40.40 for <bug-libtool@HIDDEN> (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2016 00:40:40 -0800 (PST) To: bug-libtool@HIDDEN From: Michael <mhofma@HIDDEN> Subject: broken handling of spaces after -{L,R,l} X-Enigmail-Draft-Status: N1110 Message-ID: <56D7F887.8090703@HIDDEN> Date: Thu, 3 Mar 2016 09:40:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090702020906090402040503" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 03 Mar 2016 05:25:43 -0500 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------090702020906090402040503 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, in m4/libtool.m4, the handling of spaces after -{L,R,l} for parsing linker commands looks as follows: case $prev$p in -L* | -R* | -l*) # Some compilers place space between "-{L,R}" and the path. # Remove the space. if test x-L = "$p" || test x-R = "$p"; then prev=$p continue fi This seems to be broken for two reasons: 1. The case handling captures -l, but the following tests consider only -L and -R. 2. The tests for equality use an x on the left side, but not on the right side. A working code should look as follows (patch is attached): case $prev$p in -L* | -R* | -l*) # Some compilers place space between "-{L,R,l}" and the path. # Remove the space. if test x-L = "x$p" || test x-R = "x$p" || test x-l = "x$p"; then prev=$p continue fi I stumbled across this bug when using gfortran (5.3.1) which emits the following (valid) line: Driving: gfortran -v conftest.o -l gfortran -l m -shared-libgcc The current (broken) libtool leads to "-l -l" in the "postdeps_FC" variable. After the fix, the correct "-lgfortran -lm" appears. Best regards, Michael --------------090702020906090402040503 Content-Type: text/x-patch; name="libtool_fix_space_handling.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="libtool_fix_space_handling.patch" diff --git a/m4/libtool.m4 b/m4/libtool.m4 index ee292af..8349119 100644 --- a/m4/libtool.m4 +++ b/m4/libtool.m4 @@ -7557,10 +7557,11 @@ if AC_TRY_EVAL(ac_compile); then case $prev$p in -L* | -R* | -l*) - # Some compilers place space between "-{L,R}" and the path. + # Some compilers place space between "-{L,R,l}" and the path. # Remove the space. - if test x-L = "$p" || - test x-R = "$p"; then + if test x-L = "x$p" || + test x-R = "x$p" || + test x-l = "x$p"; then prev=$p continue fi --------------090702020906090402040503--
Michael <mhofma@HIDDEN>
:bug-libtool@HIDDEN
.
Full text available.bug-libtool@HIDDEN
:bug#22895
; Package libtool
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.