GNU bug report logs - #23063
24.5; Multi-line sql statements are not saved correctly

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23063 in the body.
You can then email your comments to 23063 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; Multi-line sql statements are not saved correctly
Date: Sat, 19 Mar 2016 18:10:33 +0300

[Message part 1 (text/plain, inline)]

Currently comint.el does not respect local values of 
comint-input-ring-separator. Sql mode on the other hand sets it locally. 
This prevents multi-line sql history from working.

Sql history is stored using comint-write-input-ring. When it saves the 
history file, it uses with-current-buffer, thus ignoring previous local 
value. When read comint-read-input-ring uses with-temp-buffer with 
similar results.

This seems to have been caused by the fix for this bug 
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16814>.

-- 
Best Regards,
Nikolay Kudryavtsev

[Message part 2 (text/html, inline)]

Message #10 received at 23063 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: 23063 <at> debbugs.gnu.org, Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com>
Subject: Re: bug#23063: 24.5; Multi-line sql statements are not saved correctly
Date: Sun, 03 May 2020 03:17:59 +0200

Hi Michael,

Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com> writes:

> Currently comint.el does not respect local values of comint-input-ring-separator. Sql mode on the other hand sets it locally. This prevents multi-line sql history from working.
>
> Sql history is stored using comint-write-input-ring. When it saves the history file, it uses with-current-buffer, thus ignoring previous local value. When read comint-read-input-ring uses with-temp-buffer with similar results.
>
> This seems to have been caused by the fix for this bug.

This bug was tagged as "unreproducible moreinfo" in a message to
control <at> debbugs called "Close bugs" sent on 21 Apr 2019, but the bug
itself was never closed.

Should the bug be closed as well?

Thanks in advance.

Best regards,
Stefan Kangas

Message #15 received at 23063-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com>,
 23063-done <at> debbugs.gnu.org
Subject: Re: bug#23063: 24.5; Multi-line sql statements are not saved correctly
Date: Tue, 11 Aug 2020 20:23:09 -0700

Stefan Kangas <stefan <at> marxist.se> writes:

> Hi Michael,
>
> Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com> writes:
>
>> Currently comint.el does not respect local values of comint-input-ring-separator. Sql mode on the other hand sets it locally. This prevents multi-line sql history from working.
>>
>> Sql history is stored using comint-write-input-ring. When it saves the history file, it uses with-current-buffer, thus ignoring previous local value. When read comint-read-input-ring uses with-temp-buffer with similar results.
>>
>> This seems to have been caused by the fix for this bug.
>
> This bug was tagged as "unreproducible moreinfo" in a message to
> control <at> debbugs called "Close bugs" sent on 21 Apr 2019, but the bug
> itself was never closed.
>
> Should the bug be closed as well?

No reply here within 14 weeks.  I'm going to assume the intention here
was to close this bug, so I'm doing that now.

If this conclusion is incorrect, please reply to this email (use "Reply
to all" in your email client) and we can reopen the bug report.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.