GNU bug report logs - #23063
24.5; Multi-line sql statements are not saved correctly

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 19 Mar 2016 15:10:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 19 11:10:54 2016
Received: from localhost ([127.0.0.1]:53812 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ahIWk-0005r8-ET
	for submit <at> debbugs.gnu.org; Sat, 19 Mar 2016 11:10:54 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45703)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <nikolay.kudryavtsev@HIDDEN>) id 1ahIWi-0005qu-K1
 for submit <at> debbugs.gnu.org; Sat, 19 Mar 2016 11:10:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <nikolay.kudryavtsev@HIDDEN>) id 1ahIWc-000447-HK
 for submit <at> debbugs.gnu.org; Sat, 19 Mar 2016 11:10:47 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
 HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:52074)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <nikolay.kudryavtsev@HIDDEN>) id 1ahIWc-000443-ED
 for submit <at> debbugs.gnu.org; Sat, 19 Mar 2016 11:10:46 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36670)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <nikolay.kudryavtsev@HIDDEN>) id 1ahIWb-0003Lv-IF
 for bug-gnu-emacs@HIDDEN; Sat, 19 Mar 2016 11:10:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <nikolay.kudryavtsev@HIDDEN>) id 1ahIWY-00042k-8X
 for bug-gnu-emacs@HIDDEN; Sat, 19 Mar 2016 11:10:45 -0400
Received: from mail-lb0-x231.google.com ([2a00:1450:4010:c04::231]:34369)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <nikolay.kudryavtsev@HIDDEN>) id 1ahIWX-00042X-SN
 for bug-gnu-emacs@HIDDEN; Sat, 19 Mar 2016 11:10:42 -0400
Received: by mail-lb0-x231.google.com with SMTP id k12so104446327lbb.1
 for <bug-gnu-emacs@HIDDEN>; Sat, 19 Mar 2016 08:10:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=from:to:subject:message-id:date:user-agent:mime-version;
 bh=6nph0R9iXyxuvc9jLaN7ydcJk2wInv9I8EQda9hTzMg=;
 b=BdGG/YQViDN4oCnjsUOEvdk/YlBvGVmvFPLfQqoGEkPRPW2wnhSejKScAAQRXW3D5S
 Xzdi1k9u19L/6zI5usP69EtNjl0jWyai4vdjIhQdcPifYs8Th464m2w8hs5NieLA6lL8
 vT8jUpoHsRCqt6dbJxDcBM/lvMNG0LzDjEyIUXW4nXW5kZnmQa4T8GShu6GUL9HF6RDo
 lZvrVVHTQux/QOn6mxB1RBq2niwpiVRQQrocBsynU/c3mVBzwBOjXXP871NWS4Rp5zwX
 vaGAx0dJDt+aD6cUfo7AB5Ruu0CaXnk5NgXUsAKn/SBalMFV+/rzJlzuGf/e5rxSqUn4
 Gbjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:subject:message-id:date:user-agent
 :mime-version;
 bh=6nph0R9iXyxuvc9jLaN7ydcJk2wInv9I8EQda9hTzMg=;
 b=ccUmudW1lyDBVioYrSqr6wleQfN4m9ykpjwMRxlPejVit/ei5rmTUnkE+P/F+izNS2
 z/1kh9CFeSzUdj88zO8NTER2rhTwa6HcZqr8/vFVSB4KfVWdeBDwrPPqT3vjDIRdaqUc
 d9e5o6c8hCM7Fk7fHMd5ioo1Jz31HtCSg9VWs3iEBFpWo6AxNL2/spS5SmNcxv7HJxJR
 ror7nr+bK+He2aqJwM377/5HRpcKuo8WLn2unRPeG5+cMiNLh11Yw9u48ham08q/oTlR
 ufgqleLLFo+zglzJZyC2VGa3zhlElzfrgzU6TzPAANAeEPTDulV9xT5Irkb6Dxlw+vU4
 QZ/g==
X-Gm-Message-State: AD7BkJLN+OEiwPxAXZpMWJA4evf2fTrDMzhby0U6Haqv1oSFDnl9CjywhZOG2BjNpNt8Lw==
X-Received: by 10.112.158.69 with SMTP id ws5mr8063589lbb.23.1458400240816;
 Sat, 19 Mar 2016 08:10:40 -0700 (PDT)
Received: from [192.168.199.2]
 (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126])
 by smtp.gmail.com with ESMTPSA id j205sm3020058lfd.0.2016.03.19.08.10.39
 for <bug-gnu-emacs@HIDDEN> (version=TLSv1/SSLv3 cipher=OTHER);
 Sat, 19 Mar 2016 08:10:40 -0700 (PDT)
From: Nikolay Kudryavtsev <nikolay.kudryavtsev@HIDDEN>
X-Google-Original-From: Nikolay Kudryavtsev <Nikolay.Kudryavtsev@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 24.5; Multi-line sql statements are not saved correctly
Message-ID: <56ED6BE9.208@HIDDEN>
Date: Sat, 19 Mar 2016 18:10:33 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="------------080205020304060107010609"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

This is a multi-part message in MIME format.
--------------080205020304060107010609
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Currently comint.el does not respect local values of 
comint-input-ring-separator. Sql mode on the other hand sets it locally. 
This prevents multi-line sql history from working.

Sql history is stored using comint-write-input-ring. When it saves the 
history file, it uses with-current-buffer, thus ignoring previous local 
value. When read comint-read-input-ring uses with-temp-buffer with 
similar results.

This seems to have been caused by the fix for this bug 
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16814>.

-- 
Best Regards,
Nikolay Kudryavtsev


--------------080205020304060107010609
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=utf-8">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Currently comint.el does not respect local values of
    comint-input-ring-separator. Sql mode on the other hand sets it
    locally. This prevents multi-line sql history from working.<br>
    <br>
    Sql history is stored using comint-write-input-ring. When it saves
    the history file, it uses with-current-buffer, thus ignoring
    previous local value. When read comint-read-input-ring uses
    with-temp-buffer with similar results.<br>
    <br>
    This seems to have been caused by the fix for <a
      href="http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16814">this bug</a>.<br>
    <pre class="moz-signature" cols="72">-- 
Best Regards,
Nikolay Kudryavtsev</pre>
  </body>
</html>

--------------080205020304060107010609--