GNU bug report logs - #23408
25.0.90; bookmark.el: incorrect use of `define-error'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sat, 30 Apr 2016 19:37:01 UTC

Severity: minor

Tags: easy, fixed, patch

Found in version 25.0.90

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23408 in the body.
You can then email your comments to 23408 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23408; Package emacs. (Sat, 30 Apr 2016 19:37:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 30 Apr 2016 19:37:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.90; bookmark.el: incorrect use of `define-error'
Date: Sat, 30 Apr 2016 11:35:42 -0800 (GMT-08:00)

See bug #20625.

Summary:

bookmark.el uses `define-error' without passing a string for argument
MESSAGE.

Emacs Dev had decided that this is incorrect usage, and thus that
`define-error' does not provide the same functionality as you get by
using property `error-conditions' directly.

Either change the bookmark.el code to use `error-conditions' directly
(as before) or change it to provide a string MESSAGE arg for the
definition of `bookmark-errors'.


In GNU Emacs 25.0.90.4 (i686-w64-mingw32)
 of 2016-03-20
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --host=i686-w64-mingw32 --without-dbus
 --without-compress-install CFLAGS=-static'
Added tag(s) easy. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Sun, 11 Jun 2017 23:54:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23408; Package emacs. (Wed, 12 Jun 2019 16:48:02 GMT) Full text and rfc822 format available.

Message #10 received at 23408 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 23408 <at> debbugs.gnu.org
Subject: Re: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
Date: Wed, 12 Jun 2019 18:47:15 +0200

[Message part 1 (text/plain, inline)]
Drew Adams <drew.adams <at> oracle.com> writes:
> bookmark.el uses `define-error' without passing a string for argument
> MESSAGE.
>
> Emacs Dev had decided that this is incorrect usage, and thus that
> `define-error' does not provide the same functionality as you get by
> using property `error-conditions' directly.

The attached patch should fix this.

Thanks,
Stefan Kangas

[0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23408; Package emacs. (Wed, 12 Jun 2019 17:14:02 GMT) Full text and rfc822 format available.

Message #13 received at 23408 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Kangas <stefan <at> marxist.se>, 23408 <at> debbugs.gnu.org
Subject: RE: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
Date: Wed, 12 Jun 2019 10:12:56 -0700 (PDT)

> The attached patch should fix this.


LGTM. Thx.
Added tag(s) patch. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Wed, 12 Jun 2019 17:14:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23408; Package emacs. (Sat, 15 Jun 2019 21:46:02 GMT) Full text and rfc822 format available.

Message #18 received at 23408 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 23408 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
Date: Sat, 15 Jun 2019 17:45:44 -0400

tags 23408 fixed
close 23408 27.1
quit

Drew Adams <drew.adams <at> oracle.com> writes:

>> The attached patch should fix this.
>
>
> LGTM. Thx.

Pushed to master.

cdd8cb3a9e 2019-06-15T17:08:58-04:00 "Add MESSAGE string to bookmark-errors (bug#23408)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cdd8cb3a9e18f87da31e52236fd2c4ebfcd676bd
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 15 Jun 2019 21:46:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 23408 <at> debbugs.gnu.org and Drew Adams <drew.adams <at> oracle.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 15 Jun 2019 21:46:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 14 Jul 2019 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 287 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.