GNU bug report logs - #23569
thing-at-point, source of slowness

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23569 in the body.
You can then email your comments to 23569 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: thing-at-point, source of slowness
Date: Wed, 18 May 2016 09:59:41 +0200

[Message part 1 (text/plain, inline)]

in thingatpt.el:

;; The function bounds-of-thing-at-point finds the beginning and end
;; positions by moving first forward to the end of the "thing", and then
;; backwards to the beginning.

;;;;;;;

Also *bounds-of-thing-at-point jumps to-and-fro, doing some sanity check 
every time.

Suggest to jump ***first *at the beginning, as backward move might be slow.

Avoid to-and-fro, deliver tests instead, so first try will be reliable 
or return nil.
*

[Message part 2 (text/html, inline)]

Message #8 received at 23569 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 23569 <at> debbugs.gnu.org
Subject: Re: bug#23569: thing-at-point, source of slowness
Date: Wed, 18 May 2016 20:52:47 +0300

> From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
> Date: Wed, 18 May 2016 09:59:41 +0200
> 
> Suggest to jump first at the beginning, as backward move might be slow. 

Can you tell why?  AFAIK, moving back is no slower than moving
forward.

Message #11 received at 23569 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23569 <at> debbugs.gnu.org
Subject: Re: bug#23569: thing-at-point, source of slowness
Date: Mon, 23 May 2016 08:42:54 +0200

On 18.05.2016 19:52, Eli Zaretskii wrote:
>> From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
>> Date: Wed, 18 May 2016 09:59:41 +0200
>>
>> Suggest to jump first at the beginning, as backward move might be slow.
> Can you tell why?  AFAIK, moving back is no slower than moving
> forward.

Referring to non-greedy behaviour of re-search-backward. Which requires 
additional checks WRT to a greedy-like match.

After all, it doesn't seem that important, as implemented forms don't 
use re-search.

Remains the to-and-fro issue.

Message #14 received at 23569 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 23569 <at> debbugs.gnu.org
Subject: Re: bug#23569: thing-at-point, source of slowness
Date: Thu, 08 Jul 2021 02:49:45 +0200

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> in thingatpt.el:
>
> ;; The function bounds-of-thing-at-point finds the beginning and end
> ;; positions by moving first forward to the end of the "thing", and then
> ;; backwards to the beginning.
>
> ;;;;;;;
>
> Also bounds-of-thing-at-point jumps to-and-fro, doing some sanity check every
> time.
>
> Suggest to jump first at the beginning, as backward move might be slow. 
>
> Avoid to-and-fro, deliver tests instead, so first try will be reliable or
> return nil.

(I'm going through old bug reports that unfortunately got little response at
the time.)

I'm not sure I understand the issue, even with the response you gave to
Eli at the time.

Do you have a test case that demonstrates this slowness, and an example
of how you'd change the code?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 23569 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 23569 <at> debbugs.gnu.org
Subject: Re: bug#23569: thing-at-point, source of slowness
Date: Thu, 8 Jul 2021 07:41:54 +0200

On 08.07.21 02:49, Lars Ingebrigtsen wrote:
> Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
>
>> in thingatpt.el:
>>
>> ;; The function bounds-of-thing-at-point finds the beginning and end
>> ;; positions by moving first forward to the end of the "thing", and then
>> ;; backwards to the beginning.
>>
>> ;;;;;;;
>>
>> Also bounds-of-thing-at-point jumps to-and-fro, doing some sanity check every
>> time.
>>
>> Suggest to jump first at the beginning, as backward move might be slow.
>>
>> Avoid to-and-fro, deliver tests instead, so first try will be reliable or
>> return nil.
> (I'm going through old bug reports that unfortunately got little response at
> the time.)
>
> I'm not sure I understand the issue, even with the response you gave to
> Eli at the time.
>
> Do you have a test case that demonstrates this slowness, and an example
> of how you'd change the code?
>
Thanks for your care. Don't think it's worth digging into that after 
that long time. Suggest to close.

Message #22 received at 23569 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 23569 <at> debbugs.gnu.org
Subject: Re: bug#23569: thing-at-point, source of slowness
Date: Thu, 08 Jul 2021 14:40:01 +0200

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> Thanks for your care. Don't think it's worth digging into that after
> that long time. Suggest to close.

OK; done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.