GNU bug report logs - #23636
Please apply this patched function to package.el in Emacs 25.

Previous Next

Package: emacs;

Reported by: Robert Weiner <rswgnu <at> gmail.com>

Date: Sat, 28 May 2016 05:04:02 UTC

Severity: wishlist

Merged with 18976, 23607

Found in version 25.0.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23636 in the body.
You can then email your comments to 23636 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23636; Package emacs. (Sat, 28 May 2016 05:04:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Robert Weiner <rswgnu <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 28 May 2016 05:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Weiner <rswgnu <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: Please apply this patched function to package.el in Emacs 25.
Date: Sat, 28 May 2016 01:02:22 -0400
[Message part 1 (text/plain, inline)]
Here is the actual patch to go along with my message from 5 days ago which
included only the full replacement function.

On Mon, May 23, 2016 at 7:11 PM, Robert Weiner <rswgnu <at> gmail.com> wrote:

> Replacing this function in package.el allows for correct generation of the
> <package>-autoloads.el file for packages that have .el files in multiple
> subdirectories.  The only thing changed is the line with 'apply' in it.  It
> ignores symlinks to directories in case there are any.  It is a simple
> change.  I hope you like it.
>
> This is important for larger packages such as my forthcoming Hyperbole
> package which includes a 2nd directory of code.
>
> *** package-orig.el 2016-05-28 00:54:25.000000000 -0400
> --- package.el 2016-05-28 00:54:25.000000000 -0400
> ***************
> *** 916,928 ****
>            (backup-inhibited t)
>            (version-control 'never))
>       (package-autoload-ensure-default-file generated-autoload-file)
> !     (update-directory-autoloads pkg-dir)
>       (let ((buf (find-buffer-visiting generated-autoload-file)))
>         (when buf (kill-buffer buf)))
>       auto-name))
>
>   (defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
>    "Generate autoloads, description file, etc.. for PKG-DESC installed at
> PKG-DIR."
>     (package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
>     (let ((desc-file (expand-file-name (package--description-file pkg-dir)
>                                        pkg-dir)))
> --- 911,927 ----
>            (backup-inhibited t)
>            (version-control 'never))
>       (package-autoload-ensure-default-file generated-autoload-file)
> !     (apply #'update-directory-autoloads pkg-dir
> !     (delq nil (mapcar (lambda (f) (and (file-directory-p f)
> !        (not (file-symlink-p f))
> !        f))
> !       (directory-files pkg-dir t "[a-zA-Z].*" nil))))
>       (let ((buf (find-buffer-visiting generated-autoload-file)))
>         (when buf (kill-buffer buf)))
>       auto-name))
>
>   (defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
>    "Generate autoloads, description file, etc. for PKG-DESC installed at
> PKG-DIR."
>     (package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
>     (let ((desc-file (expand-file-name (package--description-file pkg-dir)
>                                        pkg-dir)))
> ***************
>
>
[Message part 2 (text/html, inline)]

Forcibly Merged 23607 23636. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 31 May 2016 16:51:02 GMT) Full text and rfc822 format available.

Merged 18976 23607 23636. Request was from Noam Postavsky <npostavs <at> users.sourceforge.net> to control <at> debbugs.gnu.org. (Wed, 15 Jun 2016 03:42:02 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 23607 <at> debbugs.gnu.org and Robert Weiner <rswgnu <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Tue, 15 Sep 2020 15:57:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 14 Oct 2020 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 166 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.