GNU bug report logs - #23793
25.0.95; CEDET should use xref marker stack when jumping

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23793 in the body.
You can then email your comments to 23793 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bastian Beischer <bastian.beischer <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org,cedet-devel <at> lists.sourceforge.net
Subject: 25.0.95; CEDET should use xref marker stack when jumping
Date: Sat, 18 Jun 2016 12:55:06 +0200

[Message part 1 (text/plain, inline)]

CEDET / Semantic should use xref-push-marker-stack when jumping to a
tag, this makes it easy to pop back to the original place.

Patch for Emacs 25.0.95 is attached - but maybe there are more places
that need fixing? There's also the option to put this in
semantic-go-to-tag directly.

[xref.patch (text/x-diff, inline)]

diff --git a/lisp/cedet/semantic/analyze/refs.el b/lisp/cedet/semantic/analyze/refs.el
index f876827..1087dbd 100644
--- a/lisp/cedet/semantic/analyze/refs.el
+++ b/lisp/cedet/semantic/analyze/refs.el
@@ -347,6 +347,8 @@ semantic-analyze-proto-impl-toggle
 	     (if (semantic-tag-prototype-p tag) "implementation" "prototype")))
 
     (push-mark)
+    (when (fboundp 'xref-push-marker-stack)
+      (xref-push-marker-stack))
     (semantic-go-to-tag target)
     (switch-to-buffer (current-buffer))
     (semantic-momentary-highlight-tag target))
diff --git a/lisp/cedet/semantic/complete.el b/lisp/cedet/semantic/complete.el
index de76232..825ca8d 100644
--- a/lisp/cedet/semantic/complete.el
+++ b/lisp/cedet/semantic/complete.el
@@ -2105,6 +2105,8 @@ semantic-complete-jump-local
   (let ((tag (semantic-complete-read-tag-buffer-deep "Jump to symbol: ")))
     (when (semantic-tag-p tag)
       (push-mark)
+      (when (fboundp 'xref-push-marker-stack)
+        (xref-push-marker-stack))
       (goto-char (semantic-tag-start tag))
       (semantic-momentary-highlight-tag tag)
       (message "%S: %s "
@@ -2119,6 +2121,8 @@ semantic-complete-jump
   (let* ((tag (semantic-complete-read-tag-project "Jump to symbol: ")))
     (when (semantic-tag-p tag)
       (push-mark)
+      (when (fboundp 'xref-push-marker-stack)
+        (xref-push-marker-stack))
       (semantic-go-to-tag tag)
       (switch-to-buffer (current-buffer))
       (semantic-momentary-highlight-tag tag)
@@ -2138,6 +2142,8 @@ semantic-complete-jump-local-members
 	(unless start
 	  (error "Tag %s has no location" (semantic-format-tag-prototype tag)))
 	(push-mark)
+        (when (fboundp 'xref-push-marker-stack)
+          (xref-push-marker-stack))
 	(goto-char start)
 	(semantic-momentary-highlight-tag tag)
 	(message "%S: %s "
diff --git a/lisp/cedet/semantic/ia.el b/lisp/cedet/semantic/ia.el
index 214fbb5..562d3cf 100644
--- a/lisp/cedet/semantic/ia.el
+++ b/lisp/cedet/semantic/ia.el
@@ -316,8 +316,8 @@ semantic-ia--fast-jump-helper
   ;; 1) Push the mark, so you can pop global mark back, or
   ;;    use semantic-mru-bookmark mode to do so.
   (push-mark)
-  (when (fboundp 'push-tag-mark)
-    (push-tag-mark))
+  (when (fboundp 'xref-push-marker-stack)
+    (xref-push-marker-stack))
   ;; 2) Visits the tag.
   (semantic-go-to-tag dest)
   ;; 3) go-to-tag doesn't switch the buffer in the current window,
@@ -385,8 +385,8 @@ semantic-ia-fast-jump
       ;; Push the mark, so you can pop global mark back, or
       ;; use semantic-mru-bookmark mode to do so.
       (push-mark)
-      (when (fboundp 'push-tag-mark)
-	(push-tag-mark))
+      (when (fboundp 'xref-push-marker-stack)
+	(xref-push-marker-stack))
 
       (semantic-decoration-include-visit)
       )
diff --git a/lisp/cedet/semantic/senator.el b/lisp/cedet/semantic/senator.el
index 38abc9e..39ab639 100644
--- a/lisp/cedet/semantic/senator.el
+++ b/lisp/cedet/semantic/senator.el
@@ -526,6 +526,8 @@ senator-go-to-up-reference
     (if (not result)
         (error "No up reference found")
       (push-mark)
+      (when (fboundp 'xref-push-marker-stack)
+        (xref-push-marker-stack))
       (cond
        ;; A tag
        ((semantic-tag-p result)

Message #8 received at 23793 <at> debbugs.gnu.org (full text, mbox):

From: Eric Ludlam <eric <at> siege-engine.com>
To: 23793 <at> debbugs.gnu.org
Subject: Fwd: Re: [CEDET-devel] 25.0.95; CEDET should use xref marker stack
 when jumping
Date: Sat, 1 Oct 2016 11:30:16 -0400

Hiya,

Sorry for a slow reply.  I think this patch is fine, but I don't have 
submit access for Emacs.

Eric

-------- Forwarded Message --------
Subject: Re: [CEDET-devel] 25.0.95; CEDET should use xref marker stack 
when jumping
Date: Wed, 14 Sep 2016 08:09:43 +0200
From: Bastian Beischer <bastian.beischer <at> gmail.com>
To: Eric Ludlam <eric <at> siege-engine.com>

Hey Eric,

thanks - I agree with you. Will you commit the patch also to the CEDET
repository? Ah, and could you do me a favor and send your message also
to

23793 <at> debbugs.gnu.org

so that the bug thread in the emacs bug tracker receives your reply?

Thanks, your help is appreciated.
Bastian

On Wed, Sep 14, 2016 at 1:28 AM, Eric Ludlam <eric <at> siege-engine.com> wrote:
> Hi Bastian,
>
> Thanks.  Your patch makes sense to me, though I'm less familiar with the
> latest in Emacs.
>
> I think your patch makes sense to push to emacs.  I've had trouble getting
> merges from the CEDET repository back to Emacs, so I wouldn't want to make
> anyone wait for that.
>
> Eric
>
>
> On 06/18/2016 06:55 AM, Bastian Beischer wrote:
>>
>> CEDET / Semantic should use xref-push-marker-stack when jumping to a
>> tag, this makes it easy to pop back to the original place.
>>
>> Patch for Emacs 25.0.95 is attached - but maybe there are more places
>> that need fixing? There's also the option to put this in
>> semantic-go-to-tag directly.
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols
>> are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning
>> reports. http://sdm.link/zohomanageengine
>>
>>
>>
>> _______________________________________________
>> Cedet-devel mailing list
>> Cedet-devel <at> lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/cedet-devel
>>
>



-- 
Bastian Beischer
RWTH Aachen University of Technology

@CERN
Office: Bdg 32-4-B12
Phone: +41-22-76-75750
E-mail: bastian.beischer <at> cern.ch
Address: CERN, CH-1211 Geneve 23

@RWTH Aachen
Office: 28 C 203
Phone: +49-241-80-27205
E-mail: beischer <at> physik.rwth-aachen.de
Address: I. Physikalisches Institut B, Sommerfeldstr. 14, D-52074 Aachen

Message #11 received at 23793 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Ludlam <eric <at> siege-engine.com>
Cc: 23793 <at> debbugs.gnu.org
Subject: Re: bug#23793: Fwd: Re: [CEDET-devel] 25.0.95;
 CEDET should use xref marker stack when jumping
Date: Tue, 25 Jun 2019 15:12:28 +0200

Eric Ludlam <eric <at> siege-engine.com> writes:

> Sorry for a slow reply.  I think this patch is fine, but I don't have
> submit access for Emacs.

I have now applied it to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 23793 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Bastian Beischer <bastian.beischer <at> gmail.com>
Cc: cedet-devel <at> lists.sourceforge.net, 23793 <at> debbugs.gnu.org
Subject: Re: bug#23793: 25.0.95;
 CEDET should use xref marker stack when jumping
Date: Tue, 25 Jun 2019 15:13:27 +0200

Bastian Beischer <bastian.beischer <at> gmail.com> writes:

> CEDET / Semantic should use xref-push-marker-stack when jumping to a
> tag, this makes it easy to pop back to the original place.
>
> Patch for Emacs 25.0.95 is attached - but maybe there are more places
> that need fixing? There's also the option to put this in
> semantic-go-to-tag directly.

Thanks; I've applied it to the Emacs trunk.  It was just small enough to
apply without a copyright assignment, if I counted the lines correctly,
but for further changes, we'd need some copyright assignment paperwork.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 23793 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: cedet-devel <at> lists.sourceforge.net,
 Bastian Beischer <bastian.beischer <at> gmail.com>, 23793 <at> debbugs.gnu.org
Subject: Re: bug#23793: 25.0.95;
 CEDET should use xref marker stack when jumping
Date: Tue, 25 Jun 2019 09:36:28 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Thanks; I've applied it to the Emacs trunk.  It was just small enough to
> apply without a copyright assignment, if I counted the lines correctly,
> but for further changes, we'd need some copyright assignment paperwork.

As far as I understand it, the patch is essentially
s/push-tag-mark/xref-push-marker-stack/ + copying that call to a few
other places, so it counts as one line for copyright purposes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.