GNU bug report logs - #23826
25.1.50; Wrong fontification of parameter in c++-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23826 in the body.
You can then email your comments to 23826 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Andrus <darthandrus <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; Wrong fontification of parameter in c++-mode
Date: Wed, 22 Jun 2016 09:35:45 -0600

From `emacs -Q`, open a buffer in c++-mode and insert the following:

// X is fontified with font-lock-variable-face and x is not fontified
int foo(xml::XmlElement xml, X const& x )
{
    return 0;
}

// Fontified correctly
int bar(XmlElement xml, X const& x )
{
    return 1;
}


Notice that the namespace qualification of XmlElement causes the second
parameter to be incorrectly fontified (or so it appears).

-Ivan

Message #8 received at 23826 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Ivan Andrus <darthandrus <at> gmail.com>
Cc: 23826 <at> debbugs.gnu.org
Subject: Re: bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
Date: Thu, 3 Oct 2019 06:18:11 +0200

Ivan Andrus <darthandrus <at> gmail.com> writes:

>>From `emacs -Q`, open a buffer in c++-mode and insert the following:
>
> // X is fontified with font-lock-variable-face and x is not fontified
> int foo(xml::XmlElement xml, X const& x )
> {
>     return 0;
> }
>
> // Fontified correctly
> int bar(XmlElement xml, X const& x )
> {
>     return 1;
> }
>
>
> Notice that the namespace qualification of XmlElement causes the second
> parameter to be incorrectly fontified (or so it appears).

I can't reproduce this on current master: X has font-lock-type-face and
x font-lock-variable-name-face.

Are you still seeing this on a recent version of Emacs?

If I don't hear back from you within a couple of weeks, I'll just assume
that this has been fixed and close this as unreproducible.

Best regards,
Stefan Kangas

Message #13 received at 23826 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Andrus <darthandrus <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 23826 <at> debbugs.gnu.org
Subject: Re: bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
Date: Thu, 3 Oct 2019 21:02:15 -0600

On Oct 2, 2019, at 10:18 PM, Stefan Kangas <stefan <at> marxist.se> wrote:
> 
> Ivan Andrus <darthandrus <at> gmail.com> writes:
> 
>>> From `emacs -Q`, open a buffer in c++-mode and insert the following:
>> 
>> // X is fontified with font-lock-variable-face and x is not fontified
>> int foo(xml::XmlElement xml, X const& x )
>> {
>>    return 0;
>> }
>> 
>> // Fontified correctly
>> int bar(XmlElement xml, X const& x )
>> {
>>    return 1;
>> }
>> 
>> 
>> Notice that the namespace qualification of XmlElement causes the second
>> parameter to be incorrectly fontified (or so it appears).
> 
> I can't reproduce this on current master: X has font-lock-type-face and
> x font-lock-variable-name-face.
> 
> Are you still seeing this on a recent version of Emacs?

Indeed, this is working for me now.

> If I don't hear back from you within a couple of weeks, I'll just assume
> that this has been fixed and close this as unreproducible.

Thanks for following up.

-Ivan

Message #16 received at 23826 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Andrus <darthandrus <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 23826 <at> debbugs.gnu.org
Subject: Re: bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
Date: Thu, 3 Oct 2019 21:15:15 -0600

On Oct 2, 2019, at 10:18 PM, Stefan Kangas <stefan <at> marxist.se> wrote:
> 
> Ivan Andrus <darthandrus <at> gmail.com> writes:
> 
>>> From `emacs -Q`, open a buffer in c++-mode and insert the following:
>> 
>> // X is fontified with font-lock-variable-face and x is not fontified
>> int foo(xml::XmlElement xml, X const& x )
>> {
>>   return 0;
>> }
>> 
>> // Fontified correctly
>> int bar(XmlElement xml, X const& x )
>> {
>>   return 1;
>> }
>> 
>> 
>> Notice that the namespace qualification of XmlElement causes the second
>> parameter to be incorrectly fontified (or so it appears).
> 
> I can't reproduce this on current master: X has font-lock-type-face and
> x font-lock-variable-name-face.
> 
> Are you still seeing this on a recent version of Emacs?

Indeed, this is working for me now.

> If I don't hear back from you within a couple of weeks, I'll just assume
> that this has been fixed and close this as unreproducible.

Thanks for following up.

-Ivan

Message #21 received at 23826-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Ivan Andrus <darthandrus <at> gmail.com>
Cc: 23826-done <at> debbugs.gnu.org
Subject: Re: bug#23826: 25.1.50; Wrong fontification of parameter in c++-mode
Date: Fri, 4 Oct 2019 06:54:47 +0200

Ivan Andrus <darthandrus <at> gmail.com> writes:

> > I can't reproduce this on current master: X has font-lock-type-face and
> > x font-lock-variable-name-face.
> >
> > Are you still seeing this on a recent version of Emacs?
>
> Indeed, this is working for me now.

Thanks for verifying.  Closing this now.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.