GNU bug report logs - #24046
[PATCH] vc-git: prevent execution of git stash in error cases

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24046 in the body.
You can then email your comments to 24046 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] vc-git: prevent execution of git stash in error cases
Date: Thu, 21 Jul 2016 18:46:18 +0600

[Message part 1 (text/plain, inline)]

Here is simple patch which adds two additional checks to the vc-git-stash-show
function to check that correct stash name is passed and actually repo
has stashes.

Thank you

[0001-vc-git-prevent-execution-of-git-stash-in-error-cases.patch (text/x-patch, attachment)]

Message #8 received at 24046 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Cc: 24046 <at> debbugs.gnu.org
Subject: Re: bug#24046: [PATCH] vc-git: prevent execution of git stash in
 error cases
Date: Sat, 03 Jun 2017 23:00:07 -0400

Alexander Kuleshov <kuleshovmail <at> gmail.com> writes:

> Here is simple patch which adds two additional checks to the vc-git-stash-show
> function to check that correct stash name is passed and actually repo
> has stashes.

I'm not sure this is a good idea, we just end up duplicating checks that
'git stash' is going to perform anyway...

Message #11 received at 24046 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: npostavs <at> users.sourceforge.net
Cc: 24046 <at> debbugs.gnu.org, Alexander Kuleshov <kuleshovmail <at> gmail.com>
Subject: Re: bug#24046: [PATCH] vc-git: prevent execution of git stash in
 error cases
Date: Tue, 25 Jun 2019 14:03:03 +0200

npostavs <at> users.sourceforge.net writes:

> Alexander Kuleshov <kuleshovmail <at> gmail.com> writes:
>
>> Here is simple patch which adds two additional checks to the vc-git-stash-show
>> function to check that correct stash name is passed and actually repo
>> has stashes.
>
> I'm not sure this is a good idea, we just end up duplicating checks that
> 'git stash' is going to perform anyway...

I agree, and even if we did want to add these checks, they should be
done in all the stash-related commands...

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.