GNU bug report logs - #24147
emacsclient should pass frame-parameters to tty frames

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24147 in the body.
You can then email your comments to 24147 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Shields <shields <at> msrl.com>
To: bug-gnu-emacs <at> gnu.org
Subject: emacsclient should pass frame-parameters to tty frames
Date: Wed, 3 Aug 2016 16:51:06 -0700

[Message part 1 (text/plain, inline)]

Currently, emacsclient's --frame-parameters argument is silently
ignored when creating frames on a tty.  This prevents emacsclient from
giving the new frame a name.

I've attached a patch that corrects this.

My employer, Google, has an existing contributor license agreement
that covers this change.

[0001-Pass-frame-parameters-to-server-create-tty-frame.patch (application/octet-stream, attachment)]

Message #8 received at 24147 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Shields <shields <at> msrl.com>
Cc: 24147 <at> debbugs.gnu.org
Subject: Re: bug#24147: emacsclient should pass frame-parameters to tty frames
Date: Sat, 06 Aug 2016 13:06:12 +0300

> From: Michael Shields <shields <at> msrl.com>
> Date: Wed, 3 Aug 2016 16:51:06 -0700
> 
> Currently, emacsclient's --frame-parameters argument is silently
> ignored when creating frames on a tty.  This prevents emacsclient from
> giving the new frame a name.
> 
> I've attached a patch that corrects this.

Thanks.  But I think, for compatibility with the GUI use case, the
additional parameter should be &optional, not mandatory.

Are there other arguments we currently pass to GUI frames, but not to
TTY frames, which might make sense on TTY frames as well?  If so, I
think we should make these two types of use more similar.

Message #11 received at 24147 <at> debbugs.gnu.org (full text, mbox):

From: Michael Shields <shields <at> msrl.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24147 <at> debbugs.gnu.org
Subject: Re: bug#24147: emacsclient should pass frame-parameters to tty frames
Date: Wed, 24 Aug 2016 08:08:15 -0700

On Sat, Aug 6, 2016 at 3:06 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> Thanks.  But I think, for compatibility with the GUI use case, the
> additional parameter should be &optional, not mandatory.

Isn't server-process-filter the only caller of server-create-tty-frame?

Message #14 received at 24147 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Shields <shields <at> msrl.com>
Cc: 24147 <at> debbugs.gnu.org
Subject: Re: bug#24147: emacsclient should pass frame-parameters to tty frames
Date: Wed, 24 Aug 2016 18:15:49 +0300

> From: Michael Shields <shields <at> msrl.com>
> Date: Wed, 24 Aug 2016 08:08:15 -0700
> Cc: 24147 <at> debbugs.gnu.org
> 
> On Sat, Aug 6, 2016 at 3:06 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Thanks.  But I think, for compatibility with the GUI use case, the
> > additional parameter should be &optional, not mandatory.
> 
> Isn't server-process-filter the only caller of server-create-tty-frame?

Sorry, I don't see how that fact is relevant.  As I said, I'd like
server-create-window-system-frame and server-create-tty-frame be
compatible wrt their argument lists.  I think it's better for
long-term maintainability.

Thanks.

Message #17 received at 24147 <at> debbugs.gnu.org (full text, mbox):

From: Michael Shields <shields <at> msrl.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24147 <at> debbugs.gnu.org
Subject: Re: bug#24147: emacsclient should pass frame-parameters to tty frames
Date: Wed, 24 Aug 2016 08:20:37 -0700

On Wed, Aug 24, 2016 at 8:15 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> Sorry, I don't see how that fact is relevant.  As I said, I'd like
> server-create-window-system-frame and server-create-tty-frame be
> compatible wrt their argument lists.  I think it's better for
> long-term maintainability.

I don't know why the argument is optional in either of them.  There is
only one caller, and it always passes all the arguments.

But, I'll change it if you like.

Message #20 received at 24147 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Shields <shields <at> msrl.com>
Cc: 24147 <at> debbugs.gnu.org
Subject: Re: bug#24147: emacsclient should pass frame-parameters to tty frames
Date: Wed, 24 Aug 2016 18:57:39 +0300

> From: Michael Shields <shields <at> msrl.com>
> Date: Wed, 24 Aug 2016 08:20:37 -0700
> Cc: 24147 <at> debbugs.gnu.org
> 
> On Wed, Aug 24, 2016 at 8:15 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Sorry, I don't see how that fact is relevant.  As I said, I'd like
> > server-create-window-system-frame and server-create-tty-frame be
> > compatible wrt their argument lists.  I think it's better for
> > long-term maintainability.
> 
> I don't know why the argument is optional in either of them.  There is
> only one caller, and it always passes all the arguments.

That argument was optional since it was introduced 5 years ago, so I
see no reason to change it now.

> But, I'll change it if you like.

Please do, and thanks.

Message #23 received at 24147 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Shields <shields <at> msrl.com>
Cc: 24147 <at> debbugs.gnu.org
Subject: Re: bug#24147: emacsclient should pass frame-parameters to tty frames
Date: Tue, 25 Jun 2019 13:58:45 +0200

Michael Shields <shields <at> msrl.com> writes:

> Currently, emacsclient's --frame-parameters argument is silently
> ignored when creating frames on a tty.  This prevents emacsclient from
> giving the new frame a name.
>
> I've attached a patch that corrects this.

I've now applied the patch to the Emacs trunk, adjusting for Eli's
comments about the PARAMETERS argument being optional.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.