GNU logs - #24556, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#24556: 25.1.50; Undo partially broken in patch mode
Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 28 Sep 2016 13:30:03 +0000
Resent-Message-ID: <handler.24556.B.147506935321040 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 24556 <at> debbugs.gnu.org
From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Message-ID: <544bf69a-4bbf-c03b-c4fb-0432b6bd12fb@HIDDEN>
Date: Wed, 28 Sep 2016 09:28:43 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="jJJnd06Lfl6o8Fqj3OSQ1jxnuapwm7awu"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--jJJnd06Lfl6o8Fqj3OSQ1jxnuapwm7awu
Content-Type: multipart/mixed; boundary="fAuNSRQwec0Crs4Lq2muaJjhig8iKsJPq";
 protected-headers="v1"
From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= <clement.pitclaudel@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Message-ID: <544bf69a-4bbf-c03b-c4fb-0432b6bd12fb@HIDDEN>
Subject: 25.1.50; Undo partially broken in patch mode

--fAuNSRQwec0Crs4Lq2muaJjhig8iKsJPq
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Recipe in emacs -Q:

* Open a patch or diff file
* Press C-c C-d [diff-unified->context]
* Press C-_ [undo]

Undo fails with the following backtrace:

Debugger entered--Lisp error: (error "Changes to be undone by function di=
fferent than announced")
  signal(error ("Changes to be undone by function different than announce=
d"))
  error("Changes to be undone by function different than announced")
  primitive-undo(1 ((apply -274 1289 9209 diff-context->unified 1289 9209=
) (apply -271 514 1289 diff-context->unified 514 1289) (#("---" 0 3 (font=
ified t face diff-header)) . 478) (481 . 484) (#("+++" 0 3 (fontified t f=
ace diff-header)) . 496) (t 22126 61486 433935 691000) (t 22126 61486 433=
935 691000) (499 . 502) (t 22126 61486 433935 691000)))
  undo-more(1)
  undo(nil)
  funcall-interactively(undo nil)
  call-interactively(undo nil nil)
  command-execute(undo)

Cl=C3=A9ment.

In GNU Emacs 25.1.50.7 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2016-07-20 built on clem-w50-mint
Repository revision: a1a0c208e3e895a6ea0942e8e5c4077faf12c7ad
Windowing system distributor 'The X.Org Foundation', version 11.0.1180300=
0
System Description:	Linux Mint 18 Sarah


--fAuNSRQwec0Crs4Lq2muaJjhig8iKsJPq--

--jJJnd06Lfl6o8Fqj3OSQ1jxnuapwm7awu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJX68WQAAoJEPqg+cTm90wjOxMP+wffpd0c1Nsg6Wtl7jyXyhTa
cfT8PaQCMnWTgIvZU3GTt3/KQwPpaiua+oqGezNlFbXxfnhh+YXx79NHHHBO3BWH
8ROMhrzgUnC2yC+UYDwL1wpFzvLAuT/rcGoJ8PER6bFx6VWS3Rao846nERQXhWjf
PMHxLAAw1CybPlReYrFMLE+HCLRnAnCp3dbT3gY0hG12/8nSRTWXX30Tvf/nXLNu
uM1KdW1oDMYyU86ac3b3pLmV0o/gbee74TQsrfjfdLevhML5Q9/oMI+RRZ6J03D0
ucPP3iyviyy2L2gbD1zpsP9Xpzlv4poSsLTUiSGpNQ3ADYw2IGtABM7p12RcbIYH
LnmVTFF7gf+tviZrwHk3l34DHxYzQeo18IQQg9jcqKCBND2yzHiGOdhOcVIxn5u7
D/JuhvyScNrMYmdZO0kqmAnlfDrLD0WmdS3GYPIis/pd0k7VPjJddabELtWuSZXA
Nx9umUtG9M15vokMecXzevAJJ6IeD5bw9sNTJrav3JahkA1AfXby8O54n9u11qDO
zX+HxNyemTe5QPobinqKigLAeCHXTJBd7nzQkzDAuPF2Tsp+mqV6Cp9RLuMBmZ9u
i1Wkw+ehSUJ9DiLv1pz4M/JlMY1uijtHcpWu3go9w3diQ9/WS274ZB3NtvklCkOd
E3Flw+YFEKYPX9kk7v/7
=nsMl
-----END PGP SIGNATURE-----

--jJJnd06Lfl6o8Fqj3OSQ1jxnuapwm7awu--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Subject: bug#24556: Acknowledgement (25.1.50; Undo partially broken in
 patch mode)
Message-ID: <handler.24556.B.147506935321040.ack <at> debbugs.gnu.org>
References: <544bf69a-4bbf-c03b-c4fb-0432b6bd12fb@HIDDEN>
X-Gnu-PR-Message: ack 24556
X-Gnu-PR-Package: emacs
Reply-To: 24556 <at> debbugs.gnu.org
Date: Wed, 28 Sep 2016 13:30:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 24556 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
24556: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24556
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 25 Jun 2019 00:13:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 24 20:13:34 2019
Received: from localhost ([127.0.0.1]:58402 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hfZ5a-0001JL-MD
	for submit <at> debbugs.gnu.org; Mon, 24 Jun 2019 20:13:34 -0400
Received: from quimby.gnus.org ([80.91.231.51]:39138)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hfZ5Z-0001JE-Uk
 for control <at> debbugs.gnu.org; Mon, 24 Jun 2019 20:13:34 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories)
 by quimby.gnus.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <larsi@HIDDEN>) id 1hfZ5X-00019W-BE
 for control <at> debbugs.gnu.org; Tue, 25 Jun 2019 02:13:33 +0200
Date: Tue, 25 Jun 2019 02:13:31 +0200
Message-Id: <m34l4eh68k.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #24556
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 24556 + confirmed quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 24556 + confirmed
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#24556: 25.1.50; Undo partially broken in patch mode
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 25 Jun 2019 00:16:02 +0000
Resent-Message-ID: <handler.24556.B24556.15614217578709 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Cc: 24556 <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <544bf69a-4bbf-c03b-c4fb-0432b6bd12fb@HIDDEN>
Date: Tue, 25 Jun 2019 02:15:51 +0200
In-Reply-To: <544bf69a-4bbf-c03b-c4fb-0432b6bd12fb@HIDDEN>
 ("=?UTF-8?Q?Cl=C3=A9ment?=
 Pit--Claudel"'s message of "Wed, 28 Sep 2016 09:28:43 -0400")
Message-ID: <m3zhm6frk8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
 
 Content preview:  =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN> writes:
    > Recipe in emacs -Q: > > * Open a patch or diff file > * Press C-c C-d [diff-unified->context]
    > * Press C-_ [undo] > > Undo fails with the following backtrace: > > Debugger
    entered--Lisp error: (err [...] 
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Cl=C3=A9ment Pit--Claudel <clement.pitclaudel@HIDDEN> writes:

> Recipe in emacs -Q:
>
> * Open a patch or diff file
> * Press C-c C-d [diff-unified->context]
> * Press C-_ [undo]
>
> Undo fails with the following backtrace:
>
> Debugger entered--Lisp error: (error "Changes to be undone by function di=
fferent than announced")
>   signal(error ("Changes to be undone by function different than announce=
d"))

I can confirm that this is still the case.

This code in diff-unified->context certainly looks like a likely culprit:

		(unless (or (not reversible) (eq buffer-undo-list t))
                  ;; Drop the many undo entries and replace them with
                  ;; a single entry that uses diff-context->unified to do
                  ;; the work.
		  (setq buffer-undo-list
			(cons (list 'apply (- old-end end) start (point-max)
				    'diff-context->unified start (point-max))
			      old-undo)))))))))))


--=20
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.