GNU bug report logs - #24606
25.1.50; (thing-at-point 'filename) doesn't recognize names with @

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24606 in the body.
You can then email your comments to 24606 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; (thing-at-point 'filename) doesn't recognize names with @
Date: Tue, 4 Oct 2016 16:18:48 +0900 (JST)

X-Debbugs-CC: Emanuel Berg <embe8573 <at> student.uu.se>
X-Debbugs-CC: tino.calancha <at> gmail.com

Problem reported by Emanuel Berg in:
https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01219.html

emacs -Q:

(let ((str "/lib/systemd/system/getty@.service")
      res)
  (with-temp-buffer
    (insert str)
    (let ((thing-at-point-file-name-chars "-@~/[:alnum:]_.${}#%,:"))
      (push `(thing-at-point-patched . ,(thing-at-point 'filename)) res))
    (push `(thing-at-point . ,(thing-at-point 'filename)) res)) res)
=> ((thing-at-point . ".service") (thing-at-point-patched . "/lib/systemd/system/getty@.service"))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From 3a4a8c7245a4b4713a92cd77e75a375cf366a825 Mon Sep 17 00:00:00 2001
From: Emanuel Berg <embe8573 <at> student.uu.se>
Date: Tue, 4 Oct 2016 16:10:44 +0900
Subject: [PATCH] thing-at-point: Add @ as a valid character for file names

Reported in:
https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01219.html
* lisp/thingatpt.el (thing-at-point-file-name-chars): Add @ (Bug#24606).
---
 lisp/thingatpt.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 9920fa0..704dc69 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -244,7 +244,7 @@ thing-at-point-bounds-of-list-at-point

 ;;  Filenames

-(defvar thing-at-point-file-name-chars "-~/[:alnum:]_.${}#%,:"
+(defvar thing-at-point-file-name-chars "-@~/[:alnum:]_.${}#%,:"
   "Characters allowable in filenames.")

 (put 'filename 'end-op
-- 
2.9.3

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.0)
 of 2016-10-04 built on calancha-pc
Repository revision: 74b4f13842f3119f98797ea76d9be42457b330e1

Message #8 received at 24606 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 24606 <at> debbugs.gnu.org
Subject: Re: bug#24606: 25.1.50;
 (thing-at-point 'filename) doesn't recognize names with @
Date: Tue, 04 Oct 2016 11:02:46 +0300

> From: Tino Calancha <tino.calancha <at> gmail.com>
> Date: Tue, 4 Oct 2016 16:18:48 +0900 (JST)
> Cc: tino.calancha <at> gmail.com
> 
> >From 3a4a8c7245a4b4713a92cd77e75a375cf366a825 Mon Sep 17 00:00:00 2001
> From: Emanuel Berg <embe8573 <at> student.uu.se>
> Date: Tue, 4 Oct 2016 16:10:44 +0900
> Subject: [PATCH] thing-at-point: Add @ as a valid character for file names
> 
> Reported in:
> https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01219.html
> * lisp/thingatpt.el (thing-at-point-file-name-chars): Add @ (Bug#24606).
> ---
>   lisp/thingatpt.el | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
> index 9920fa0..704dc69 100644
> --- a/lisp/thingatpt.el
> +++ b/lisp/thingatpt.el
> @@ -244,7 +244,7 @@ thing-at-point-bounds-of-list-at-point
> 
>   ;;  Filenames
> 
> -(defvar thing-at-point-file-name-chars "-~/[:alnum:]_.${}#%,:"
> +(defvar thing-at-point-file-name-chars "-@~/[:alnum:]_.${}#%,:"
>     "Characters allowable in filenames.")

On a typical Posix system, a file name can include any character
except '/' and a null character.  So I'm not sure we should add every
character that some user somewhere needs.

How many others here need this character be in a file name, for
thing-at-point purposes?  Maybe we should ask on emacs-devel before
deciding.

Message #13 received at 24606 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24606 <at> debbugs.gnu.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#24606: 25.1.50; (thing-at-point 'filename) doesn't
 recognize names with @
Date: Wed, 19 Aug 2020 13:55:29 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> On a typical Posix system, a file name can include any character
> except '/' and a null character.  So I'm not sure we should add every
> character that some user somewhere needs.
>
> How many others here need this character be in a file name, for
> thing-at-point purposes?  Maybe we should ask on emacs-devel before
> deciding.

That was three years ago, with no followup.

I don't think adding @ here is particularly vital -- you used to never
see that character in file names, but lately it seems to have become
more popular?  I bump into file names like that from time to time now.

So I've applied the patch -- it's hard to see how it'd introduce any
regressions, and it's slightly useful.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.