GNU bug report logs - #24645
[PATCH] hexl-mode does not fontify buffer

Previous Next

Package: emacs;

Reported by: Wilfred Hughes <me <at> wilfred.me.uk>

Date: Sat, 8 Oct 2016 18:40:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 14194

Found in version 24.3

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24645 in the body.
You can then email your comments to 24645 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#24645; Package emacs. (Sat, 08 Oct 2016 18:40:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Wilfred Hughes <me <at> wilfred.me.uk>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 08 Oct 2016 18:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilfred Hughes <me <at> wilfred.me.uk>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] hexl-mode does not fontify buffer
Date: Sat, 8 Oct 2016 14:39:20 -0400

[Message part 1 (text/plain, inline)]
hexl-mode does not ensure font-lock is enabled, so the faces
hexl-address-region and hexl-ascii-region are not applied.

See patch attached.

[0001-Apply-font-lock-in-hexl-mode-buffers.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24645; Package emacs. (Sat, 08 Oct 2016 18:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 24645 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Wilfred Hughes <me <at> wilfred.me.uk>, 24645 <at> debbugs.gnu.org
Subject: Re: bug#24645: [PATCH] hexl-mode does not fontify buffer
Date: Sat, 8 Oct 2016 21:42:07 +0300

On 08.10.2016 21:39, Wilfred Hughes wrote:
> hexl-mode does not ensure font-lock is enabled, so the faces
> hexl-address-region and hexl-ascii-region are not applied.

Would a user who disabled global-font-lock-mode really want that?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24645; Package emacs. (Wed, 02 Nov 2016 04:35:02 GMT) Full text and rfc822 format available.

Message #11 received at 24645 <at> debbugs.gnu.org (full text, mbox):

From: Wilfred Hughes <me <at> wilfred.me.uk>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 24645 <at> debbugs.gnu.org
Subject: Re: bug#24645: [PATCH] hexl-mode does not fontify buffer
Date: Wed, 2 Nov 2016 00:34:05 -0400

[Message part 1 (text/plain, inline)]
Fair enough. Here's an updated patch that respects global-font-lock-mode.

On 8 October 2016 at 14:42, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> On 08.10.2016 21:39, Wilfred Hughes wrote:
>>
>> hexl-mode does not ensure font-lock is enabled, so the faces
>> hexl-address-region and hexl-ascii-region are not applied.
>
>
> Would a user who disabled global-font-lock-mode really want that?
>

[0001-Apply-font-lock-in-hexl-mode-buffers.patch (text/x-patch, attachment)]
Merged 14194 24645. Request was from Noam Postavsky <npostavs <at> users.sourceforge.net> to control <at> debbugs.gnu.org. (Wed, 29 Nov 2017 15:25:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24645; Package emacs. (Thu, 27 Jun 2019 11:32:02 GMT) Full text and rfc822 format available.

Message #16 received at 24645 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Wilfred Hughes <me <at> wilfred.me.uk>
Cc: 14194 <at> debbugs.gnu.org, 24645 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#24645: [PATCH] hexl-mode does not fontify buffer
Date: Thu, 27 Jun 2019 13:30:56 +0200

Wilfred Hughes <me <at> wilfred.me.uk> writes:

> Fair enough. Here's an updated patch that respects global-font-lock-mode.

Thanks; applied to the Emacs trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 27 Jun 2019 11:32:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 14194 <at> debbugs.gnu.org and Jordon Biondo <biondoj <at> mail.gvsu.edu> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 27 Jun 2019 11:32:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 26 Jul 2019 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 269 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.