GNU bug report logs - #24737
`guix lint` should not check patch-file-names on inherited sources

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Severity: minor; Reported by: Marius Bakke <mbakke@HIDDEN>; dated Wed, 19 Oct 2016 15:33:01 UTC; Maintainer for guix is bug-guix@HIDDEN.
Severity set to 'minor' from 'normal' Request was from ludo@HIDDEN (Ludovic Courtès) to control <at> debbugs.gnu.org. Full text available.

Message received at 24737 <at> debbugs.gnu.org:


Received: (at 24737) by debbugs.gnu.org; 24 Oct 2016 20:04:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 24 16:04:05 2016
Received: from localhost ([127.0.0.1]:54910 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1bylTY-00084c-TF
	for submit <at> debbugs.gnu.org; Mon, 24 Oct 2016 16:04:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49625)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1bylTX-000849-Lw
 for 24737 <at> debbugs.gnu.org; Mon, 24 Oct 2016 16:04:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1bylTP-00071U-DU
 for 24737 <at> debbugs.gnu.org; Mon, 24 Oct 2016 16:03:58 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55944)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1bylTP-00071O-9b; Mon, 24 Oct 2016 16:03:55 -0400
Received: from reverse-83.fdn.fr ([80.67.176.83]:55714 helo=pluto)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1bylTO-0002be-OI; Mon, 24 Oct 2016 16:03:55 -0400
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: Marius Bakke <mbakke@HIDDEN>
Subject: Re: bug#24737: `guix lint` should not check patch-file-names on
 inherited sources
References: <87zim05tvp.fsf@HIDDEN>
 <87eg3c5d8b.fsf@HIDDEN>
 <87insk5i7l.fsf@HIDDEN>
 <87funo5hjw.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 3 Brumaire an 225 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-unknown-linux-gnu
Date: Mon, 24 Oct 2016 22:03:52 +0200
In-Reply-To: <87funo5hjw.fsf@HIDDEN>
 (Marius Bakke's message of "Sat, 22 Oct 2016 20:07:15 +0100")
Message-ID: <871sz5345z.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -6.4 (------)
X-Debbugs-Envelope-To: 24737
Cc: 24737 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.4 (------)

Marius Bakke <mbakke@HIDDEN> skribis:

> Marius Bakke <mbakke@HIDDEN> writes:
>
>> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>>
>>> Marius Bakke <mbakke@HIDDEN> skribis:
>>>
>>>> After patching 'notmuch', `guix lint -c patch-file-names` does not pass
>>>> for 'python-notmuch' which inherits the source from 'notmuch'.
>>>
>>> I agree but that=E2=80=99s not quite possible: the =E2=80=9Cinheritance=
=E2=80=9D relation (which
>>> is really just a copy of a record) is not known at run time.
>>>
>>> So we=E2=80=99d need another trick to guess whether a patch is coming f=
rom
>>> elsewhere and should consequently be ignored by =E2=80=98lint=E2=80=99.
>>
>> Here is a "RFC" patch that thwarts the warning if the source file name
>> is different from the package name. Not sure how to properly make it
>> part of the procedure, so that the checks are actually skipped as well.
>
> I just realized this approach will skip this check completely, if there
> are no packages that are named the same as origin (e.g. in the case of
> the soon-to-be-added avro, where the source is shared between the
> various avro-{c,python,java} etc packages.)
>
> The best approach is probably to check patch-file-names against
> (origin-actual-file-name (package-source package)), assuming one can
> extract the "base" name of origin-actual-file-name reliably.

(=E2=80=98origin-actual-file-name=E2=80=99 already returns a basename.)

Could you check whether the patch your proposed works well for some of
the annoying cases we currently have, and also adds those as test cases
in =E2=80=98tests/lint.scm=E2=80=99?  (See the manual on how to run the tes=
ts (info
"(guix) Running the Test Suite").)

If that works well enough, we should go for it.

The only 100% reliable way to address this, I think, would be to build a
patch to package mapping, and then make sure that for each patch, at
least one of the corresponding packages has a matching name.  The
problem is that =E2=80=98lint=E2=80=99 is currently designed to work one pa=
ckage at a
time.

Thanks!

Ludo=E2=80=99.




Information forwarded to bug-guix@HIDDEN:
bug#24737; Package guix. Full text available.

Message received at 24737 <at> debbugs.gnu.org:


Received: (at 24737) by debbugs.gnu.org; 22 Oct 2016 19:07:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 22 15:07:20 2016
Received: from localhost ([127.0.0.1]:46586 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1by1dY-0005fX-Ev
	for submit <at> debbugs.gnu.org; Sat, 22 Oct 2016 15:07:20 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49699)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mbakke@HIDDEN>) id 1by1dW-0005fQ-UT
 for 24737 <at> debbugs.gnu.org; Sat, 22 Oct 2016 15:07:19 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 5E93320566;
 Sat, 22 Oct 2016 15:07:17 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute4.internal (MEProxy); Sat, 22 Oct 2016 15:07:17 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc
 :content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-sasl-enc
 :x-sasl-enc; s=mesmtp; bh=A12rhqGbVxBicQQ9PRH5tb931nE=; b=d0TVdD
 fJaxDyTCkYusrnN9YK0Rpots7qkmX3V951D8GnAxlEczTxVcmE56JE613/MyW852
 k/1yiytRvKyOwYy1fW8jcdyk4b6aPk4x3PMksTgt7U+ebliUGIeJAxKpvB4ewWim
 ZhhtBKUAL9h6EMBnLfLywo3tGtU/PuJIHMHh4=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=A12rhqGbVxBicQQ
 9PRH5tb931nE=; b=P1HRYf5AbcVMsR06b6co8nGOtKgm3OayvLnVTsgPfd4H7mn
 WIOA+uM4xLKjMIyiWbWKMNB//+BOf0GnKnjxYim0xbyQBjbfGytqpPoTzioYsBa3
 PdQQERgm/rk99bQynaRK/7DoDHHIacre0JPwzrY1bjR5F6M2US2K0GAt4Wf4=
X-Sasl-enc: O9bp0xpwJKfbJoBjLNBBcXu0NeGR6IOtxJSIfwSaqhwT 1477163237
Received: from localhost (169.243.187.81.in-addr.arpa [81.187.243.169])
 by mail.messagingengine.com (Postfix) with ESMTPA id 0ED4CF29CB;
 Sat, 22 Oct 2016 15:07:16 -0400 (EDT)
From: Marius Bakke <mbakke@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#24737: `guix lint` should not check patch-file-names on
 inherited sources
In-Reply-To: <87insk5i7l.fsf@HIDDEN>
References: <87zim05tvp.fsf@HIDDEN>
 <87eg3c5d8b.fsf@HIDDEN>
 <87insk5i7l.fsf@HIDDEN>
Date: Sat, 22 Oct 2016 20:07:15 +0100
Message-ID: <87funo5hjw.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 24737
Cc: 24737 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Marius Bakke <mbakke@HIDDEN> writes:

> Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
>
>> Marius Bakke <mbakke@HIDDEN> skribis:
>>
>>> After patching 'notmuch', `guix lint -c patch-file-names` does not pass
>>> for 'python-notmuch' which inherits the source from 'notmuch'.
>>
>> I agree but that=E2=80=99s not quite possible: the =E2=80=9Cinheritance=
=E2=80=9D relation (which
>> is really just a copy of a record) is not known at run time.
>>
>> So we=E2=80=99d need another trick to guess whether a patch is coming fr=
om
>> elsewhere and should consequently be ignored by =E2=80=98lint=E2=80=99.
>
> Here is a "RFC" patch that thwarts the warning if the source file name
> is different from the package name. Not sure how to properly make it
> part of the procedure, so that the checks are actually skipped as well.

I just realized this approach will skip this check completely, if there
are no packages that are named the same as origin (e.g. in the case of
the soon-to-be-added avro, where the source is shared between the
various avro-{c,python,java} etc packages.)

The best approach is probably to check patch-file-names against
(origin-actual-file-name (package-source package)), assuming one can
extract the "base" name of origin-actual-file-name reliably.




Information forwarded to bug-guix@HIDDEN:
bug#24737; Package guix. Full text available.

Message received at 24737 <at> debbugs.gnu.org:


Received: (at 24737) by debbugs.gnu.org; 22 Oct 2016 18:53:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 22 14:53:05 2016
Received: from localhost ([127.0.0.1]:46563 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1by1Pl-0005Iv-Ns
	for submit <at> debbugs.gnu.org; Sat, 22 Oct 2016 14:53:05 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58553)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mbakke@HIDDEN>) id 1by1Pk-0005In-FK
 for 24737 <at> debbugs.gnu.org; Sat, 22 Oct 2016 14:53:04 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id E0582205D8;
 Sat, 22 Oct 2016 14:53:03 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute4.internal (MEProxy); Sat, 22 Oct 2016 14:53:03 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc
 :content-type:date:from:in-reply-to:message-id:mime-version
 :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ZN/+w
 zj7siUROYnMm5s0wrikGeE=; b=Ycd6dinRS9CWemZoAau+0+worJBysQBJItdZG
 ZYduZbYxbScLFssnphnyCsyBJM96/P3wCwNKwBj5dnDC/2h9i5LWFI3Xflixg+UT
 thMawMWwcLcQuyAgmK4bqioGFIro/PdXF8KaLcbYqGkZYexSM9XVrGralTC9An6m
 zItk14=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-sasl-enc
 :x-sasl-enc; s=smtpout; bh=ZN/+wzj7siUROYnMm5s0wrikGeE=; b=GI1Ga
 109EdtoXhlZLQObOBNQVoZ7/dG6JgRTCmDRLlYY7+TRVpDtPoTJBq/QRNbl2QfoU
 M2YevfydpFJoHBGjPujKcCe+j64Ts0VyYOl+qz9YASttxbwxQsYSVlgQJmVhwF2J
 GBoz9/4u9cUPgD0Bdx1goNLKDKD+qz+qe4JXZ0=
X-Sasl-enc: +/ACXg8s28LsWFKO0vAFe4/MsoXY/6eGTLSNj3uY38Cx 1477162383
Received: from localhost (169.243.187.81.in-addr.arpa [81.187.243.169])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8B69CF29CB;
 Sat, 22 Oct 2016 14:53:03 -0400 (EDT)
From: Marius Bakke <mbakke@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#24737: `guix lint` should not check patch-file-names on
 inherited sources
In-Reply-To: <87eg3c5d8b.fsf@HIDDEN>
References: <87zim05tvp.fsf@HIDDEN>
 <87eg3c5d8b.fsf@HIDDEN>
Date: Sat, 22 Oct 2016 19:53:02 +0100
Message-ID: <87insk5i7l.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 24737
Cc: 24737 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Marius Bakke <mbakke@HIDDEN> skribis:
>
>> After patching 'notmuch', `guix lint -c patch-file-names` does not pass
>> for 'python-notmuch' which inherits the source from 'notmuch'.
>
> I agree but that=E2=80=99s not quite possible: the =E2=80=9Cinheritance=
=E2=80=9D relation (which
> is really just a copy of a record) is not known at run time.
>
> So we=E2=80=99d need another trick to guess whether a patch is coming from
> elsewhere and should consequently be ignored by =E2=80=98lint=E2=80=99.

Here is a "RFC" patch that thwarts the warning if the source file name
is different from the package name. Not sure how to properly make it
part of the procedure, so that the checks are actually skipped as well.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-lint-Skip-patch-file-names-on-inherited-sources.patch

From 160132bdc23b34c6331adf00af46af19dd8d737c Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@HIDDEN>
Date: Sat, 22 Oct 2016 19:12:00 +0100
Subject: [PATCH] lint: Skip 'patch-file-names' on inherited sources.

* guix/scripts/lint.scm (check-patch-file-names): Only report when the
  source file name matches the package name.
---
 guix/scripts/lint.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index d6281ea..ba1bbc3 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -497,10 +497,13 @@ patch could not be found."
                      (_  #f))     ;must be an <origin> or something like that.
                    (or (and=> (package-source package) origin-patches)
                        '()))
-      (emit-warning
-       package
-       (_ "file names of patches should start with the package name")
-       'patch-file-names))))
+      ;; Skip report when the source file name differs (i.e. inherited).
+      (and (string-prefix? (package-name package)
+                           (origin-actual-file-name (package-source package)))
+           (emit-warning
+            package
+            (_ "file names of patches should start with the package name")
+            'patch-file-names)))))
 
 (define (escape-quotes str)
   "Replace any quote character in STR by an escaped quote character."
-- 
2.10.1


--=-=-=--




Information forwarded to bug-guix@HIDDEN:
bug#24737; Package guix. Full text available.

Message received at 24737 <at> debbugs.gnu.org:


Received: (at 24737) by debbugs.gnu.org; 19 Oct 2016 19:51:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 19 15:51:51 2016
Received: from localhost ([127.0.0.1]:40077 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1bwwty-0007qW-VY
	for submit <at> debbugs.gnu.org; Wed, 19 Oct 2016 15:51:51 -0400
Received: from eggs.gnu.org ([208.118.235.92]:46818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1bwwtx-0007qK-4j
 for 24737 <at> debbugs.gnu.org; Wed, 19 Oct 2016 15:51:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1bwwto-0006yH-2r
 for 24737 <at> debbugs.gnu.org; Wed, 19 Oct 2016 15:51:44 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58364)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1bwwtn-0006yD-Vt; Wed, 19 Oct 2016 15:51:40 -0400
Received: from reverse-83.fdn.fr ([80.67.176.83]:38912 helo=pluto)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1bwwtn-0001nV-8k; Wed, 19 Oct 2016 15:51:39 -0400
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: Marius Bakke <mbakke@HIDDEN>
Subject: Re: bug#24737: `guix lint` should not check patch-file-names on
 inherited sources
References: <87zim05tvp.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 28 =?utf-8?Q?Vend=C3=A9miaire?= an 225 de la
 =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-unknown-linux-gnu
Date: Wed, 19 Oct 2016 21:51:32 +0200
In-Reply-To: <87zim05tvp.fsf@HIDDEN>
 (Marius Bakke's message of "Wed, 19 Oct 2016 14:51:54 +0100")
Message-ID: <87eg3c5d8b.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.3 (-----)
X-Debbugs-Envelope-To: 24737
Cc: 24737 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.3 (-----)

Marius Bakke <mbakke@HIDDEN> skribis:

> After patching 'notmuch', `guix lint -c patch-file-names` does not pass
> for 'python-notmuch' which inherits the source from 'notmuch'.

I agree but that=E2=80=99s not quite possible: the =E2=80=9Cinheritance=E2=
=80=9D relation (which
is really just a copy of a record) is not known at run time.

So we=E2=80=99d need another trick to guess whether a patch is coming from
elsewhere and should consequently be ignored by =E2=80=98lint=E2=80=99.

Thanks,
Ludo=E2=80=99.




Information forwarded to bug-guix@HIDDEN:
bug#24737; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Oct 2016 15:32:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 19 11:32:48 2016
Received: from localhost ([127.0.0.1]:39930 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1bwsrH-0001Hh-Q4
	for submit <at> debbugs.gnu.org; Wed, 19 Oct 2016 11:32:48 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45567)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mbakke@HIDDEN>) id 1bwrHw-000705-0Q
 for submit <at> debbugs.gnu.org; Wed, 19 Oct 2016 09:52:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mbakke@HIDDEN>) id 1bwrHq-0000yZ-0h
 for submit <at> debbugs.gnu.org; Wed, 19 Oct 2016 09:52:06 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
 T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:49735)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mbakke@HIDDEN>) id 1bwrHp-0000yP-Sv
 for submit <at> debbugs.gnu.org; Wed, 19 Oct 2016 09:52:05 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36500)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <mbakke@HIDDEN>) id 1bwrHo-0007b9-1Z
 for bug-guix@HIDDEN; Wed, 19 Oct 2016 09:52:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mbakke@HIDDEN>) id 1bwrHk-0000ti-5Q
 for bug-guix@HIDDEN; Wed, 19 Oct 2016 09:52:04 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57043)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mbakke@HIDDEN>) id 1bwrHk-0000tF-1b
 for bug-guix@HIDDEN; Wed, 19 Oct 2016 09:52:00 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 7B97A2064E
 for <bug-guix@HIDDEN>; Wed, 19 Oct 2016 09:51:59 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute4.internal (MEProxy); Wed, 19 Oct 2016 09:51:59 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=
 content-type:date:from:message-id:mime-version:subject:to
 :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=5LX/cTbyHdBYllSPrVCpk6Ty7qM
 =; b=WK5PbxDbOlmuPVAik+etqtJY0xP+Cwn/X42opYaJIlmW20ae+eho2kXjfQl
 bC/AgqXeRT589pqinniJeqWAm77bF29k8GRVBWqnPTjdN3Yg7jEUQox+yUd/3q/H
 lziHoyQLN51jBj1sRkorZjTUWytjsdCPVh5xhm2H7yBkiVh0=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:message-id
 :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=5L
 X/cTbyHdBYllSPrVCpk6Ty7qM=; b=h31QhKyCykKCoNqqLH2P4vVw0fwHIdfbrz
 C3YUxLq6f9jug2p2QxX5gUIEAuGY/E6y9eNbYZoSM0Rq35kECeNpOxj1lqbqIPTi
 Gl5wcClWQryWKI8HC9IsLw3ExMNVe5FPAj+xKmPQX0h9sLHh0MymsXTz6HOi2BgG
 aQLTgqInQ=
X-Sasl-enc: Xy89qIbuNPujDAS8Wvg9TfJH/65dkSXU3ijAiMvG2EzO 1476885119
Received: from localhost (169.243.187.81.in-addr.arpa [81.187.243.169])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1C3D0CC0C0
 for <bug-guix@HIDDEN>; Wed, 19 Oct 2016 09:51:59 -0400 (EDT)
From: Marius Bakke <mbakke@HIDDEN>
To: bug-guix@HIDDEN
Subject: `guix lint` should not check patch-file-names on inherited sources
Date: Wed, 19 Oct 2016 14:51:54 +0100
Message-ID: <87zim05tvp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.4 (----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Wed, 19 Oct 2016 11:32:47 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.4 (----)

After patching 'notmuch', `guix lint -c patch-file-names` does not pass
for 'python-notmuch' which inherits the source from 'notmuch'.




Acknowledgement sent to Marius Bakke <mbakke@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#24737; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 2 Nov 2016 22:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.