GNU bug report logs - #25114
24.5; doc of `isearch-search-string' should say it returns nil if STRING not found

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sun, 4 Dec 2016 23:00:03 UTC

Severity: minor

Tags: fixed

Found in version 24.5

Fixed in versions 26.1, 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25114 in the body.
You can then email your comments to 25114 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25114; Package emacs. (Sun, 04 Dec 2016 23:00:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 04 Dec 2016 23:00:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; doc of `isearch-search-string' should say it returns nil if
 STRING not found
Date: Sun, 4 Dec 2016 14:59:42 -0800 (PST)

Some of the Isearch code (e.g. `isearch-lazy-highlight-search')
uses the return value of `isearch-search-string' as a Boolean value.
The doc string should say that it returns nil if STRING is not found.


In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25114; Package emacs. (Sat, 27 Jul 2019 11:44:02 GMT) Full text and rfc822 format available.

Message #8 received at 25114 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 25114 <at> debbugs.gnu.org
Subject: Re: bug#25114: 24.5; doc of `isearch-search-string' should say it
 returns nil if STRING not found
Date: Sat, 27 Jul 2019 13:43:39 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> Some of the Isearch code (e.g. `isearch-lazy-highlight-search')
> uses the return value of `isearch-search-string' as a Boolean value.
> The doc string should say that it returns nil if STRING is not found.

This seems like it was fixed by 65575c24aaa in 2016.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 27 Jul 2019 11:44:04 GMT) Full text and rfc822 format available.
bug marked as fixed in version 26.1, send any further explanations to 25114 <at> debbugs.gnu.org and Drew Adams <drew.adams <at> oracle.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 27 Jul 2019 11:44:04 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25114; Package emacs. (Sat, 27 Jul 2019 16:17:02 GMT) Full text and rfc822 format available.

Message #15 received at 25114 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 25114 <at> debbugs.gnu.org
Subject: RE: bug#25114: 24.5; doc of `isearch-search-string' should say it
 returns nil if STRING not found
Date: Sat, 27 Jul 2019 09:16:18 -0700 (PDT)

> > Some of the Isearch code (e.g. `isearch-lazy-highlight-search')
> > uses the return value of `isearch-search-string' as a Boolean value.
> > The doc string should say that it returns nil if STRING is not found.
> 
> This seems like it was fixed by 65575c24aaa in 2016.

Good.  It's not fixed in Emacs 26, at least, which is
what the bug report references.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25114; Package emacs. (Sat, 27 Jul 2019 16:32:02 GMT) Full text and rfc822 format available.

Message #18 received at 25114 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 25114 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#25114: 24.5;
 doc of `isearch-search-string' should say it returns nil if STRING
 not found
Date: Sat, 27 Jul 2019 12:31:13 -0400

fixed 25114 25.1
quit

Drew Adams <drew.adams <at> oracle.com> writes:

>> > Some of the Isearch code (e.g. `isearch-lazy-highlight-search')
>> > uses the return value of `isearch-search-string' as a Boolean value.
>> > The doc string should say that it returns nil if STRING is not found.
>> 
>> This seems like it was fixed by 65575c24aaa in 2016.
>
> Good.  It's not fixed in Emacs 26, at least, which is
> what the bug report references.

The fix [1: 65575c24aa] is included in 25.1.

[1: 65575c24aa]: 2016-01-20 15:09:09 +0200
  Fix doc string of 'isearch-search-fun-function'
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=65575c24aaad9bedf6b84cc062cc03fbe4dd1315
bug Marked as fixed in versions 25.1. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Sat, 27 Jul 2019 16:32:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25114; Package emacs. (Sat, 27 Jul 2019 16:36:02 GMT) Full text and rfc822 format available.

Message #23 received at 25114 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 25114 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#25114: 24.5;
 doc of `isearch-search-string' should say it returns nil if STRING
 not found
Date: Sat, 27 Jul 2019 19:35:37 +0300

> Date: Sat, 27 Jul 2019 09:16:18 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> Cc: 25114 <at> debbugs.gnu.org
> 
> > This seems like it was fixed by 65575c24aaa in 2016.
> 
> It's not fixed in Emacs 26, at least

Yes, it is.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 25 Aug 2019 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 240 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.