GNU bug report logs - #25124
[PATCH] gnus-message-citation-mode should fontify if derived from message-mode.

Previous Next

Package: emacs;

Reported by: Hong Xu <hong <at> topbug.net>

Date: Tue, 6 Dec 2016 09:28:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 25022

Found in version 25.1.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25124 in the body.
You can then email your comments to 25124 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25124; Package emacs. (Tue, 06 Dec 2016 09:28:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Hong Xu <hong <at> topbug.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 06 Dec 2016 09:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hong Xu <hong <at> topbug.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] gnus-message-citation-mode should fontify if derived from
 message-mode.
Date: Tue,  6 Dec 2016 01:27:26 -0800

	* gnus-cite.el (gnus-message-citation-mode): Fontify if the major
	mode is derived from message-mode (not necessarily equal to
	message-mode).
---
 lisp/gnus/gnus-cite.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/gnus/gnus-cite.el b/lisp/gnus/gnus-cite.el
index 502a3be35550..e012b256d09d 100644
--- a/lisp/gnus/gnus-cite.el
+++ b/lisp/gnus/gnus-cite.el
@@ -1204,7 +1204,7 @@ gnus-message-citation-mode
   nil ;; init-value
   "" ;; lighter
   nil ;; keymap
-  (when (eq major-mode 'message-mode)   ;FIXME: Use derived-mode-p.
+  (when (derived-mode-p 'message-mode)
     ;; FIXME: Use font-lock-add-keywords!
     (let ((defaults (car (if (featurep 'xemacs)
 			     (get 'message-mode 'font-lock-defaults)
-- 
2.1.4
Forcibly Merged 25022 25124. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 06 Dec 2016 17:36:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25124; Package emacs. (Thu, 16 Feb 2017 22:13:01 GMT) Full text and rfc822 format available.

Message #10 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hong Xu <hong <at> topbug.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] gnus-message-citation-mode should fontify if derived from
 message-mode.
Date: Thu, 16 Feb 2017 14:12:42 -0800

[Message part 1 (text/plain, inline)]
On 2016-12-06 Tue 01:27 GMT-0800, Hong Xu <hong <at> topbug.net> wrote:

> 	* gnus-cite.el (gnus-message-citation-mode): Fontify if the major
> 	mode is derived from message-mode (not necessarily equal to
> 	message-mode).
> ---
>  lisp/gnus/gnus-cite.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-cite.el b/lisp/gnus/gnus-cite.el
> index 502a3be35550..e012b256d09d 100644
> --- a/lisp/gnus/gnus-cite.el
> +++ b/lisp/gnus/gnus-cite.el
> @@ -1204,7 +1204,7 @@ gnus-message-citation-mode
>    nil ;; init-value
>    "" ;; lighter
>    nil ;; keymap
> -  (when (eq major-mode 'message-mode)   ;FIXME: Use derived-mode-p.
> +  (when (derived-mode-p 'message-mode)
>      ;; FIXME: Use font-lock-add-keywords!
>      (let ((defaults (car (if (featurep 'xemacs)
>  			     (get 'message-mode 'font-lock-defaults)


Still consider this patch? The fix is quite straightforward.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25124; Package emacs. (Mon, 24 Jun 2019 23:23:02 GMT) Full text and rfc822 format available.

Message #13 received at 25124 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Hong Xu <hong <at> topbug.net>
Cc: 25124 <at> debbugs.gnu.org, 25022 <at> debbugs.gnu.org
Subject: Re: bug#25124: [PATCH] gnus-message-citation-mode should fontify if
 derived from message-mode.
Date: Tue, 25 Jun 2019 01:22:45 +0200

Hong Xu <hong <at> topbug.net> writes:

> 	* gnus-cite.el (gnus-message-citation-mode): Fontify if the major
> 	mode is derived from message-mode (not necessarily equal to
> 	message-mode).

Thanks; applied to the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 23 Sep 2019 11:13:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 25022 <at> debbugs.gnu.org and Hong Xu <hong <at> topbug.net> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 23 Sep 2019 11:13:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 21 Oct 2019 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 188 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.