GNU bug report logs - #25175
flyspell-mode: stay off of C-c . best

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25175 in the body.
You can then email your comments to 25175 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: flyspell-mode: stay off of C-c . best
Date: Mon, 12 Dec 2016 02:23:28 +0800

X-Debbugs-cc: Manuel Serrano <Manuel.Serrano <at> sophia.inria.fr>

Here binding C-. is too dangerous, as it is too close to undo, C-/,
and it will subtly change words not on the screen, far up in the document, with the only
evidence being some choices in the modeline. Easy to overlook when doing
a lot of undos and ones finger slips a little.

Also well gosh if flyspell-use-meta-tab is already true by default, so
isn't one key enough. Why do you have to bind two keys to the same thing?

(defvar flyspell-mode-map
  (let ((map (make-sparse-keymap)))
    (if flyspell-use-meta-tab
      (define-key map "\M-\t" 'flyspell-auto-correct-word))
    (define-key map flyspell-auto-correct-binding 'flyspell-auto-correct-previous-word)
    (define-key map [(control ?\,)] 'flyspell-goto-next-error)
    (define-key map [(control ?\.)] 'flyspell-auto-correct-word)
    (define-key map [?\C-c ?$] 'flyspell-correct-word-before-point)
    map)
  "Minor mode keymap for Flyspell mode--for the whole buffer.")

OK in .emacs I will do
(eval-after-load "flyspell-mode"
  '(progn ;too close to C-/ (undo) and already on ESC TAB:
     (define-key flyspell-mode-map [(control ?\.)] [])))

Also we see

;; Some user variables control the behavior of flyspell.  They are
;; those defined under the `User variables' comment.

but below is

;;*---------------------------------------------------------------------*/
;;*    User configuration ...                                           */
;;*---------------------------------------------------------------------*/

not 'User variables'. So change one or the other. emacs-version "25.1.1".

Message #8 received at 25175 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: manuel serrano <manuel.serrano <at> sophia.inria.fr>, 25175 <at> debbugs.gnu.org
Subject: Re: bug#25175: flyspell-mode: stay off of C-c . best
Date: Mon, 14 Oct 2019 21:59:37 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> X-Debbugs-cc: Manuel Serrano <Manuel.Serrano <at> sophia.inria.fr>
>
> Here binding C-. is too dangerous, as it is too close to undo, C-/,
> and it will subtly change words not on the screen, far up in the document, with the only
> evidence being some choices in the modeline. Easy to overlook when doing
> a lot of undos and ones finger slips a little.

It changes the word at point, so I'm not sure what you mean by "not on
the screen".

Anyway, there haven't been many complaints about the key binding that I
know of, so it doesn't seem to be a general problems, so I'm closing
this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.