GNU logs - #25191, boring messages


Message sent to bug-gnu-emacs@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25191: Redesign `recentf-menu-bar' logic and its callers
Resent-From: Alexander Shukaev <emacs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 13 Dec 2016 01:00:02 +0000
Resent-Message-ID: <handler.25191.B.1481590791982 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 25191
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: 25191 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.1481590791982
          (code B ref -1); Tue, 13 Dec 2016 01:00:02 +0000
Received: (at submit) by debbugs.gnu.org; 13 Dec 2016 00:59:51 +0000
Received: from localhost ([127.0.0.1]:39813 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cGbRe-0000Fm-WE
	for submit <at> debbugs.gnu.org; Mon, 12 Dec 2016 19:59:51 -0500
Received: from eggs.gnu.org ([208.118.235.92]:50829)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <emacs@HIDDEN>) id 1cGbRd-0000FZ-Hr
 for submit <at> debbugs.gnu.org; Mon, 12 Dec 2016 19:59:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <emacs@HIDDEN>) id 1cGbRX-000496-8a
 for submit <at> debbugs.gnu.org; Mon, 12 Dec 2016 19:59:44 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:39393)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <emacs@HIDDEN>)
 id 1cGbRX-000492-5Z
 for submit <at> debbugs.gnu.org; Mon, 12 Dec 2016 19:59:43 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41793)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <emacs@HIDDEN>) id 1cGbRV-0005MV-UD
 for bug-gnu-emacs@HIDDEN; Mon, 12 Dec 2016 19:59:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <emacs@HIDDEN>) id 1cGbRS-00048J-QG
 for bug-gnu-emacs@HIDDEN; Mon, 12 Dec 2016 19:59:42 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50595)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <emacs@HIDDEN>)
 id 1cGbRS-00048B-Je
 for bug-gnu-emacs@HIDDEN; Mon, 12 Dec 2016 19:59:38 -0500
Received: from mfilter48-d.gandi.net (mfilter48-d.gandi.net [217.70.178.179])
 by relay8-d.mail.gandi.net (Postfix) with ESMTP id 2EB7040496
 for <bug-gnu-emacs@HIDDEN>; Tue, 13 Dec 2016 01:59:36 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at mfilter48-d.gandi.net
Received: from relay8-d.mail.gandi.net ([IPv6:::ffff:217.70.183.201])
 by mfilter48-d.gandi.net (mfilter48-d.gandi.net [::ffff:10.0.15.180])
 (amavisd-new, port 10024)
 with ESMTP id KIT6F-s8hcfu for <bug-gnu-emacs@HIDDEN>;
 Tue, 13 Dec 2016 01:59:34 +0100 (CET)
X-Originating-IP: 88.68.181.111
Received: from [192.168.3.110]
 (dslb-088-068-181-111.088.068.pools.vodafone-ip.de [88.68.181.111])
 (Authenticated sender: forum@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id A58A040493
 for <bug-gnu-emacs@HIDDEN>; Tue, 13 Dec 2016 01:59:34 +0100 (CET)
From: Alexander Shukaev <emacs@HIDDEN>
Message-ID: <f186d126-cb3a-3a28-e0fb-33385b8ffae6@HIDDEN>
Date: Tue, 13 Dec 2016 01:59:34 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

Hi,

consider

(defsubst recentf-menu-bar ()
   "Return the keymap of the global menu bar."
   (lookup-key global-map [menu-bar]))

(defun recentf-show-menu ()
   "Show the menu of recently opened files."
   (easy-menu-add-item
    (recentf-menu-bar) recentf-menu-path
    (list recentf-menu-title :filter 'recentf-make-menu-items)
    recentf-menu-before))

(defun recentf-hide-menu ()
   "Hide the menu of recently opened files."
   (easy-menu-remove-item (recentf-menu-bar) recentf-menu-path
                          recentf-menu-title))

from 'recentf.el'.  This code is ill-formed.  When `global-map' is 
customized in such a way that it does not have `(kbd "<menu-bar>")' (or 
`[menu-bar]'), then both `recentf-show-menu' and `recentf-hide-menu' 
will fail.  Furthermore, according to Emacs documentation, using 
`(current-global-map)' is more correct than `global-map'.

Looking forward to fix.

Regards,
Alexander




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alexander Shukaev <emacs@HIDDEN>
Subject: bug#25191: Acknowledgement (Redesign `recentf-menu-bar' logic and
 its callers)
Message-ID: <handler.25191.B.1481590791982.ack <at> debbugs.gnu.org>
References: <f186d126-cb3a-3a28-e0fb-33385b8ffae6@HIDDEN>
X-Gnu-PR-Message: ack 25191
X-Gnu-PR-Package: emacs
Reply-To: 25191 <at> debbugs.gnu.org
Date: Tue, 13 Dec 2016 01:00:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 25191 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
25191: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25191
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message received at control <at> debbugs.gnu.org:


Received: (at control) by debbugs.gnu.org; 4 Dec 2017 06:30:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 04 01:30:41 2017
Received: from localhost ([127.0.0.1]:44204 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eLkH3-00048n-Ni
	for submit <at> debbugs.gnu.org; Mon, 04 Dec 2017 01:30:41 -0500
Received: from mail-it0-f43.google.com ([209.85.214.43]:39661)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>) id 1eLkH1-00046y-T6
 for control <at> debbugs.gnu.org; Mon, 04 Dec 2017 01:30:40 -0500
Received: by mail-it0-f43.google.com with SMTP id 68so4006036ite.4
 for <control <at> debbugs.gnu.org>; Sun, 03 Dec 2017 22:30:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:subject:date:message-id:mime-version;
 bh=HCziABK8ebNMfltADQ75ov0yqgDKj9dPT3LNXmmbB5g=;
 b=EdPVAiKeO/J4O6aPceS9z/WmZQWSryjhQkmVYe4l7YbJzEbPJLHKVmC0+4DkY91dCV
 y3n4JHl7Iv3r5eeL9P8cQQVYdhIThUw4HJybjwoPUBCs9hMOWd8lyjZx5kIrZnZvC37R
 6mCcCYiVC+ZztJCpHNHpghidW0exSgX6b9KmFNqRmgjnOxD1qRlGtIgbkzhLfVczUZaI
 jXujUZOU2opkUwAWw8Ei3ewl+Hk46WMc5CT/8b6E29uJNBEdbWy2xOit5ZDPX3iG1nqd
 +JyMvZj9rngUCYxP9N2D4TPPKepDIstMHP9OTxdfVyahwZfW+Uy7uuHsUovK0StLT+Uf
 eo8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:subject:date:message-id
 :mime-version;
 bh=HCziABK8ebNMfltADQ75ov0yqgDKj9dPT3LNXmmbB5g=;
 b=dcxD1eZyPwuVw9wtcDKpj9kV/tsSr7tbPazvdbI4ilP9woSXYeGKGgdCPEDk6kx954
 9uHv0IvhBt2/Zu2s1thmAggHPK9CNFKtFCKlW4bldvpZqcmKCg/CXASjxGQppDOP5pvk
 xX2ATvnc652WcZlbh6L94B1a+BDBt6Nsz6bPWLx9yK2NYUP9ugfnOjxIMTJF0GP5QIBW
 OPOck5CaaPakLsWBPe+Lcv3iBML4xBbt34Y1IN/KG6Bz54A30MyEKaerMiJHl9xTfi7/
 s1WcR25IuuLJAtHMkEcWYqOz0RXHfbBiTIwSDcfjfCqRVJVhVht/hHiAVLqizxLxlar/
 TbzA==
X-Gm-Message-State: AKGB3mIPBafioiwXJqtA6m6RO0T1AK2GzpA4F4reu7yFH0yHxXXYk6ir
 8CpN3srugaJGLkQeL9aVhTALDg==
X-Google-Smtp-Source: AGs4zMaAkNTQyoZRrh2vnOjzrFaAcsfsmPSs8mw3mW6y9s89+NOQn/iILx5LgHb+GGB9C3z1W+rJDA==
X-Received: by 10.36.207.132 with SMTP id y126mr3100565itf.132.1512369034296; 
 Sun, 03 Dec 2017 22:30:34 -0800 (PST)
Received: from zebian ([45.2.119.34])
 by smtp.googlemail.com with ESMTPSA id k3sm5661917iok.61.2017.12.03.22.30.33
 for <control <at> debbugs.gnu.org>
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sun, 03 Dec 2017 22:30:33 -0800 (PST)
From: Noam Postavsky <npostavs@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: control message for bug #25191
Date: Mon, 04 Dec 2017 01:30:32 -0500
Message-ID: <87r2sbgg3b.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.1 (/)

retitle 25191 `recentf-menu-bar' assumes [menu-bar] is bound in global-map
quit






Last modified: Mon, 4 Dec 2017 06:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.