GNU bug report logs - #25191
`recentf-menu-bar' assumes [menu-bar] is bound in global-map

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25191 in the body.
You can then email your comments to 25191 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alexander Shukaev <emacs <at> Alexander.Shukaev.name>
To: bug-gnu-emacs <at> gnu.org
Subject: Redesign `recentf-menu-bar' logic and its callers
Date: Tue, 13 Dec 2016 01:59:34 +0100

Hi,

consider

(defsubst recentf-menu-bar ()
  "Return the keymap of the global menu bar."
  (lookup-key global-map [menu-bar]))

(defun recentf-show-menu ()
  "Show the menu of recently opened files."
  (easy-menu-add-item
   (recentf-menu-bar) recentf-menu-path
   (list recentf-menu-title :filter 'recentf-make-menu-items)
   recentf-menu-before))

(defun recentf-hide-menu ()
  "Hide the menu of recently opened files."
  (easy-menu-remove-item (recentf-menu-bar) recentf-menu-path
                         recentf-menu-title))

from 'recentf.el'.  This code is ill-formed.  When `global-map' is 
customized in such a way that it does not have `(kbd "<menu-bar>")' (or 
`[menu-bar]'), then both `recentf-show-menu' and `recentf-hide-menu' 
will fail.  Furthermore, according to Emacs documentation, using 
`(current-global-map)' is more correct than `global-map'.

Looking forward to fix.

Regards,
Alexander

Message #10 received at 25191 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alexander Shukaev <emacs <at> Alexander.Shukaev.name>
Cc: 25191 <at> debbugs.gnu.org
Subject: Re: bug#25191: Redesign `recentf-menu-bar' logic and its callers
Date: Wed, 09 Oct 2019 09:46:16 +0200

Alexander Shukaev <emacs <at> Alexander.Shukaev.name> writes:

> (defsubst recentf-menu-bar ()
>   "Return the keymap of the global menu bar."
>   (lookup-key global-map [menu-bar]))
>
> (defun recentf-show-menu ()
>   "Show the menu of recently opened files."
>   (easy-menu-add-item
>    (recentf-menu-bar) recentf-menu-path
>    (list recentf-menu-title :filter 'recentf-make-menu-items)
>    recentf-menu-before))
>
> (defun recentf-hide-menu ()
>   "Hide the menu of recently opened files."
>   (easy-menu-remove-item (recentf-menu-bar) recentf-menu-path
>                          recentf-menu-title))
>
> from 'recentf.el'.  This code is ill-formed.  When `global-map' is
> customized in such a way that it does not have `(kbd "<menu-bar>")'
> (or `[menu-bar]'), then both `recentf-show-menu' and
> `recentf-hide-menu' will fail.

I've now added checks to protect against this in Emacs 27.

> Furthermore, according to Emacs documentation, using
> `(current-global-map)' is more correct than `global-map'.

That's true, but I think fixing that is more a matter of somebody
grepping and replacing rather than fixing piecemeal, perhaps...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.