GNU bug report logs - #25230
Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries

Previous Next

Package: emacs;

Reported by: Reuben Thomas <rrt <at> sc3d.org>

Date: Mon, 19 Dec 2016 12:30:02 UTC

Severity: wishlist

Tags: fixed

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25230 in the body.
You can then email your comments to 25230 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Mon, 19 Dec 2016 12:30:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Reuben Thomas <rrt <at> sc3d.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 19 Dec 2016 12:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-emacs <bug-emacs <at> gnu.org>
Subject: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in
 built-in dictionaries
Date: Mon, 19 Dec 2016 12:28:57 +0000
[Message part 1 (text/plain, inline)]
I noticed that I had not quite finished the work of commit 854ed8a, which
removed the test for support for POSIX character classes, as that is now
guaranteed.

In ispell-set-spellchecker-params, there is code that used to be run
conditionally on support for POSIX character classes, which sets all the
CASECHARS and NOT-CASECHARS entries for built-in dictionaries to
[[:alpha:]] and [^[:alpha:]] respectively.

There is no point doing this unconditionally, so instead, put these
character classes directly into the initial values used in
ispell-dictionary-base-alist. This change also makes the variable's
initialization easier to read.

The attached patch makes these changes.

-- 
http://rrt.sc3d.org
[Message part 2 (text/html, inline)]
[0001-Use-alpha-by-default-for-ispell-built-in-dictionarie.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Mon, 19 Dec 2016 16:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Mon, 19 Dec 2016 18:23:26 +0200
> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Mon, 19 Dec 2016 12:28:57 +0000
> 
> In ispell-set-spellchecker-params, there is code that used to be run conditionally on support for POSIX
> character classes, which sets all the CASECHARS and NOT-CASECHARS entries for built-in dictionaries to
> [[:alpha:]] and [^[:alpha:]] respectively.
> 
> There is no point doing this unconditionally, so instead, put these character classes directly into the initial
> values used in ispell-dictionary-base-alist. This change also makes the variable's initialization easier to read.
> 
> The attached patch makes these changes.
> 
> -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> +     ;; just use a minimal regexp.
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)

You are assuming that [[:alpha:]] and [A-Za-z] are identical.  But
they are far from being identical, not since Emacs 25.1.  I mentioned
this in another thread today.

>      ("brasileiro"			; Brazilian mode
> -     "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> -     "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> -     "[']" nil nil nil iso-8859-1)
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1)

Same here: [[:alpha:]] is much broader now than any set of characters
supported by a single language.

In any case, these settings are for Ispell, which only supports
single-byte encodings.  We cannot use arbitrary characters with it.

IOW, I don't think this patch is in the right direction.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Mon, 19 Dec 2016 21:18:01 GMT) Full text and rfc822 format available.

Message #11 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Mon, 19 Dec 2016 21:17:17 +0000
[Message part 1 (text/plain, inline)]
On 19 December 2016 at 16:23, Eli Zaretskii <eliz <at> gnu.org> wrote:

>
> You are assuming that [[:alpha:]] and [A-Za-z] are identical.


​No, because my patch does not change the current behaviour of the code.
The assumption that [:alpha:] is OK to use here instead of A-Za-z is
already in the code.​

IOW, I don't think this patch is in the right direction.
>

​From the conversation on other bugs, I think that the correct thing to do
here is to remove the first part of my patch (so that the hardwired
dictionaries keep their individual casechars and not-casechars settings),
and keep the second part of the patch (so that
ispell-set-spellchecker-params does not change them all to [:alpha:].

Does that sound plausible? If so, I'll prepare a modified patch for your
consideration.

-- 
http://rrt.sc3d.org
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Tue, 20 Dec 2016 15:39:02 GMT) Full text and rfc822 format available.

Message #14 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Tue, 20 Dec 2016 17:37:58 +0200
> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Mon, 19 Dec 2016 21:17:17 +0000
> Cc: 25230 <at> debbugs.gnu.org
> 
>     You are assuming that [[:alpha:]] and [A-Za-z] are identical.
> 
> ​No, because my patch does not change the current behaviour of the code. The assumption that [:alpha:] is OK to use here instead of A-Za-z is already in the code.​

Can you point out where in the code you see that assumption?

> ​From the conversation on other bugs, I think that the correct thing to do here is to remove the first part of my patch (so that the hardwired dictionaries keep their individual casechars and not-casechars settings), and keep the second part of the patch (so that ispell-set-spellchecker-params does not change them all to [:alpha:].
> 
> Does that sound plausible?

I think so, but we should make sure the hard-wired values work with
Aspell, before we make that change.  If they don't, we should provide
something that works for Aspell.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Tue, 20 Dec 2016 18:43:01 GMT) Full text and rfc822 format available.

Message #17 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Tue, 20 Dec 2016 18:42:05 +0000
[Message part 1 (text/plain, inline)]
On 20 December 2016 at 15:37, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Reuben Thomas <rrt <at> sc3d.org>
> > Date: Mon, 19 Dec 2016 21:17:17 +0000
> > Cc: 25230 <at> debbugs.gnu.org
> >
> >     You are assuming that [[:alpha:]] and [A-Za-z] are identical.
> >
> > ​No, because my patch does not change the current behaviour of the code.
> The assumption that [:alpha:] is OK to use here instead of A-Za-z is
> already in the code.​
>
> Can you point out where in the code you see that assumption?
>

The current code in about line 1300 (ispell-set-spellchecker-params)
unconditionally overrides all the built-in dictionaries' values for
casechars and not-casechars with [:alpha:] in the loop that starts

(dolist (adict ispell-dictionary-alist) …)

At this point, ispell-dictionary-alist already contains
ispell-dictionary-base-alist (see a few lines above). Therefore, the
original values in the intializer are never used. (Hence my original patch.)

​​
> > ​From the conversation on other bugs, I think that the correct thing to
> do here is to remove the first part of my patch (so that the hardwired
> dictionaries keep their individual casechars and not-casechars settings),
> and keep the second part of the patch (so that
> ispell-set-spellchecker-params does not change them all to [:alpha:].
> >
> > Does that sound plausible?
>
> I think so, but we should make sure the hard-wired values work with
> Aspell, before we make that change.  If they don't, we should provide
> something that works for Aspell.
>

​I thought the hard-wired values were only for ispell dictionaries (for
aspell, the dictionaries are searched for on the computer)…

-- 
http://rrt.sc3d.org
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Tue, 20 Dec 2016 19:38:01 GMT) Full text and rfc822 format available.

Message #20 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Tue, 20 Dec 2016 21:37:24 +0200
> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Tue, 20 Dec 2016 18:42:05 +0000
> Cc: 25230 <at> debbugs.gnu.org
> 
>  > ​No, because my patch does not change the current behaviour of the code. The assumption that
>  [:alpha:] is OK to use here instead of A-Za-z is already in the code.​
> 
>  Can you point out where in the code you see that assumption?
> 
> The current code in about line 1300 (ispell-set-spellchecker-params) unconditionally overrides all the built-in
> dictionaries' values for casechars and not-casechars with [:alpha:] in the loop that starts
> 
> (dolist (adict ispell-dictionary-alist) …)

That's the place where you suggested to keep the original values.  I
thought there were other places, but it's good to know there are none.

>  I think so, but we should make sure the hard-wired values work with
>  Aspell, before we make that change. If they don't, we should provide
>  something that works for Aspell.
> 
> ​I thought the hard-wired values were only for ispell dictionaries (for aspell, the dictionaries are searched for on
> the computer)…

But if we find that an installed dictionary is one of those in the
data base of the hard-wired values, we use those values, right?
Because AFAIK Aspell provides only one of the 3 character sets we need
in its dictionaries, the other 2 need to be somehow guessed or
provided by the user.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Tue, 20 Dec 2016 21:46:02 GMT) Full text and rfc822 format available.

Message #23 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Tue, 20 Dec 2016 21:45:24 +0000
[Message part 1 (text/plain, inline)]
On 20 December 2016 at 19:37, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Reuben Thomas <rrt <at> sc3d.org>
> > Date: Tue, 20 Dec 2016 18:42:05 +0000
> > Cc: 25230 <at> debbugs.gnu.org
> >
> >  > ​No, because my patch does not change the current behaviour of the
> code. The assumption that
> >  [:alpha:] is OK to use here instead of A-Za-z is already in the code.​
> >
> >  Can you point out where in the code you see that assumption?
> >
> > The current code in about line 1300 (ispell-set-spellchecker-params)
> unconditionally overrides all the built-in
> > dictionaries' values for casechars and not-casechars with [:alpha:] in
> the loop that starts
> >
> > (dolist (adict ispell-dictionary-alist) …)
>
> That's the place where you suggested to keep the original values.  I
> thought there were other places, but it's good to know there are none.
>

​I believe not, indeed.​

>  I think so, but we should make sure the hard-wired values work with
> >  Aspell, before we make that change. If they don't, we should provide
> >  something that works for Aspell.
> >
> > ​I thought the hard-wired values were only for ispell dictionaries (for
> aspell, the dictionaries are searched for on
> > the computer)…
>
> But if we find that an installed dictionary is one of those in the
> data base of the hard-wired values, we use those values, right?
>

​No, for aspell, we should only be using aspell dictionaries (found by
ispell-find-aspell-dictionaries).​


> Because AFAIK Aspell provides only one of the 3 character sets we need
> in its dictionaries, the other 2 need to be somehow guessed or
> provided by the user.
>

​They are guessed as [:alpha:], because we don't have better information
(that I know of).

-- 
http://rrt.sc3d.org
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Wed, 21 Dec 2016 00:21:01 GMT) Full text and rfc822 format available.

Message #26 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 00:20:27 +0000
[Message part 1 (text/plain, inline)]
Here's an updated patch, which simply removes the overriding of the
built-in CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It
assumes that all other dictionaries (either configured by the user or found
by the various auto-scanning functions) will have sensible
CASECHARS/NOT-CASECHARS values, which is expected to be the case at present.
[Message part 2 (text/html, inline)]
[0001-Keep-default-CASECHARS-NOT-CASECHARS-for-ispell-buil.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Wed, 21 Dec 2016 17:17:02 GMT) Full text and rfc822 format available.

Message #29 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 19:15:27 +0200
> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Wed, 21 Dec 2016 00:20:27 +0000
> Cc: 25230 <at> debbugs.gnu.org
> 
> Here's an updated patch, which simply removes the overriding of the built-in
> CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes that all other dictionaries (either
> configured by the user or found by the various auto-scanning functions) will have sensible
> CASECHARS/NOT-CASECHARS values, which is expected to be the case at present.

Looks like you sent the wrong patch, as this:

> diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
> index 23ee412..82e5c2b 100644
> --- a/lisp/textmodes/ispell.el
> +++ b/lisp/textmodes/ispell.el
> @@ -436,114 +436,70 @@ ispell-dictionary-base-alist
>       ;; The default dictionary.  It may be English.aff, or any other
>       ;; dictionary depending on locale and such things.  We should probably
>       ;; ask ispell what dictionary it's using, but until we do that, let's
> -     ;; just use a minimal regexp. [:alpha:] will later be set if possible.
> -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> +     ;; just use a minimal regexp.
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
>      ("american"				; Yankee English
> -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
>      ("brasileiro"			; Brazilian mode
> -     "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> -     "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]"
> -     "[']" nil nil nil iso-8859-1)
> +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1)

leaves the overriding in place.  Am I missing something?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Wed, 21 Dec 2016 17:32:02 GMT) Full text and rfc822 format available.

Message #32 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 17:31:46 +0000
[Message part 1 (text/plain, inline)]
On 21 December 2016 at 17:15, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Reuben Thomas <rrt <at> sc3d.org>
> > Date: Wed, 21 Dec 2016 00:20:27 +0000
> > Cc: 25230 <at> debbugs.gnu.org
> >
> > Here's an updated patch, which simply removes the overriding of the
> built-in
> > CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes
> that all other dictionaries (either
> > configured by the user or found by the various auto-scanning functions)
> will have sensible
> > CASECHARS/NOT-CASECHARS values, which is expected to be the case at
> present.
>
> Looks like you sent the wrong patch, as this:
>
> > diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
> > index 23ee412..82e5c2b 100644
> > --- a/lisp/textmodes/ispell.el
> > +++ b/lisp/textmodes/ispell.el
> > @@ -436,114 +436,70 @@ ispell-dictionary-base-alist
> >       ;; The default dictionary.  It may be English.aff, or any other
> >       ;; dictionary depending on locale and such things.  We should
> probably
> >       ;; ask ispell what dictionary it's using, but until we do that,
> let's
> > -     ;; just use a minimal regexp. [:alpha:] will later be set if
> possible.
> > -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> > +     ;; just use a minimal regexp.
> > +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
> >      ("american"                              ; Yankee English
> > -     "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1)
> > +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1)
> >      ("brasileiro"                    ; Brazilian mode
> > -     "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\
> 334\302\312\324a-z\341\351\355\363\372\340\350\354\362\
> 371\343\365\347\374\342\352\364]"
> > -     "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\
> 307\334\302\312\324a-z\341\351\355\363\372\340\350\354\
> 362\371\343\365\347\374\342\352\364]"
> > -     "[']" nil nil nil iso-8859-1)
> > +     "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1)
>
> leaves the overriding in place.  Am I missing something?
>

​I'm baffled, I somehow inverted the sense of what I meant to do,
discarding the correct bit of the patch and keeping the incorrect bit.
Sorry about that. I attach what should now be the correct patch.

-- 
http://rrt.sc3d.org
[Message part 2 (text/html, inline)]
[0001-Keep-default-CASECHARS-NOT-CASECHARS-for-ispell-buil.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Wed, 21 Dec 2016 18:04:01 GMT) Full text and rfc822 format available.

Message #35 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 20:03:04 +0200
> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Wed, 21 Dec 2016 17:31:46 +0000
> Cc: 25230 <at> debbugs.gnu.org
> 
> ​I'm baffled, I somehow inverted the sense of what I meant to do, discarding the correct bit of the patch and
> keeping the incorrect bit.

Mysteries of Git...

> Sorry about that. I attach what should now be the correct patch.

That looks good, thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Wed, 21 Dec 2016 22:34:01 GMT) Full text and rfc822 format available.

Message #38 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25230 <at> debbugs.gnu.org
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Wed, 21 Dec 2016 22:33:01 +0000
[Message part 1 (text/plain, inline)]
On 21 December 2016 at 18:03, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Reuben Thomas <rrt <at> sc3d.org>
> > Date: Wed, 21 Dec 2016 17:31:46 +0000
> > Cc: 25230 <at> debbugs.gnu.org
> >
> > ​I'm baffled, I somehow inverted the sense of what I meant to do,
> discarding the correct bit of the patch and
> > keeping the incorrect bit.
>
> Mysteries of Git...
>

​Mysteries of magit in this case, which seems appropriate!​


> > Sorry about that. I attach what should now be the correct patch.
>
> That looks good, thanks.
>

​Good, I've installed it. Thanks for the review.

-- 
http://rrt.sc3d.org
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25230; Package emacs. (Mon, 24 Jun 2019 23:09:02 GMT) Full text and rfc822 format available.

Message #41 received at 25230 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25230 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for
 CASECHARS in built-in dictionaries
Date: Tue, 25 Jun 2019 01:08:07 +0200
Reuben Thomas <rrt <at> sc3d.org> writes:

>  That looks good, thanks.
>
> ​Good, I've installed it. Thanks for the review.

As far as I can tell, the issue in this bug report was resolved, but the
report wasn't closed, so I'm doing that now.  If that's a mistake,
please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 24 Jun 2019 23:09:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 25230 <at> debbugs.gnu.org and Reuben Thomas <rrt <at> sc3d.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 24 Jun 2019 23:09:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 23 Jul 2019 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.