GNU bug report logs - #25281
rust importer duplicates input

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25281 in the body.
You can then email your comments to 25281 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> libertad.pw>
To: bug-guix <at> gnu.org
Subject: rust importer duplicates input
Date: Tue, 27 Dec 2016 16:10:40 +0000

I'm on the grand journey into rusty land, and while I'm
assembling a list of what needs to be packaged to package our
prototype, I got this:

ng0 <at> wasp ~$ guix import crate net2
following redirection to `https://crates-io.s3-us-west-1.amazonaws.com/crates/net2/net2-0.2.26.crate'...
(package
  (name "rust-net2")
  (version "0.2.26")
  (source
    (origin
      (method url-fetch)
      (uri (crate-uri "net2" version))
      (file-name
        (string-append name "-" version ".tar.gz"))
      (sha256
        (base32
          "1qp3q6xynb481rsp3ig1nmqb6qlxfba3shfrmqij88cppsv9rpsy"))))
  (build-system cargo-build-system)
  (inputs
    `(("rust-cfg-if" ,rust-cfg-if)
      ("rust-kernel32-sys" ,rust-kernel32-sys)
      ("rust-libc" ,rust-libc)
      ("rust-libc" ,rust-libc)
      ("rust-libc" ,rust-libc)
      ("rust-libc" ,rust-libc)
      ("rust-libc" ,rust-libc)
      ("rust-winapi" ,rust-winapi)
      ("rust-ws2-32-sys" ,rust-ws2-32-sys)))
  (home-page
    "https://github.com/rust-lang-nursery/net2-rs")
  (synopsis
    "Extensions to the standard library's networking types as proposed in RFC 1158.
")
  (description
    "Extensions to the standard library's networking types as proposed in RFC 1158.
")
  (license (list license:expat license:asl2.0)))

-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

Message #8 received at 25281 <at> debbugs.gnu.org (full text, mbox):

From: David Craven <david <at> craven.ch>
To: ng0 <ng0 <at> libertad.pw>
Cc: 25281 <at> debbugs.gnu.org
Subject: Re: bug#25281: rust importer duplicates input
Date: Wed, 28 Dec 2016 01:01:39 +0100

Looking at the Cargo.toml file we see this:

[target."cfg(unix)".dependencies]
libc = "0.2.14"
# Compat with older Cargo versions temporarily
[target.x86_64-unknown-linux-gnu.dependencies]
libc = "0.2.14"
[target.i686-unknown-linux-gnu.dependencies]
libc = "0.2.14"
[target.x86_64-apple-darwin.dependencies]
libc = "0.2.14"
[target.i686-apple-darwin.dependencies]
libc = "0.2.14"

I started reimplementing cargos dependency resolution algorithm, but
think now that it's better to use a Cargo.lock file when one is
provided.

When there isn't a cargo lock file it's a library in the sense that it
is a collection of source code that can be reused in a cargo project
that has a Cargo.lock file.

I don't think that this is a issue that needs fixing.

Message #11 received at 25281 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: David Craven <david <at> craven.ch>
Cc: ng0 <ng0 <at> libertad.pw>, 25281 <at> debbugs.gnu.org
Subject: Re: bug#25281: rust importer duplicates input
Date: Wed, 28 Dec 2016 13:06:28 +0100

David Craven <david <at> craven.ch> writes:

> Looking at the Cargo.toml file we see this:
>
> [target."cfg(unix)".dependencies]
> libc = "0.2.14"
> # Compat with older Cargo versions temporarily
> [target.x86_64-unknown-linux-gnu.dependencies]
> libc = "0.2.14"
> [target.i686-unknown-linux-gnu.dependencies]
> libc = "0.2.14"
> [target.x86_64-apple-darwin.dependencies]
> libc = "0.2.14"
> [target.i686-apple-darwin.dependencies]
> libc = "0.2.14"
>
> I started reimplementing cargos dependency resolution algorithm, but
> think now that it's better to use a Cargo.lock file when one is
> provided.
>
> When there isn't a cargo lock file it's a library in the sense that it
> is a collection of source code that can be reused in a cargo project
> that has a Cargo.lock file.
>
> I don't think that this is a issue that needs fixing.

Could the importer be changed to either ignore targets that don’t match
the current architecture or to uniquify the list of inputs?

~~ Ricardo

Message #14 received at 25281 <at> debbugs.gnu.org (full text, mbox):

From: David Craven <david <at> craven.ch>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: ng0 <ng0 <at> libertad.pw>, 25281 <at> debbugs.gnu.org
Subject: Re: bug#25281: rust importer duplicates input
Date: Wed, 28 Dec 2016 21:51:19 +0100

> Could the importer be changed to either ignore targets that don’t match
> the current architecture or to uniquify the list of inputs?

It could, but I don't see an advantage. It takes more than just
removing duplicate inputs for the thing to build. I'd find time spent
on a Cargo.lock parser (which should be quite easy) to be more useful,
but if someone wants to do it...

Message #17 received at 25281 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: ng0 <ng0 <at> libertad.pw>
Cc: 25281 <at> debbugs.gnu.org
Subject: Re: bug#25281: rust importer duplicates input
Date: Fri, 02 Jul 2021 10:52:56 +0200

Hi,

On mar., 27 déc. 2016 at 16:10, ng0 <ng0 <at> libertad.pw> wrote:

> ng0 <at> wasp ~$ guix import crate net2
> following redirection to `https://crates-io.s3-us-west-1.amazonaws.com/crates/net2/net2-0.2.26.crate'...
> (package
>   (name "rust-net2")
>   (version "0.2.26")
>   (source
>     (origin
>       (method url-fetch)
>       (uri (crate-uri "net2" version))
>       (file-name
>         (string-append name "-" version ".tar.gz"))
>       (sha256
>         (base32
>           "1qp3q6xynb481rsp3ig1nmqb6qlxfba3shfrmqij88cppsv9rpsy"))))
>   (build-system cargo-build-system)
>   (inputs
>     `(("rust-cfg-if" ,rust-cfg-if)
>       ("rust-kernel32-sys" ,rust-kernel32-sys)
>       ("rust-libc" ,rust-libc)
>       ("rust-libc" ,rust-libc)
>       ("rust-libc" ,rust-libc)
>       ("rust-libc" ,rust-libc)
>       ("rust-libc" ,rust-libc)
>       ("rust-winapi" ,rust-winapi)
>       ("rust-ws2-32-sys" ,rust-ws2-32-sys)))
>   (home-page
>     "https://github.com/rust-lang-nursery/net2-rs")
>   (synopsis
>     "Extensions to the standard library's networking types as proposed in RFC 1158.
> ")
>   (description
>     "Extensions to the standard library's networking types as proposed in RFC 1158.
> ")
>   (license (list license:expat license:asl2.0)))

Using Guix 3694c0d, I get this:

--8<---------------cut here---------------start------------->8---
$ guix import crate net2
(define-public rust-net2-0.2
  (package
    (name "rust-net2")
    (version "0.2.37")
    (source
      (origin
        (method url-fetch)
        (uri (crate-uri "net2" version))
        (file-name
          (string-append name "-" version ".tar.gz"))
        (sha256
          (base32
            "1bk8jp0i12gvhrlaqbfq19ancja70r1rg3sywbhjl0385g8k05ir"))))
    (build-system cargo-build-system)
    (arguments
      `(#:cargo-inputs
        (("rust-cfg-if" ,rust-cfg-if-0.1)
         ("rust-libc" ,rust-libc-0.2)
         ("rust-winapi" ,rust-winapi-0.3))))
    (home-page
      "https://github.com/deprecrated/net2-rs")
    (synopsis
      "Extensions to the standard library's networking types as proposed in RFC 1158.
")
    (description
      "Extensions to the standard library's networking types as proposed in RFC 1158.
")
    (license (list license:expat license:asl2.0))))
--8<---------------cut here---------------end--------------->8---

Therefore, I think this bug report can be close.  WDYT?


All the best,
simon

Message #22 received at 25281-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: ng0 <ng0 <at> libertad.pw>
Cc: 25281-done <at> debbugs.gnu.org
Subject: Re: bug#25281: rust importer duplicates input
Date: Sat, 03 Jul 2021 09:54:07 +0200

Hi,

On Fri, 02 Jul 2021 at 10:52, zimoun <zimon.toutoune <at> gmail.com> wrote:
> On mar., 27 déc. 2016 at 16:10, ng0 <ng0 <at> libertad.pw> wrote:
>
>> ng0 <at> wasp ~$ guix import crate net2
>> following redirection to `https://crates-io.s3-us-west-1.amazonaws.com/crates/net2/net2-0.2.26.crate'...
>> (package
>>   (name "rust-net2")
>>   (version "0.2.26")
>>   (source
>>     (origin
>>       (method url-fetch)
>>       (uri (crate-uri "net2" version))
>>       (file-name
>>         (string-append name "-" version ".tar.gz"))
>>       (sha256
>>         (base32
>>           "1qp3q6xynb481rsp3ig1nmqb6qlxfba3shfrmqij88cppsv9rpsy"))))
>>   (build-system cargo-build-system)
>>   (inputs
>>     `(("rust-cfg-if" ,rust-cfg-if)
>>       ("rust-kernel32-sys" ,rust-kernel32-sys)
>>       ("rust-libc" ,rust-libc)
>>       ("rust-libc" ,rust-libc)
>>       ("rust-libc" ,rust-libc)
>>       ("rust-libc" ,rust-libc)
>>       ("rust-libc" ,rust-libc)
>>       ("rust-winapi" ,rust-winapi)
>>       ("rust-ws2-32-sys" ,rust-ws2-32-sys)))
>>   (home-page
>>     "https://github.com/rust-lang-nursery/net2-rs")
>>   (synopsis
>>     "Extensions to the standard library's networking types as proposed in RFC 1158.
>> ")
>>   (description
>>     "Extensions to the standard library's networking types as proposed in RFC 1158.
>> ")
>>   (license (list license:expat license:asl2.0)))
>
> Using Guix 3694c0d, I get this:
>
> $ guix import crate net2
> (define-public rust-net2-0.2
>   (package
>     (name "rust-net2")
>     (version "0.2.37")
>     (source
>       (origin
>         (method url-fetch)
>         (uri (crate-uri "net2" version))
>         (file-name
>           (string-append name "-" version ".tar.gz"))
>         (sha256
>           (base32
>             "1bk8jp0i12gvhrlaqbfq19ancja70r1rg3sywbhjl0385g8k05ir"))))
>     (build-system cargo-build-system)
>     (arguments
>       `(#:cargo-inputs
>         (("rust-cfg-if" ,rust-cfg-if-0.1)
>          ("rust-libc" ,rust-libc-0.2)
>          ("rust-winapi" ,rust-winapi-0.3))))
>     (home-page
>       "https://github.com/deprecrated/net2-rs")
>     (synopsis
>       "Extensions to the standard library's networking types as proposed in RFC 1158.
> ")
>     (description
>       "Extensions to the standard library's networking types as proposed in RFC 1158.
> ")
>     (license (list license:expat license:asl2.0))))
>
> Therefore, I think this bug report can be close.  WDYT?

I get a «Delivery Status Notification (Failure)» from the email address
of the submitter, and I consider this issue is now fixed, so closing.

If I misread something or misunderstand a point, please reopen.

All the best,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.