GNU bug report logs - #25364
etags malloc problems

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25364 in the body.
You can then email your comments to 25364 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: <5upnzm+87w9w470225qs <at> sharklasers.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: etags malloc problems
Date: Thu, 05 Jan 2017 03:07:13 +0000

[Message part 1 (text/plain, inline)]

clang-3.9  -g -pipe -Wall -O1 -fsanitize=address -fno-omit-frame-pointer   -MD  -MF.depend.etags.o -MTetags.o -std=gnu99 -fstack-protector-strong    -Qunused-arguments  -c etags.c -o etags.o
etags.c:6367:25: warning: assigning to 'unsigned char *' from 'char [256]'
      converts between pointers to integer types with different sign
      [-Wpointer-sign]
      patbuf->translate = lc_trans;     /* translation table to fold case  */
                        ^ ~~~~~~~~
1 warning generated.
clang-3.9 -g -pipe -Wall -O1 -fsanitize=address -fno-omit-frame-pointer -std=gnu99 -fstack-protector-strong -Qunused-arguments  -o etags etags.o  
echo ./etags.c | ./etags -l auto -S -

=================================================================
==5176==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 120 byte(s) in 1 object(s) allocated from:
    #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
    #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
    #2 0x5036c5 in main /tmp/etags/etags.c:1097:15
    #3 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)

Direct leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
    #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
    #2 0x5036b8 in main /tmp/etags/etags.c:1091:20
    #3 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
    #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
    #2 0x50447c in concat /tmp/etags/etags.c:6958:18
    #3 0x503706 in main /tmp/etags/etags.c:1109:15
    #4 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)

SUMMARY: AddressSanitizer: 184 byte(s) leaked in 3 allocation(s).

the attached patch is what i used to make etags.c compile.





----
Sent using Sharklasers.com
Block or report abuse: https://www.sharklasers.com//abuse/?a=Q1RzSAoOVvkQhQ%2B3414YfAGJQtiX

[etagswithoutemacs.diff (text/x-patch, attachment)]

Message #8 received at 25364 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 5upnzm+87w9w470225qs <at> sharklasers.com
Cc: 25364 <at> debbugs.gnu.org
Subject: Re: bug#25364: etags malloc problems
Date: Thu, 05 Jan 2017 17:36:19 +0200

> Date: Thu, 05 Jan 2017 03:07:13 +0000
> From: <5upnzm+87w9w470225qs <at> sharklasers.com>
> 
> clang-3.9  -g -pipe -Wall -O1 -fsanitize=address -fno-omit-frame-pointer   -MD  -MF.depend.etags.o -MTetags.o -std=gnu99 -fstack-protector-strong    -Qunused-arguments  -c etags.c -o etags.o
> etags.c:6367:25: warning: assigning to 'unsigned char *' from 'char [256]'
>       converts between pointers to integer types with different sign
>       [-Wpointer-sign]
>       patbuf->translate = lc_trans;     /* translation table to fold case  */
>                         ^ ~~~~~~~~
> 1 warning generated.

This warning is a harmless nuisance, AFAIU.

> ==5176==ERROR: LeakSanitizer: detected memory leaks
> 
> Direct leak of 120 byte(s) in 1 object(s) allocated from:
>     #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
>     #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
>     #2 0x5036c5 in main /tmp/etags/etags.c:1097:15
>     #3 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
> 
> Direct leak of 40 byte(s) in 1 object(s) allocated from:
>     #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
>     #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
>     #2 0x5036b8 in main /tmp/etags/etags.c:1091:20
>     #3 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
> 
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
>     #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
>     #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
>     #2 0x50447c in concat /tmp/etags/etags.c:6958:18
>     #3 0x503706 in main /tmp/etags/etags.c:1109:15
>     #4 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
> 
> SUMMARY: AddressSanitizer: 184 byte(s) leaked in 3 allocation(s).
> 
> the attached patch is what i used to make etags.c compile.

I'm not sure I understand why all those patches are needed.  Is that
just to shut up the above warning?  If there were other problems
during compilation, please show the warning/error messages.

Also, it looks like you are using some old version of the Emacs
sources, because neither Emacs 25.1, the latest released version, nor
the current master branch match the line numbers reported by the
compiler.  Could you try the latest version of the sources, and see if
the problems you found are still there?

Thanks.

Message #11 received at 25364 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: <5upnzm+87w9w470225qs <at> sharklasers.com>
Cc: 25364 <at> debbugs.gnu.org
Subject: Re: bug#25364: etags malloc problems
Date: Thu, 05 Jan 2017 16:52:47 +0100

On Jan 05 2017, <5upnzm+87w9w470225qs <at> sharklasers.com> wrote:

> ==5176==ERROR: LeakSanitizer: detected memory leaks
>
> Direct leak of 120 byte(s) in 1 object(s) allocated from:
>     #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
>     #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
>     #2 0x5036c5 in main /tmp/etags/etags.c:1097:15
>     #3 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
>
> Direct leak of 40 byte(s) in 1 object(s) allocated from:
>     #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
>     #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
>     #2 0x5036b8 in main /tmp/etags/etags.c:1091:20
>     #3 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
>
> Direct leak of 24 byte(s) in 1 object(s) allocated from:
>     #0 0x4cba68 in __interceptor_malloc (/tmp/etags/etags+0x4cba68)
>     #1 0x5043f8 in xmalloc /tmp/etags/etags.c:7238:18
>     #2 0x50447c in concat /tmp/etags/etags.c:6958:18
>     #3 0x503706 in main /tmp/etags/etags.c:1109:15
>     #4 0x7fb31bc332b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)

These are all allocations in main, no point in freeing them if the
process is exiting anyway.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #14 received at 25364 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: <5upnzm+87w9w470225qs <at> sharklasers.com>
Cc: 25364 <at> debbugs.gnu.org
Subject: Re: bug#25364: etags malloc problems
Date: Thu, 05 Jan 2017 11:54:48 -0500

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

Placating clang is not a design goal of Emacs.  If this is an actual
bug, then we should fix it.  Otherwhse we should ignore it.

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Message #17 received at 25364 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Richard Stallman <rms <at> gnu.org>
Cc: 5upnzm+87w9w470225qs <at> sharklasers.com, 25364 <at> debbugs.gnu.org
Subject: Re: bug#25364: etags malloc problems
Date: Sun, 29 Sep 2019 17:17:46 +0200

Richard Stallman <rms <at> gnu.org> writes:

> Placating clang is not a design goal of Emacs.  If this is an actual
> bug, then we should fix it.  Otherwhse we should ignore it.

I don't think there were any actual bugs in this report, so I'm closing
it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.