GNU bug report logs - #25402
Race condition in "colors" test

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 8 Jan 2017 22:36:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 08 17:36:11 2017
Received: from localhost ([127.0.0.1]:47191 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cQM4R-0006fJ-6e
	for submit <at> debbugs.gnu.org; Sun, 08 Jan 2017 17:36:11 -0500
Received: from eggs.gnu.org ([208.118.235.92]:36457)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sanvila@HIDDEN>) id 1cQM4Q-0006f4-0D
 for submit <at> debbugs.gnu.org; Sun, 08 Jan 2017 17:36:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <sanvila@HIDDEN>) id 1cQM4J-00008J-Ar
 for submit <at> debbugs.gnu.org; Sun, 08 Jan 2017 17:36:04 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:49126)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <sanvila@HIDDEN>) id 1cQM4J-000086-6x
 for submit <at> debbugs.gnu.org; Sun, 08 Jan 2017 17:36:03 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55661)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <sanvila@HIDDEN>) id 1cQM4H-0003Yt-Nx
 for bug-diffutils@HIDDEN; Sun, 08 Jan 2017 17:36:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <sanvila@HIDDEN>) id 1cQM4C-00006x-Pn
 for bug-diffutils@HIDDEN; Sun, 08 Jan 2017 17:36:01 -0500
Received: from zmta02.unex.es ([158.49.17.56]:49949)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <sanvila@HIDDEN>) id 1cQM4C-0008F3-I1
 for bug-diffutils@HIDDEN; Sun, 08 Jan 2017 17:35:56 -0500
Received: from localhost (localhost [127.0.0.1])
 by zmta02.unex.es (Postfix) with ESMTP id 45D9F60F14;
 Sun,  8 Jan 2017 23:35:13 +0100 (CET)
Received: from zmta02.unex.es ([127.0.0.1])
 by localhost (zmta02.servicios.unex.es [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id FwT7QakKEWkK; Sun,  8 Jan 2017 23:35:10 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by zmta02.unex.es (Postfix) with ESMTP id 39AE360F3B;
 Sun,  8 Jan 2017 23:35:10 +0100 (CET)
X-Virus-Scanned: amavisd-new at zmta02.siue
Received: from zmta02.unex.es ([127.0.0.1])
 by localhost (zmta02.servicios.unex.es [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id ISCADcYlN73k; Sun,  8 Jan 2017 23:35:10 +0100 (CET)
Received: from zproxy02.unex.es (zproxy02.servicios.unex.es [10.254.208.62])
 by zmta02.unex.es (Postfix) with ESMTPS id 0B47A60F14;
 Sun,  8 Jan 2017 23:35:10 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by zproxy02.unex.es (Postfix) with ESMTP id F2E9761025;
 Sun,  8 Jan 2017 23:35:09 +0100 (CET)
Received: from zproxy02.unex.es ([127.0.0.1])
 by localhost (zproxy02.servicios.unex.es [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id hqGNKcT75Eh8; Sun,  8 Jan 2017 23:35:09 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by zproxy02.unex.es (Postfix) with ESMTP id 6951261007;
 Sun,  8 Jan 2017 23:35:09 +0100 (CET)
X-Virus-Scanned: amavisd-new at zproxy02.siue
Received: from zproxy02.unex.es ([127.0.0.1])
 by localhost (zproxy02.servicios.unex.es [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id nSdOnXc_HkfD; Sun,  8 Jan 2017 23:35:09 +0100 (CET)
Received: from cantor.unex.es (cantor.unex.es [158.49.50.20])
 by zproxy02.unex.es (Postfix) with ESMTPSA id 3FAD260EC9;
 Sun,  8 Jan 2017 23:35:09 +0100 (CET)
Received: by cantor.unex.es (Postfix, from userid 1000)
 id E0080612A8; Sun,  8 Jan 2017 23:35:08 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by cantor.unex.es (Postfix) with ESMTP id D1974612A5;
 Sun,  8 Jan 2017 23:35:08 +0100 (CET)
Date: Sun, 8 Jan 2017 23:35:08 +0100 (CET)
From: Santiago Vila <sanvila@HIDDEN>
To: bug-diffutils@HIDDEN
Subject: Race condition in "colors" test
Message-ID: <alpine.DEB.2.20.1701082322140.581@HIDDEN>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
X-Debbugs-Cc: sanvila@HIDDEN,debian.axhn@HIDDEN
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
Cc: debian.axhn@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

Hello.

The test suite for diffutils 3.5 has a tendency to fail in our ppc64el
architecture:

https://buildd.debian.org/status/logs.php?pkg=diffutils&ver=1%3A3.5-2&arch=ppc64el

According to Christoph Biedl (Cc:ed), there is a race condition here:

| mkfifo fifo
| printf '%*s-a' 1000000 > a
| head -c 10 < fifo > /dev/null &
+ diff --color=always ---presume-output-tty a b > fifo
| test $? = 141 || fail=1

Quoting Christoph:

> There is a race condition involved, it fails in about three of
> four attempts - but not at all if the test is run under strace.

> A "sleep 0.1" before the diff made the test pass in ten of ten
> attempts. So the reason might indeed be the head command hasn't opened
> fifo yet by the time diff tries to write to it.

For the Debian package, I am going to add a "sleep 1"
(slightly more portable), but Christoph points out that this
should not really be architecture specific.

Thanks.