GNU bug report logs - #25575
Make ido respect completions-common-part face

Previous Next

Package: emacs;

Reported by: Luis Gerhorst <privat <at> luisgerhorst.de>

Date: Sun, 29 Jan 2017 22:24:02 UTC

Severity: wishlist

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25575 in the body.
You can then email your comments to 25575 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25575; Package emacs. (Sun, 29 Jan 2017 22:24:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Luis Gerhorst <privat <at> luisgerhorst.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 29 Jan 2017 22:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luis Gerhorst <privat <at> luisgerhorst.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Make ido respect completions-common-part face
Date: Sun, 29 Jan 2017 23:22:27 +0100
Hi,
This would allow the user to customize the display of the common part of completions, e.g. remove the decorators around it and only distinguish it by using a different face (which looks much cleaner). Company also display the common part this way (see the `company-preview-common` face).

Here's a advice based snippet that does what I want. It does not seem to handle colors properly but since completions-common-part just underlines text for me, it's ok:

(defun luis-propertize-ido-common-match-string (&rest _)
  (when ido-common-match-string
    (setq ido-common-match-string
          (propertize ido-common-match-string
                      'face 'completions-common-part))))

(defun luis-unpropertize-ido-common-match-string (&rest _)
  (when ido-common-match-string
    (setq ido-common-match-string
          (propertize ido-common-match-string
                      'face nil))))

(advice-add 'ido-completions :before
            #'luis-propertize-ido-common-match-string)
(advice-add 'ido-completions :after
            #'luis-unpropertize-ido-common-match-string)

Best regards,
Luis




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25575; Package emacs. (Thu, 09 Feb 2017 01:24:02 GMT) Full text and rfc822 format available.

Message #8 received at 25575 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Luis Gerhorst <privat <at> luisgerhorst.de>, 25575 <at> debbugs.gnu.org
Subject: Re: bug#25575: Make ido respect completions-common-part face
Date: Thu, 9 Feb 2017 03:23:00 +0200
Hey Luis,

On 30.01.2017 00:22, Luis Gerhorst wrote:

> This would allow the user to customize the display of the common part of completions, e.g. remove the decorators around it and only distinguish it by using a different face (which looks much cleaner). Company also display the common part this way (see the `company-preview-common` face).

Could you post a screenshot of the result that you see?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25575; Package emacs. (Fri, 05 Feb 2021 13:27:02 GMT) Full text and rfc822 format available.

Message #11 received at 25575 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 25575 <at> debbugs.gnu.org, Luis Gerhorst <privat <at> luisgerhorst.de>
Subject: Re: bug#25575: Make ido respect completions-common-part face
Date: Fri, 05 Feb 2021 14:26:21 +0100
Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 30.01.2017 00:22, Luis Gerhorst wrote:
>
>> This would allow the user to customize the display of the common
>> part of completions, e.g. remove the decorators around it and only
>> distinguish it by using a different face (which looks much
>> cleaner). Company also display the common part this way (see the
>> `company-preview-common` face).
>
> Could you post a screenshot of the result that you see?

More information was requested, but no response was given within a few
years, so I'm closing this bug report.  If this is something that should
still be worked on, please respond to this email and we'll reopen the
bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug closed, send any further explanations to 25575 <at> debbugs.gnu.org and Luis Gerhorst <privat <at> luisgerhorst.de> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 05 Feb 2021 13:27:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 06 Mar 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 50 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.