X-Loop: help-debbugs@HIDDEN
Subject: bug#25664: util.c of diffutils 3.5 fails to build on Windows
Resent-From: Kees Dekker <Kees.Dekker@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Thu, 09 Feb 2017 15:01:01 +0000
Resent-Message-ID: <handler.25664.B.148665245813321 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 25664
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords:
To: 25664 <at> debbugs.gnu.org
X-Debbugs-Original-To: "bug-diffutils@HIDDEN" <bug-diffutils@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.148665245813321
(code B ref -1); Thu, 09 Feb 2017 15:01:01 +0000
Received: (at submit) by debbugs.gnu.org; 9 Feb 2017 15:00:58 +0000
Received: from localhost ([127.0.0.1]:33350 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1cbqDR-0003Sm-Ie
for submit <at> debbugs.gnu.org; Thu, 09 Feb 2017 10:00:57 -0500
Received: from eggs.gnu.org ([208.118.235.92]:49827)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <Kees.Dekker@HIDDEN>) id 1cbqDP-0003SZ-HO
for submit <at> debbugs.gnu.org; Thu, 09 Feb 2017 10:00:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <Kees.Dekker@HIDDEN>) id 1cbqDG-0002Cc-AF
for submit <at> debbugs.gnu.org; Thu, 09 Feb 2017 10:00:50 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE
autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:55116)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <Kees.Dekker@HIDDEN>)
id 1cbqDG-0002CY-6e
for submit <at> debbugs.gnu.org; Thu, 09 Feb 2017 10:00:46 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40784)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <Kees.Dekker@HIDDEN>) id 1cbqDC-0005JM-RP
for bug-diffutils@HIDDEN; Thu, 09 Feb 2017 10:00:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <Kees.Dekker@HIDDEN>) id 1cbqD7-0002Bc-UR
for bug-diffutils@HIDDEN; Thu, 09 Feb 2017 10:00:42 -0500
Received: from nlsmtpp2.infor.com ([194.149.81.57]:27731)
by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <Kees.Dekker@HIDDEN>)
id 1cbqD7-0002AS-EU
for bug-diffutils@HIDDEN; Thu, 09 Feb 2017 10:00:37 -0500
X-SBRS: None
X-IronPort-AV: E=Sophos;i="5.35,349,1484002800";
d="scan'208,217";a="221255059"
From: Kees Dekker <Kees.Dekker@HIDDEN>
Thread-Topic: util.c of diffutils 3.5 fails to build on Windows
Thread-Index: AdKC1+0Bi9L+XnejQiSbmJrT6uRX1Q==
Date: Thu, 9 Feb 2017 15:00:34 +0000
Message-ID: <858F859BB4F2824EBAB5D4ED58214CB7016A452D7E@HIDDEN>
Accept-Language: nl-NL, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.21.104.139]
Content-Type: multipart/alternative;
boundary="_000_858F859BB4F2824EBAB5D4ED58214CB7016A452D7ENLBAWEXMBX3in_"
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.1 (----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.1 (----)
--_000_858F859BB4F2824EBAB5D4ED58214CB7016A452D7ENLBAWEXMBX3in_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi,
Contrary to diffutils 3.3, src/util.c got an additional piece of code, that=
is quite UNIX centric. I've the following build errors when building util.=
c with Visual Studio's cl.exe:
- SIGSTOP, SIGTSTP, SIGALRM, SIGHUP, SIGPIPE, SIGQUIT not defined.=
Windows has a very limited set of signaling, see: https://msdn.microsoft.c=
om/en-us/library/xdkz3x12.aspx
- The pseudo signals SIGKILL, SIGSTOP are not defined, similar to =
lib/sigaction.c.
- There is already special msvc code for signal handling, but is n=
ot used here.
- Even if the code compiles, the pr_program is UNIX centric too (P=
R_PROGRAM =3D /usr/bin/pr). I think the stuff behind paginate is solely UNI=
X. Can you add this behind platform specific ifdefs (#ifndef _WIN32)?
Even with using http://git.savannah.gnu.org/gitweb/?p=3Dgperf.git;a=3Dblob_=
plain;f=3DREADME.windows (step 2, native build for visual studio, using the=
ar-lib and compile helper scripts) (and making some minor fixes, see also =
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25663) util.c did not compi=
le.
The errors are:
util.c(227): error C2065: 'SIGSTOP': undeclared identifier
util.c(248): error C2065: 'SIGTSTP': undeclared identifier
util.c(251): error C2065: 'SIGALRM': undeclared identifier
util.c(251): error C2065: 'SIGHUP': undeclared identifier
util.c(251): error C2065: 'SIGPIPE': undeclared identifier
util.c(251): error C2065: 'SIGQUIT': undeclared identifier
util.c(301): error C2065: 'SIGTSTP': undeclared identifier
util.c(246): error C2099: initializer is not a constant
util.c(565): warning C4116: unnamed type definition in parentheses
util.c(896): warning C4047: '=3D': 'FILE *' differs in levels of indirectio=
n from 'int'
make[1]: *** [Makefile:1418: util.obj] Error 2
make[1]: Leaving directory '/cygdrive/d/temp/kees/downloads/diffutils-3.5/s=
rc'
make: *** [Makefile:1277: all] Error 2
I'm willing to try to make a fix, but I first like to hear your thoughts...=
.
My idea is to remove references to the 'pr' tool on Windows/Visual Studio, =
as it is not available.
Regards,
Kees
--_000_858F859BB4F2824EBAB5D4ED58214CB7016A452D7ENLBAWEXMBX3in_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle19
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1727099478;
mso-list-type:hybrid;
mso-list-template-ids:1184014546 167683726 67698691 67698693 67698689 6769=
8691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:-;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:.25in;
text-indent:-.25in;
font-family:"Calibri",sans-serif;
mso-fareast-font-family:Calibri;
mso-bidi-font-family:"Times New Roman";}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:.75in;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:1.25in;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:1.75in;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:2.25in;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:2.75in;
text-indent:-.25in;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:3.25in;
text-indent:-.25in;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:3.75in;
text-indent:-.25in;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:4.25in;
text-indent:-.25in;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3D"EN-US" link=3D"#0563C1" vlink=3D"#954F72">
<div class=3D"WordSection1">
<p class=3D"MsoNormal">Hi,<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Contrary to diffutils 3.3, src/util.c got an additio=
nal piece of code, that is quite UNIX centric. I’ve the following bui=
ld errors when building util.c with Visual Studio’s cl.exe:<o:p></o:p=
></p>
<p class=3D"MsoListParagraph" style=3D"margin-left:.25in;text-indent:-.25in=
;mso-list:l0 level1 lfo2">
<![if !supportLists]><span style=3D"mso-list:Ignore">-<span style=3D"font:7=
.0pt "Times New Roman"">  =
;
</span></span><![endif]>SIGSTOP, SIGTSTP, SIGALRM, SIGHUP, SIGPIPE, SIGQUIT=
not defined. Windows has a very limited set of signaling, see:
<a href=3D"https://msdn.microsoft.com/en-us/library/xdkz3x12.aspx">https://=
msdn.microsoft.com/en-us/library/xdkz3x12.aspx</a><o:p></o:p></p>
<p class=3D"MsoListParagraph" style=3D"margin-left:.25in;text-indent:-.25in=
;mso-list:l0 level1 lfo2">
<![if !supportLists]><span style=3D"mso-list:Ignore">-<span style=3D"font:7=
.0pt "Times New Roman"">  =
;
</span></span><![endif]>The pseudo signals SIGKILL, SIGSTOP are not defined=
, similar to lib/sigaction.c.<o:p></o:p></p>
<p class=3D"MsoListParagraph" style=3D"margin-left:.25in;text-indent:-.25in=
;mso-list:l0 level1 lfo2">
<![if !supportLists]><span style=3D"mso-list:Ignore">-<span style=3D"font:7=
.0pt "Times New Roman"">  =
;
</span></span><![endif]>There is already special msvc code for signal handl=
ing, but is not used here.<o:p></o:p></p>
<p class=3D"MsoListParagraph" style=3D"margin-left:.25in;text-indent:-.25in=
;mso-list:l0 level1 lfo2">
<![if !supportLists]><span style=3D"mso-list:Ignore">-<span style=3D"font:7=
.0pt "Times New Roman"">  =
;
</span></span><![endif]>Even if the code compiles, the pr_program is UNIX c=
entric too (PR_PROGRAM =3D /usr/bin/pr). I think the stuff behind paginate =
is solely UNIX. Can you add this behind platform specific ifdefs (#ifndef _=
WIN32)?<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Even with using <a href=3D"http://git.savannah.gnu.o=
rg/gitweb/?p=3Dgperf.git;a=3Dblob_plain;f=3DREADME.windows">
http://git.savannah.gnu.org/gitweb/?p=3Dgperf.git;a=3Dblob_plain;f=3DREADME=
.windows</a> (step 2, native build for visual studio, using the ar-lib and =
compile helper scripts) (and making some minor fixes, see also
<a href=3D"https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25663">https://d=
ebbugs.gnu.org/cgi/bugreport.cgi?bug=3D25663</a>) util.c did not compile.<o=
:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">The errors are:<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">util.c(227): error C2065: 'SIGSTOP': undeclared iden=
tifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(248): error C2065: 'SIGTSTP': undeclared iden=
tifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(251): error C2065: 'SIGALRM': undeclared iden=
tifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(251): error C2065: 'SIGHUP': undeclared ident=
ifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(251): error C2065: 'SIGPIPE': undeclared iden=
tifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(251): error C2065: 'SIGQUIT': undeclared iden=
tifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(301): error C2065: 'SIGTSTP': undeclared iden=
tifier<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(246): error C2099: initializer is not a const=
ant<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(565): warning C4116: unnamed type definition =
in parentheses<o:p></o:p></p>
<p class=3D"MsoNormal">util.c(896): warning C4047: '=3D': 'FILE *' differs =
in levels of indirection from 'int'<o:p></o:p></p>
<p class=3D"MsoNormal">make[1]: *** [Makefile:1418: util.obj] Error 2<o:p><=
/o:p></p>
<p class=3D"MsoNormal">make[1]: Leaving directory '/cygdrive/d/temp/kees/do=
wnloads/diffutils-3.5/src'<o:p></o:p></p>
<p class=3D"MsoNormal">make: *** [Makefile:1277: all] Error 2<o:p></o:p></p=
>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">I’m willing to try to make a fix, but I first =
like to hear your thoughts….<o:p></o:p></p>
<p class=3D"MsoNormal">My idea is to remove references to the ‘prR=
17; tool on Windows/Visual Studio, as it is not available.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Regards,<o:p></o:p></p>
<p class=3D"MsoNormal">Kees<o:p></o:p></p>
</div>
</body>
</html>
--_000_858F859BB4F2824EBAB5D4ED58214CB7016A452D7ENLBAWEXMBX3in_--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Kees Dekker <Kees.Dekker@HIDDEN> Subject: bug#25664: Acknowledgement (util.c of diffutils 3.5 fails to build on Windows) Message-ID: <handler.25664.B.148665245813321.ack <at> debbugs.gnu.org> References: <858F859BB4F2824EBAB5D4ED58214CB7016A452D7E@HIDDEN> X-Gnu-PR-Message: ack 25664 X-Gnu-PR-Package: diffutils Reply-To: 25664 <at> debbugs.gnu.org Date: Thu, 09 Feb 2017 15:01:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-diffutils@HIDDEN If you wish to submit further information on this problem, please send it to 25664 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 25664: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25664 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.