GNU bug report logs - #25797
Subject: 25.2; enhancement-request: expose ibuffer filter keymap as a named prefix

Previous Next

Package: emacs;

Reported by: ivan <ivan.brennan <at> gmail.com>

Date: Sun, 19 Feb 2017 19:17:02 UTC

Severity: wishlist

Tags: fixed

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25797 in the body.
You can then email your comments to 25797 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25797; Package emacs. (Sun, 19 Feb 2017 19:17:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to ivan <ivan.brennan <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 19 Feb 2017 19:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ivan <ivan.brennan <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Subject: 25.2; enhancement-request: expose ibuffer filter keymap as a
 named prefix
Date: Sun, 19 Feb 2017 14:16:22 -0500
ibuffer uses "/" as a prefix key for filter commands, like
ibuffer-filter-by-name ("/ n").

As an evil user, I wanted to use a different prefix, since evil uses
"/" for searching.

I use "SPC" as a leader-key, so I decided to put the filter commands
behind "SPC /".

The ibuffer "/" prefix is an anonymous keymap, so I had to bind my new
key to the result of a lookup-key call:

(bind-map-for-mode-inherit ivan/ibuffer-leader-map ivan/leader-map
  :major-modes (ibuffer-mode)
  :bindings
  ("/" (lookup-key ibuffer-mode-map "/")))  ; <= here

This works, but it would be nice if ibuffer's "/" prefix was bound to
a named keymap, so the above line could instead be something like:

("/" ibuffer-filter-map)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25797; Package emacs. (Fri, 26 Jul 2019 12:46:02 GMT) Full text and rfc822 format available.

Message #8 received at 25797 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: ivan <ivan.brennan <at> gmail.com>
Cc: 25797 <at> debbugs.gnu.org
Subject: Re: bug#25797: Subject: 25.2; enhancement-request: expose ibuffer
 filter keymap as a named prefix
Date: Fri, 26 Jul 2019 14:45:05 +0200
ivan <ivan.brennan <at> gmail.com> writes:

> ibuffer uses "/" as a prefix key for filter commands, like
> ibuffer-filter-by-name ("/ n").
>
> As an evil user, I wanted to use a different prefix, since evil uses
> "/" for searching.
>
> I use "SPC" as a leader-key, so I decided to put the filter commands
> behind "SPC /".
>
> The ibuffer "/" prefix is an anonymous keymap, so I had to bind my new
> key to the result of a lookup-key call:
>
> (bind-map-for-mode-inherit ivan/ibuffer-leader-map ivan/leader-map
>   :major-modes (ibuffer-mode)
>   :bindings
>   ("/" (lookup-key ibuffer-mode-map "/")))  ; <= here
>
> This works, but it would be nice if ibuffer's "/" prefix was bound to
> a named keymap, so the above line could instead be something like:
>
> ("/" ibuffer-filter-map)

Sounds reasonable.  I've now done this on the Emacs trunk.

(I kept the slightly eccentric way of specifying keys, though:

    (define-key map (kbd "m") 'ibuffer-filter-by-used-mode)
    (define-key map (kbd "M") 'ibuffer-filter-by-derived-mode)
    (define-key map (kbd "n") 'ibuffer-filter-by-name)

Most of these are redundant, but I guess it's a stylistic choice, so I
kept it.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 26 Jul 2019 12:46:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 27.1, send any further explanations to 25797 <at> debbugs.gnu.org and ivan <ivan.brennan <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 26 Jul 2019 12:46:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 24 Aug 2019 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 244 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.