GNU logs - #25814, boring messages


Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: Windows same_file macro is not reliable
Resent-From: Kees Dekker <Kees.Dekker@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Mon, 20 Feb 2017 16:02:01 +0000
Resent-Message-ID: <handler.25814.B.148760649920922 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: 25814 <at> debbugs.gnu.org
X-Debbugs-Original-To: "bug-diffutils@HIDDEN" <bug-diffutils@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.148760649920922
          (code B ref -1); Mon, 20 Feb 2017 16:02:01 +0000
Received: (at submit) by debbugs.gnu.org; 20 Feb 2017 16:01:39 +0000
Received: from localhost ([127.0.0.1]:47685 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cfqPD-0005RN-6k
	for submit <at> debbugs.gnu.org; Mon, 20 Feb 2017 11:01:39 -0500
Received: from eggs.gnu.org ([208.118.235.92]:56094)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Kees.Dekker@HIDDEN>) id 1cfqPA-0005Qy-Sx
 for submit <at> debbugs.gnu.org; Mon, 20 Feb 2017 11:01:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Kees.Dekker@HIDDEN>) id 1cfqP0-0004If-EH
 for submit <at> debbugs.gnu.org; Mon, 20 Feb 2017 11:01:31 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:47690)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <Kees.Dekker@HIDDEN>)
 id 1cfqP0-0004Ib-Aj
 for submit <at> debbugs.gnu.org; Mon, 20 Feb 2017 11:01:26 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46992)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <Kees.Dekker@HIDDEN>) id 1cfqOt-0003qp-2J
 for bug-diffutils@HIDDEN; Mon, 20 Feb 2017 11:01:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Kees.Dekker@HIDDEN>) id 1cfqOo-0004G6-7S
 for bug-diffutils@HIDDEN; Mon, 20 Feb 2017 11:01:19 -0500
Received: from nlsmtpp2.infor.com ([194.149.81.57]:35721)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <Kees.Dekker@HIDDEN>)
 id 1cfqOn-0004FO-PN
 for bug-diffutils@HIDDEN; Mon, 20 Feb 2017 11:01:14 -0500
X-SBRS: None
X-IronPort-AV: E=Sophos;i="5.35,186,1484002800"; 
 d="scan'208,217";a="223679625"
From: Kees Dekker <Kees.Dekker@HIDDEN>
Thread-Topic: Windows same_file macro is not reliable
Thread-Index: AdKLb5IYqfAagsvkQrusM8I69coRpQ==
Date: Mon, 20 Feb 2017 16:01:09 +0000
Message-ID: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
Accept-Language: nl-NL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.21.104.113]
Content-Type: multipart/alternative;
 boundary="_000_858F859BB4F2824EBAB5D4ED58214CB7016A4559B1NLBAWEXMBX3in_"
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.1 (----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.1 (----)

--_000_858F859BB4F2824EBAB5D4ED58214CB7016A4559B1NLBAWEXMBX3in_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi,

On file systems that do not support inodes (e.g. NTFS, because not everythi=
ng is POSIX), the same_file() macro (in system.h) is incorrect as st_ino (a=
nd probably st_dev) are meaningless. See also https://msdn.microsoft.com/en=
- us/library/14h5k7ff.aspx<https://msdn.microsoft.com/en-%20us/library/14h5=
k7ff.aspx>. I would suggest to add an #ifdef _WIN32 macro that let return s=
ame_file() 0.

The same applies to same_file_attributes macro. The st_uid and st_gid field=
s are never set to a useful value on Windows (see MSDN URL as mentioned bef=
ore).

The resulting suggested code would be:

#if _WIN32
# define same_file(s, t) 0
#else
# define same_file(s, t) \
    ((((s)->st_ino =3D=3D (t)->st_ino) && ((s)->st_dev =3D=3D (t)->st_dev))=
 \
     || same_special_file (s, t))
#endif

and

#ifndef same_file_attributes
#if _WIN32
# define same_file_attributes(s, t) 0
#else
# define same_file_attributes(s, t) \
   ((s)->st_mode =3D=3D (t)->st_mode \
    && (s)->st_nlink =3D=3D (t)->st_nlink \
    && (s)->st_uid =3D=3D (t)->st_uid \
    && (s)->st_gid =3D=3D (t)->st_gid \
    && (s)->st_size =3D=3D (t)->st_size \
    && (s)->st_mtime =3D=3D (t)->st_mtime \
    && (s)->st_ctime =3D=3D (t)->st_ctime)
#endif
#endif

Since I'm unfamiliar with git, please check whether this change is feasible=
.

Regards,
Kees

--_000_858F859BB4F2824EBAB5D4ED58214CB7016A4559B1NLBAWEXMBX3in_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
	{mso-style-name:msonormal;
	mso-margin-top-alt:auto;
	margin-right:0in;
	mso-margin-bottom-alt:auto;
	margin-left:0in;
	font-size:12.0pt;
	font-family:"Times New Roman",serif;}
span.EmailStyle18
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;
	font-family:"Calibri",sans-serif;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3D"EN-US" link=3D"#0563C1" vlink=3D"#954F72">
<div class=3D"WordSection1">
<p class=3D"MsoNormal">Hi,<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">On file systems that do not support inodes (e.g. NTF=
S, because not everything is POSIX), the same_file() macro (in system.h) is=
 incorrect as st_ino (and probably st_dev) are meaningless. See also
<a href=3D"https://msdn.microsoft.com/en-%20us/library/14h5k7ff.aspx">https=
://msdn.microsoft.com/en- us/library/14h5k7ff.aspx</a>. I would suggest to =
add an #ifdef _WIN32 macro that let return same_file() 0.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">The same applies to same_file_attributes macro. The =
st_uid and st_gid fields are never set to a useful value on Windows (see MS=
DN URL as mentioned before).<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">The resulting suggested code would be:<o:p></o:p></p=
>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">#if _WIN32<o:p></o:p></p>
<p class=3D"MsoNormal"># define same_file(s, t) 0<o:p></o:p></p>
<p class=3D"MsoNormal">#else<o:p></o:p></p>
<p class=3D"MsoNormal"># define same_file(s, t) \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; ((((s)-&gt;st_ino =3D=3D (t)-&gt;=
st_ino) &amp;&amp; ((s)-&gt;st_dev =3D=3D (t)-&gt;st_dev)) \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp;&nbsp; || same_special_file (s, t)=
)<o:p></o:p></p>
<p class=3D"MsoNormal">#endif<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">and<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">#ifndef same_file_attributes<o:p></o:p></p>
<p class=3D"MsoNormal">#if _WIN32<o:p></o:p></p>
<p class=3D"MsoNormal"># define same_file_attributes(s, t) 0<o:p></o:p></p>
<p class=3D"MsoNormal">#else<o:p></o:p></p>
<p class=3D"MsoNormal"># define same_file_attributes(s, t) \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp; ((s)-&gt;st_mode =3D=3D (t)-&gt;st_mode=
 \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; &amp;&amp; (s)-&gt;st_nlink =3D=
=3D (t)-&gt;st_nlink \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; &amp;&amp; (s)-&gt;st_uid =3D=3D =
(t)-&gt;st_uid \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; &amp;&amp; (s)-&gt;st_gid =3D=3D =
(t)-&gt;st_gid \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; &amp;&amp; (s)-&gt;st_size =3D=3D=
 (t)-&gt;st_size \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; &amp;&amp; (s)-&gt;st_mtime =3D=
=3D (t)-&gt;st_mtime \<o:p></o:p></p>
<p class=3D"MsoNormal">&nbsp;&nbsp;&nbsp; &amp;&amp; (s)-&gt;st_ctime =3D=
=3D (t)-&gt;st_ctime)<o:p></o:p></p>
<p class=3D"MsoNormal">#endif<o:p></o:p></p>
<p class=3D"MsoNormal">#endif<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Since I&#8217;m unfamiliar with git, please check wh=
ether this change is feasible.<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoNormal">Regards,<o:p></o:p></p>
<p class=3D"MsoNormal">Kees<o:p></o:p></p>
</div>
</body>
</html>

--_000_858F859BB4F2824EBAB5D4ED58214CB7016A4559B1NLBAWEXMBX3in_--




Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Kees Dekker <Kees.Dekker@HIDDEN>
Subject: bug#25814: Acknowledgement (Windows same_file macro is not reliable)
Message-ID: <handler.25814.B.148760649920922.ack <at> debbugs.gnu.org>
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
X-Gnu-PR-Message: ack 25814
X-Gnu-PR-Package: diffutils
Reply-To: 25814 <at> debbugs.gnu.org
Date: Mon, 20 Feb 2017 16:02:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-diffutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 25814 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
25814: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25814
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: [bug-diffutils] bug#25814: Windows same_file macro is not reliable
Resent-From: Eric Blake <eblake@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Mon, 20 Feb 2017 16:54:02 +0000
Resent-Message-ID: <handler.25814.B25814.148760964125703 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Kees Dekker <Kees.Dekker@HIDDEN>, 25814 <at> debbugs.gnu.org
Received: via spool by 25814-submit <at> debbugs.gnu.org id=B25814.148760964125703
          (code B ref 25814); Mon, 20 Feb 2017 16:54:02 +0000
Received: (at 25814) by debbugs.gnu.org; 20 Feb 2017 16:54:01 +0000
Received: from localhost ([127.0.0.1]:47708 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cfrDt-0006gV-D5
	for submit <at> debbugs.gnu.org; Mon, 20 Feb 2017 11:54:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47940)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eblake@HIDDEN>) id 1cfrDr-0006gI-1a
 for 25814 <at> debbugs.gnu.org; Mon, 20 Feb 2017 11:53:59 -0500
Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com
 [10.5.11.28])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 3BB5463322;
 Mon, 20 Feb 2017 16:53:54 +0000 (UTC)
Received: from [10.10.123.67] (unknown [10.10.123.67])
 by smtp.corp.redhat.com (Postfix) with ESMTP id CB6286D13B;
 Mon, 20 Feb 2017 16:53:53 +0000 (UTC)
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
From: Eric Blake <eblake@HIDDEN>
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
Organization: Red Hat, Inc.
Message-ID: <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
Date: Mon, 20 Feb 2017 10:53:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="fn0PIjd1eILJCMA9Qv8M1SCJE0XDm6juk"
X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.39]); Mon, 20 Feb 2017 16:53:54 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--fn0PIjd1eILJCMA9Qv8M1SCJE0XDm6juk
Content-Type: multipart/mixed; boundary="UlJhvbwO8w5CeXMUCUeBCXv0eBHFmJUEt";
 protected-headers="v1"
From: Eric Blake <eblake@HIDDEN>
To: Kees Dekker <Kees.Dekker@HIDDEN>, 25814 <at> debbugs.gnu.org
Message-ID: <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
Subject: Re: [bug-diffutils] bug#25814: Windows same_file macro is not
 reliable
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
In-Reply-To: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>

--UlJhvbwO8w5CeXMUCUeBCXv0eBHFmJUEt
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/20/2017 10:01 AM, Kees Dekker wrote:
> Hi,
>=20
> On file systems that do not support inodes (e.g. NTFS,

NTFS supports inodes; Cygwin uses them.  Just because Window's native
stat() is broken does not mean NTFS is broken.

> because not everything is POSIX), the same_file() macro (in system.h) i=
s incorrect as st_ino (and probably st_dev) are meaningless.

Rather, instead of ignoring inode, it would be nicer (but indeed a more
complex task) to have gnulib work around window's broken stat() to
provide a version that works instead.  It only matters for file systems
that support hard links (like NTFS); on file systems like FAT that lack
hard links, hard-coding that inodes don't work is okay, but on NTFS
where hard-links are supported, treating same_file() as always returning
0 gives wrong results.

At any rate, this is an issue that needs to be resolved in gnulib, as
more than just diffutils is affected by it.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--UlJhvbwO8w5CeXMUCUeBCXv0eBHFmJUEt--

--fn0PIjd1eILJCMA9Qv8M1SCJE0XDm6juk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJYqx8fAAoJEKeha0olJ0NqNZQH/1Av9ZpLrz8NY36ICt0Vqh7P
GEPNRwK8cHO7USc1EKeqyd04pOLUthMUAVVie1xr31PJfWkoEadhLFaqEoe9Hy9Y
AhcvBzSOjOJbNhRwpIANdirq5TEZHvBnfIX4iFWGiO59a+N+zMPkwDtoQ+KwZ7ch
JxmMaMpEerWhdkEDjMGvTA72hDUyKcQyI5xQ0axAKvumstq+yQHJt9o1+eWNw4nG
2HQVGCUjJ5XpD87GvtpWUDMh8EgGq4ba07VaiU2rCJSE5zk0QQwO97QxjRklUhrt
oJDUbvtReNcNJyQ/w+lweFyboSVgFsBKvh/hZHab+2cZXViTMUGRoKsGaQa1iEY=
=CPNm
-----END PGP SIGNATURE-----

--fn0PIjd1eILJCMA9Qv8M1SCJE0XDm6juk--




Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: [bug-diffutils] bug#25814: Windows same_file macro is not reliable
Resent-From: Kees Dekker <Kees.Dekker@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Tue, 21 Feb 2017 09:22:02 +0000
Resent-Message-ID: <handler.25814.B25814.14876688986421 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Eric Blake <eblake@HIDDEN>, "25814 <at> debbugs.gnu.org" <25814 <at> debbugs.gnu.org>
Received: via spool by 25814-submit <at> debbugs.gnu.org id=B25814.14876688986421
          (code B ref 25814); Tue, 21 Feb 2017 09:22:02 +0000
Received: (at 25814) by debbugs.gnu.org; 21 Feb 2017 09:21:38 +0000
Received: from localhost ([127.0.0.1]:48204 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cg6de-0001fV-AA
	for submit <at> debbugs.gnu.org; Tue, 21 Feb 2017 04:21:38 -0500
Received: from nlsmtpp2.infor.com ([194.149.81.57]:28118)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Kees.Dekker@HIDDEN>) id 1cg6dd-0001fJ-85
 for 25814 <at> debbugs.gnu.org; Tue, 21 Feb 2017 04:21:37 -0500
X-SBRS: None
X-IronPort-AV: E=Sophos;i="5.35,189,1484002800"; d="scan'208";a="223816507"
From: Kees Dekker <Kees.Dekker@HIDDEN>
Thread-Topic: [bug-diffutils] bug#25814: Windows same_file macro is not
 reliable
Thread-Index: AdKLb5IYqfAagsvkQrusM8I69coRpQAIfWWAACP/ThA=
Date: Tue, 21 Feb 2017 09:21:29 +0000
Message-ID: <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
 <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
In-Reply-To: <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
Accept-Language: nl-NL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.21.104.113]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

PiBOVEZTIHN1cHBvcnRzIGlub2RlczsgQ3lnd2luIHVzZXMgdGhlbS4gIEp1c3QgYmVjYXVzZSBX
aW5kb3cncyBuYXRpdmUNCj4gc3RhdCgpIGlzIGJyb2tlbiBkb2VzIG5vdCBtZWFuIE5URlMgaXMg
YnJva2VuLg0KDQpOVEZTIGlzIG5vdCBicm9rZW4sIGJ1dCBhY2NvcmRpbmcgdG8gTVNETiwgaXQg
ZG9lcyBub3Qgc3VwcG9ydCBpbm9kZXMuIFRoZSBmYWN0IHRoYXQgQ3lnd2luIHN1cHBvcnRzIGlz
LCBpcyBtb3JlIGhvdyBDeWd3aW4gaW1wbGVtZW50ZWQgZnN0YXQvc3RydWN0IGZzdGF0IChtb3Jl
IGluIHRoZSAqTklYIHdheSkuIFNpbmNlIEN5Z3dpbiBpcyBub3QgYW4gb3B0aW9uIGZvciB1cyAo
ZXZlcnl0aGluZyBpcyBuYXRpdmUgV2luZG93cy9WaXN1YWwgU3R1ZGlvKSwgaXQgZG9lcyBub3Qg
aGVscCBtZSBpbiBzYXlpbmcgJ0N5Z3dpbiBpcyBhIHNvbHV0aW9uJy4gSSBrbm93IHRoYXQgdGhl
IEdOVSBndXlzIGxpa2UgQ3lnd2luLCBidXQgb24gV2luZG93cywgaXQgaXMgYmV5b25kIHJlYWxp
dHkgdG8gZXhwZWN0IHRoYXQgQ3lnd2luIG9uIFdpbmRvd3MgaXMgYSBzeW5vbnltIHRvIG5hdGl2
ZSBXaW5kb3dzLiBJdCBpcyBub3QuDQoNCj4+IGJlY2F1c2Ugbm90IGV2ZXJ5dGhpbmcgaXMgUE9T
SVgpLCB0aGUgc2FtZV9maWxlKCkgbWFjcm8gKGluIHN5c3RlbS5oKSBpcyBpbmNvcnJlY3QgYXMg
c3RfaW5vIChhbmQgcHJvYmFibHkgc3RfZGV2KSBhcmUgbWVhbmluZ2xlc3MuDQoNCj5SYXRoZXIs
IGluc3RlYWQgb2YgaWdub3JpbmcgaW5vZGUsIGl0IHdvdWxkIGJlIG5pY2VyIChidXQgaW5kZWVk
IGEgbW9yZQ0KPmNvbXBsZXggdGFzaykgdG8gaGF2ZSBnbnVsaWIgd29yayBhcm91bmQgd2luZG93
J3MgYnJva2VuIHN0YXQoKSB0bw0KPnByb3ZpZGUgYSB2ZXJzaW9uIHRoYXQgd29ya3MgaW5zdGVh
ZC4gIEl0IG9ubHkgbWF0dGVycyBmb3IgZmlsZSBzeXN0ZW1zDQo+dGhhdCBzdXBwb3J0IGhhcmQg
bGlua3MgKGxpa2UgTlRGUyk7IG9uIGZpbGUgc3lzdGVtcyBsaWtlIEZBVCB0aGF0IGxhY2sNCj5o
YXJkIGxpbmtzLCBoYXJkLWNvZGluZyB0aGF0IGlub2RlcyBkb24ndCB3b3JrIGlzIG9rYXksIGJ1
dCBvbiBOVEZTDQo+d2hlcmUgaGFyZC1saW5rcyBhcmUgc3VwcG9ydGVkLCB0cmVhdGluZyBzYW1l
X2ZpbGUoKSBhcyBhbHdheXMgcmV0dXJuaW5nDQo+MCBnaXZlcyB3cm9uZyByZXN1bHRzLg0KDQo+
QXQgYW55IHJhdGUsIHRoaXMgaXMgYW4gaXNzdWUgdGhhdCBuZWVkcyB0byBiZSByZXNvbHZlZCBp
biBnbnVsaWIsIGFzDQo+bW9yZSB0aGFuIGp1c3QgZGlmZnV0aWxzIGlzIGFmZmVjdGVkIGJ5IGl0
Lg0KDQpJIGRvbid0IGtub3cgaG93IEN5Z3dpbiBpbXBsZW1lbnRzIHN0YXQoKSwgYnV0IG1heWJl
IHRoZXkgdXNlIHNvbWV0aGluZyBsaWtlIEdldEZpbGVJbmZvcm1hdGlvbkJ5SGFuZGxlKCkgKHNl
ZTogaHR0cHM6Ly9tc2RuLm1pY3Jvc29mdC5jb20vbmwtbmwvbGlicmFyeS93aW5kb3dzL2Rlc2t0
b3AvYWEzNjM3ODgodj12cy44NSkuYXNweCkuIEFueWhvdywgaXQgd291bGQgYmUgYSBnb29kIGlk
ZWEgdG8gaW1wcm92ZSBnbnVsaWIgZm9yIHN1cHBvcnQgKGlmIHlvdSBsaWtlIHRvIGNvcnNldCBX
aW5kb3dzIGluIGEgUE9TSVggZm9ybSksIGJ1dCB0aGUgZml4IGluIGRpZmYgaXMgbm93IHZlcnkg
c2ltcGxlLiBKdXN0IHJld3JpdGUgdGhlIG1hY3JvcyBhcyBJIGRlc2NyaWJlZCBiZWZvcmUuIEZv
ciB0aGUgbG9uZ2VyIHRlcm0sIGl0IG1heSBiZSB3b3J0aCB0byB3YWl0IGZvciBhIGdudWxpYiBm
aXgsIGJ1dCB0aGF0IGlzIChmb3IgbWUgZm9yIG5vdykgdG9vIGxvbmcgdG8gd2FpdC4gSSdtIG5v
dCB1bmRlcnN0YW5kaW5nIHdoeSByZXR1cm5pbmcgMCBmb3Igc2FtZV9maWxlIGNhdXNlcyBwcm9i
bGVtcy4gSXQganVzdCByZXN1bHRzIGluIGFuIGFjdHVhbCBjb21wYXJlLiBUaGF0IGlzIHNvbWUg
aW5lZmZpY2llbmN5LCBidXQgbm90IGVycm9uZW91cyBpc24ndCBpdD8NCg0KUmVnYXJkcywNCktl
ZXMNCg0KDQoNCg==




Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: [bug-diffutils] bug#25814: Windows same_file macro is not reliable
Resent-From: Eric Blake <eblake@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Tue, 21 Feb 2017 14:19:01 +0000
Resent-Message-ID: <handler.25814.B25814.14876867377146 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Kees Dekker <Kees.Dekker@HIDDEN>, "25814 <at> debbugs.gnu.org" <25814 <at> debbugs.gnu.org>
Received: via spool by 25814-submit <at> debbugs.gnu.org id=B25814.14876867377146
          (code B ref 25814); Tue, 21 Feb 2017 14:19:01 +0000
Received: (at 25814) by debbugs.gnu.org; 21 Feb 2017 14:18:57 +0000
Received: from localhost ([127.0.0.1]:48409 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cgBHL-0001rB-Vd
	for submit <at> debbugs.gnu.org; Tue, 21 Feb 2017 09:18:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55372)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eblake@HIDDEN>) id 1cgBHJ-0001qx-Pn
 for 25814 <at> debbugs.gnu.org; Tue, 21 Feb 2017 09:18:54 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 20E1E4E024;
 Tue, 21 Feb 2017 14:18:49 +0000 (UTC)
Received: from [10.10.123.67] (ovpn-123-67.rdu2.redhat.com [10.10.123.67] (may
 be forged))
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 v1LEIldu009952; Tue, 21 Feb 2017 09:18:48 -0500
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
 <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
 <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
From: Eric Blake <eblake@HIDDEN>
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
Organization: Red Hat, Inc.
Message-ID: <6e685363-1a99-c407-e44e-6c877765a376@HIDDEN>
Date: Tue, 21 Feb 2017 08:18:46 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="gMGK38tfFdrFuxp3Km8XQrrshShGrjr09"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Tue, 21 Feb 2017 14:18:49 +0000 (UTC)
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gMGK38tfFdrFuxp3Km8XQrrshShGrjr09
Content-Type: multipart/mixed; boundary="2LAqbX6nGtuIcS4pWjeMK8fIdHghNLP9s";
 protected-headers="v1"
From: Eric Blake <eblake@HIDDEN>
To: Kees Dekker <Kees.Dekker@HIDDEN>,
 "25814 <at> debbugs.gnu.org" <25814 <at> debbugs.gnu.org>
Message-ID: <6e685363-1a99-c407-e44e-6c877765a376@HIDDEN>
Subject: Re: [bug-diffutils] bug#25814: Windows same_file macro is not
 reliable
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
 <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
 <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
In-Reply-To: <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>

--2LAqbX6nGtuIcS4pWjeMK8fIdHghNLP9s
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/21/2017 03:21 AM, Kees Dekker wrote:
>> NTFS supports inodes; Cygwin uses them.  Just because Window's native
>> stat() is broken does not mean NTFS is broken.
>=20
> NTFS is not broken, but according to MSDN, it does not support inodes. =
The fact that Cygwin supports is, is more how Cygwin implemented fstat/st=
ruct fstat (more in the *NIX way). Since Cygwin is not an option for us (=
everything is native Windows/Visual Studio), it does not help me in sayin=
g 'Cygwin is a solution'. I know that the GNU guys like Cygwin, but on Wi=
ndows, it is beyond reality to expect that Cygwin on Windows is a synonym=
 to native Windows. It is not.

[Please configure your mailer to wrap long lines]

I didn't say you had to use Cygwin, but was rather pointing out that
Cygwin is able to implement stat() on top of NTFS in a manner that
exposes NTFS' native inodes, so the native inodes exist and are
available through native Windows API (how else would cygwin be able to
get it).  And therefore it should be possible to write a gnulib stat()
replacement for mingw that uses the same tricks as cygwin uses to get at
the raw NTFS inode information.

>> At any rate, this is an issue that needs to be resolved in gnulib, as
>> more than just diffutils is affected by it.
>=20
> I don't know how Cygwin implements stat(),

It's open source, so you can find out by reading the source code.

https://cygwin.com/git/gitweb.cgi?p=3Dnewlib-cygwin.git;a=3Dblob;f=3Dwins=
up/cygwin/fhandler_disk_file.cc#l220

inline ino_t
path_conv::get_ino_by_handle (HANDLE hdl)
{
  IO_STATUS_BLOCK io;
  FILE_INTERNAL_INFORMATION fii;

  if (NT_SUCCESS (NtQueryInformationFile (hdl, &io, &fii, sizeof fii,
                                          FileInternalInformation))
      && isgood_inode (fii.IndexNumber.QuadPart))
    return fii.IndexNumber.QuadPart;
  return 0;
}

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--2LAqbX6nGtuIcS4pWjeMK8fIdHghNLP9s--

--gMGK38tfFdrFuxp3Km8XQrrshShGrjr09
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJYrExGAAoJEKeha0olJ0Nq0RIH/RP9D8GWfICLalmLSS6HJTLo
vHQ/s4it3u4AnOFw7ejEjpTgD5gGjqaoxt8F4ZtUqAgWmu3UMS8qbpxglWacs/As
uFOsWkGSz9tkpmuntUh/+nldm/gn21ieAq1Za7wyQmVO8nNZeSebIKqUrZRBangi
RrFgxwa+j5bzWhghfenm9C3jWYPhuefkluXBpFMR5bV5jlFZkxKa5d+s9+uhJblF
0UeuyRGtBa1nlwgPkpnaC/eqEvCiVdE/ryusmQRHXWptLmgB1JAFbgFa+D7hHpjA
4K/f87o7xKI+L1uIrQlraNN7x6zMH6IYeKbY661NL6aEzuP/tFdp1ZkyDf0dwmo=
=aKIw
-----END PGP SIGNATURE-----

--gMGK38tfFdrFuxp3Km8XQrrshShGrjr09--




Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: [bug-diffutils] bug#25814: bug#25814: Windows same_file macro is not reliable
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Tue, 21 Feb 2017 16:32:02 +0000
Resent-Message-ID: <handler.25814.B25814.148769466519610 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Kees Dekker <Kees.Dekker@HIDDEN>, Eric Blake <eblake@HIDDEN>, "25814 <at> debbugs.gnu.org" <25814 <at> debbugs.gnu.org>
Received: via spool by 25814-submit <at> debbugs.gnu.org id=B25814.148769466519610
          (code B ref 25814); Tue, 21 Feb 2017 16:32:02 +0000
Received: (at 25814) by debbugs.gnu.org; 21 Feb 2017 16:31:05 +0000
Received: from localhost ([127.0.0.1]:49100 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cgDLF-00056E-Kw
	for submit <at> debbugs.gnu.org; Tue, 21 Feb 2017 11:31:05 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39716)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1cgDLE-00055k-M1
 for 25814 <at> debbugs.gnu.org; Tue, 21 Feb 2017 11:31:05 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9366816007F;
 Tue, 21 Feb 2017 08:30:58 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id 2wRCeRM0-iqi; Tue, 21 Feb 2017 08:30:58 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id EA7D016010C;
 Tue, 21 Feb 2017 08:30:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id 8F0MejVR0IST; Tue, 21 Feb 2017 08:30:57 -0800 (PST)
Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D16B916007F;
 Tue, 21 Feb 2017 08:30:57 -0800 (PST)
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
 <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
 <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
Message-ID: <4b2bd9d8-f59d-855d-a1ba-7fdbaa78279f@HIDDEN>
Date: Tue, 21 Feb 2017 08:30:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

On 02/21/2017 01:21 AM, Kees Dekker wrote:
> the fix in diff is now very simple

That may be, but it's bad software engineering practice to apply a bunch 
of painful-to-maintain "simple" changes to diffutils and other programs 
when the real problem is elsewhere. Let's fix the real problem. Surely 
it is a simple fix to Gnulib.





Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: [bug-diffutils] bug#25814: bug#25814: Windows same_file macro is not reliable
Resent-From: Kees Dekker <Kees.Dekker@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Tue, 21 Feb 2017 16:33:02 +0000
Resent-Message-ID: <handler.25814.B25814.148769475519743 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Paul Eggert <eggert@HIDDEN>, Eric Blake <eblake@HIDDEN>, "25814 <at> debbugs.gnu.org" <25814 <at> debbugs.gnu.org>
Received: via spool by 25814-submit <at> debbugs.gnu.org id=B25814.148769475519743
          (code B ref 25814); Tue, 21 Feb 2017 16:33:02 +0000
Received: (at 25814) by debbugs.gnu.org; 21 Feb 2017 16:32:35 +0000
Received: from localhost ([127.0.0.1]:49104 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cgDMg-00058N-VM
	for submit <at> debbugs.gnu.org; Tue, 21 Feb 2017 11:32:35 -0500
Received: from nlsmtpp2.infor.com ([194.149.81.57]:50650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <Kees.Dekker@HIDDEN>) id 1cgDMf-000587-Ti
 for 25814 <at> debbugs.gnu.org; Tue, 21 Feb 2017 11:32:34 -0500
X-SBRS: None
X-IronPort-AV: E=Sophos;i="5.35,190,1484002800"; d="scan'208";a="223931022"
From: Kees Dekker <Kees.Dekker@HIDDEN>
Thread-Topic: [bug-diffutils] bug#25814: bug#25814: Windows same_file macro
 is not reliable
Thread-Index: AQHSjF/x02OQud1swUqX8AekjEBf/aFzpz+A
Date: Tue, 21 Feb 2017 16:32:26 +0000
Message-ID: <858F859BB4F2824EBAB5D4ED58214CB7016A45626E@HIDDEN>
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
 <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
 <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
 <4b2bd9d8-f59d-855d-a1ba-7fdbaa78279f@HIDDEN>
In-Reply-To: <4b2bd9d8-f59d-855d-a1ba-7fdbaa78279f@HIDDEN>
Accept-Language: nl-NL, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.21.104.113]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Spam-Score: -0.6 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.6 (/)

DQo+VGhhdCBtYXkgYmUsIGJ1dCBpdCdzIGJhZCBzb2Z0d2FyZSBlbmdpbmVlcmluZyBwcmFjdGlj
ZSB0byBhcHBseSBhIGJ1bmNoIA0KPm9mIHBhaW5mdWwtdG8tbWFpbnRhaW4gInNpbXBsZSIgY2hh
bmdlcyB0byBkaWZmdXRpbHMgYW5kIG90aGVyIHByb2dyYW1zIA0KPndoZW4gdGhlIHJlYWwgcHJv
YmxlbSBpcyBlbHNld2hlcmUuIExldCdzIGZpeCB0aGUgcmVhbCBwcm9ibGVtLiBTdXJlbHkgDQo+
aXQgaXMgYSBzaW1wbGUgZml4IHRvIEdudWxpYi4NCg0KSSdtIHVuZm9ydHVuYXRlbHkgbGFja2lu
ZyBvZiB0aW1lLiBEbyBJIG5lZWQgdG8gZG8gc29tZXRoaW5nIGVsc2UgdG8gcHV0IHRoaXMgb24g
YSBUT0RPIGxpc3Qgb2YgR251bGliPw0KDQo=




Message sent to bug-diffutils@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: bug#25814: [bug-diffutils] bug#25814: bug#25814: Windows same_file macro is not reliable
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-diffutils@HIDDEN
Resent-Date: Tue, 21 Feb 2017 16:58:02 +0000
Resent-Message-ID: <handler.25814.B25814.148769626221923 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 25814
X-GNU-PR-Package: diffutils
X-GNU-PR-Keywords: 
To: Kees Dekker <Kees.Dekker@HIDDEN>, Eric Blake <eblake@HIDDEN>, "25814 <at> debbugs.gnu.org" <25814 <at> debbugs.gnu.org>
Received: via spool by 25814-submit <at> debbugs.gnu.org id=B25814.148769626221923
          (code B ref 25814); Tue, 21 Feb 2017 16:58:02 +0000
Received: (at 25814) by debbugs.gnu.org; 21 Feb 2017 16:57:42 +0000
Received: from localhost ([127.0.0.1]:49122 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1cgDkz-0005hX-PD
	for submit <at> debbugs.gnu.org; Tue, 21 Feb 2017 11:57:41 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44594)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1cgDkx-0005hJ-JY
 for 25814 <at> debbugs.gnu.org; Tue, 21 Feb 2017 11:57:39 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 27EA816010D;
 Tue, 21 Feb 2017 08:57:34 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id 0KQbxtHMm2-P; Tue, 21 Feb 2017 08:57:33 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7360616010C;
 Tue, 21 Feb 2017 08:57:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id Nc76TipMCPbe; Tue, 21 Feb 2017 08:57:33 -0800 (PST)
Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5C50616010A;
 Tue, 21 Feb 2017 08:57:33 -0800 (PST)
References: <858F859BB4F2824EBAB5D4ED58214CB7016A4559B1@HIDDEN>
 <d9291b09-3fee-5223-57aa-742b60df3faa@HIDDEN>
 <858F859BB4F2824EBAB5D4ED58214CB7016A455E28@HIDDEN>
 <4b2bd9d8-f59d-855d-a1ba-7fdbaa78279f@HIDDEN>
 <858F859BB4F2824EBAB5D4ED58214CB7016A45626E@HIDDEN>
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
Message-ID: <a688627e-7f16-abbc-033c-49c1dc69c3a1@HIDDEN>
Date: Tue, 21 Feb 2017 08:57:33 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <858F859BB4F2824EBAB5D4ED58214CB7016A45626E@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

On 02/21/2017 08:32 AM, Kees Dekker wrote:
> Do I need to do something else to put this on a TODO list of Gnulib?

I suggest sending email to bug-gnulib@HIDDEN It should be 
self-contained, i.e., assume readers are unfamiliar with this thread.






Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.