GNU bug report logs - #25836
[PATCH] gnu: Add gspell

unarchive 25836

From: Catonano <catonano <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add gspell
Date: Wed, 22 Feb 2017 16:26:04 +0100

[Message part 1 (text/plain, inline)]
tests are disabled because they fail

I left a pair of attempts I made, commented out

Also, a link to the gspell mailing list where I asked for help

[Message part 2 (text/html, inline)]
[0001-gnu-Add-gspell.patch (application/octet-stream, attachment)]
From: Catonano <catonano <at> gmail.com>
To: 25836 <at> debbugs.gnu.org
Subject: Re: bug#25836: Acknowledgement ([PATCH] gnu: Add gspell)
Date: Wed, 22 Feb 2017 16:41:03 +0100

[Message part 1 (text/plain, inline)]
I already found a mistake.

The license is LGPL 2.1, not GPL 2.1

[Message part 2 (text/html, inline)]
From: ludo <at> gnu.org (Ludovic Courtès)
To: Catonano <catonano <at> gmail.com>
Cc: 25836 <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Fri, 10 Mar 2017 11:57:12 +0100

Hi Catonano,

Thanks for the patch.  I’ve modified the package like this:

--8<---------------cut here---------------start------------->8---
(define-public gspell
  (package
    (name "gspell")
    (version "1.3.2")
    (source (origin
              (method url-fetch)
              (uri (string-append "mirror://gnome/sources/" name "/"
                                  (version-major+minor version) "/"
                                  name "-" version ".tar.xz"))
              (sha256
               (base32
                "1n4kd5i11l79h8bpvx3cz79ww0b4z89y99h4czvyg80qlarn585w"))))
    (build-system glib-or-gtk-build-system)
    (arguments
     '(#:phases
       (modify-phases %standard-phases
         (add-before 'check 'pre-check
           (lambda* (#:key inputs #:allow-other-keys)
             ;; Tests require a running X server.
             (system "Xvfb :1 &")
             (setenv "DISPLAY" ":1")

             ;; For the missing /etc/machine-id.
             (setenv "DBUS_FATAL_WARNINGS" "0")

             ;; Allow Enchant and its Aspell backend to find the en_US
             ;; dictionary.
             (setenv "ASPELL_CONF"
                     (string-append "dict-dir "
                                    (assoc-ref inputs "aspell-dict-en")
                                    "/lib/aspell"))
             #t)))))
    (inputs
     `(("enchant" ,enchant)
       ("iso-codes" ,iso-codes)
       ("gtk+" ,gtk+)
       ("glib" ,glib)))
    (native-inputs
     `(("glib" ,glib "bin")
       ("pkg-config" ,pkg-config)
       ("xmllint" ,libxml2)

       ;; For tests.
       ("xorg-server" ,xorg-server)
       ("aspell-dict-en" ,aspell-dict-en)))
    (home-page
     "https://wiki.gnome.org/Projects/gspell")
    (synopsis "GNOME's alternative spell checker")
    (description
     "gspell provides a flexible API to add spell checking to a GTK+ application.")
    (license license:gpl2+)))
--8<---------------cut here---------------end--------------->8---

However, the tests still fail to find dictionaries as can be seen in
test-checker.log for instance:

--8<---------------cut here---------------start------------->8---
process 133: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/etc/machine-id": No such file or directory
See the manual page for dbus-uuidgen to correct this issue.
/checker/check_word: **
ERROR:../../gspell-1.3.2/testsuite/test-checker.c:32:test_check_word: assertion failed: (lang != NULL)
FAIL test-checker (exit status: 134)
--8<---------------cut here---------------end--------------->8---

(The bit about D-Bus is a harmless warning.)  The assertion failure
corresponds to:

--8<---------------cut here---------------start------------->8---
	lang = gspell_language_lookup ("en_US");
	g_assert (lang != NULL);
--8<---------------cut here---------------end--------------->8---

For some reason, ‘get_aspell_dict_info_list’ looks for things under
Aspell’s $prefix, and thus returns an empty list.

This is because ‘ASPELL_CONF’ is ignored here, contrary to what happens
when running the ‘aspell’ program.

To be continued…

Ludo’.




From: ludo <at> gnu.org (Ludovic Courtès)
To: aspell-devel <at> gnu.org
Cc: Catonano <catonano <at> gmail.com>, 25836 <at> debbugs.gnu.org
Subject: Honoring ‘ASPELL_CONF’ in libaspell
Date: Sun, 26 Mar 2017 15:52:35 +0200

[Message part 1 (text/plain, inline)]
Hello!

GNU Guix does not follow the file system hierarchy standard (FHS) and
thus does not have a “standard location” where dictionaries can be
looked for.

When using the ‘aspell’ command-line tool, that’s not a problem: users
can simply do

  export ASPELL_CONF="dict-dir $HOME/.guix-profile/lib/aspell"

and then ‘aspell’ will look for dictionaries in this place.

However, libaspell does not honor ‘ASPELL_CONF’, and thus libraries such
as Enchant that link against libaspell think there are no dictionaries
around because they’re not looking in the right place:

  https://bugs.gnu.org/25836

To work around this, I considered patching our ‘aspell’ package in Guix
such that libaspell would always honor ‘ASPELL_CONF’.  I tried this
naive patch:


[Message part 2 (text/x-patch, inline)]

--- aspell-0.60.6.1/lib/new_config.cpp	2017-03-10 11:16:56.343795853 +0100
+++ aspell-0.60.6.1/lib/new_config.cpp	2017-03-10 11:16:57.607786182 +0100
@@ -17,6 +17,10 @@ namespace acommon {
   Config * new_config() 
   {
     Config * config = new_basic_config();
+
+    // Honor 'ASPELL_CONF' unconditionally.
+    config->read_in_settings();
+
     setup_static_filters(config);
     return config;
   }

[Message part 3 (text/plain, inline)]
… but it breaks the ‘aspell’ command:

  aspell: common/config.cpp:1335: acommon::PosibErr<void> acommon::Config::set_committed_state(bool): Assertion `empty()' failed.

So two questions:

  1. What am I doing wrong in this patch?  :-)

  2. What’s your take on the general issue of this need to configure
     libaspell when its users (Enchant here) are oblivious to this
     configuration?

Thanks in advance,
Ludo’.

From: Kevin Atkinson <kevina <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Catonano <catonano <at> gmail.com>, 25836 <at> debbugs.gnu.org, aspell-devel <at> gnu.org
Subject: Re: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell
Date: Sun, 26 Mar 2017 12:57:48 -0400 (EDT)

[Message part 1 (text/plain, inline)]
Hi,

It would be better to change the compiled in defaults.  I believe
the --enable-dict-dir configure option should change the default for dict-dir.

Kevin

On Sun, 26 Mar 2017, Ludovic Courtès wrote:

> Hello!
>
> GNU Guix does not follow the file system hierarchy standard (FHS) and
> thus does not have a “standard location” where dictionaries can be
> looked for.
>
> When using the ‘aspell’ command-line tool, that’s not a problem: users
> can simply do
>
>  export ASPELL_CONF="dict-dir $HOME/.guix-profile/lib/aspell"
>
> and then ‘aspell’ will look for dictionaries in this place.
>
> However, libaspell does not honor ‘ASPELL_CONF’, and thus libraries such
> as Enchant that link against libaspell think there are no dictionaries
> around because they’re not looking in the right place:
>
>  https://bugs.gnu.org/25836
>
> To work around this, I considered patching our ‘aspell’ package in Guix
> such that libaspell would always honor ‘ASPELL_CONF’.  I tried this
> naive patch:
>
>
From: ludo <at> gnu.org (Ludovic Courtès)
To: Kevin Atkinson <kevina <at> gnu.org>
Cc: Catonano <catonano <at> gmail.com>, 25836 <at> debbugs.gnu.org, aspell-devel <at> gnu.org
Subject: Re: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell
Date: Mon, 27 Mar 2017 10:26:53 +0200

Hi Kevin,

From your reply it seems the second part of my message got lost; you can
see it at <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14>.

Kevin Atkinson <kevina <at> gnu.org> skribis:

> It would be better to change the compiled in defaults.  I believe
> the --enable-dict-dir configure option should change the default for dict-dir.

The problem is that dict-dir is typically
“$HOME/.guix-profile/lib/aspell”, so we can’t choose it at configure
time (unless Aspell expands “$HOME”?).

Even if we did, we’d like to offer users the ability to choose
dictionaries located in a different place.

How would you achieve that?

Thanks for your reply,
Ludo’.




From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: 25836 <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Thu, 30 Mar 2017 13:57:29 +0200

ludo <at> gnu.org (Ludovic Courtès) writes:

> Thanks for the patch.  I’ve modified the package like this:
>
> [...]
>     (inputs
>      `(("enchant" ,enchant)
>        ("iso-codes" ,iso-codes)
>        ("gtk+" ,gtk+)
>        ("glib" ,glib)))
>     (native-inputs
>      `(("glib" ,glib "bin")
>        ("pkg-config" ,pkg-config)
>        ("xmllint" ,libxml2)
>
>        ;; For tests.
>        ("xorg-server" ,xorg-server)
>        ("aspell-dict-en" ,aspell-dict-en)))

Just for reference, for when we solve the dictionary issue:

While experimenting with this package and (unsuccessfully) trying to get
it to find aspell dictionaries, I also noticed we could add the
following native inputs:

+       ("docbook-xsl" ,docbook-xsl)
+       ("gobject-introspection" ,gobject-introspection)
+       ("gtk-doc" ,gtk-doc)
+       ("vala" ,vala)
        ("glib" ,glib "bin")
        ("pkg-config" ,pkg-config)
        ("xmllint" ,libxml2)
        ("xorg-server" ,xorg-server)))

and the following configure flag to build docs:

+       #:configure-flags '("--enable-gtk-doc")

I'm not really familiar with the gobject system, but I suppose
generating the bindings is useful? :)

Thomas




From: Catonano <catonano <at> gmail.com>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: 25836 <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Thu, 30 Mar 2017 14:08:27 +0200

[Message part 1 (text/plain, inline)]
I believe it's worthwhile to make this known to the guix reviewers community
https://lists.gnu.org/archive/html/aspell-devel/2017-03/msg00003.html

Hope this helps

Ciao ! :-)


2017-03-30 13:57 GMT+02:00 Thomas Danckaert <post <at> thomasdanckaert.be>:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
> > Thanks for the patch.  I’ve modified the package like this:
> >
> > [...]
> >     (inputs
> >      `(("enchant" ,enchant)
> >        ("iso-codes" ,iso-codes)
> >        ("gtk+" ,gtk+)
> >        ("glib" ,glib)))
> >     (native-inputs
> >      `(("glib" ,glib "bin")
> >        ("pkg-config" ,pkg-config)
> >        ("xmllint" ,libxml2)
> >
> >        ;; For tests.
> >        ("xorg-server" ,xorg-server)
> >        ("aspell-dict-en" ,aspell-dict-en)))
>
> Just for reference, for when we solve the dictionary issue:
>
> While experimenting with this package and (unsuccessfully) trying to get
> it to find aspell dictionaries, I also noticed we could add the
> following native inputs:
>
> +       ("docbook-xsl" ,docbook-xsl)
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("gtk-doc" ,gtk-doc)
> +       ("vala" ,vala)
>         ("glib" ,glib "bin")
>         ("pkg-config" ,pkg-config)
>         ("xmllint" ,libxml2)
>         ("xorg-server" ,xorg-server)))
>
> and the following configure flag to build docs:
>
> +       #:configure-flags '("--enable-gtk-doc")
>
> I'm not really familiar with the gobject system, but I suppose
> generating the bindings is useful? :)
>
> Thomas
>
>
>
>

[Message part 2 (text/html, inline)]
From: Catonano <catonano <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 25836 <at> debbugs.gnu.org, Kevin Atkinson <kevina <at> gnu.org>,
 aspell-devel <at> gnu.org
Subject: Re: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell
Date: Wed, 3 May 2017 18:49:41 +0200

[Message part 1 (text/plain, inline)]
2017-03-27 10:26 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org>:

> Hi Kevin,
>
> From your reply it seems the second part of my message got lost; you can
> see it at <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14>.
>
> Kevin Atkinson <kevina <at> gnu.org> skribis:
>
> > It would be better to change the compiled in defaults.  I believe
> > the --enable-dict-dir configure option should change the default for
> dict-dir.
>
> The problem is that dict-dir is typically
> “$HOME/.guix-profile/lib/aspell”, so we can’t choose it at configure
> time (unless Aspell expands “$HOME”?).
>
> Even if we did, we’d like to offer users the ability to choose
> dictionaries located in a different place.
>
> How would you achieve that?
>
> Thanks for your reply,
> Ludo’.
>


ehm, are there any news on this ?

[Message part 2 (text/html, inline)]
From: Kevin Atkinson <kevina <at> gnu.org>
To: Catonano <catonano <at> gmail.com>, Ludovic Courtès
 <ludo <at> gnu.org>
Cc: 25836 <at> debbugs.gnu.org, aspell-devel <at> gnu.org
Subject: Re: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell
Date: Wed, 3 May 2017 14:14:08 -0400

[Message part 1 (text/plain, inline)]
Sorry,

For compiled in defaults there is some support for expansion, see 
Config::get_default() in common/config.cpp.  In particular the following 
should work: "<$HOME|.>/.guix-profile/lib/aspell. Due to the way the 
code is written an alternative must always be given, in particular 
"<$HOME>/.guix-profile/lib/aspell" is unlikely to work.  You could also 
use: "<home-dir>/.guix-profile/lib/aspell".  Note that the expansion is 
only for compiled in defaults, if the value is manually set, then there 
is no expansion.

When you do "aspell --config" it will print the defaults and then also 
what it expands to.

On 05/03/2017 12:49 PM, Catonano wrote:
> 2017-03-27 10:26 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org 
> <mailto:ludo <at> gnu.org>>:
>
>     Hi Kevin,
>
>     From your reply it seems the second part of my message got lost;
>     you can
>     see it at <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14
>     <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25836#14>>.
>
>     Kevin Atkinson <kevina <at> gnu.org <mailto:kevina <at> gnu.org>> skribis:
>
>     > It would be better to change the compiled in defaults.  I believe
>     > the --enable-dict-dir configure option should change the default
>     for dict-dir.
>
>     The problem is that dict-dir is typically
>     “$HOME/.guix-profile/lib/aspell”, so we can’t choose it at configure
>     time (unless Aspell expands “$HOME”?).
>
>     Even if we did, we’d like to offer users the ability to choose
>     dictionaries located in a different place.
>
>     How would you achieve that?
>
>     Thanks for your reply,
>     Ludo’.
>
>
>
> ehm, are there any news on this ?
>
>
> _______________________________________________
> Aspell-devel mailing list
> Aspell-devel <at> gnu.org
> https://lists.gnu.org/mailman/listinfo/aspell-devel


[Message part 2 (text/html, inline)]
From: ludo <at> gnu.org (Ludovic Courtès)
To: Kevin Atkinson <kevina <at> gnu.org>
Cc: Catonano <catonano <at> gmail.com>, 25836 <at> debbugs.gnu.org, aspell-devel <at> gnu.org
Subject: Re: bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell
Date: Wed, 17 May 2017 16:21:40 +0200

Hi Kevin,

Kevin Atkinson <kevina <at> gnu.org> skribis:

> For compiled in defaults there is some support for expansion, see
> Config::get_default() in common/config.cpp.  In particular the
> following should work: "<$HOME|.>/.guix-profile/lib/aspell. Due to the
> way the code is written an alternative must always be given, in
> particular "<$HOME>/.guix-profile/lib/aspell" is unlikely to work.
> You could also use: "<home-dir>/.guix-profile/lib/aspell".  Note that
> the expansion is only for compiled in defaults, if the value is
> manually set, then there is no expansion.
>
> When you do "aspell --config" it will print the defaults and then also
> what it expands to.

Thanks for the tips.  I ended up using something similar to what you
suggest:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6d35b1c99c15f87a30fdf1a38c88db844b3e8303

Ludo’.




From: ludo <at> gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post <at> thomasdanckaert.be>, Catonano <catonano <at> gmail.com>
Cc: 25836-done <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Wed, 17 May 2017 16:24:18 +0200

Hi,

I just pushed gspell as 411ba511893feca223656122059cb12378b95c91,
finally!  \o/

Thomas Danckaert <post <at> thomasdanckaert.be> skribis:

> Just for reference, for when we solve the dictionary issue:
>
> While experimenting with this package and (unsuccessfully) trying to get
> it to find aspell dictionaries, I also noticed we could add the
> following native inputs:
>
> +       ("docbook-xsl" ,docbook-xsl)
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("gtk-doc" ,gtk-doc)
> +       ("vala" ,vala)
>         ("glib" ,glib "bin")
>         ("pkg-config" ,pkg-config)
>         ("xmllint" ,libxml2)
>         ("xorg-server" ,xorg-server)))
>
> and the following configure flag to build docs:
>
> +       #:configure-flags '("--enable-gtk-doc")
>
> I'm not really familiar with the gobject system, but I suppose
> generating the bindings is useful? :)

For now we don’t have any users of gspell at all, let alone users of its
Vala bindings, so perhaps we can leave it as is?

Building the docs to a separate “doc” output could be marginally useful,
I think.

WDYT?

Thanks,
Ludo’.




From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: ludo <at> gnu.org
Cc: catonano <at> gmail.com, 25836 <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Wed, 17 May 2017 17:16:26 +0200 (CEST)

From: ludo <at> gnu.org (Ludovic Courtès)
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Wed, 17 May 2017 16:24:18 +0200

>> I'm not really familiar with the gobject system, but I suppose
>> generating the bindings is useful? :)
>
> For now we don’t have any users of gspell at all, let alone users 
> of its
> Vala bindings, so perhaps we can leave it as is?
>
> Building the docs to a separate “doc” output could be marginally 
> useful,
> I think.

For me, it's me as it is.  I have no use for those bindings or the 
documentation myself.  I just stumbled upon them while trying to 
debug the package, and thought I'd mention it just in case.

When I submit a package, I usually try to enable as many options as I 
can, even though I don't use them myself, just in case someone might 
need them.  Maybe this is overkill?  Is there a general 
recommendation for Guix?

Thomas

From: Catonano <catonano <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Thomas Danckaert <post <at> thomasdanckaert.be>, 25836-done <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Wed, 17 May 2017 19:22:57 +0200

[Message part 1 (text/plain, inline)]
2017-05-17 16:24 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org>:

> Hi,
>
> I just pushed gspell as 411ba511893feca223656122059cb12378b95c91,
> finally!  \o/
>
> Thomas Danckaert <post <at> thomasdanckaert.be> skribis:
>
> > Just for reference, for when we solve the dictionary issue:
> >
> > While experimenting with this package and (unsuccessfully) trying to get
> > it to find aspell dictionaries, I also noticed we could add the
> > following native inputs:
> >
> > +       ("docbook-xsl" ,docbook-xsl)
> > +       ("gobject-introspection" ,gobject-introspection)
> > +       ("gtk-doc" ,gtk-doc)
> > +       ("vala" ,vala)
> >         ("glib" ,glib "bin")
> >         ("pkg-config" ,pkg-config)
> >         ("xmllint" ,libxml2)
> >         ("xorg-server" ,xorg-server)))
> >
> > and the following configure flag to build docs:
> >
> > +       #:configure-flags '("--enable-gtk-doc")
> >
> > I'm not really familiar with the gobject system, but I suppose
> > generating the bindings is useful? :)
>
> For now we don’t have any users of gspell at all, let alone users of its
> Vala bindings, so perhaps we can leave it as is?
>

Originally, I wanted gspell because I understood that it's a dependency of
Polari, the Gnome chat client.

Once this aspell path thing is solved, should any bindings be necessary for
Polari, they could be added later, couldn't they ?

[Message part 2 (text/html, inline)]
From: Catonano <catonano <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Thomas Danckaert <post <at> thomasdanckaert.be>, 25836-done <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Wed, 17 May 2017 19:24:12 +0200

[Message part 1 (text/plain, inline)]
2017-05-17 19:22 GMT+02:00 Catonano <catonano <at> gmail.com>:

>
>
> 2017-05-17 16:24 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org>:
>
>> Hi,
>>
>> I just pushed gspell as 411ba511893feca223656122059cb12378b95c91,
>> finally!  \o/
>>
>> Thomas Danckaert <post <at> thomasdanckaert.be> skribis:
>>
>> > Just for reference, for when we solve the dictionary issue:
>> >
>> > While experimenting with this package and (unsuccessfully) trying to get
>> > it to find aspell dictionaries, I also noticed we could add the
>> > following native inputs:
>> >
>> > +       ("docbook-xsl" ,docbook-xsl)
>> > +       ("gobject-introspection" ,gobject-introspection)
>> > +       ("gtk-doc" ,gtk-doc)
>> > +       ("vala" ,vala)
>> >         ("glib" ,glib "bin")
>> >         ("pkg-config" ,pkg-config)
>> >         ("xmllint" ,libxml2)
>> >         ("xorg-server" ,xorg-server)))
>> >
>> > and the following configure flag to build docs:
>> >
>> > +       #:configure-flags '("--enable-gtk-doc")
>> >
>> > I'm not really familiar with the gobject system, but I suppose
>> > generating the bindings is useful? :)
>>
>> For now we don’t have any users of gspell at all, let alone users of its
>> Vala bindings, so perhaps we can leave it as is?
>>
>
> Originally, I wanted gspell because I understood that it's a dependency of
> Polari, the Gnome chat client.
>
> Once this aspell path thing is solved, should any bindings be necessary
> for Polari, they could be added later, couldn't they ?
>
>
>
Thank you so much or this, Ludo ! 🤗

[Message part 2 (text/html, inline)]
From: Kevin Atkinson <kevina <at> gnu.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Catonano <catonano <at> gmail.com>, 25836 <at> debbugs.gnu.org, aspell-devel <at> gnu.org
Subject: Re: bug#25836: [aspell-devel] Honoring ‘ASPELL_CONF’ in libaspell
Date: Wed, 17 May 2017 14:14:24 -0400

On Wed, 17 May 2017 16:21:40 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hi Kevin,
> 
> Kevin Atkinson <kevina <at> gnu.org> skribis:
> 
> > For compiled in defaults there is some support for expansion, see
> > Config::get_default() in common/config.cpp.  In particular the
> > following should work: "<$HOME|.>/.guix-profile/lib/aspell. Due to
> > the way the code is written an alternative must always be given, in
> > particular "<$HOME>/.guix-profile/lib/aspell" is unlikely to work.
> > You could also use: "<home-dir>/.guix-profile/lib/aspell".  Note
> > that the expansion is only for compiled in defaults, if the value is
> > manually set, then there is no expansion.
> >
> > When you do "aspell --config" it will print the defaults and then
> > also what it expands to.
> 
> Thanks for the tips.  I ended up using something similar to what you
> suggest:
> 
>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6d35b1c99c15f87a30fdf1a38c88db844b3e8303

If you tested it both with $ASPELL_DICT_DIR defined and without then it
looks good.

Kevin




From: ludo <at> gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: catonano <at> gmail.com, 25836 <at> debbugs.gnu.org
Subject: Re: bug#25836: [PATCH] gnu: Add gspell
Date: Wed, 17 May 2017 21:56:55 +0200

Thomas Danckaert <post <at> thomasdanckaert.be> skribis:

> From: ludo <at> gnu.org (Ludovic Courtès)
> Subject: Re: bug#25836: [PATCH] gnu: Add gspell
> Date: Wed, 17 May 2017 16:24:18 +0200
>
>>> I'm not really familiar with the gobject system, but I suppose
>>> generating the bindings is useful? :)
>>
>> For now we don’t have any users of gspell at all, let alone users of
>> its
>> Vala bindings, so perhaps we can leave it as is?
>>
>> Building the docs to a separate “doc” output could be marginally
>> useful,
>> I think.
>
> For me, it's me as it is.

Hi! Is it you?  :-)

> I have no use for those bindings or the documentation myself.  I just
> stumbled upon them while trying to debug the package, and thought I'd
> mention it just in case.
>
> When I submit a package, I usually try to enable as many options as I
> can, even though I don't use them myself, just in case someone might
> need them.  Maybe this is overkill?  Is there a general recommendation
> for Guix?

It depends!  The recommendation is to check what ‘guix size’ says and
weigh the usefulness/size ratio of the added dependency:

  https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

Ludo’.





GNU bug report logs - #25836 [PATCH] gnu: Add gspell

GNU bug report logs - #25836
[PATCH] gnu: Add gspell