GNU bug report logs - #25848
[PATCH] gnu: %bootstrap-coreutils&co: Patch egrep/fgrep to point to the correct grep.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25848 in the body.
You can then email your comments to 25848 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: guix-patches <at> gnu.org
Cc: efraim <at> flashner.co.il
Subject: [PATCH] gnu: %bootstrap-coreutils&co: Patch egrep/fgrep to point to
 the correct grep.
Date: Thu, 23 Feb 2017 13:41:18 +0200

Hello everyone, 

Commit 653add37af10b0d5dbc20c8bc7ce30eec8cf4ae7 patches egrep/fgrep to point to the location of grep. 
But the problem is that when it was run on Hurd, the path for grep in egrep/fgrep had this form: 
/gnu/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-grep-2.25/bin/grep

The above was not being substituted and caused the build to fail. So I changed the pattern to 
"/[^ ]+/bin/grep" and now the path is always replaced. 

Also (getcwd) returns the current path which the build takes place. This happens to be /tmp/guix-build-..-bootstrap-binaries-0.
This is wrong because it should point to the final place in /gnu/store. That why I am using "out".

Thank you,
Manolis

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: manolis837 <at> gmail.com,guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: %bootstrap-coreutils&co: Patch egrep/fgrep to point
 to the correct grep.
Date: Sat, 25 Feb 2017 18:58:51 +0000

On February 23, 2017 1:41:18 PM GMT+02:00, manolis837 <at> gmail.com wrote:
>
>Hello everyone, 
>
>Commit 653add37af10b0d5dbc20c8bc7ce30eec8cf4ae7 patches egrep/fgrep to
>point to the location of grep. 
>But the problem is that when it was run on Hurd, the path for grep in
>egrep/fgrep had this form: 
>/gnu/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-grep-2.25/bin/grep
>
>The above was not being substituted and caused the build to fail. So I
>changed the pattern to 
>"/[^ ]+/bin/grep" and now the path is always replaced. 
>

I also pushed a patch that patched the generated [e|f]grep to not have the path inserted into it, so the aarch64 bootstrap binaries have:
#!/bin/sh
exec grep -F...
I think we're going to have to find a way that works for both architectures. I tried using (%current-target) but I couldn't get it to work inside the snippet.

>Also (getcwd) returns the current path which the build takes place.
>This happens to be /tmp/guix-build-..-bootstrap-binaries-0.
>This is wrong because it should point to the final place in /gnu/store.
>That why I am using "out".

While that is probably better, in the end it doesn't really matter I believe, when I ran 'find /gnu -name fgrep -execdir cat {} +' it showed both bash and grep pointing to the bootstrap binaries.

>Thank you,
>Manolis

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Message #13 received at 25848 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 25848 <at> debbugs.gnu.org
Subject: [PATCH] gnu: %bootstrap-coreutils
Date: Mon, 16 Nov 2020 18:59:50 +0100

@Manolis: Does this problem still exist with all the new Hurd work from
Janneke and Co?

Message #16 received at 25848 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: manolis837 <at> gmail.com
Cc: 25848 <at> debbugs.gnu.org, efraim <at> flashner.co.il
Subject: Re: bug#25848: [PATCH] gnu: %bootstrap-coreutils&co: Patch
 egrep/fgrep to point to the correct grep.
Date: Wed, 05 Jan 2022 00:57:25 +0100

Hi Manolis,

I am doing bug triage and I hit this one [1].

1: <http://issues.guix.gnu.org/issue/25848>


On Thu, 23 Feb 2017 at 13:41, manolis837 <at> gmail.com wrote:

> Commit 653add37af10b0d5dbc20c8bc7ce30eec8cf4ae7 patches egrep/fgrep to point to the location of grep.
> But the problem is that when it was run on Hurd, the path for grep in egrep/fgrep had this form:
> /gnu/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-grep-2.25/bin/grep
>
> The above was not being substituted and caused the build to fail. So I changed the pattern to
> "/[^ ]+/bin/grep" and now the path is always replaced.
>
> Also (getcwd) returns the current path which the build takes place. This happens to be /tmp/guix-build-..-bootstrap-binaries-0.
> This is wrong because it should point to the final place in /gnu/store. That why I am using "out".

Is it still relevant after the work by janneke among many others?  And
exposed in these blog post [2,3].


2: <https://guix.gnu.org/en/blog/2020/a-hello-world-virtual-machine-running-the-hurd/>
3: <https://guix.gnu.org/en/blog/2020/childhurds-and-substitutes/>


Cheers,
simon

Message #19 received at 25848 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 25848 <at> debbugs.gnu.org, manolis837 <at> gmail.com
Subject: Re: bug#25848: [PATCH] gnu: %bootstrap-coreutils&co: Patch
 egrep/fgrep to point to the correct grep.
Date: Wed, 5 Jan 2022 10:23:17 +0200

[Message part 1 (text/plain, inline)]

On Wed, Jan 05, 2022 at 12:57:25AM +0100, zimoun wrote:
> Hi Manolis,
> 
> I am doing bug triage and I hit this one [1].
> 
> 1: <http://issues.guix.gnu.org/issue/25848>
> 
> 
> On Thu, 23 Feb 2017 at 13:41, manolis837 <at> gmail.com wrote:
> 
> > Commit 653add37af10b0d5dbc20c8bc7ce30eec8cf4ae7 patches egrep/fgrep to point to the location of grep.
> > But the problem is that when it was run on Hurd, the path for grep in egrep/fgrep had this form:
> > /gnu/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-grep-2.25/bin/grep
> >
> > The above was not being substituted and caused the build to fail. So I changed the pattern to
> > "/[^ ]+/bin/grep" and now the path is always replaced.
> >
> > Also (getcwd) returns the current path which the build takes place. This happens to be /tmp/guix-build-..-bootstrap-binaries-0.
> > This is wrong because it should point to the final place in /gnu/store. That why I am using "out".
> 
> Is it still relevant after the work by janneke among many others?  And
> exposed in these blog post [2,3].
> 
> 
> 2: <https://guix.gnu.org/en/blog/2020/a-hello-world-virtual-machine-running-the-hurd/>
> 3: <https://guix.gnu.org/en/blog/2020/childhurds-and-substitutes/>
> 

Judging that the Hurd, aarch64 and powerpc are all have Guix working on
them I assume it's working well enough that we can close this bug.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 25848-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 25848-done <at> debbugs.gnu.org, manolis837 <at> gmail.com
Subject: Re: bug#25848: [PATCH] gnu: %bootstrap-coreutils&co: Patch
 egrep/fgrep to point to the correct grep.
Date: Wed, 05 Jan 2022 10:00:54 +0100

Hi,

On Wed, 05 Jan 2022 at 10:23, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> On Wed, Jan 05, 2022 at 12:57:25AM +0100, zimoun wrote:
>> On Thu, 23 Feb 2017 at 13:41, manolis837 <at> gmail.com wrote:

> Judging that the Hurd, aarch64 and powerpc are all have Guix working on
> them I assume it's working well enough that we can close this bug.

Therefore, I am closing.


Thanks,
simon

Message #32 received at 25848-done <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 25848-done <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: bug#25848: [PATCH] gnu: %bootstrap-coreutils&co: Patch
 egrep/fgrep to point to the correct grep.
Date: Wed, 5 Jan 2022 19:23:31 +0200

[Message part 1 (text/plain, inline)]

Thank you, yes it can be closed.

On Wed, 5 Jan 2022, 11:11 zimoun, <zimon.toutoune <at> gmail.com> wrote:

> Hi,
>
> On Wed, 05 Jan 2022 at 10:23, Efraim Flashner <efraim <at> flashner.co.il>
> wrote:
> > On Wed, Jan 05, 2022 at 12:57:25AM +0100, zimoun wrote:
> >> On Thu, 23 Feb 2017 at 13:41, manolis837 <at> gmail.com wrote:
>
> > Judging that the Hurd, aarch64 and powerpc are all have Guix working on
> > them I assume it's working well enough that we can close this bug.
>
> Therefore, I am closing.
>
>
> Thanks,
> simon
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.