GNU bug report logs - #25892
24.4; gnus-after-getting-new-news-hook is not fired when running gnus-summary-rescan-group

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25892 in the body.
You can then email your comments to 25892 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Łukasz Stelmach <l.stelmach <at> samsung.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.4; gnus-after-getting-new-news-hook is not fired when running
 gnus-summary-rescan-group
Date: Mon, 27 Feb 2017 15:07:07 +0100

[Message part 1 (text/plain, inline)]

Hi,

Unlike in pressing g in the *Group* buffer M-g in *Summmary…* buffers
doesn't activate hooks in gnus-after-getting-new-news-hook.

My patch will follow this report.
-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 25892 <at> debbugs.gnu.org (full text, mbox):

From: Łukasz Stelmach <l.stelmach <at> samsung.com>
To: 25892 <at> debbugs.gnu.org
Cc: Łukasz Stelmach <l.stelmach <at> samsung.com>
Subject: [PATCH] Run gnus-after-getting-new-news-hook after scanning a single
 group
Date: Tue, 28 Feb 2017 08:57:37 +0100

* lisp/gnus/gnus-group.el (gnus-group-get-new-news-this-group):
Run gnus-after-getting-new-news-hook after scanning selected groups.
---
 lisp/gnus/gnus-group.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 2488cdb..72a4870 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4093,6 +4093,7 @@ If DONT-SCAN is non-nil, scan non-activated groups as well."
 	       method (gnus-group-real-name group) active))
 	    (gnus-group-update-group group nil t))
 	(gnus-error 3 "%s error: %s" group (gnus-status-message group))))
+    (gnus-run-hooks 'gnus-after-getting-new-news-hook)
     (when beg
       (goto-char beg))
     (when gnus-goto-next-group-when-activating
-- 
2.1.4

Message #11 received at 25892 <at> debbugs.gnu.org (full text, mbox):

From: Łukasz Stelmach <l.stelmach <at> samsung.com>
To: 25892 <at> debbugs.gnu.org
Subject: Re: bug#25892: Acknowledgement (24.4; gnus-after-getting-new-news-hook
 is not fired when running gnus-summary-rescan-group)
Date: Tue, 28 Feb 2017 09:05:01 +0100

Control: tags -1 +patch

Message #20 received at 25892 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Łukasz Stelmach <l.stelmach <at> samsung.com>
Cc: 25892 <at> debbugs.gnu.org
Subject: Re: bug#25892: [PATCH] Run gnus-after-getting-new-news-hook after
 scanning a single group
Date: Thu, 12 Apr 2018 00:09:57 +0200

Łukasz Stelmach <l.stelmach <at> samsung.com> writes:

> * lisp/gnus/gnus-group.el (gnus-group-get-new-news-this-group):
> Run gnus-after-getting-new-news-hook after scanning selected groups.
> ---
>  lisp/gnus/gnus-group.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
> index 2488cdb..72a4870 100644
> --- a/lisp/gnus/gnus-group.el
> +++ b/lisp/gnus/gnus-group.el
> @@ -4093,6 +4093,7 @@ If DONT-SCAN is non-nil, scan non-activated groups as well."
>  	       method (gnus-group-real-name group) active))
>  	    (gnus-group-update-group group nil t))
>  	(gnus-error 3 "%s error: %s" group (gnus-status-message group))))
> +    (gnus-run-hooks 'gnus-after-getting-new-news-hook)
>      (when beg
>        (goto-char beg))
>      (when gnus-goto-next-group-when-activating

Thanks; applied to Emacs 27.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.