GNU bug report logs - #2591
Custom should warn if 'other is not the last in a choice

Previous Next

Package: emacs;

Reported by: rms <at> gnu.org

Date: Sat, 7 Mar 2009 04:05:13 UTC

Severity: normal

Merged with 65852

Found in version 30.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2591 in the body.
You can then email your comments to 2591 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report stored :
bug#2591; Package emacs. (Sat, 07 Mar 2009 04:05:13 GMT) Full text and rfc822 format available.

Message #3 received at quiet <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Richard M Stallman <rms <at> gnu.org>
To: quiet <at> debbugs.gnu.org
Subject: Custom should warn if 'other is not the last in a choice
Date: Sun, 01 Mar 2009 16:30:08 -0500

Severity: wishlist

[ resent from
  http://lists.gnu.org/archive/html/emacs-devel/2009-03/msg00002.html ]

Regarding this change,

       :group 'find-file
       :version "23.1"
    -  :type '(choice (other :tag "Always" t)
    -		 (const :tag "After completion" after-completion)
    -		 (const :tag "Never" nil)))
    +  :type '(choice (const :tag "After completion" after-completion)
    +		 (const :tag "Never" nil)
    +		 (other :tag "Always" t)))

perhaps compiling defcustom should give an error if :other appears
other than last.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#2591; Package emacs. (Tue, 03 Oct 2023 22:22:02 GMT) Full text and rfc822 format available.

Message #6 received at 2591 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 2591 <at> debbugs.gnu.org
Cc: rms <at> gnu.org
Subject: Re: bug#2591: Custom should warn if 'other is not the last in a choice
Date: Tue, 3 Oct 2023 19:21:26 -0300

close 2591 30.1
quit


Richard M Stallman <rms <at> gnu.org> writes:

> [ resent from
> http://lists.gnu.org/archive/html/emacs-devel/2009-03/msg00002.html ]
>
> Regarding this change,
>
>        :group 'find-file
>        :version "23.1"
>     -  :type '(choice (other :tag "Always" t)
>     -         (const :tag "After completion" after-completion)
>     -         (const :tag "Never" nil)))
>     +  :type '(choice (const :tag "After completion" after-completion)
>     +         (const :tag "Never" nil)
>     +         (other :tag "Always" t)))
>
> perhaps compiling defcustom should give an error if :other appears
> other than last.

commit f8ea47ebf45c5ea0cd788667f7bdb805f42e08e0 introduced many checks
for defcustom, including this.  See also Bug#65852

It's my conclusion that this Bug Report can be closed.  Feel free to
reopen if I'm mistaken.
bug marked as fixed in version 30.1, send any further explanations to 2591 <at> debbugs.gnu.org and rms <at> gnu.org Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 03 Oct 2023 22:22:02 GMT) Full text and rfc822 format available.
Forcibly Merged 2591 65852. Request was from Mattias Engdegård <mattias.engdegard <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 11 Oct 2023 11:46:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 08 Nov 2023 12:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 168 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.