GNU bug report logs - #25916
[PATCH] gnu: mumble: Make builds bit-reproducible.

Previous Next

Package: guix-patches;

Reported by: Kei Kebreau <kei <at> openmailbox.org>

Date: Wed, 1 Mar 2017 16:37:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25916 in the body.
You can then email your comments to 25916 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#25916; Package guix-patches. (Wed, 01 Mar 2017 16:37:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kei Kebreau <kei <at> openmailbox.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 01 Mar 2017 16:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Wed,  1 Mar 2017 11:35:30 -0500
* gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
---
 gnu/packages/telephony.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 87261825c..4ff2acd25 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -330,6 +330,12 @@ address of one of the participants.")
               (modules '((guix build utils)))
               (snippet
                `(begin
+                  ;; Remove timestamps for reproducibility.
+                  (substitute* "src/Version.h"
+                    (("\"Compiled \" __DATE__ \" \" __TIME__") "\"\""))
+                  (substitute* "src/mumble/VersionCheck.cpp"
+                    (("^.*__DATE__.*$") "")
+                    (("^.*__TIME__.*$") ""))
                   ;; Remove bundled software.
                   (for-each delete-file-recursively '("3rdparty"
                                                       "speex"
-- 
2.12.0





Information forwarded to guix-patches <at> gnu.org:
bug#25916; Package guix-patches. (Wed, 01 Mar 2017 16:44:02 GMT) Full text and rfc822 format available.

Message #8 received at 25916 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>, 25916 <at> debbugs.gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Wed, 01 Mar 2017 17:43:46 +0100
[Message part 1 (text/plain, inline)]
Kei Kebreau <kei <at> openmailbox.org> writes:

> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.

Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
'core-updates' is merged. See this commit, which backports a gcc7 patch.

d71d6fe85c4db778be6a2081cbbec6a3a494e4f9

> ---
>  gnu/packages/telephony.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index 87261825c..4ff2acd25 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -330,6 +330,12 @@ address of one of the participants.")
>                (modules '((guix build utils)))
>                (snippet
>                 `(begin
> +                  ;; Remove timestamps for reproducibility.
> +                  (substitute* "src/Version.h"
> +                    (("\"Compiled \" __DATE__ \" \" __TIME__") "\"\""))
> +                  (substitute* "src/mumble/VersionCheck.cpp"
> +                    (("^.*__DATE__.*$") "")
> +                    (("^.*__TIME__.*$") ""))
>                    ;; Remove bundled software.
>                    (for-each delete-file-recursively '("3rdparty"
>                                                        "speex"
> -- 
> 2.12.0
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#25916; Package guix-patches. (Wed, 01 Mar 2017 17:21:01 GMT) Full text and rfc822 format available.

Message #11 received at 25916 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 25916 <at> debbugs.gnu.org
Subject: Re: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Wed, 01 Mar 2017 12:20:41 -0500
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:

> Kei Kebreau <kei <at> openmailbox.org> writes:
>
>> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>
> Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
> 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>
> d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>

Yay, what a useful patch!

Aren't we pretty close to merging core-updates? If that's the case, I
won't worry about pushing this to master.

>> ---
>>  gnu/packages/telephony.scm | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
>> index 87261825c..4ff2acd25 100644
>> --- a/gnu/packages/telephony.scm
>> +++ b/gnu/packages/telephony.scm
>> @@ -330,6 +330,12 @@ address of one of the participants.")
>>                (modules '((guix build utils)))
>>                (snippet
>>                 `(begin
>> +                  ;; Remove timestamps for reproducibility.
>> +                  (substitute* "src/Version.h"
>> +                    (("\"Compiled \" __DATE__ \" \" __TIME__") "\"\""))
>> +                  (substitute* "src/mumble/VersionCheck.cpp"
>> +                    (("^.*__DATE__.*$") "")
>> +                    (("^.*__TIME__.*$") ""))
>>                    ;; Remove bundled software.
>>                    (for-each delete-file-recursively '("3rdparty"
>>                                                        "speex"
>> -- 
>> 2.12.0
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#25916; Package guix-patches. (Wed, 01 Mar 2017 20:07:01 GMT) Full text and rfc822 format available.

Message #14 received at 25916 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 25916 <at> debbugs.gnu.org
Subject: Re: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Wed, 01 Mar 2017 21:06:02 +0100
[Message part 1 (text/plain, inline)]
Kei Kebreau <kei <at> openmailbox.org> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Kei Kebreau <kei <at> openmailbox.org> writes:
>>
>>> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>>> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>>
>> Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
>> 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>>
>> d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>>
>
> Yay, what a useful patch!
>
> Aren't we pretty close to merging core-updates? If that's the case, I
> won't worry about pushing this to master.

I would guess at least 1-2 weeks more, but it's getting there.

Thanks anyway!
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#25916; Package guix-patches. (Wed, 01 Mar 2017 21:45:01 GMT) Full text and rfc822 format available.

Message #17 received at 25916 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 25916 <at> debbugs.gnu.org
Subject: Re: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Wed, 1 Mar 2017 16:44:01 -0500
[Message part 1 (text/plain, inline)]
On Wed, Mar 01, 2017 at 12:20:41PM -0500, Kei Kebreau wrote:
> Marius Bakke <mbakke <at> fastmail.com> writes:
> 
> > Kei Kebreau <kei <at> openmailbox.org> writes:
> >
> >> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
> >> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
> >
> > Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
> > 'core-updates' is merged. See this commit, which backports a gcc7 patch.
> >
> > d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
> >
> 
> Yay, what a useful patch!
> 
> Aren't we pretty close to merging core-updates? If that's the case, I
> won't worry about pushing this to master.

Someone should try checking if they can reproduce mumble on
core-updates, to make sure the backported GCC 7 patch is working
correctly :)
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#25916; Package guix-patches. (Thu, 02 Mar 2017 01:23:01 GMT) Full text and rfc822 format available.

Message #20 received at 25916 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, Kei Kebreau <kei <at> openmailbox.org>
Cc: 25916 <at> debbugs.gnu.org
Subject: Re: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Thu, 02 Mar 2017 02:22:26 +0100
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Mar 01, 2017 at 12:20:41PM -0500, Kei Kebreau wrote:
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>> 
>> > Kei Kebreau <kei <at> openmailbox.org> writes:
>> >
>> >> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>> >> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>> >
>> > Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
>> > 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>> >
>> > d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>> >
>> 
>> Yay, what a useful patch!
>> 
>> Aren't we pretty close to merging core-updates? If that's the case, I
>> won't worry about pushing this to master.
>
> Someone should try checking if they can reproduce mumble on
> core-updates, to make sure the backported GCC 7 patch is working
> correctly :)

That's a good test. Unfortunately, mumble fails to build on
'core-updates'.

starting phase `configure'
Reading /tmp/guix-build-mumble-1.2.19.drv-0/mumble-1.2.19/celt-0.7.0-build/celt-0.7.0-build.pro
Reading /tmp/guix-build-mumble-1.2.19.drv-0/mumble-1.2.19/celt-0.11.0-build/celt-0.11.0-build.pro
Reading /tmp/guix-build-mumble-1.2.19.drv-0/mumble-1.2.19/src/mumble/mumble.pro
Project ERROR: Package speexdsp not found
phase `configure' failed after 0.2 seconds

It seems to be related to the speex update; apparently the DSP component
have been split out of speex into a separate package:

https://github.com/xiph/speexdsp
[signature.asc (application/pgp-signature, inline)]

Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Tue, 04 Apr 2017 21:43:01 GMT) Full text and rfc822 format available.

Notification sent to Kei Kebreau <kei <at> openmailbox.org>:
bug acknowledged by developer. (Tue, 04 Apr 2017 21:43:02 GMT) Full text and rfc822 format available.

Message #25 received at 25916-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 25916-done <at> debbugs.gnu.org, Kei Kebreau <kei <at> openmailbox.org>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#25916: [PATCH] gnu: mumble: Make builds bit-reproducible.
Date: Tue, 04 Apr 2017 23:42:01 +0200
Hello!

Marius Bakke <mbakke <at> fastmail.com> skribis:

> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Wed, Mar 01, 2017 at 12:20:41PM -0500, Kei Kebreau wrote:
>>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>> 
>>> > Kei Kebreau <kei <at> openmailbox.org> writes:
>>> >
>>> >> * gnu/packages/telephony.scm (mumble)[source]: Add 'substitute*' calls
>>> >> to 'snippet' for src/Version.h and src/mumble/VersionCheck.cpp.
>>> >
>>> > Thanks a lot for this! The patch LGTM, but FYI won't be necessary once
>>> > 'core-updates' is merged. See this commit, which backports a gcc7 patch.
>>> >
>>> > d71d6fe85c4db778be6a2081cbbec6a3a494e4f9
>>> >
>>> 
>>> Yay, what a useful patch!
>>> 
>>> Aren't we pretty close to merging core-updates? If that's the case, I
>>> won't worry about pushing this to master.
>>
>> Someone should try checking if they can reproduce mumble on
>> core-updates, to make sure the backported GCC 7 patch is working
>> correctly :)
>
> That's a good test. Unfortunately, mumble fails to build on
> 'core-updates'.

It builds with current master (post ‘core-updates’ merge).

I’ve done a --check build and can confirm that our GCC now honors
‘SOURCE_DATE_EPOCH’, so the patch isn’t needed.  \o/

Closing this bug!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 03 May 2017 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 331 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.