GNU bug report logs - #25955
[PATCH] guix: Only attempt to build json builder if json is available.

Previous Next

Package: guix-patches;

Reported by: John Darrington <john <at> darrington.wattle.id.au>

Date: Fri, 3 Mar 2017 17:44:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25955 in the body.
You can then email your comments to 25955 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#25955; Package guix-patches. (Fri, 03 Mar 2017 17:44:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to John Darrington <john <at> darrington.wattle.id.au>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 03 Mar 2017 17:44:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: guix-patches <at> gnu.org
Cc: John Darrington <john <at> darrington.wattle.id.au>
Subject: [PATCH] guix: Only attempt to build json builder if json is available.
Date: Fri,  3 Mar 2017 18:43:27 +0100
* guix/import/stackage.scm: avoid loading the json module.
---
 guix/import/stackage.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
index 5b25adc..c8f195a 100644
--- a/guix/import/stackage.scm
+++ b/guix/import/stackage.scm
@@ -23,7 +23,6 @@
   #:use-module (srfi srfi-26)
   #:use-module (srfi srfi-34)
   #:use-module (srfi srfi-35)
-  #:use-module (guix import json)
   #:use-module (guix import hackage)
   #:use-module (guix memoization)
   #:use-module (guix packages)
@@ -31,6 +30,8 @@
   #:export (stackage->guix-package
             %stackage-updater))
 
+(module-autoload! (current-module) '(guix import json) '(json))
+
 
 ;;;
 ;;; Stackage info fetcher and access functions
-- 
2.1.4





Information forwarded to guix-patches <at> gnu.org:
bug#25955; Package guix-patches. (Mon, 13 Mar 2017 13:17:01 GMT) Full text and rfc822 format available.

Message #8 received at 25955 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: John Darrington <john <at> darrington.wattle.id.au>
Cc: 25955 <at> debbugs.gnu.org
Subject: Re: bug#25955: [PATCH] guix: Only attempt to build json builder if
 json is available.
Date: Mon, 13 Mar 2017 14:16:27 +0100
John Darrington <john <at> darrington.wattle.id.au> skribis:

> * guix/import/stackage.scm: avoid loading the json module.
> ---
>  guix/import/stackage.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
> index 5b25adc..c8f195a 100644
> --- a/guix/import/stackage.scm
> +++ b/guix/import/stackage.scm
> @@ -23,7 +23,6 @@
>    #:use-module (srfi srfi-26)
>    #:use-module (srfi srfi-34)
>    #:use-module (srfi srfi-35)
> -  #:use-module (guix import json)
>    #:use-module (guix import hackage)
>    #:use-module (guix memoization)
>    #:use-module (guix packages)
> @@ -31,6 +30,8 @@
>    #:export (stackage->guix-package
>              %stackage-updater))
>  
> +(module-autoload! (current-module) '(guix import json) '(json))

We don’t do that for any of the other (guix import …) modules that uses
(guix import json).  What problem does it cause?

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#25955; Package guix-patches. (Wed, 15 Mar 2017 15:37:02 GMT) Full text and rfc822 format available.

Message #11 received at 25955 <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: 25955 <at> debbugs.gnu.org
Date: Wed, 15 Mar 2017 16:36:16 +0100
[Message part 1 (text/plain, inline)]
But the other modules are protected in Makefile.am.

The problem it causes, is that it's not possible to build Guix unless 
guile-json is present.

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#25955; Package guix-patches. (Thu, 16 Mar 2017 14:21:01 GMT) Full text and rfc822 format available.

Message #14 received at 25955 <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: Ludovic Court??s <ludo <at> gnu.org>
Cc: John Darrington <john <at> darrington.wattle.id.au>, 25955 <at> debbugs.gnu.org
Subject: Re: bug#25955: [PATCH] guix: Only attempt to build json builder if
 json is available.
Date: Thu, 16 Mar 2017 15:19:58 +0100
[Message part 1 (text/plain, inline)]
On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:
     John Darrington <john <at> darrington.wattle.id.au> skribis:
     
     > * guix/import/stackage.scm: avoid loading the json module.
     > ---
     >  guix/import/stackage.scm | 3 ++-
     >  1 file changed, 2 insertions(+), 1 deletion(-)
     >
     > diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
     > index 5b25adc..c8f195a 100644
     > --- a/guix/import/stackage.scm
     > +++ b/guix/import/stackage.scm
     > @@ -23,7 +23,6 @@
     >    #:use-module (srfi srfi-26)
     >    #:use-module (srfi srfi-34)
     >    #:use-module (srfi srfi-35)
     > -  #:use-module (guix import json)
     >    #:use-module (guix import hackage)
     >    #:use-module (guix memoization)
     >    #:use-module (guix packages)
     > @@ -31,6 +30,8 @@
     >    #:export (stackage->guix-package
     >              %stackage-updater))
     >  
     > +(module-autoload! (current-module) '(guix import json) '(json))
     
     We don???t do that for any of the other (guix import ???) modules that uses

No.  But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .

     (guix import json).  What problem does it cause?
     

It means that one cannot build guix on a foreign system if guile-json is absent.


J'
     

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#25955; Package guix-patches. (Thu, 16 Mar 2017 15:42:01 GMT) Full text and rfc822 format available.

Message #17 received at 25955 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: John Darrington <john <at> darrington.wattle.id.au>
Cc: 25955 <at> debbugs.gnu.org
Subject: Re: bug#25955: [PATCH] guix: Only attempt to build json builder if
 json is available.
Date: Thu, 16 Mar 2017 16:40:51 +0100
John Darrington <john <at> darrington.wattle.id.au> skribis:

> On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:
>      John Darrington <john <at> darrington.wattle.id.au> skribis:
>      
>      > * guix/import/stackage.scm: avoid loading the json module.
>      > ---
>      >  guix/import/stackage.scm | 3 ++-
>      >  1 file changed, 2 insertions(+), 1 deletion(-)
>      >
>      > diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
>      > index 5b25adc..c8f195a 100644
>      > --- a/guix/import/stackage.scm
>      > +++ b/guix/import/stackage.scm
>      > @@ -23,7 +23,6 @@
>      >    #:use-module (srfi srfi-26)
>      >    #:use-module (srfi srfi-34)
>      >    #:use-module (srfi srfi-35)
>      > -  #:use-module (guix import json)
>      >    #:use-module (guix import hackage)
>      >    #:use-module (guix memoization)
>      >    #:use-module (guix packages)
>      > @@ -31,6 +30,8 @@
>      >    #:export (stackage->guix-package
>      >              %stackage-updater))
>      >  
>      > +(module-autoload! (current-module) '(guix import json) '(json))
>      
>      We don???t do that for any of the other (guix import ???) modules that uses
>
> No.  But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .

Oh right.  Then let’s move this one under “if HAVE_GUILE_JSON” as well.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#25955; Package guix-patches. (Thu, 16 Mar 2017 17:11:02 GMT) Full text and rfc822 format available.

Message #20 received at 25955 <at> debbugs.gnu.org (full text, mbox):

From: John Darrington <john <at> darrington.wattle.id.au>
To: Ludovic Court??s <ludo <at> gnu.org>
Cc: John Darrington <john <at> darrington.wattle.id.au>, 25955 <at> debbugs.gnu.org
Subject: Re: bug#25955: [PATCH] guix: Only attempt to build json builder if
 json is available.
Date: Thu, 16 Mar 2017 18:10:37 +0100
[Message part 1 (text/plain, inline)]
On Thu, Mar 16, 2017 at 04:40:51PM +0100, Ludovic Court??s wrote:
     John Darrington <john <at> darrington.wattle.id.au> skribis:
     
     > On Mon, Mar 13, 2017 at 02:16:27PM +0100, Ludovic Court??s wrote:
     >      John Darrington <john <at> darrington.wattle.id.au> skribis:
     >      
     >      > * guix/import/stackage.scm: avoid loading the json module.
     >      > ---
     >      >  guix/import/stackage.scm | 3 ++-
     >      >  1 file changed, 2 insertions(+), 1 deletion(-)
     >      >
     >      > diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
     >      > index 5b25adc..c8f195a 100644
     >      > --- a/guix/import/stackage.scm
     >      > +++ b/guix/import/stackage.scm
     >      > @@ -23,7 +23,6 @@
     >      >    #:use-module (srfi srfi-26)
     >      >    #:use-module (srfi srfi-34)
     >      >    #:use-module (srfi srfi-35)
     >      > -  #:use-module (guix import json)
     >      >    #:use-module (guix import hackage)
     >      >    #:use-module (guix memoization)
     >      >    #:use-module (guix packages)
     >      > @@ -31,6 +30,8 @@
     >      >    #:export (stackage->guix-package
     >      >              %stackage-updater))
     >      >  
     >      > +(module-autoload! (current-module) '(guix import json) '(json))
     >      
     >      We don???t do that for any of the other (guix import ???) modules that uses
     >
     > No.  But all the others are projected in Makefile.am by "if HAVE_GUILE_JSON" .
     
     Oh right.  Then let???s move this one under ???if HAVE_GUILE_JSON??? as well.

No. I tried that.  Unfortunately there are other modules which need this one.

J'
     
-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

[signature.asc (application/pgp-signature, inline)]

Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Fri, 02 Jun 2017 16:25:02 GMT) Full text and rfc822 format available.

Notification sent to John Darrington <john <at> darrington.wattle.id.au>:
bug acknowledged by developer. (Fri, 02 Jun 2017 16:25:02 GMT) Full text and rfc822 format available.

Message #25 received at 25955-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: John Darrington <john <at> darrington.wattle.id.au>
Cc: 25955-done <at> debbugs.gnu.org
Subject: Re: bug#25955: [PATCH] guix: Only attempt to build json builder if
 json is available.
Date: Fri, 02 Jun 2017 18:24:18 +0200
John Darrington <john <at> darrington.wattle.id.au> skribis:

> * guix/import/stackage.scm: avoid loading the json module.

This was fixed later in commit 37fd9567710b0fc0d7b083f8a1eba3528597c2f6.

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 01 Jul 2017 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 272 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.