GNU bug report logs - #25964
26.0.50; byte-recompile-directory saving unrelated buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25964 in the body.
You can then email your comments to 25964 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; byte-recompile-directory saving unrelated buffer
Date: Sat, 04 Mar 2017 05:58:34 +0100

[Message part 1 (text/plain, inline)]

I think it is somewhat annoying when I install a Lisp package and it
asks me whether I want to save a completely unrelated buffer in some
other project.  This is especially true, if this unrelated buffer has a
function like check-parens on its after-save-hook, which may signal an
error, and in turn will abort the whole package installation.

The buffer saving happens in byte-recompile-directory via
save-some-buffer. So I wonder, if this can be made more selective, like
so:

[Message part 2 (text/x-diff, inline)]

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 25513bd024..86b1617fd7 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1661,7 +1661,12 @@ byte-recompile-directory
   (if arg (setq arg (prefix-numeric-value arg)))
   (if noninteractive
       nil
-    (save-some-buffers)
+    (save-some-buffers
+     nil (lambda ()
+           (let ((file (buffer-file-name)))
+             (and file
+                  (string-match-p emacs-lisp-file-regexp file)
+                  (file-in-directory-p file directory)))))
     (force-mode-line-update))
   (with-current-buffer (get-buffer-create byte-compile-log-buffer)
     (setq default-directory (expand-file-name directory))

[Message part 3 (text/plain, inline)]

Thanks,
-ap

Message #8 received at 25964 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Andreas Politz <politza <at> hochschule-trier.de>
Cc: 25964 <at> debbugs.gnu.org
Subject: Re: bug#25964: 26.0.50;
 byte-recompile-directory saving unrelated buffer
Date: Sat, 04 Mar 2017 00:08:33 -0500

merge 25964 25340
quit

Andreas Politz <politza <at> hochschule-trier.de> writes:

> I think it is somewhat annoying when I install a Lisp package and it
> asks me whether I want to save a completely unrelated buffer in some
> other project.  This is especially true, if this unrelated buffer has a
> function like check-parens on its after-save-hook, which may signal an
> error, and in turn will abort the whole package installation.
>
> The buffer saving happens in byte-recompile-directory via
> save-some-buffer. So I wonder, if this can be made more selective, like
> so:

There is a similar patch in #25340, although it makes the behaviour
optional.

Message #13 received at 25964 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Politz <politza <at> hochschule-trier.de>
To: npostavs <at> users.sourceforge.net
Cc: 25964 <at> debbugs.gnu.org
Subject: Re: bug#25964: 26.0.50;
 byte-recompile-directory saving unrelated buffer
Date: Sat, 04 Mar 2017 11:08:43 +0100

Ok, thanks.

Message #18 received at 25964 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Andreas Politz <politza <at> hochschule-trier.de>
Cc: 25964 <at> debbugs.gnu.org
Subject: Re: bug#25964: 26.0.50;
 byte-recompile-directory saving unrelated buffer
Date: Sat, 20 May 2017 18:29:00 -0400

severity 25964 minor
tags 25340 fixed
close 25340 26.1
quit

npostavs <at> users.sourceforge.net writes:
>
> Andreas Politz <politza <at> hochschule-trier.de> writes:
>
>> I think it is somewhat annoying when I install a Lisp package and it
>> asks me whether I want to save a completely unrelated buffer in some
>> other project.  This is especially true, if this unrelated buffer has a
>> function like check-parens on its after-save-hook, which may signal an
>> error, and in turn will abort the whole package installation.
>>
>> The buffer saving happens in byte-recompile-directory via
>> save-some-buffer. So I wonder, if this can be made more selective, like
>> so:
>
> There is a similar patch in #25340, although it makes the behaviour
> optional.

It seems #25340 is stalled, so I've pushed your patch instead [1: f151eb0141].

[1: f151eb0141]: 2017-05-20 18:28:23 -0400
  Don't save unrelated buffers before recompiling directory (Bug#25964)
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f151eb01418b80d102c767566e93ac332a8bf7c3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.