GNU bug report logs - #26175
guix download fails if filename contains "@"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26175 in the body.
You can then email your comments to 26175 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: bug-guix <at> gnu.org
Subject: guix download fails if filename contains "@"
Date: Sun, 19 Mar 2017 19:06:22 +0100

guix download fails if filename contains "@":invalid character `@' in name


$ guix download
mirror://kde/stable/applications/16.12.3/src/kde-l10n/kde-l10n-ca <at> valencia-16.12.3.tar.xz
[...]
Starting download of /tmp/guix-file.oVF3qZ
From
http://mirror.karneval.cz/pub/kde/stable/applications/16.12.3/src/kde-l10n/kde-l10n-ca <at> valencia-16.12.3.tar.xz...
 ...cia-16.12.3.tar.xz  2.0MiB            1.4MiB/s 00:01
[####################] 100.0%
guix download: error: build failed: invalid character `@' in name
`kde-l10n-ca <at> valencia-16.12.3.tar.xz'


Guix version:
/gnu/store/v83285dvjy923ikq1dddncixb6kfba0k-guix-0.12.0-5.1162/bin/guix

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #8 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: bug#26175: guix download fails if filename contains "@"
Date: Mon, 20 Mar 2017 23:22:40 +0100

Hello,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> guix download fails if filename contains "@":invalid character `@' in name
>
>
> $ guix download
> mirror://kde/stable/applications/16.12.3/src/kde-l10n/kde-l10n-ca <at> valencia-16.12.3.tar.xz
> [...]
> Starting download of /tmp/guix-file.oVF3qZ
> From
> http://mirror.karneval.cz/pub/kde/stable/applications/16.12.3/src/kde-l10n/kde-l10n-ca <at> valencia-16.12.3.tar.xz...
>  ...cia-16.12.3.tar.xz  2.0MiB            1.4MiB/s 00:01
> [####################] 100.0%
> guix download: error: build failed: invalid character `@' in name
> `kde-l10n-ca <at> valencia-16.12.3.tar.xz'

To address this we’d need an extra command-line option in ‘guix
download’ to specify the name to use in the store (similar to the
‘file-name’ field in <origin>.)

So one would type:

  guix download --name=foo.tar.xz mirror://…/kde-l10n-ca <at> valencia-16.12.3.tar.xz

In the meantime, you can work around it by doing something like:

  guix download -o foo.tar.xz mirror://…/kde-l10n-ca <at> valencia-16.12.3.tar.xz
  guix hash foo.tar.xz

Thanks,
Ludo’.

Message #11 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: bug#26175: guix download fails if filename contains "@"
Date: Mon, 20 Mar 2017 23:30:35 +0100

Am 20.03.2017 um 23:22 schrieb Ludovic Courtès:
> To address this we’d need an extra command-line option in ‘guix
> download’ to specify the name to use in the store (similar to the
> ‘file-name’ field in <origin>.)
>
> So one would type:
>
>   guix download --name=foo.tar.xz mirror://…/kde-l10n-ca <at> valencia-16.12.3.tar.xz

IMHO this i not a good solution, since it puts the burden of handling a
non-obvious restriction to the user. This makes things complicated and
less-skilled discourages people. "guix download" should implement some
escape automatic mechanisms.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #14 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: bug#26175: guix download fails if filename contains "@"
Date: Tue, 21 Mar 2017 09:57:09 +0100

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> Am 20.03.2017 um 23:22 schrieb Ludovic Courtès:
>> To address this we’d need an extra command-line option in ‘guix
>> download’ to specify the name to use in the store (similar to the
>> ‘file-name’ field in <origin>.)
>>
>> So one would type:
>>
>>   guix download --name=foo.tar.xz mirror://…/kde-l10n-ca <at> valencia-16.12.3.tar.xz
>
> IMHO this i not a good solution, since it puts the burden of handling a
> non-obvious restriction to the user. This makes things complicated and
> less-skilled discourages people. "guix download" should implement some
> escape automatic mechanisms.

Oh right, that’s another possibility, and I agree it’d be better.

Ludo’.

Message #17 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: [bug#36976] [PATCH 1/1] download: Map file-name characters not
 allowed in store.
Date: Tue, 3 Sep 2019 16:39:35 +0200

Hi Ludo,

while http://issues.guix.gnu.org/issue/36976 is going to solve the issue
for "guix download", I found that there are other cases where invalid
characters in store names appear. Thus we need a more elaborate solution
- or several solutions.

Any suggestions which cases to check and how to fix them?


E.g. "@" and "%" are not allowed in package source base names: When
building the package below, which used the "offending URL, yields an error:

guix build: error: invalid character `@' in name
`kde-l10n-ca <at> valencia-14.11.80.tar.xz.drv'

Same when trying to work around this be using "…%40…".

(use-modules (guix packages) (guix download) (guix build-system gnu))

(package
  (name "kde-l10n-ca-valencia")
  (version "14.11.80")
  (source
   (origin
     (method url-fetch)
     (uri (string-append "mirror://kde//Attic/applications/"
                         version "/src/kde-l10n/"
                         "kde-l10n-ca <at> valencia-" version ".tar.xz"))
     (sha256 (base32
"1mqadassxcm0m9r1l02m5vr4bbandn48xz8gifvxmb4wiz8i8d0w"))))
  (build-system gnu-build-system)
  (synopsis "") (description "") (license "") (home-page ""))

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #20 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: [bug#36976] [PATCH 1/1] download: Map file-name characters not
 allowed in store.
Date: Wed, 04 Sep 2019 12:32:41 +0200

Hi,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

>    (origin
>      (method url-fetch)
>      (uri (string-append "mirror://kde//Attic/applications/"
>                          version "/src/kde-l10n/"
>                          "kde-l10n-ca <at> valencia-" version ".tar.xz"))

In this case just add a ‘file-name’ field.  I think that’s a reasonable
expectation.

Thanks,
Ludo’.

Message #23 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: [bug#36976] [PATCH 1/1] download: Map file-name characters not
 allowed in store.
Date: Sun, 8 Sep 2019 20:50:15 +0200

Am 04.09.19 um 12:32 schrieb Ludovic Courtès:
> Hi,
>
> Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:
>
>>    (origin
>>      (method url-fetch)
>>      (uri (string-append "mirror://kde//Attic/applications/"
>>                          version "/src/kde-l10n/"
>>                          "kde-l10n-ca <at> valencia-" version ".tar.xz"))
> In this case just add a ‘file-name’ field.  I think that’s a reasonable
> expectation.
>
> Thanks,
> Ludo’.

Agreed. WDYT about adding this as a hint when the error shows up?

How can I catch the "error: invalid character `@' in name" in guix build?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #26 received at 26175 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26175 <at> debbugs.gnu.org
Subject: Re: [bug#36976] [PATCH 1/1] download: Map file-name characters not
 allowed in store.
Date: Sun, 08 Sep 2019 22:07:10 +0200

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> Am 04.09.19 um 12:32 schrieb Ludovic Courtès:
>> Hi,
>>
>> Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:
>>
>>>    (origin
>>>      (method url-fetch)
>>>      (uri (string-append "mirror://kde//Attic/applications/"
>>>                          version "/src/kde-l10n/"
>>>                          "kde-l10n-ca <at> valencia-" version ".tar.xz"))
>> In this case just add a ‘file-name’ field.  I think that’s a reasonable
>> expectation.
>>
>> Thanks,
>> Ludo’.
>
> Agreed. WDYT about adding this as a hint when the error shows up?
>
> How can I catch the "error: invalid character `@' in name" in guix build?

Unfortunately it cannot really be caught.  I mean, you could catch
‘&store-protocol-error’ error conditions, but then the error message is
just a string, there’s no error code you can compare against.

Ludo’.

Message #31 received at 26175-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 26175-close <at> debbugs.gnu.org
Subject: Re: [bug#36976] [PATCH 1/1] download: Map file-name characters not
 allowed in store.
Date: Thu, 26 Sep 2019 17:53:10 +0200

Done, see dec845606d2d184da31065fa26cd951b84b3ce2d and
<http://issues.guix.gnu.org/issue/36976#5>

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.