GNU bug report logs - #26211
[PATCH] gnu: networkmanager-qt: Disable a failing test.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26211 in the body.
You can then email your comments to 26211 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: networkmanager-qt: Disable a failing test.
Date: Tue, 21 Mar 2017 20:59:29 +0100

The error-message was: "D-Bus library appears to be incorrectly set up;
failed to read machine uuid: Failed to open '/etc/machine-id':
No such file or directory".

* gnu/packages/kde-frameworks.scm (networkmanager-qt):
  [disable-failing-tests] New phase.
---
 gnu/packages/kde-frameworks.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 5b11f12..01bbe29 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1113,6 +1113,13 @@ messages.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'disable-failing-tests
+           (lambda* _
+             ;; Disable test requiring a dbus machine-id:
+             (substitute* "autotests/CMakeLists.txt"
+               (("^ecm_add_test\\(activeconnectiontest\\.cpp .*")
+                ""))
+             #t))
          (replace 'check
            (lambda _
              (setenv "DBUS_FATAL_WARNINGS" "0")
-- 
2.7.4

Message #8 received at 26211 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 26211 <at> debbugs.gnu.org
Subject: Re:
Date: Tue, 21 Mar 2017 21:04:34 +0100

This fixes a build failure occuring since at least 2016-12-04.

This is the fixed version of the patch I sent (and retracted) yesterday
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26197


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #11 received at 26211 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26211 <at> debbugs.gnu.org
Subject: Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
Date: Tue, 21 Mar 2017 16:24:53 -0400

[Message part 1 (text/plain, inline)]

On Tue, Mar 21, 2017 at 08:59:29PM +0100, Hartmut Goebel wrote:
> The error-message was: "D-Bus library appears to be incorrectly set up;
> failed to read machine uuid: Failed to open '/etc/machine-id':
> No such file or directory".
> 
> * gnu/packages/kde-frameworks.scm (networkmanager-qt):
>   [disable-failing-tests] New phase.
> ---
>  gnu/packages/kde-frameworks.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 5b11f12..01bbe29 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -1113,6 +1113,13 @@ messages.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'disable-failing-tests
> +           (lambda* _
> +             ;; Disable test requiring a dbus machine-id:
> +             (substitute* "autotests/CMakeLists.txt"
> +               (("^ecm_add_test\\(activeconnectiontest\\.cpp .*")
> +                ""))
> +             #t))

In (gnu packages gnome), there are some packages where we work around
this problem with (setenv "DBUS_FATAL_WARNINGS" "0").

If we used that instead, do you know if the test would still be able to
check some things for us? Or does it just disable the test in another
way?

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 26211 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26211 <at> debbugs.gnu.org
Subject: Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
Date: Tue, 21 Mar 2017 23:12:48 +0100

Am 21.03.2017 um 21:24 schrieb Leo Famulari:
> In (gnu packages gnome), there are some packages where we work around
> this problem with (setenv "DBUS_FATAL_WARNINGS" "0").

Unfortunately this will not make the test pass.

TO fix the test, we would need to be able to create /etc&machine-id,
which is not possible in the build-container AFAIK.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #17 received at 26211 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26211 <at> debbugs.gnu.org
Subject: Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
Date: Sat, 25 Mar 2017 15:17:13 +0100

Hi Hartmut,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> The error-message was: "D-Bus library appears to be incorrectly set up;
> failed to read machine uuid: Failed to open '/etc/machine-id':
> No such file or directory".

The output is:

--8<---------------cut here---------------start------------->8---
starting phase `check'
process 2014: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/etc/machine-id": No such file or directory
See the manual page for dbus-uuidgen to correct this issue.
Test project /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build
      Start  1: managertest
 1/25 Test  #1: managertest ......................   Passed    0.01 sec
      Start  2: settingstest
 2/25 Test  #2: settingstest .....................   Passed    0.01 sec
      Start  3: activeconnectiontest
 3/25 Test  #3: activeconnectiontest .............***Failed    0.81 sec
      Start  4: 8021xsettingtest

[...]

96% tests passed, 1 tests failed out of 25

Total Test time (real) =   0.97 sec

The following tests FAILED:
	  3 - activeconnectiontest (Failed)
Errors while running CTest
phase `check' failed after 1.0 seconds
--8<---------------cut here---------------end--------------->8---

So the failure is the ‘activeconnectiontest’ test, not the D-Bus thing.
Outside the chroot build environment (and outside of ‘guix environment
-C’), this test passes.

When running “ctest --verbose”, we see:

--8<---------------cut here---------------start------------->8---
3: Test command: /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest
3: Test timeout computed to be: 9.99988e+06
3: ********* Start testing of ActiveConnectionTest *********
3: Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.4)
3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap&) Unhandled property "Devices"
3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Carrier"
3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "HwAddress"
3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "PermHwAddress"
3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Speed"
3: PASS   : ActiveConnectionTest::initTestCase()
3: FAIL!  : ActiveConnectionTest::testActiveConnection() Compared values are not the same
3:    Actual   (activeConnectionStateChangedSpy.count()): 0
3:    Expected (1)                                      : 1
3:    Loc: [/tmp/guix-build-networkmanager-qt-5.28.0.drv-0/networkmanager-qt-5.28.0/autotests/activeconnectiontest.cpp(118)]
3: PASS   : ActiveConnectionTest::cleanupTestCase()
3: Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 805ms
3: ********* Finished testing of ActiveConnectionTest *********
 3/25 Test  #3: activeconnectiontest .............***Failed    0.81 sec
--8<---------------cut here---------------end--------------->8---

We can get more details as explained at
<http://doc.qt.io/qt-5/qtest-overview.html> by running:

  dbus-launch /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest -vs

That didn’t really help me though.  The strace output shows nothing
obvious either (such uses code looking for actual network interfaces via
/proc/net/dev or using ioctls); it seems the code has complete mocks for
network interfaces and shouldn’t depend on the real network interfaces.

Could be maybe seek advice from upstream?

HTH,
Ludo’.

Message #22 received at 26211 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 26211 <at> debbugs.gnu.org
Subject: Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
Date: Fri, 08 Sep 2017 17:46:23 +0200

Hi Hartmut,

Any update on this?

Thanks,
Ludo’.

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Hi Hartmut,
>
> Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:
>
>> The error-message was: "D-Bus library appears to be incorrectly set up;
>> failed to read machine uuid: Failed to open '/etc/machine-id':
>> No such file or directory".
>
> The output is:
>
> starting phase `check'
> process 2014: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/etc/machine-id": No such file or directory
> See the manual page for dbus-uuidgen to correct this issue.
> Test project /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build
>       Start  1: managertest
>  1/25 Test  #1: managertest ......................   Passed    0.01 sec
>       Start  2: settingstest
>  2/25 Test  #2: settingstest .....................   Passed    0.01 sec
>       Start  3: activeconnectiontest
>  3/25 Test  #3: activeconnectiontest .............***Failed    0.81 sec
>       Start  4: 8021xsettingtest
>
> [...]
>
> 96% tests passed, 1 tests failed out of 25
>
> Total Test time (real) =   0.97 sec
>
> The following tests FAILED:
> 	  3 - activeconnectiontest (Failed)
> Errors while running CTest
> phase `check' failed after 1.0 seconds
>
>
> So the failure is the ‘activeconnectiontest’ test, not the D-Bus thing.
> Outside the chroot build environment (and outside of ‘guix environment
> -C’), this test passes.
>
> When running “ctest --verbose”, we see:
>
> 3: Test command: /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest
> 3: Test timeout computed to be: 9.99988e+06
> 3: ********* Start testing of ActiveConnectionTest *********
> 3: Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.4)
> 3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap&) Unhandled property "Devices"
> 3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Carrier"
> 3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "HwAddress"
> 3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "PermHwAddress"
> 3: QWARN  : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Speed"
> 3: PASS   : ActiveConnectionTest::initTestCase()
> 3: FAIL!  : ActiveConnectionTest::testActiveConnection() Compared values are not the same
> 3:    Actual   (activeConnectionStateChangedSpy.count()): 0
> 3:    Expected (1)                                      : 1
> 3:    Loc: [/tmp/guix-build-networkmanager-qt-5.28.0.drv-0/networkmanager-qt-5.28.0/autotests/activeconnectiontest.cpp(118)]
> 3: PASS   : ActiveConnectionTest::cleanupTestCase()
> 3: Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 805ms
> 3: ********* Finished testing of ActiveConnectionTest *********
>  3/25 Test  #3: activeconnectiontest .............***Failed    0.81 sec
>
> We can get more details as explained at
> <http://doc.qt.io/qt-5/qtest-overview.html> by running:
>
>   dbus-launch /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest -vs
>
> That didn’t really help me though.  The strace output shows nothing
> obvious either (such uses code looking for actual network interfaces via
> /proc/net/dev or using ioctls); it seems the code has complete mocks for
> network interfaces and shouldn’t depend on the real network interfaces.
>
> Could be maybe seek advice from upstream?
>
> HTH,
> Ludo’.

Message #27 received at 26211-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26211-close <at> debbugs.gnu.org
Subject: Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
Date: Sun, 17 Sep 2017 13:18:19 +0200

This patch is no longer required with the current version.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.