GNU bug report logs - #26238
core-updates: Fix time zone bug in `date` 8.26

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Fri, 24 Mar 2017 16:23:02 UTC

Severity: important

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26238 in the body.
You can then email your comments to 26238 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Fri, 24 Mar 2017 16:23:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 24 Mar 2017 16:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: core-updates: Fix time zone bug in `date` 8.26
Date: Fri, 24 Mar 2017 12:22:34 -0400
[Message part 1 (text/plain, inline)]
After discussion on #guix, Ludovic and I decided to try grafting
coreutils to fix a bug in `date` that breaks converting between time
zones.

https://gnunet.org/bot/log/guix/2017-03-24#T1333113

But, I'm not sure how to handle coreutils-final from (gnu packages
commencement).

Any advice?
[0001-WIP-coreutils-Fix-a-time-zone-bug-in-date-8.26.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Fri, 24 Mar 2017 18:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Fri, 24 Mar 2017 19:42:43 +0100
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> After discussion on #guix, Ludovic and I decided to try grafting
> coreutils to fix a bug in `date` that breaks converting between time
> zones.
>
> https://gnunet.org/bot/log/guix/2017-03-24#T1333113
>
> But, I'm not sure how to handle coreutils-final from (gnu packages
> commencement).
>
> Any advice?

It looks like coreutils-final can e.g.
(inherit (coreutils)
         (replacement #f)).

However, I'm unable to test it since the datetime fix requires this
patch to the bundled gnulib:

https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14

...but it doesn't apply cleanly:

"5 out of 24 hunks FAILED -- saving rejects to file lib/parse-datetime.y.rej"

Maybe we should try to graft 8.27 instead?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Fri, 24 Mar 2017 19:37:02 GMT) Full text and rfc822 format available.

Message #11 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Fri, 24 Mar 2017 20:36:40 +0100
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:

> Leo Famulari <leo <at> famulari.name> writes:
>
>> After discussion on #guix, Ludovic and I decided to try grafting
>> coreutils to fix a bug in `date` that breaks converting between time
>> zones.
>>
>> https://gnunet.org/bot/log/guix/2017-03-24#T1333113
>>
>> But, I'm not sure how to handle coreutils-final from (gnu packages
>> commencement).
>>
>> Any advice?
>
> It looks like coreutils-final can e.g.
> (inherit (coreutils)
>          (replacement #f)).

I tried (package (inherit coreutils) (replacement #f)) in
coreutils-final, but could not get it to work either. The implicit build
inputs are still getting rebuilt. So, I'm lost. :-)

> Maybe we should try to graft 8.27 instead?

How many days does Hydra use on a full rebuild on the different arches?
Not counting the jobs that need to be restarted manually, disk space
management etc..

:-(
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 06:46:01 GMT) Full text and rfc822 format available.

Message #14 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 08:45:25 +0200
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> After discussion on #guix, Ludovic and I decided to try grafting
> coreutils to fix a bug in `date` that breaks converting between time
> zones.
>
> https://gnunet.org/bot/log/guix/2017-03-24#T1333113

How serious is this problem? Maybe we can try to do another core-updates
round immediately after the current iteration is merged. Is it something
we can live with for 3-4 weeks?

I already have updates for perl, ed, xorg and others in my queue, not to
mention coreutils and Guile 2.2. WDYT?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 14:13:01 GMT) Full text and rfc822 format available.

Message #17 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 16:12:40 +0200
Hi Leo,

Leo Famulari <leo <at> famulari.name> skribis:

> But, I'm not sure how to handle coreutils-final from (gnu packages
> commencement).

I think ‘coreutils-final’ doesn’t need the replacement because the
‘coreutils’ package that we get on GuixSD or when typing ‘guix package
-i coreutils’ is not ‘coreutils-final’.

‘-final’ is only used as an implicit input of ‘gnu-build-system’, where
the ‘date’ bug is arguably not a problem.

So for ‘coreutils-final’, I’d just do:

  (replacement #f)

WDYT?

> From 25897d2d2201251c7e98d938f9a78e00c4f6f27d Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo <at> famulari.name>
> Date: Fri, 24 Mar 2017 12:18:21 -0400
> Subject: [PATCH] WIP: coreutils: Fix a time-zone bug in date 8.26.
>
> * gnu/packages/base.scm (coreutils)[replacement]: New field.
> (coreutils/fixed): New variable.
> * gnu/packages/commencement.scm (coreutils-final): *** Help wanted :) ***
> * gnu/packages/patches/coreutils-fix-time-zone-conversion.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

[...]

>  (define-public coreutils-minimal
>    ;; Coreutils without its optional dependencies.
>    (package
>      (inherit coreutils)
>      (name "coreutils-minimal")
> +    (replacement #f)
>      (outputs '("out"))
>      (inputs '())))

For good measure, ‘coreutils-minimal’ should also have:

  (source (package-source coreutils/fixed))

so that it gets the fix (nothing depends on ‘coreutils-minimal’, so
there’s no need for a graft here.)

Thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 20:02:01 GMT) Full text and rfc822 format available.

Message #20 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 16:01:14 -0400
[Message part 1 (text/plain, inline)]
On Sun, Mar 26, 2017 at 04:12:40PM +0200, Ludovic Courtès wrote:
> Leo Famulari <leo <at> famulari.name> skribis:
> I think ‘coreutils-final’ doesn’t need the replacement because the
> ‘coreutils’ package that we get on GuixSD or when typing ‘guix package
> -i coreutils’ is not ‘coreutils-final’.

Right.

> ‘-final’ is only used as an implicit input of ‘gnu-build-system’, where
> the ‘date’ bug is arguably not a problem.
> 
> So for ‘coreutils-final’, I’d just do:
> 
>   (replacement #f)
> 
> WDYT?

I adapted the example of diffutils-boot0 in the attached patch.

> For good measure, ‘coreutils-minimal’ should also have:
> 
>   (source (package-source coreutils/fixed))
> 
> so that it gets the fix (nothing depends on ‘coreutils-minimal’, so
> there’s no need for a graft here.)

Ah, thanks for pointing this out.

I've attached a revised patch.
[0001-gnu-coreutils-Fix-a-time-zone-bug-in-date-8.26.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 20:14:02 GMT) Full text and rfc822 format available.

Message #23 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 16:13:00 -0400
[Message part 1 (text/plain, inline)]
On Sun, Mar 26, 2017 at 08:45:25AM +0200, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> 
> > After discussion on #guix, Ludovic and I decided to try grafting
> > coreutils to fix a bug in `date` that breaks converting between time
> > zones.
> >
> > https://gnunet.org/bot/log/guix/2017-03-24#T1333113
> 
> How serious is this problem? Maybe we can try to do another core-updates
> round immediately after the current iteration is merged. Is it something
> we can live with for 3-4 weeks?

It breaks converting between time zones using the `date` command.

https://bugs.debian.org/851934

As a person who screwed something up once because of a botched time zone
conversion, I'd rather fix it :)

But I understand if there is a strong objection to this graft.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 20:30:03 GMT) Full text and rfc822 format available.

Message #26 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 22:29:38 +0200
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> On Sun, Mar 26, 2017 at 08:45:25AM +0200, Marius Bakke wrote:
>> Leo Famulari <leo <at> famulari.name> writes:
>> 
>> > After discussion on #guix, Ludovic and I decided to try grafting
>> > coreutils to fix a bug in `date` that breaks converting between time
>> > zones.
>> >
>> > https://gnunet.org/bot/log/guix/2017-03-24#T1333113
>> 
>> How serious is this problem? Maybe we can try to do another core-updates
>> round immediately after the current iteration is merged. Is it something
>> we can live with for 3-4 weeks?
>
> It breaks converting between time zones using the `date` command.
>
> https://bugs.debian.org/851934
>
> As a person who screwed something up once because of a botched time zone
> conversion, I'd rather fix it :)
>
> But I understand if there is a strong objection to this graft.

I don't object to the graft, as it does sound like a serious regression.
My reaction was mostly a "flight" response after seeing the gnulib patch
that this depends upon (the parse_datetime2 API change).

https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14

Are you working on backporting it?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 20:56:01 GMT) Full text and rfc822 format available.

Message #29 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 16:55:52 -0400
[Message part 1 (text/plain, inline)]
On Sun, Mar 26, 2017 at 10:29:38PM +0200, Marius Bakke wrote:
> I don't object to the graft, as it does sound like a serious regression.
> My reaction was mostly a "flight" response after seeing the gnulib patch
> that this depends upon (the parse_datetime2 API change).
> 
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14
> 
> Are you working on backporting it?

Ah, I failed to understand that it would be required to backport the
gnulib commit as well. That does look hairy.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Sun, 26 Mar 2017 21:27:02 GMT) Full text and rfc822 format available.

Message #32 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Sun, 26 Mar 2017 23:26:33 +0200
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> On Sun, Mar 26, 2017 at 10:29:38PM +0200, Marius Bakke wrote:
>> I don't object to the graft, as it does sound like a serious regression.
>> My reaction was mostly a "flight" response after seeing the gnulib patch
>> that this depends upon (the parse_datetime2 API change).
>> 
>> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14
>> 
>> Are you working on backporting it?
>
> Ah, I failed to understand that it would be required to backport the
> gnulib commit as well. That does look hairy.

Maybe grafting 8.27 is better. It would be good to build it out on a new
core-updates branch quickly to catch any problems it might introduce.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Mon, 27 Mar 2017 08:29:02 GMT) Full text and rfc822 format available.

Message #35 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Mon, 27 Mar 2017 10:27:59 +0200
Leo Famulari <leo <at> famulari.name> skribis:

> From 466a0ebad18ee5e38f280acf19ab19aadffa2206 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo <at> famulari.name>
> Date: Fri, 24 Mar 2017 12:18:21 -0400
> Subject: [PATCH] gnu: coreutils: Fix a time-zone bug in date 8.26.
>
> * gnu/packages/base.scm (coreutils)[replacement]: New field.
> (coreutils/fixed): New variable.
> (coreutils-minimal)[source]: Use the source of coreutils/fixed.
> * gnu/packages/commencement.scm (coreutils-final)[replacement]: New field.
> * gnu/packages/patches/coreutils-fix-time-zone-conversion.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

LGTM, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Mon, 27 Mar 2017 11:37:01 GMT) Full text and rfc822 format available.

Message #38 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26238 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Mon, 27 Mar 2017 13:36:32 +0200
Marius Bakke <mbakke <at> fastmail.com> skribis:

> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Sun, Mar 26, 2017 at 10:29:38PM +0200, Marius Bakke wrote:
>>> I don't object to the graft, as it does sound like a serious regression.
>>> My reaction was mostly a "flight" response after seeing the gnulib patch
>>> that this depends upon (the parse_datetime2 API change).
>>> 
>>> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14
>>> 
>>> Are you working on backporting it?
>>
>> Ah, I failed to understand that it would be required to backport the
>> gnulib commit as well. That does look hairy.
>
> Maybe grafting 8.27 is better. It would be good to build it out on a new
> core-updates branch quickly to catch any problems it might introduce.

Let’s merge this one first.  :-)

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Mon, 27 Mar 2017 15:37:02 GMT) Full text and rfc822 format available.

Message #41 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26238 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Mon, 27 Mar 2017 11:35:58 -0400
[Message part 1 (text/plain, inline)]
On Mon, Mar 27, 2017 at 01:36:32PM +0200, Ludovic Courtès wrote:
> Marius Bakke <mbakke <at> fastmail.com> skribis:
> 
> > Leo Famulari <leo <at> famulari.name> writes:
> >
> >> On Sun, Mar 26, 2017 at 10:29:38PM +0200, Marius Bakke wrote:
> >>> I don't object to the graft, as it does sound like a serious regression.
> >>> My reaction was mostly a "flight" response after seeing the gnulib patch
> >>> that this depends upon (the parse_datetime2 API change).
> >>> 
> >>> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14
> >>> 
> >>> Are you working on backporting it?
> >>
> >> Ah, I failed to understand that it would be required to backport the
> >> gnulib commit as well. That does look hairy.
> >
> > Maybe grafting 8.27 is better. It would be good to build it out on a new
> > core-updates branch quickly to catch any problems it might introduce.
> 
> Let’s merge this one first.  :-)

Yeah, and I think we'll have to skip this bug fix for now,
unfortunately. Unless somebody else feels up to the task of backporting
the gnulib changes.
[signature.asc (application/pgp-signature, inline)]

Severity set to 'important' from 'normal' Request was from ludo <at> gnu.org (Ludovic Courtès) to control <at> debbugs.gnu.org. (Wed, 29 Mar 2017 11:18:01 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Mon, 17 Apr 2017 21:31:02 GMT) Full text and rfc822 format available.

Message #46 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Mon, 17 Apr 2017 23:30:36 +0200
Hi Leo!

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Leo Famulari <leo <at> famulari.name> skribis:
>
>> From 466a0ebad18ee5e38f280acf19ab19aadffa2206 Mon Sep 17 00:00:00 2001
>> From: Leo Famulari <leo <at> famulari.name>
>> Date: Fri, 24 Mar 2017 12:18:21 -0400
>> Subject: [PATCH] gnu: coreutils: Fix a time-zone bug in date 8.26.
>>
>> * gnu/packages/base.scm (coreutils)[replacement]: New field.
>> (coreutils/fixed): New variable.
>> (coreutils-minimal)[source]: Use the source of coreutils/fixed.
>> * gnu/packages/commencement.scm (coreutils-final)[replacement]: New field.
>> * gnu/packages/patches/coreutils-fix-time-zone-conversion.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>
> LGTM, thanks!

Was there anything wrong with this patch?  Otherwise I still think it’s
worth applying to ‘master’.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Mon, 17 Apr 2017 21:38:02 GMT) Full text and rfc822 format available.

Message #49 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, Leo Famulari
 <leo <at> famulari.name>
Cc: 26238 <at> debbugs.gnu.org
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Mon, 17 Apr 2017 23:37:36 +0200
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Leo!
>
> ludo <at> gnu.org (Ludovic Courtès) skribis:
>
>> Leo Famulari <leo <at> famulari.name> skribis:
>>
>>> From 466a0ebad18ee5e38f280acf19ab19aadffa2206 Mon Sep 17 00:00:00 2001
>>> From: Leo Famulari <leo <at> famulari.name>
>>> Date: Fri, 24 Mar 2017 12:18:21 -0400
>>> Subject: [PATCH] gnu: coreutils: Fix a time-zone bug in date 8.26.
>>>
>>> * gnu/packages/base.scm (coreutils)[replacement]: New field.
>>> (coreutils/fixed): New variable.
>>> (coreutils-minimal)[source]: Use the source of coreutils/fixed.
>>> * gnu/packages/commencement.scm (coreutils-final)[replacement]: New field.
>>> * gnu/packages/patches/coreutils-fix-time-zone-conversion.patch: New file.
>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>
>> LGTM, thanks!
>
> Was there anything wrong with this patch?  Otherwise I still think it’s
> worth applying to ‘master’.

It depends on this gnulib patch, which does not apply cleanly and needs
a rather difficult backport:

https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Tue, 18 Apr 2017 07:55:01 GMT) Full text and rfc822 format available.

Message #52 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26238 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Tue, 18 Apr 2017 09:54:10 +0200
Morning!

Marius Bakke <mbakke <at> fastmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hi Leo!
>>
>> ludo <at> gnu.org (Ludovic Courtès) skribis:
>>
>>> Leo Famulari <leo <at> famulari.name> skribis:
>>>
>>>> From 466a0ebad18ee5e38f280acf19ab19aadffa2206 Mon Sep 17 00:00:00 2001
>>>> From: Leo Famulari <leo <at> famulari.name>
>>>> Date: Fri, 24 Mar 2017 12:18:21 -0400
>>>> Subject: [PATCH] gnu: coreutils: Fix a time-zone bug in date 8.26.
>>>>
>>>> * gnu/packages/base.scm (coreutils)[replacement]: New field.
>>>> (coreutils/fixed): New variable.
>>>> (coreutils-minimal)[source]: Use the source of coreutils/fixed.
>>>> * gnu/packages/commencement.scm (coreutils-final)[replacement]: New field.
>>>> * gnu/packages/patches/coreutils-fix-time-zone-conversion.patch: New file.
>>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>>
>>> LGTM, thanks!
>>
>> Was there anything wrong with this patch?  Otherwise I still think it’s
>> worth applying to ‘master’.
>
> It depends on this gnulib patch, which does not apply cleanly and needs
> a rather difficult backport:
>
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14

Oh right, sorry for being sloppy.

A while back you suggested using directly 8.27 as the replacement:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26238#32

I think it would be a good idea.

Thoughts?

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Tue, 18 Apr 2017 18:38:01 GMT) Full text and rfc822 format available.

Message #55 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26238 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Tue, 18 Apr 2017 20:37:04 +0200
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Morning!
>
> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> Ludovic Courtès <ludo <at> gnu.org> writes:
>>
>>> Hi Leo!
>>>
>>> ludo <at> gnu.org (Ludovic Courtès) skribis:
>>>
>>>> Leo Famulari <leo <at> famulari.name> skribis:
>>>>
>>>>> From 466a0ebad18ee5e38f280acf19ab19aadffa2206 Mon Sep 17 00:00:00 2001
>>>>> From: Leo Famulari <leo <at> famulari.name>
>>>>> Date: Fri, 24 Mar 2017 12:18:21 -0400
>>>>> Subject: [PATCH] gnu: coreutils: Fix a time-zone bug in date 8.26.
>>>>>
>>>>> * gnu/packages/base.scm (coreutils)[replacement]: New field.
>>>>> (coreutils/fixed): New variable.
>>>>> (coreutils-minimal)[source]: Use the source of coreutils/fixed.
>>>>> * gnu/packages/commencement.scm (coreutils-final)[replacement]: New field.
>>>>> * gnu/packages/patches/coreutils-fix-time-zone-conversion.patch: New file.
>>>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>>>
>>>> LGTM, thanks!
>>>
>>> Was there anything wrong with this patch?  Otherwise I still think it’s
>>> worth applying to ‘master’.
>>
>> It depends on this gnulib patch, which does not apply cleanly and needs
>> a rather difficult backport:
>>
>> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4e6e16b3f43ce96302b1e52e48730c1f15e18c14
>
> Oh right, sorry for being sloppy.
>
> A while back you suggested using directly 8.27 as the replacement:
>
>   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26238#32
>
> I think it would be a good idea.
>
> Thoughts?

Here is a WIP patch that adds a graft for coreutils 8.27. I stole Leos
code for the (gnu packages commencement) part. It builds with
`./pre-inst-env guix build coreutils`, but my after reconfiguring my
system on it, `date --version` still shows 8.26.

Any idea what's wrong?

[0001-gnu-coreutils-Replace-with-8.27.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Tue, 18 Apr 2017 21:35:02 GMT) Full text and rfc822 format available.

Message #58 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26238 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Tue, 18 Apr 2017 23:34:14 +0200
Marius Bakke <mbakke <at> fastmail.com> skribis:

> Here is a WIP patch that adds a graft for coreutils 8.27. I stole Leos
> code for the (gnu packages commencement) part. It builds with
> `./pre-inst-env guix build coreutils`, but my after reconfiguring my
> system on it, `date --version` still shows 8.26.
>
> Any idea what's wrong?

Bah!  The system uses ‘coreutils-final’ due to this stanza in (gnu
system):

     ;; The packages below are also in %FINAL-INPUTS, so take them from
     ;; there to avoid duplication.
     (map canonical-package
          (list guile-2.0 bash coreutils findutils grep sed
                diffutils patch gawk tar gzip bzip2 xz lzip))

Not sure how to handle it.  We could explicitly write ‘coreutils-8.27’
above, which would solve the problem.  It would also make the graft much
less useful, except for people explicitly doing:

  guix package -i coreutils

So we might just as well remove the graft.

Thoughts?

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Wed, 19 Apr 2017 16:50:01 GMT) Full text and rfc822 format available.

Message #61 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26238 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Wed, 19 Apr 2017 18:49:04 +0200
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> Here is a WIP patch that adds a graft for coreutils 8.27. I stole Leos
>> code for the (gnu packages commencement) part. It builds with
>> `./pre-inst-env guix build coreutils`, but my after reconfiguring my
>> system on it, `date --version` still shows 8.26.
>>
>> Any idea what's wrong?
>
> Bah!  The system uses ‘coreutils-final’ due to this stanza in (gnu
> system):
>
>      ;; The packages below are also in %FINAL-INPUTS, so take them from
>      ;; there to avoid duplication.
>      (map canonical-package
>           (list guile-2.0 bash coreutils findutils grep sed
>                 diffutils patch gawk tar gzip bzip2 xz lzip))
>
> Not sure how to handle it.  We could explicitly write ‘coreutils-8.27’
> above, which would solve the problem.  It would also make the graft much
> less useful, except for people explicitly doing:
>
>   guix package -i coreutils
>
> So we might just as well remove the graft.

Okay, that makes sense. I dropped the graft in the patch below and can
confirm it works on my system. Note that coreutils-8.27 is now public so
that `guix package -i coreutils` will pull in 8.27 regardless. PTAL.

[0001-gnu-Add-workaround-for-date-regression-in-coreutils-.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26238; Package guix-patches. (Wed, 19 Apr 2017 20:01:02 GMT) Full text and rfc822 format available.

Message #64 received at 26238 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26238 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Wed, 19 Apr 2017 22:00:32 +0200
Heya,

Marius Bakke <mbakke <at> fastmail.com> skribis:

>> Not sure how to handle it.  We could explicitly write ‘coreutils-8.27’
>> above, which would solve the problem.  It would also make the graft much
>> less useful, except for people explicitly doing:
>>
>>   guix package -i coreutils
>>
>> So we might just as well remove the graft.
>
> Okay, that makes sense. I dropped the graft in the patch below and can
> confirm it works on my system. Note that coreutils-8.27 is now public so
> that `guix package -i coreutils` will pull in 8.27 regardless. PTAL.

Indeed.

> From 5be25413a76ca84c18e4f4174629af5fe6e87db1 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke <at> fastmail.com>
> Date: Tue, 18 Apr 2017 20:13:45 +0200
> Subject: [PATCH] gnu: Add workaround for `date` regression in coreutils <at> 8.26.
>
> See <https://bugs.gnu.org/23035> and <https://bugs.gnu.org/26238>.
>
> * gnu/packages/base.scm (coreutils-8.27): New variable.
> * gnu/system.scm (%base-packages): Use that instead of COREUTILS.

Go for it!

Thanks,
Ludo’.




Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Wed, 19 Apr 2017 20:13:02 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Wed, 19 Apr 2017 20:13:02 GMT) Full text and rfc822 format available.

Message #69 received at 26238-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26238-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#26238: core-updates: Fix time zone bug in `date` 8.26
Date: Wed, 19 Apr 2017 22:12:02 +0200
[Message part 1 (text/plain, inline)]
Ludovic Courtès <ludo <at> gnu.org> writes:

>> From 5be25413a76ca84c18e4f4174629af5fe6e87db1 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <mbakke <at> fastmail.com>
>> Date: Tue, 18 Apr 2017 20:13:45 +0200
>> Subject: [PATCH] gnu: Add workaround for `date` regression in coreutils <at> 8.26.
>>
>> See <https://bugs.gnu.org/23035> and <https://bugs.gnu.org/26238>.
>>
>> * gnu/packages/base.scm (coreutils-8.27): New variable.
>> * gnu/system.scm (%base-packages): Use that instead of COREUTILS.
>
> Go for it!

Pushed!
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 18 May 2017 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 316 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.